Re: [Mingw-w64-public] [PATCH 2/2] Use public _acmdln and _wcmdln declarations in crt and get rid of no loner needed ucrtbase compat hack.

> On Nov 28, 2017, at 04:06, s...@posteo.jp wrote: > > Thanks for the patch Jacek , I just tested building a x86_64 toolchain and it > builds just fine. Yes, Jacek’s patch does make it build, but it won’t actually successfully load at runtime since it tries to reference a function that doesn’t

Re: [Mingw-w64-public] [PATCH 2/2] Use public _acmdln and _wcmdln declarations in crt and get rid of no loner needed ucrtbase compat hack.

> On Nov 28, 2017, at 02:40, Jacek Caban wrote: > > Hi Sven, > > > On 11/28/17 12:07 AM, Sven Kretzschmar wrote: >> Do you have an idea how to fix this ? >> Should I just revoke the corresponding change/patch ? : >>

Re: [Mingw-w64-public] [PATCH 2/2] Use public _acmdln and _wcmdln declarations in crt and get rid of no loner needed ucrtbase compat hack.

configure:3401: checking whether the C compiler works configure:3423: x86_64-w64-mingw32-gcc -march=x86-64 -mtune=generic -O2 -pipe -DHAVE_BZIP2 -D_FORTIFY_SOURCE=2 -D__USE_MINGW_ANSI_STDIO=1 -pipe conftest.c -lbz2 >&5 configure:3427: $? = 0 configure:3475: result: yes configure:3478: checking for

Re: [Mingw-w64-public] [PATCH 2/2] Use public _acmdln and _wcmdln declarations in crt and get rid of no loner needed ucrtbase compat hack.

Thanks for the patch Jacek , I just tested building a x86_64 toolchain and it builds just fine. - Sora On 28.11.2017 01:40, Jacek Caban wrote: Hi Sven, On 11/28/17 12:07 AM, Sven Kretzschmar wrote: Do you have an idea how to fix this ? Should I just revoke the corresponding change/patch ?

Re: [Mingw-w64-public] [PATCH 2/2] Use public _acmdln and _wcmdln declarations in crt and get rid of no loner needed ucrtbase compat hack.

Oouf, so that was the problem, thought i was going nuts, the last pull from msys2 broke the compiler completely with those exact errors. Mind giving me a hint when it's fixed ?. Den 28-11-2017 kl. 00:07 skrev Sven Kretzschmar: > It seems that this patch somehow broke cross-compiling the gnu

Re: [Mingw-w64-public] [PATCH 2/2] Use public _acmdln and _wcmdln declarations in crt and get rid of no loner needed ucrtbase compat hack.

It seems that this patch somehow broke cross-compiling the gnu toolchain when _not_ using the "--with-default-msvcrt=ucrtbase" option. I am getting the following errors during "make" in gcc subdir (final build step for building cross-compiler from Cygwin to mingw64 x86_64): configure:3713:

Re: [Mingw-w64-public] [PATCH 2/2] Use public _acmdln and _wcmdln declarations in crt and get rid of no loner needed ucrtbase compat hack.

On Fri, 24 Nov 2017, Jacek Caban wrote: Signed-off-by: Jacek Caban --- mingw-w64-crt/crt/ucrtbase_compat.c | 8 mingw-w64-crt/include/internal.h| 12 2 files changed, 20 deletions(-) Nice, thanks! Signed-off-by: Martin Storsjö