Re: [Mingw-w64-public] DirectWrite additions

2016-10-18 Thread Jacek Caban
I'm sorry, I missed the mail. The patch looks good to me. Thanks! Jacek On 18.10.2016 19:33, Ruben Van Boxem wrote: > Friendly ping! > > 2016-10-04 21:50 GMT+02:00 Ruben Van Boxem : > >> Hi Jacek, >> >> I got delayed doing other stuff like painting doors and partying etc. but >> I still have to p

Re: [Mingw-w64-public] DirectWrite additions

2016-10-18 Thread Ruben Van Boxem
Friendly ping! 2016-10-04 21:50 GMT+02:00 Ruben Van Boxem : > Hi Jacek, > > I got delayed doing other stuff like painting doors and partying etc. but > I still have to patch the MinGW-w64 master version to work with Skia. > Attached is the patch I need to apply. I tried to match your previous > c

Re: [Mingw-w64-public] DirectWrite additions

2016-10-04 Thread Ruben Van Boxem
Hi Jacek, I got delayed doing other stuff like painting doors and partying etc. but I still have to patch the MinGW-w64 master version to work with Skia. Attached is the patch I need to apply. I tried to match your previous comments about the interface copy paste. Hope it's OK now. Please apply i

Re: [Mingw-w64-public] DirectWrite additions

2016-08-26 Thread Jacek Caban
Hi David, It looks like I committed more than intended. I'm sorry about that. Yes, please commit your patch. Thanks, Jacek On 26.08.2016 03:01, David Wohlferd wrote: > So what happened here? The winerror.h that got checked in still has > the duplicate defines? > > Is there some reason I can't r

Re: [Mingw-w64-public] DirectWrite additions

2016-08-25 Thread David Wohlferd
So what happened here? The winerror.h that got checked in still has the duplicate defines? Is there some reason I can't remove the dupes (attached)? dw On 8/24/2016 9:46 AM, Jacek Caban wrote: Hi Ruben, I'm sorry I didn't look at this earlier. I committed winerror.h (it seems that you inc

Re: [Mingw-w64-public] DirectWrite additions

2016-08-24 Thread Jacek Caban
Hi Ruben, I'm sorry I didn't look at this earlier. I committed winerror.h (it seems that you included the same defines in two different places in those patches, so please retest with committed version) and wincodec.idl parts. However, dwrite_2.h needs some more work. We try to provide dwrite API

Re: [Mingw-w64-public] DirectWrite additions

2016-08-24 Thread Ruben Van Boxem
I would like to reiterate my request to include the following the changes in MinGW-w64. I have no commit rights, and Kai half-OKed them, so input from someone in the team that can commit them directly would be greatly appreciated! I'll attach both patches (which are required to build Skia with Min

Re: [Mingw-w64-public] DirectWrite additions

2016-08-09 Thread Ruben Van Boxem
Hi Kai (and Jacek), Thanks for taking a look. Note there are two patches: one I linked to in the body of my email, the other was attached. Both would need to be applied by someone (I don't have commit rights). Cheers, Ruben 2016-08-09 10:58 GMT+02:00 Kai Tietz : > Hi Ruben, > > patch looks fi

Re: [Mingw-w64-public] DirectWrite additions

2016-08-09 Thread Kai Tietz
Hi Ruben, patch looks fine to me. As long as there are no objections (Jacek do you?), go ahead and apply. Thanks, Kai 2016-08-08 20:57 GMT+02:00 Ruben Van Boxem : > Hi guys, > > it would be nice to keep up to date with new APIs that gain real world use, > like this little patch: > https://gith