Re: [Mingw-w64-public] DirectWrite additions

[Jacek Caban]

I'm sorry, I missed the mail. The patch looks good to me.

Thanks!
Jacek

On 18.10.2016 19:33, Ruben Van Boxem wrote:
> Friendly ping!
>
> 2016-10-04 21:50 GMT+02:00 Ruben Van Boxem :
>
>> Hi Jacek,
>>
>> I got delayed doing other stuff like painting doors and partying etc. but
>> I still have to patch the MinGW-w64 master version to work with Skia.
>> Attached is the patch I need to apply. I tried to match your previous
>> comments about the interface copy paste. Hope it's OK now.
>>
>> Please apply if OK.
>>
>> Cheers,
>>
>> Ruben


--
Check out the vibrant tech community on one of the world's most 
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] DirectWrite additions

[Ruben Van Boxem]

Friendly ping!

2016-10-04 21:50 GMT+02:00 Ruben Van Boxem :

> Hi Jacek,
>
> I got delayed doing other stuff like painting doors and partying etc. but
> I still have to patch the MinGW-w64 master version to work with Skia.
> Attached is the patch I need to apply. I tried to match your previous
> comments about the interface copy paste. Hope it's OK now.
>
> Please apply if OK.
>
> Cheers,
>
> Ruben
>
> 2016-08-26 14:37 GMT+02:00 Jacek Caban :
>
>> Hi David,
>>
>> It looks like I committed more than intended. I'm sorry about that. Yes,
>> please commit your patch.
>>
>> Thanks,
>> Jacek
>>
>> On 26.08.2016 03:01, David Wohlferd wrote:
>> > So what happened here?  The winerror.h that got checked in still has
>> > the duplicate defines?
>> >
>> > Is there some reason I can't remove the dupes (attached)?
>> >
>> > dw
>> >
>> >
>> > On 8/24/2016 9:46 AM, Jacek Caban wrote:
>> >> Hi Ruben,
>> >>
>> >> I'm sorry I didn't look at this earlier.
>> >>
>> >> I committed winerror.h (it seems that you included the same defines in
>> >> two different places in those patches, so please retest with committed
>> >> version) and wincodec.idl parts.
>> >>
>> >> However, dwrite_2.h needs some more work. We try to provide dwrite APIs
>> >> for plain C, which makes things a bit more painful than that. You need
>> >> to add THIS (for functions with no arguments) or THIS_ macros in the
>> >> beginning of declaration of each functions. Also to preserve proper
>> vtbl
>> >> layout, declaration of parent interface needs to be copied inside
>> >> __cplusplus guard. See other declarations for an example. Also we try
>> to
>> >> avoid using things like _In_, _Out_ macros in our headers.
>> >>
>> >> Thanks,
>> >> Jacek
>> >>
>> >> On 24.08.2016 18:25, Ruben Van Boxem wrote:
>> >>> I would like to reiterate my request to include the following the
>> >>> changes
>> >>> in MinGW-w64. I have no commit rights, and Kai half-OKed them, so
>> input
>> >>> from someone in the team that can commit them directly would be
>> greatly
>> >>> appreciated!
>> >>>
>> >>> I'll attach both patches (which are required to build Skia with
>> >>> MinGW-w64)
>> >>> to this email for convenience. Note there were duplicate GUID's in the
>> >>> previous patch, those were removed here.
>> >>>
>> >>> Please OK and apply so I can stop keeing my custom builds of MinGW-w64
>> >>> around, thanks :)
>> >>>
>> >>> Cheers!
>> >>>
>> >>> Ruben
>> >>>
>> >>> 2016-08-09 19:44 GMT+02:00 Ruben Van Boxem > >:
>> >>>
>>  Hi Kai (and Jacek),
>> 
>>  Thanks for taking a look.
>> 
>>  Note there are two patches: one I linked to in the body of my
>>  email, the
>>  other was attached. Both would need to be applied by someone (I
>>  don't have
>>  commit rights).
>> 
>>  Cheers,
>> 
>>  Ruben
>> 
>>  2016-08-09 10:58 GMT+02:00 Kai Tietz :
>> 
>> > Hi Ruben,
>> >
>> > patch looks fine to me.  As long as there are no objections
>> > (Jacek  do
>> > you?), go ahead and apply.
>> >
>> > Thanks,
>> > Kai
>> >
>> > 2016-08-08 20:57 GMT+02:00 Ruben Van Boxem
>> > :
>> >> Hi guys,
>> >>
>> >> it would be nice to keep up to date with new APIs that gain real
>> >> world
>> > use,
>> >> like this little patch:
>> >> https://github.com/Alexpux/mingw-w64/pull/1/commits/6c0efe37
>> > b32510f72020e38726c7a84690a926fd
>> >> Which is now needed for Qt 5.7 (and skia).
>> >>
>> >> I would also like to point out attached patch that adds various
>> >> GUIDs
>> >> missing I ran into when compiling skia.
>> >>
>> >> Cheers,
>> >>
>> >> Ruben
>> >>
>> >> 
>> > --
>> >> What NetFlow Analyzer can do for you? Monitors network bandwidth
>> and
>> > traffic
>> >> patterns at an interface-level. Reveals which users, apps, and
>> > protocols are
>> >> consuming the most bandwidth. Provides multi-vendor support for
>> >> NetFlow,
>> >> J-Flow, sFlow and other flows. Make informed decisions using
>> >> capacity
>> >> planning reports. http://sdm.link/zohodev2dev
>> >> ___
>> >> Mingw-w64-public mailing list
>> >> Mingw-w64-public@lists.sourceforge.net
>> >> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>> >>
>> > 
>> > --
>> > What NetFlow Analyzer can do for you? Monitors network bandwidth and
>> > traffic
>> > patterns at an interface-level. Reveals which users, apps, and
>> > protocols
>> > are
>> > consuming the most bandwidth. Provides multi-vendor support for
>> > NetFlow,
>> > J-Flow, sFlow and 

Re: [Mingw-w64-public] DirectWrite additions

[David Wohlferd]

So what happened here?  The winerror.h that got checked in still has the 
duplicate defines?


Is there some reason I can't remove the dupes (attached)?

dw


On 8/24/2016 9:46 AM, Jacek Caban wrote:

Hi Ruben,

I'm sorry I didn't look at this earlier.

I committed winerror.h (it seems that you included the same defines in
two different places in those patches, so please retest with committed
version) and wincodec.idl parts.

However, dwrite_2.h needs some more work. We try to provide dwrite APIs
for plain C, which makes things a bit more painful than that. You need
to add THIS (for functions with no arguments) or THIS_ macros in the
beginning of declaration of each functions. Also to preserve proper vtbl
layout, declaration of parent interface needs to be copied inside
__cplusplus guard. See other declarations for an example. Also we try to
avoid using things like _In_, _Out_ macros in our headers.

Thanks,
Jacek

On 24.08.2016 18:25, Ruben Van Boxem wrote:

I would like to reiterate my request to include the following the changes
in MinGW-w64. I have no commit rights, and Kai half-OKed them, so input
from someone in the team that can commit them directly would be greatly
appreciated!

I'll attach both patches (which are required to build Skia with MinGW-w64)
to this email for convenience. Note there were duplicate GUID's in the
previous patch, those were removed here.

Please OK and apply so I can stop keeing my custom builds of MinGW-w64
around, thanks :)

Cheers!

Ruben

2016-08-09 19:44 GMT+02:00 Ruben Van Boxem :


Hi Kai (and Jacek),

Thanks for taking a look.

Note there are two patches: one I linked to in the body of my email, the
other was attached. Both would need to be applied by someone (I don't have
commit rights).

Cheers,

Ruben

2016-08-09 10:58 GMT+02:00 Kai Tietz :


Hi Ruben,

patch looks fine to me.  As long as there are no objections (Jacek  do
you?), go ahead and apply.

Thanks,
Kai

2016-08-08 20:57 GMT+02:00 Ruben Van Boxem :

Hi guys,

it would be nice to keep up to date with new APIs that gain real world

use,

like this little patch:
https://github.com/Alexpux/mingw-w64/pull/1/commits/6c0efe37

b32510f72020e38726c7a84690a926fd

Which is now needed for Qt 5.7 (and skia).

I would also like to point out attached patch that adds various GUIDs
missing I ran into when compiling skia.

Cheers,

Ruben



--

What NetFlow Analyzer can do for you? Monitors network bandwidth and

traffic

patterns at an interface-level. Reveals which users, apps, and

protocols are

consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public



--
What NetFlow Analyzer can do for you? Monitors network bandwidth and
traffic
patterns at an interface-level. Reveals which users, apps, and protocols
are
consuming the most bandwidth. Provides multi-vendor support for NetFlow,
J-Flow, sFlow and other flows. Make informed decisions using capacity
planning reports. http://sdm.link/zohodev2dev
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public




--


___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


--
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public



diff --git a/mingw-w64-headers/include/winerror.h b/mingw-w64-headers/include/winerror.h
index 55ebd50..aee0618 100644
--- a/mingw-w64-headers/include/winerror.h
+++ b/mingw-w64-headers/include/winerror.h
@@ -3467,20 +3467,6 @@ __CRT_INLINE HRESULT HRESULT_FROM_WIN32(__LONG32 x) { return x <= 0 ? (HRESULT)x
 #define DXGI_ERROR_NAME_ALREADY_EXISTS  _HRESULT_TYPEDEF_(0x887A002C)
 #define DXGI_ERROR_SDK_COMPONENT_MISSING_HRESULT_TYPEDEF_(0x887A002D)
 
-#define DWRITE_E_FILEFORMAT   _HRESULT_TYPEDEF_(0x88985000)
-#define DWRITE_E_UNEXPECTED   _HRESULT_TYPEDEF_(0x88985001)
-#define DWRITE_E_NOFONT   _HRESULT_TYPEDEF_(0x88985002)
-#define DWRITE_E_FILENOTFOUND _HRESULT_TYPEDEF_(0x88985003)
-#define DWRITE_E_FILEACCESS   

Re: [Mingw-w64-public] DirectWrite additions

[Jacek Caban]

Hi Ruben,

I'm sorry I didn't look at this earlier.

I committed winerror.h (it seems that you included the same defines in
two different places in those patches, so please retest with committed
version) and wincodec.idl parts.

However, dwrite_2.h needs some more work. We try to provide dwrite APIs
for plain C, which makes things a bit more painful than that. You need
to add THIS (for functions with no arguments) or THIS_ macros in the
beginning of declaration of each functions. Also to preserve proper vtbl
layout, declaration of parent interface needs to be copied inside
__cplusplus guard. See other declarations for an example. Also we try to
avoid using things like _In_, _Out_ macros in our headers.

Thanks,
Jacek

On 24.08.2016 18:25, Ruben Van Boxem wrote:
> I would like to reiterate my request to include the following the changes
> in MinGW-w64. I have no commit rights, and Kai half-OKed them, so input
> from someone in the team that can commit them directly would be greatly
> appreciated!
>
> I'll attach both patches (which are required to build Skia with MinGW-w64)
> to this email for convenience. Note there were duplicate GUID's in the
> previous patch, those were removed here.
>
> Please OK and apply so I can stop keeing my custom builds of MinGW-w64
> around, thanks :)
>
> Cheers!
>
> Ruben
>
> 2016-08-09 19:44 GMT+02:00 Ruben Van Boxem :
>
>> Hi Kai (and Jacek),
>>
>> Thanks for taking a look.
>>
>> Note there are two patches: one I linked to in the body of my email, the
>> other was attached. Both would need to be applied by someone (I don't have
>> commit rights).
>>
>> Cheers,
>>
>> Ruben
>>
>> 2016-08-09 10:58 GMT+02:00 Kai Tietz :
>>
>>> Hi Ruben,
>>>
>>> patch looks fine to me.  As long as there are no objections (Jacek  do
>>> you?), go ahead and apply.
>>>
>>> Thanks,
>>> Kai
>>>
>>> 2016-08-08 20:57 GMT+02:00 Ruben Van Boxem :
 Hi guys,

 it would be nice to keep up to date with new APIs that gain real world
>>> use,
 like this little patch:
 https://github.com/Alexpux/mingw-w64/pull/1/commits/6c0efe37
>>> b32510f72020e38726c7a84690a926fd
 Which is now needed for Qt 5.7 (and skia).

 I would also like to point out attached patch that adds various GUIDs
 missing I ran into when compiling skia.

 Cheers,

 Ruben

 
>>> --
 What NetFlow Analyzer can do for you? Monitors network bandwidth and
>>> traffic
 patterns at an interface-level. Reveals which users, apps, and
>>> protocols are
 consuming the most bandwidth. Provides multi-vendor support for NetFlow,
 J-Flow, sFlow and other flows. Make informed decisions using capacity
 planning reports. http://sdm.link/zohodev2dev
 ___
 Mingw-w64-public mailing list
 Mingw-w64-public@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

>>> 
>>> --
>>> What NetFlow Analyzer can do for you? Monitors network bandwidth and
>>> traffic
>>> patterns at an interface-level. Reveals which users, apps, and protocols
>>> are
>>> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>>> J-Flow, sFlow and other flows. Make informed decisions using capacity
>>> planning reports. http://sdm.link/zohodev2dev
>>> ___
>>> Mingw-w64-public mailing list
>>> Mingw-w64-public@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>>>
>>
>>
>>
>> --
>>
>>
>> ___
>> Mingw-w64-public mailing list
>> Mingw-w64-public@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


--
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Re: [Mingw-w64-public] DirectWrite additions

[Ruben Van Boxem]

I would like to reiterate my request to include the following the changes
in MinGW-w64. I have no commit rights, and Kai half-OKed them, so input
from someone in the team that can commit them directly would be greatly
appreciated!

I'll attach both patches (which are required to build Skia with MinGW-w64)
to this email for convenience. Note there were duplicate GUID's in the
previous patch, those were removed here.

Please OK and apply so I can stop keeing my custom builds of MinGW-w64
around, thanks :)

Cheers!

Ruben

2016-08-09 19:44 GMT+02:00 Ruben Van Boxem :

> Hi Kai (and Jacek),
>
> Thanks for taking a look.
>
> Note there are two patches: one I linked to in the body of my email, the
> other was attached. Both would need to be applied by someone (I don't have
> commit rights).
>
> Cheers,
>
> Ruben
>
> 2016-08-09 10:58 GMT+02:00 Kai Tietz :
>
>> Hi Ruben,
>>
>> patch looks fine to me.  As long as there are no objections (Jacek  do
>> you?), go ahead and apply.
>>
>> Thanks,
>> Kai
>>
>> 2016-08-08 20:57 GMT+02:00 Ruben Van Boxem :
>> > Hi guys,
>> >
>> > it would be nice to keep up to date with new APIs that gain real world
>> use,
>> > like this little patch:
>> > https://github.com/Alexpux/mingw-w64/pull/1/commits/6c0efe37
>> b32510f72020e38726c7a84690a926fd
>> >
>> > Which is now needed for Qt 5.7 (and skia).
>> >
>> > I would also like to point out attached patch that adds various GUIDs
>> > missing I ran into when compiling skia.
>> >
>> > Cheers,
>> >
>> > Ruben
>> >
>> > 
>> --
>> > What NetFlow Analyzer can do for you? Monitors network bandwidth and
>> traffic
>> > patterns at an interface-level. Reveals which users, apps, and
>> protocols are
>> > consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>> > J-Flow, sFlow and other flows. Make informed decisions using capacity
>> > planning reports. http://sdm.link/zohodev2dev
>> > ___
>> > Mingw-w64-public mailing list
>> > Mingw-w64-public@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>> >
>>
>> 
>> --
>> What NetFlow Analyzer can do for you? Monitors network bandwidth and
>> traffic
>> patterns at an interface-level. Reveals which users, apps, and protocols
>> are
>> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>> J-Flow, sFlow and other flows. Make informed decisions using capacity
>> planning reports. http://sdm.link/zohodev2dev
>> ___
>> Mingw-w64-public mailing list
>> Mingw-w64-public@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>>
>
>
diff --git a/mingw-w64-headers/include/wincodec.h 
b/mingw-w64-headers/include/wincodec.h
index a863a6c..f853407 100644
--- a/mingw-w64-headers/include/wincodec.h
+++ b/mingw-w64-headers/include/wincodec.h
@@ -319,6 +319,30 @@ DEFINE_GUID(GUID_WICPixelFormat48bppRGB, 
0x6fddc324,0x4e03,0x4bfe,0xb1,0x85,0x3d
 DEFINE_GUID(GUID_WICPixelFormat64bppRGBA, 
0x6fddc324,0x4e03,0x4bfe,0xb1,0x85,0x3d,0x77,0x76,0x8d,0xc9,0x16);
 DEFINE_GUID(GUID_WICPixelFormat64bppPRGBA, 
0x6fddc324,0x4e03,0x4bfe,0xb1,0x85,0x3d,0x77,0x76,0x8d,0xc9,0x17);
 DEFINE_GUID(GUID_WICPixelFormat32bppCMYK, 
0x6fddc324,0x4e03,0x4fbe,0xb1,0x85,0x3d,0x77,0x76,0x8d,0xc9,0x1c);
+
+DEFINE_GUID(GUID_WICPixelFormat32bppBGR101010, 0x6fddc324, 0x4e03, 0x4bfe, 
0xb1, 0x85, 0x3d, 0x77, 0x76, 0x8d, 0xc9, 0x14);
+DEFINE_GUID(GUID_WICPixelFormat16bppGrayFixedPoint, 0x6fddc324, 0x4e03, 
0x4bfe, 0xb1, 0x85, 0x3d, 0x77, 0x76, 0x8d, 0xc9, 0x13);
+DEFINE_GUID(GUID_WICPixelFormat16bppGrayHalf, 0x6fddc324, 0x4e03, 0x4bfe, 
0xb1, 0x85, 0x3d, 0x77, 0x76, 0x8d, 0xc9, 0x3e);
+DEFINE_GUID(GUID_WICPixelFormat32bppGrayFloat,  0x6fddc324, 0x4e03, 0x4bfe, 
0xb1, 0x85, 0x3d, 0x77, 0x76, 0x8d, 0xc9, 0x11);
+DEFINE_GUID(GUID_WICPixelFormat32bppGrayFixedPoint, 0x6fddc324, 0x4e03, 
0x4bfe, 0xb1, 0x85, 0x3d, 0x77, 0x76, 0x8d, 0xc9, 0x3f);
+DEFINE_GUID(GUID_WICPixelFormat32bppRGBE, 0x6fddc324, 0x4e03, 0x4bfe, 0xb1, 
0x85, 0x3d, 0x77, 0x76, 0x8d, 0xc9, 0x3d);
+DEFINE_GUID(GUID_WICPixelFormat48bppBGR, 0xe605a384, 0xb468, 0x46ce, 0xbb, 
0x2e, 0x36, 0xf1, 0x80, 0xe6, 0x43, 0x13);
+DEFINE_GUID(GUID_WICPixelFormat48bppRGBFixedPoint, 0x6fddc324, 0x4e03, 0x4bfe, 
0xb1, 0x85, 0x3d, 0x77, 0x76, 0x8d, 0xc9, 0x12);
+DEFINE_GUID(GUID_WICPixelFormat48bppBGRFixedPoint, 0x49ca140e, 0xcab6, 0x493b, 
0x9d, 0xdf, 0x60, 0x18, 0x7c, 0x37, 0x53, 0x2a);
+DEFINE_GUID(GUID_WICPixelFormat48bppRGBHalf, 0x6fddc324, 0x4e03, 0x4bfe, 0xb1, 
0x85, 0x3d, 0x77, 0x76, 0x8d, 0xc9, 0x3b);
+DEFINE_GUID(GUID_WICPixelFormat64bppRGBFixedPoint, 0x6fddc324, 0x4e03, 0x4bfe, 
0xb1, 0x85, 0x3d, 0x77, 0x76, 0x8d, 0xc9, 0x40);
+DEFINE_GUID(GUID_WICPixelFormat64bppRGBHalf, 0x6fddc324, 

Re: [Mingw-w64-public] DirectWrite additions

[Kai Tietz]

Hi Ruben,

patch looks fine to me.  As long as there are no objections (Jacek  do
you?), go ahead and apply.

Thanks,
Kai

2016-08-08 20:57 GMT+02:00 Ruben Van Boxem :
> Hi guys,
>
> it would be nice to keep up to date with new APIs that gain real world use,
> like this little patch:
> https://github.com/Alexpux/mingw-w64/pull/1/commits/6c0efe37b32510f72020e38726c7a84690a926fd
>
> Which is now needed for Qt 5.7 (and skia).
>
> I would also like to point out attached patch that adds various GUIDs
> missing I ran into when compiling skia.
>
> Cheers,
>
> Ruben
>
> --
> What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
> patterns at an interface-level. Reveals which users, apps, and protocols are
> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
> J-Flow, sFlow and other flows. Make informed decisions using capacity
> planning reports. http://sdm.link/zohodev2dev
> ___
> Mingw-w64-public mailing list
> Mingw-w64-public@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>

--
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity 
planning reports. http://sdm.link/zohodev2dev
___
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public