Re: possible bug in OpenNTPD code?

2008-12-22 Thread Henning Brauer
this analysis is as correct as thye provided diff, which has been committed. * Anirban Sinha asi...@zeugmasystems.com [2008-12-05 03:07]: Hi: I am sort of digging my way through the OpenNTPD codebase for my work. I think I find a bug in the code. Please help me to understand the reason if

Re: possible bug in OpenNTPD code?

2008-12-12 Thread Anirban Sinha
I'd take a look at your other diff later. Thanks for patching the upstream source in cvs with my patch. Ani -Otto

Re: possible bug in OpenNTPD code?

2008-12-11 Thread Ed Ahlsen-Girard (TYBRIN Corp.)
From: Tom Van Looy [mailto:[EMAIL PROTECTED] Sent: Wednesday, December 10, 2008 10:50 AM To: Anirban Sinha Cc: misc@openbsd.org Subject: Re: possible bug in OpenNTPD code? Why would you assume that? That seems a bit hostile. Perhaps the developers are a bit busy at the moment

Re: possible bug in OpenNTPD code?

2008-12-10 Thread Claudio Jeker
On Thu, Dec 04, 2008 at 06:03:32PM -0800, Anirban Sinha wrote: Hi: I am sort of digging my way through the OpenNTPD codebase for my work. I think I find a bug in the code. Please help me to understand the reason if this is not a bug. In function ntp_main() (ntp.c), we poll() to check if

Re: possible bug in OpenNTPD code?

2008-12-10 Thread Hannah Schroeter
Hi! On Tue, Dec 09, 2008 at 10:36:46PM -0800, Anirban Sinha wrote: How is it blocking indefinitely? Is wait() not returning -1 with errno == ECHILD when there are no children to reap? What led you to the conclusion that this code was blocking? (What platform are you running this on?) Hmm,

Re: possible bug in OpenNTPD code?

2008-12-10 Thread Tom Van Looy
Why would you assume that? That seems a bit hostile. Perhaps the developers are a bit busy at the moment. True. I generally post on the Linux lists and I believe I am spoiled by getting quick responses from my postings. In future, I will remember to keep more patience. I would like to respond to

Re: possible bug in OpenNTPD code?

2008-12-10 Thread Anirban Sinha
I would like to respond to this with a small anecdote: I opened a call at vendor x at 17/sep/2008. The call resulted in me having to open a design change request for their OS. So, 65 days later (coincidently today), I received a tracking number and probably have to wait an other (max) 90 days

Re: possible bug in OpenNTPD code?

2008-12-09 Thread Anirban Sinha
(as opposed to reporting to the community). Thanks, Ani -Original Message- From: Anirban Sinha Sent: Thursday, December 04, 2008 6:04 PM To: 'misc@openbsd.org' Subject: possible bug in OpenNTPD code? Hi: I am sort of digging my way through the OpenNTPD codebase for my work. I think I find

Re: possible bug in OpenNTPD code?

2008-12-09 Thread Otto Moerbeek
On Tue, Dec 09, 2008 at 08:10:20PM -0800, Anirban Sinha wrote: I hope I will get some response to this. If not, I will assume that there is really no interest in fixing bugs in openntpd and in that case, I will patch only our local copy of the ntpd codebase (as opposed to reporting to the

Re: possible bug in OpenNTPD code?

2008-12-09 Thread Philip Guenther
On Tue, Dec 9, 2008 at 8:10 PM, Anirban Sinha [EMAIL PROTECTED] wrote: There is yet another bug in Openntpd. This is direct copy-paste from openntpd code (ntpd.c:main()): do { if ((pid = wait(NULL)) == -1 errno != EINTR errno != ECHILD)

Re: possible bug in OpenNTPD code?

2008-12-09 Thread Todd Alan Smith
On Tue, Dec 9, 2008 at 10:10 PM, Anirban Sinha [EMAIL PROTECTED] wrote: I hope I will get some response to this. If not, I will assume that there is really no interest in fixing bugs in openntpd and in that case, Why would you assume that? That seems a bit hostile. Perhaps the developers are a

Re: possible bug in OpenNTPD code?

2008-12-09 Thread Anirban Sinha
How is it blocking indefinitely? Is wait() not returning -1 with errno == ECHILD when there are no children to reap? What led you to the conclusion that this code was blocking? (What platform are you running this on?) Hmm, agreed. Looks like I was wrong with my analysis. In any case, I am

Re: possible bug in OpenNTPD code?

2008-12-09 Thread Anirban Sinha
Why would you assume that? That seems a bit hostile. Perhaps the developers are a bit busy at the moment. True. I generally post on the Linux lists and I believe I am spoiled by getting quick responses from my postings. In future, I will remember to keep more patience. Ani

Re: possible bug in OpenNTPD code?

2008-12-09 Thread Otto Moerbeek
On Wed, Dec 10, 2008 at 12:05:05AM -0600, Todd Alan Smith wrote: On Tue, Dec 9, 2008 at 10:10 PM, Anirban Sinha [EMAIL PROTECTED] wrote: I hope I will get some response to this. If not, I will assume that there is really no interest in fixing bugs in openntpd and in that case, Why would

Re: possible bug in OpenNTPD code?

2008-12-09 Thread Otto Moerbeek
On Tue, Dec 09, 2008 at 09:57:25PM -0800, Philip Guenther wrote: On Tue, Dec 9, 2008 at 8:10 PM, Anirban Sinha [EMAIL PROTECTED] wrote: There is yet another bug in Openntpd. This is direct copy-paste from openntpd code (ntpd.c:main()): do { if ((pid = wait(NULL)) == -1

possible bug in OpenNTPD code?

2008-12-04 Thread Anirban Sinha
Hi: I am sort of digging my way through the OpenNTPD codebase for my work. I think I find a bug in the code. Please help me to understand the reason if this is not a bug. In function ntp_main() (ntp.c), we poll() to check if there are any events of interest. We do this: 1. Check internal fds