Re: Making a portable version of imsg - where to find regression tests?

2020-12-12 Thread Aisha Tammy
On 12/12/20 6:18 PM, Ingo Schwarze wrote:
> Hi Aisha,
> 
> Aisha Tammy wrote on Sat, Dec 12, 2020 at 05:40:14PM -0500:
> 
>> I was trying to create a small standalone portable version of the
>> imsg utilities for linux and I managed to get it compiling (yea!!)
>> and have put it on github [1].
> 
> I freely admit i didn't look at that.
> 
>> It is also working with trivial test cases that I manually generated.
>> For completeness, I was also trying to find regression tests for imsg
>> but I couldn't find them in the source code (in fact, couldn't find
>> them for whole of libutil, make regress just does nothing).
> 
> OpenBSD never mixes regression tests into the main directories of the
> src tree.  All regression tests are in /usr/src/regress/.  In particular,
> those for libutil are in /usr/src/regress/lib/libutil/.
> 
>> Could anyone point to where I should look for these regression tests
> 
> If somebody wrote any regression tests for imsg, the place to put them
> would be /usr/src/regress/lib/libutil/imsg/.
> 
>> (if they exist?)
> 
> It doesn't appear there are any automated tests for imsg right now.
> Several parts of OpenBSD have regression tests, but not all have.
> 
> Yours,
>   Ingo
> 

Awesome, thanks a lot Inigo :D
That's very informative.

Cheers,
Aisha



Making a portable version of imsg - where to find regression tests?

2020-12-12 Thread Aisha Tammy
Hi,
  I was trying to create a small standalone portable version of the imsg 
utilities
for linux and I managed to get it compiling (yea!!) and have put it on github 
[1].
It is also working with trivial test cases that I manually generated.
For completeness, I was also trying to find regression tests for imsg but I 
couldn't
find them in the source code (in fact, couldn't find them for whole of libutil,
make regress just does nothing).
Could anyone point to where I should look for these regression tests (if they 
exist?)

Cheers,
Aisha

PS: thanks a lot to all of the creators of imsg :D

[1] https://github.com/bsd-ac/imsg-compat


Re: Making a portable version of imsg - where to find regression tests?

2020-12-12 Thread Ingo Schwarze
Hi Aisha,

Aisha Tammy wrote on Sat, Dec 12, 2020 at 05:40:14PM -0500:

> I was trying to create a small standalone portable version of the
> imsg utilities for linux and I managed to get it compiling (yea!!)
> and have put it on github [1].

I freely admit i didn't look at that.

> It is also working with trivial test cases that I manually generated.
> For completeness, I was also trying to find regression tests for imsg
> but I couldn't find them in the source code (in fact, couldn't find
> them for whole of libutil, make regress just does nothing).

OpenBSD never mixes regression tests into the main directories of the
src tree.  All regression tests are in /usr/src/regress/.  In particular,
those for libutil are in /usr/src/regress/lib/libutil/.

> Could anyone point to where I should look for these regression tests

If somebody wrote any regression tests for imsg, the place to put them
would be /usr/src/regress/lib/libutil/imsg/.

> (if they exist?)

It doesn't appear there are any automated tests for imsg right now.
Several parts of OpenBSD have regression tests, but not all have.

Yours,
  Ingo



Neighbor Solicitation packets try to go out on enc0

2020-12-12 Thread Axel Rau
Hello

I have a router, running rad(8).
SLAAC works as expected, but I see:
- - -
11:40:58.374264 rule 16/(match) [uid 0, pid 97445] block out on enc0: \
??:??:??:34::a > ??:??:??:34:3551:6e57:d90b:5a77: \
icmp6: neighbor sol: who has ??:??:??:34:3551:6e57:d90b:5a77\
(src lladdr: 00:60:e0:5a:75:43) [bad icmp6 cksum 0! -> b7e4] (len 32, hlim 255)
- - -
related if:
- - -
vlan14: flags=8843 mtu 1500
lladdr 00:60:e0:5a:75:43
index 16 priority 0 llprio 3
encap: vnetid 14 parent em3 txprio packet rxprio outer
groups: vlan
media: Ethernet autoselect (1000baseT full-duplex)
status: active
inet 172.16.14.1 netmask 0xff00 broadcast 172.16.14.255
inet6 fe80::260:e0ff:fe5a:7543%vlan14 prefixlen 64 scopeid 0x10
inet6 ??:??:??:34::a prefixlen 64

What is going wrong here?
Axel
---
PGP-Key: CDE74120  ☀  computing @ chaos claudius



signature.asc
Description: Message signed with OpenPGP


Switching from trunk(4) to aggr(4)

2020-12-12 Thread Daniel Jakots
Hi,

I've been using a LACP trunk on my apu (with the three em(4)). On
top of which I have some vlans. I've been doing that for years and it's
working fine.

I thought about using aggr(4) instead (for no real reason). But the
aggr interface stays in "status: no carrier".

What I did is, I replaced my hostname.trunk0

trunkproto lacp trunkport em0 trunkport em1 trunkport em2
up

with a hostname.aggr0

trunkport em0 trunkport em1 trunkport em2
up

(and changing the parent in my hostname.vlan*). To apply the new
configuration, I just reboot.

My trunk0 which works is
trunk0: flags=8843 mtu 1500 
   
lladdr 00:0d:b9:43:9f:fc
   
index 7 priority 0 llprio 3 
   
trunk: trunkproto lacp  
   
trunk id: [(8000,00:0d:b9:43:9f:fc,403C,,), 
   
 (0080,00:00:00:00:00:00,,,)]   
   
em2 lacp actor system pri 0x8000 mac 00:0d:b9:43:9f:fc, key 
0x403c, port pri 0x8000 number 0x3 
em2 lacp actor state 
activity,aggregation,sync,collecting,distributing,defaulted
em2 lacp partner system pri 0x80 mac 00:00:00:00:00:00, key 
0x0, port pri 0x80 number 0x0 
em2 lacp partner state aggregation,sync,collecting,distributing 
   
em2 port active,collecting,distributing 
   
em1 lacp actor system pri 0x8000 mac 00:0d:b9:43:9f:fc, key 
0x403c, port pri 0x8000 number 0x2 
em1 lacp actor state 
activity,aggregation,sync,collecting,distributing,defaulted
em1 lacp partner system pri 0x80 mac 00:00:00:00:00:00, key 
0x0, port pri 0x80 number 0x0 
em1 lacp partner state aggregation,sync,collecting,distributing 
   
em1 port active,collecting,distributing 
   
em0 lacp actor system pri 0x8000 mac 00:0d:b9:43:9f:fc, key 
0x403c, port pri 0x8000 number 0x1 
em0 lacp actor state 
activity,aggregation,sync,collecting,distributing,defaulted
em0 lacp partner system pri 0x80 mac 00:00:00:00:00:00, key 
0x0, port pri 0x80 number 0x0 
em0 lacp partner state aggregation,sync,collecting,distributing 
   
em0 port active,collecting,distributing 
   
groups: trunk   
   
media: Ethernet autoselect  
   
status: active

And the aggr0 which doesn't come up is:
aggr0: flags=8843 mtu 1500  
   
lladdr 00:0d:b9:43:9f:fc
   
index 6 priority 0 llprio 7 
   
trunk: trunkproto lacp  
   
trunk id: [(8000,00:0d:b9:43:9f:fc,0006,,), 
   
 (,00:00:00:00:00:00,,,)]   
   
em0 lacp actor system pri 0x8000 mac 00:0d:b9:43:9f:fc, key 
0x6, port pri 0x8000 number 0x1 
em0 lacp actor state activity,aggregation,defaulted 
   
em0 lacp partner system pri 0x0 mac 00:00:00:00:00:00, key 0x0, 
port pri 0x0 number 0x0 
em0 lacp partner state activity,aggregation,sync
   
em0 port
   
em1 lacp actor system pri 0x8000 mac 00:0d:b9:43:9f:fc, key 
0x6, port pri 0x8000 number 0x2 
em1 lacp actor state activity,aggregation,defaulted 
   
em1 lacp partner system pri 0x0 mac 00:00:00:00:00:00, key 0x0, 
port pri 0x0 number 0x0 
em1 lacp partner state activity,aggregation,sync
   
em1 port
   
em2 lacp actor system pri 0x8000 mac 00:0d:b9:43:9f:fc, key 
0x6, port pri 0x8000 number 0x3 
em2 lacp actor state activity,aggregation,defaulted 
   
em2 lacp partner system pri 0x0 mac 00:00:00:00:00:00, key 0x0, 
port pri 0x0 number 0x0 
em2 lacp partner state activity,aggregation,sync
   
em2 port
   
groups: aggr
   
media: Ethernet autoselect