Re: Single PR or many smaller PRs?

2020-10-15 Thread Demi M. Obenour
On 10/15/20 2:06 PM, Chris Bennett wrote: > On Thu, Oct 15, 2020 at 01:14:00PM -0400, Demi M. Obenour wrote: >> On 10/15/20 12:05 PM, Joerg Jung wrote: >>> As mentioned by Gilles earlier, please send them as unified diffs >>> to t...@openbsd.org if you want to have them

Re: Single PR or many smaller PRs?

2020-10-15 Thread Demi M. Obenour
On 10/15/20 2:06 PM, Chris Bennett wrote: > On Thu, Oct 15, 2020 at 01:14:00PM -0400, Demi M. Obenour wrote: >> On 10/15/20 12:05 PM, Joerg Jung wrote: >>> As mentioned by Gilles earlier, please send them as unified diffs >>> to t...@openbsd.org if you want to have them

Re: Single PR or many smaller PRs?

2020-10-15 Thread Chris Bennett
On Thu, Oct 15, 2020 at 01:14:00PM -0400, Demi M. Obenour wrote: > On 10/15/20 12:05 PM, Joerg Jung wrote: > > As mentioned by Gilles earlier, please send them as unified diffs > > to t...@openbsd.org if you want to have them > > reviewed. > > My branch is based on the

Re: Single PR or many smaller PRs?

2020-10-15 Thread Demi M. Obenour
On 10/15/20 12:05 PM, Joerg Jung wrote: > As mentioned by Gilles earlier, please send them as unified diffs > to t...@openbsd.org if you want to have them > reviewed. My branch is based on the portable branch. Do I need to rebase off of the OpenBSD repository first? D

Re: Single PR or many smaller PRs?

2020-10-15 Thread Joerg Jung
> On 15. Oct 2020, at 16:32, Demi M. Obenour wrote: > > On 10/15/20 12:48 AM, Demi M. Obenour wrote: >> On 10/14/20 7:31 PM, gil...@poolp.org wrote: >>> October 14, 2020 11:31 PM, "Demi M. Obenour" wrote: That makes sense. I will make a separate PR that just has some automake fixes. >

Re: Single PR or many smaller PRs?

2020-10-15 Thread Demi M. Obenour
On 10/15/20 12:48 AM, Demi M. Obenour wrote: > On 10/14/20 7:31 PM, gil...@poolp.org wrote: >> October 14, 2020 11:31 PM, "Demi M. Obenour" wrote: >>> That makes sense. I will make a separate PR that just has some >>> automake fixes. >>> >> >> perfect > > I filed https://github.com/OpenSMTPD/Open

Re: Single PR or many smaller PRs?

2020-10-14 Thread Demi M. Obenour
On 10/14/20 7:31 PM, gil...@poolp.org wrote: > October 14, 2020 11:31 PM, "Demi M. Obenour" wrote: >> That makes sense. I will make a separate PR that just has some >> automake fixes. >> > > perfect I filed https://github.com/OpenSMTPD/OpenSMTPD/pull/1093. That’s the biggest diff in the whole s

Re: Single PR or many smaller PRs?

2020-10-14 Thread gilles
October 14, 2020 11:31 PM, "Demi M. Obenour" wrote: > On 10/14/20 3:18 PM, gil...@poolp.org wrote: > >> October 12, 2020 10:06 PM, "Demi M. Obenour" wrote: >> >>> I created https://github.com/OpenSMTPD/OpenSMTPD/pull/1087, which >>> fixes some bugs and avoids spawning shells when it isn’t nece

Re: Single PR or many smaller PRs?

2020-10-14 Thread Demi M. Obenour
On 10/14/20 3:18 PM, gil...@poolp.org wrote: > October 12, 2020 10:06 PM, "Demi M. Obenour" wrote: > >> I created https://github.com/OpenSMTPD/OpenSMTPD/pull/1087, which >> fixes some bugs and avoids spawning shells when it isn’t necessary >> to do so. Should I split it up into multiple smaller P

Re: Single PR or many smaller PRs?

2020-10-14 Thread gilles
October 12, 2020 10:06 PM, "Demi M. Obenour" wrote: > I created https://github.com/OpenSMTPD/OpenSMTPD/pull/1087, which > fixes some bugs and avoids spawning shells when it isn’t necessary > to do so. Should I split it up into multiple smaller PRs? Also, > it has only been tested on Linux. > He

Single PR or many smaller PRs?

2020-10-12 Thread Demi M. Obenour
I created https://github.com/OpenSMTPD/OpenSMTPD/pull/1087, which fixes some bugs and avoids spawning shells when it isn’t necessary to do so. Should I split it up into multiple smaller PRs? Also, it has only been tested on Linux. Sincerely, Demi OpenPGP_0xB288B55FFF9C22C1.asc Description: ap