Hello,
Adding Node.js to depencies for testing is little overkill and I don't
know can JShint be runned on QT5 Ecmascript interpreter (searched but
nobody knows it runs on Rhino). I think we'll should at least check
every code manually with jshint and jsbeautify in future we should adopt
usage
On 09/22/2015 06:56 AM, Be wrote:
Wouldn't that require making Node.js a dependency for the tests? Is that
worth it?
For testing? I would say so, since it would only be required for running
the tests, not just building Mixxx. Though I have no idea how heavy
Node.js is.
Sincerely,
Sean M.
Wouldn't that require making Node.js a dependency for the tests? Is that
worth it?
On 09/22/2015 08:50 AM, Sean M. Pappalardo - D.J. Pegasus wrote:
> Hello.
>
> This is a good point. Can you possibly add a test to the suite that runs
> jshint (and other checkers in the future) on all of the mappi
Hello.
This is a good point. Can you possibly add a test to the suite that runs
jshint (and other checkers in the future) on all of the mapping files?
Sincerely,
Sean M. Pappalardo
"D.J. Pegasus"
Mixxx Developer - Controller Specialist
smime.p7s
Description: S/MIME Cryptographic Signature
-
I'm already using "jshint --show-non-errors" before publishing a new version
of a mapping script.
My mapping script contains a special header with some inline directives for
JSHint:
// JSHint configuration
