I see this every time I exit:
Warning [Main]: DEBUG ASSERT: "isRunning()" in file
src/engine/sidechain/engineshoutcast.cpp, line 107
Warning [Main]: EngineShoutcast:~EngineShoutcast(): Thread didn't die.
Ignored but add this to bug report if problems rise!
Since this is a debug assert, it will
I see it too FWIW.
Sincerely,
Sean M. Pappalardo
"D.J. Pegasus"
Mixxx Developer - Controller Specialist
smime.p7s
Description: S/MIME Cryptographic Signature
--
Go from Idea to Many App Stores Faster with Intel(R) XDK
G
On 12/07/2015 08:06 AM, Owen Williams wrote:
> Warning [Main]: EngineShoutcast:~EngineShoutcast(): Thread didn't die.
> Ignored but add this to bug report if problems rise!
BTW, which bug report? (Whoever wrote this message should have included
the bug number because I can't find it.)
Sincere
According to git blame debug statement first appeared in commit 4743a48
https://github.com/mixxxdj/mixxx/commit/4743a48
I'm not sure how to find out in which PR this was included though.
On 12/07/2015 05:26 PM, Sean M. Pappalardo - D.J. Pegasus wrote:
>
>
> On 12/07/2015 08:06 AM, Owen Williams
Hello,
Yes.. I wrote it message and no it doesn't have any bug. It just noise
and can be removed.
Tuukka
07.12.2015, 18:20, Sean M. Pappalardo - D.J. Pegasus kirjoitti:
I see it too FWIW.
Sincerely,
Sean M. Pappalardo
"D.J. Pegasus"
Mixxx Developer - Controller Specialist
On 12/07/2015 09:23 AM, Tuukka Pasanen wrote:
> Hello,
> Yes.. I wrote it message and no it doesn't have any bug. It just noise
> and can be removed.
How about the assert?
DEBUG_ASSERT_AND_HANDLE(isRunning())
Sincerely,
Sean M. Pappalardo
"D.J. Pegasus"
Mixxx Developer - Controller Specialist
We should fix the underlying bug. If the shoutcast thread isn't getting
shut down that's a problem.
On Mon, 2015-12-07 at 09:31 -0800, Sean M. Pappalardo - D.J. Pegasus
wrote:
>
> On 12/07/2015 09:23 AM, Tuukka Pasanen wrote:
> > Hello,
> > Yes.. I wrote it message and no it doesn't have any bug
Hi,
the issue was a false positive due to a missing ! that has slipped
though. I have just fixed it in c99b71c4019f7e821d9da7950b2f527d3e2fbf20
By the way: it was already DEBUG_ASSERT_AND_HANDLE(!isRunning()) { used.
As simple DEBUG_ASSERT would work as well since it is removed in release
builds.
Hello,
It was kind of added for crashes caused by new thread. Many users can't
gdb or use debugger. Thank for fix me :D
Sincerely,
Tuukka
07.12.2015, 21:35, Daniel Schürmann kirjoitti:
> Hi,
>
> the issue was a false positive due to a missing ! that has slipped
> though. I have just fixed it in
