Re: [Mixxx-devel] Sound Source API test.

2015-04-19 Thread Uwe Klotz
::doubleMonoToDualMono(float *,int) (?doubleMonoToDualMono@S ampleUtil@@SAXPAMH@Z) win32_build\plugins\win32_build\mediafoundation\soundsourcemediafoundation.dll : fatal error LNK1120: 6 unresolved externals On Fri, Apr 17, 2015 at 1:25 AM, Uwe Klotz uwe_kl...@web.de mailto:uwe_kl...@web.de wrote

Re: [Mixxx-devel] Sound Source API test.

2015-04-16 Thread Uwe Klotz
Thank you for your tests, Ryan! Since the old build server has been shut down I never got any feedback about my modifications on other platforms than Linux. SoundSourceSndFile is responsible for decoding WAV files. The file is analyzed correctly and plays without any issues on Fedora 21

Re: [Mixxx-devel] Sound Source API test.

2015-04-17 Thread Uwe Klotz
:14 AM, Uwe Klotz uwe_kl...@web.de mailto:uwe_kl...@web.de wrote: Thank you for your tests, Ryan! Since the old build server has been shut down I never got any feedback about my modifications on other platforms than Linux. SoundSourceSndFile is responsible for decoding WAV files

Re: [Mixxx-devel] beta deadline suggestion

2015-04-17 Thread Uwe Klotz
Just some words from my side. I really don't want to give any recommendations to you, because I'm biased ;) The NewSoundSourceAPI branch has gone through many iterations and Daniel spent a LOT of time reviewing my code very thoroughly. He also provided the key ideas to fix the MP3 decoding

Re: [Mixxx-devel] ALAC support in libsndfile since 2012 - test please

2015-06-17 Thread Uwe Klotz
]: DEBUG ASSERT: pAudioSource-isValidFrameIndex(frameIndex) in file src/analyserqueue.cpp, line 187 Warning [AnalyserQueue 1]: DEBUG ASSERT: pAudioSource-isValidFrameIndex(frameIndex) in file src/analyserqueue.cpp, line 222 On 06/16/2015 11:46 PM, Uwe Klotz wrote: Main blocker: Mixxx currently

Re: [Mixxx-devel] ALAC support in libsndfile since 2012 - test please

2015-06-17 Thread Uwe Klotz
After discovering that my libsndfile 1.0.25 is not able to open and play ALAC files I checked the website. The latest official version is 1.0.25 from 2011 and it does not support ALAC: http://www.mega-nerd.com/libsndfile The only fallback for ALAC support will be FFmpeg. Uwe On 06/16/2015

Re: [Mixxx-devel] merging 1.12 - master

2015-06-16 Thread Uwe Klotz
I may provide a resolution of the merge conflicts for the SoundSourceProxy tests. On 06/16/2015 03:13 AM, Owen Williams wrote: Master and 1.12 have diverged to the point where they are not merging cleanly. We need to make sure that bug fixes that go into 1.12 get back into master. Can

Re: [Mixxx-devel] merging 1.12 - master

2015-06-16 Thread Uwe Klotz
...and of course also for the remaining modifications. More than I expected ;) On 06/16/2015 08:29 AM, Uwe Klotz wrote: I may provide a resolution of the merge conflicts for the SoundSourceProxy tests. On 06/16/2015 03:13 AM, Owen Williams wrote: Master and 1.12 have diverged to the point

Re: [Mixxx-devel] new master failure: missing WAV files

2015-11-16 Thread Uwe Klotz
libsndfile (.aiff, .wav) fails to open paths like "file:///C:/..." produced by QUrl::toLocalFile(). We have to find out when and how this started. I remember that the tests on master were working when I fixed the SoundSourceMediaFoundation class. Might also be related to the recent Windows

Re: [Mixxx-devel] 1.12 -> trunk merge needs help

2015-10-14 Thread Uwe Klotz
Daniel has already migrated his changes for Windows (UTF-16/wchar_t) from 1.12 to master separately. It should be safe if we just choose the SoundSource and TagLib files from master in case of conflicts. On 10/15/2015 02:05 AM, Owen Williams wrote: > Can someone carefully do a merge from 1.12

Re: [Mixxx-devel] Javascript code checking

2015-09-22 Thread Uwe Klotz
I'm already using "jshint --show-non-errors" before publishing a new version of a mapping script. My mapping script contains a special header with some inline directives for JSHint: // JSHint configuration

Re: [Mixxx-devel] Proposal: delete the VAMP plugin and SoundSource plugin code

2015-12-09 Thread Uwe Klotz
Yes, I agree. On the long run this is the way to go. On the other hand I would like to keep the current (= master/2.1) SoundSourceM4A based on FAAD2 on Linux until the quality and performance of SoundSourceFFmpeg is at least comparable. This also applies to SoundSourceMP3 based on libMAD even

Re: [Mixxx-devel] Qt 5 request for testing

2016-01-04 Thread Uwe Klotz
Fedora 23 x86_64 Required packages for building with qt5=1: * qt5-qtbase-devel * qt5-qtscript-devel * qt5-qtsvg-devel * qt5-qtxmlpatterns-devel * qt5-linguist Minor bug: Library table view is empty after startup. Only after selecting another side bar item and selecting it again it gets

Re: [Mixxx-devel] new master failure: missing WAV files

2015-11-18 Thread Uwe Klotz
This PR should fix the issues with libsndfile: https://github.com/mixxxdj/mixxx/pull/778 All tests succeeded. On 11/15/2015 06:58 PM, Owen Williams wrote: > tests are failing because the wave files are missing, not sure why that > is -- could be a jenkins-specific problem: > > RUN ]

Re: [Mixxx-devel] Fwd: [libsndfile-devel] Version 1.0.26 released

2015-11-23 Thread Uwe Klotz
I've just added some comments to the launchpad bug. Uwe On 11/23/2015 07:06 AM, Sean M. Pappalardo - D.J. Pegasus wrote: Sweet, another library update! Mixxx 2.1 will nab this goodness. Is anyone interested in adding ALAC support? I know some DJ pools offer lossless music in this format.

Re: [Mixxx-devel] thoughts about our windows build env

2016-06-19 Thread Uwe Klotz
Great idea, that's what I'm waiting for :) The Windows code is barely tested due to lack of contributors and a missing CI environment. On the other hand the Windows user base seems to be big. In the past I've used a VM, no cross compiling. A VM is still a native Windows installation where you

Re: [Mixxx-devel] Windows 10 warning

2016-01-22 Thread Uwe Klotz
The SoundSourceMediaFoundation plugin that is used for M4A playback on Windows definitely has open issues: https://bugs.launchpad.net/mixxx/+bug/1490580 A fix for 2.0.x is not recommended, because 2.1 will introduce the reworked SoundSource framework. But a fix for 2.1 would definitely be

[Mixxx-devel] Test EngineBufferTest.SlowRubberBand failing with DEBUG_ASSERT

2016-02-21 Thread Uwe Klotz
The EngineBufferTest.SlowRubberBand test is failing with a DEBUG_ASSERT on master: [ RUN ] EngineBufferTest.SlowRubberBand Loading resources from "/home/uk/Projects/Mixxx/mixxx/res/" ConfigObject: Could not read "/home/uk/Projects/Mixxx/mixxx/src/test/test_data/test.cfg" Compressor attack

[Mixxx-devel] No nighty builds for Windows x64

2017-01-29 Thread Uwe Klotz
Did you notice that no nightly builds for Windows x64 are available since some days? http://downloads.mixxx.org/builds/master/release/ It started when the x86 packages became much larger than before. -- Check out the

Re: [Mixxx-devel] feature request: Analysis progress

2017-07-11 Thread Uwe Klotz
I cannot confirm your bug report. Both the analysis progress per track and the remaining tracks scheduled for analysis are shown in the UI and updated properly in all views. I'm also not able to reproduce any UI freezes during batch analysis of mutliple tracks. The analysis is performed in a

Re: [Mixxx-devel] Proper way to update PR's

2017-07-10 Thread Uwe Klotz
You need to remember the base version of your commits to reapply them without introducing unresolvable conflicts. Git even supports rebasing a range of commits "onto" a new root commit. Your personal customizations should always stay/land on top of the commit history. Creating a backup branch

Re: [Mixxx-devel] Proper way to update PR's

2017-07-10 Thread Uwe Klotz
You need to remember the base version of your commits to reapply them without introducing unresolvable conflicts. Git even supports rebasing a range of commits "onto" a new root commit. Your personal customizations should always stay/land on top of the commit history. Creating a backup branch

Re: [Mixxx-devel] Linux nightly builds

2017-12-03 Thread Uwe Klotz
https://github.com/mixxxdj/mixxx/pull/1405 Someone else should merge it ;) On 03.12.2017 17:40, Sean M. Pappalardo - D.J. Pegasus wrote: On 12/03/2017 07:18 AM, ronso wrote: What happened to the linux build server? Latest build at http://downloads.mixxx.org/builds/master/release/ is from

Re: [Mixxx-devel] Linux nightly builds

2017-12-03 Thread Uwe Klotz
I'll review my commits and try to guess what might be causing this issue. Are you able to start the build with an additional scons argument? Then please try "--debug=explain,presub,prepare,stacktrace". Strange that neither our Trusty builds on Travis nor building with the latest 2.x version

Re: [Mixxx-devel] Linux nightly builds

2017-12-03 Thread Uwe Klotz
I can reproduce the issue when piping the ouput. In this case sys.stdout.encoding that is used for decoding output from a subprocess seems to be undefined and decoding fails: https://stackoverflow.com/questions/492483/setting-the-correct-encoding-when-piping-stdout-in-python Anyone with

Re: [Mixxx-devel] Controller Questions

2018-07-07 Thread Uwe Klotz
Welcome, Thomas. Discussions now take place on Zulip: https://mixxx.zulipchat.com/ I suggest to ask your valid questions there again. Since I don't consider myself a controller mapping pro, please don't take my following remarks (see below) too serious. Kind regards, Uwe On 05.07.2018

Re: [Mixxx-devel] Learning how is Mixxx

2018-10-10 Thread Uwe Klotz
Hi Javor, using gRPC for IPC wouldn't surprise me, we already discussed isolating components of Mixxx into separate processes to avoid crashing the main process, i.e. for decoding files. But unfortunately Mixxx is still a monolithic application and we don't use gRPC. What we are using is