Re: [mkgmap-dev] Putting the DP code under the microscope (simplifyWays patch V8)

2009-08-13 Thread Clinton Gladstone
On Wed, Aug 12, 2009 at 8:01 PM, Thilo Hannemannthann...@gmx.de wrote: I'm currently working on it. Have you tried the patch together with routing? In my trials the routing was completely broken after applying the patch. I have tried this with routing, but not yet noticed a significant

Re: [mkgmap-dev] Putting the DP code under the microscope (simplifyWays patch V8)

2009-08-12 Thread Clinton Gladstone
On Sat, Jul 25, 2009 at 3:55 PM, Johann Gailjohann.g...@gmx.de wrote: Find attached an patch of my working copy. It is based mainly on my old simplifyWays patch. Its diffed against the current R1102. The main idea is to merge the lines directly before input them to the filters. It improves

Re: [mkgmap-dev] Putting the DP code under the microscope (simplifyWays patch V8)

2009-08-12 Thread Thilo Hannemann
I'm currently working on it. Have you tried the patch together with routing? In my trials the routing was completely broken after applying the patch. That is because the merging is done *after* all the routing info is generated. So if two ways are merged into one, the references in the

Re: [mkgmap-dev] Putting the DP code under the microscope

2009-07-25 Thread Johann Gail
Hi Johann, it is actually not what it seems to be. The douglasPeucker function is called recursively. If the condition (maxDistance allowedError) is fulfilled, the current part of the way can be reduced to a line (in case start- and endpoint are different points) or a point (in case

Re: [mkgmap-dev] Putting the DP code under the microscope

2009-07-25 Thread Thilo Hannemann
Hi Johann, Am 25.07.2009 um 10:54 schrieb Johann Gail: A further development would be, to consider only nodes which are visible crossings at the current zoom level. I.e. if a residential connects to a big road and the residential is not visible at the current zoom level, then it is

Re: [mkgmap-dev] Putting the DP code under the microscope

2009-07-25 Thread Felix Hartmann
Yeah, merging roads if possible would be great. Even more important would however be smoothing of curves. i.e. make serpentine corners on mountain streets more smooth, because otherwise if there is a say 160° corner, it will add a big time penalty, which in a car is more or less correct, but on a

Re: [mkgmap-dev] Putting the DP code under the microscope

2009-07-25 Thread Thilo Hannemann
Hi Felix, Am 25.07.2009 um 13:05 schrieb Felix Hartmann: Yeah, merging roads if possible would be great. Even more important would however be smoothing of curves. i.e. make serpentine corners on mountain streets more smooth, because otherwise if there is a say 160° corner, it will add a big

Re: [mkgmap-dev] Putting the DP code under the microscope

2009-07-25 Thread Johann Gail
Thilo Hannemann schrieb: Here is another approach to the lost last point. The Douglas Peucker filter is improved so that it can deal with identical start- and endpoints. If the start- and the endpoint are identical, the algorithm calculates the distance between these identical points and the

Re: [mkgmap-dev] Putting the DP code under the microscope (simplifyWays patch V8)

2009-07-25 Thread Johann Gail
However, how do you want to do the merging without loosing attributes (i.e. roadname changes, bridge, etc..), I think this could only work by running after the main processing, and merging everything identical if possible. Otherwise before merging there needs to be a check whether there is not

Re: [mkgmap-dev] Putting the DP code under the microscope

2009-07-24 Thread Johann Gail
Thilo Hannemann schrieb: Here is another approach to the lost last point. The Douglas Peucker filter is improved so that it can deal with identical start- and endpoints. If the start- and the endpoint are identical, the algorithm calculates the distance between these identical points and

Re: [mkgmap-dev] Putting the DP code under the microscope

2009-07-24 Thread Thilo Hannemann
Hi Johann, it is actually not what it seems to be. The douglasPeucker function is called recursively. If the condition (maxDistance allowedError) is fulfilled, the current part of the way can be reduced to a line (in case start- and endpoint are different points) or a point (in case

Re: [mkgmap-dev] Putting the DP code under the microscope

2009-06-17 Thread Johann Gail
Not sure, but is the i-- on line 93 erroneous? As i will be decremented at the end of the loop anyway, it seems to me that the extra decrement will give rise to the possibility that a Coord won't be tested to see if it's a CoordNode and so it will get zapped if it's not outside the error

Re: [mkgmap-dev] Putting the DP code under the microscope

2009-06-17 Thread Mark Burton
Hi Johann, But you are right. If point 4 is a CoordNode then the endpoint should not be zapped. So it is a small bug, but will probably not help at the overview map. Well watched. Please commit that change. OK, I will remove the --i and commit that change. What are your thoughts on the

Re: [mkgmap-dev] Putting the DP code under the microscope

2009-06-17 Thread Mark Burton
Hi Johann, What are your thoughts on the patch (I think it was by Thilo) that replaces the lost last point in each polygon? Seems like a good idea to me. I have looked at the patch only one minute. Seems correct. May thoughts was that the last segment ist not needed, if it is a

Re: [mkgmap-dev] Putting the DP code under the microscope

2009-06-17 Thread Thilo Hannemann
Here is another approach to the lost last point. The Douglas Peucker filter is improved so that it can deal with identical start- and endpoints. If the start- and the endpoint are identical, the algorithm calculates the distance between these identical points and the point p. So the

Re: [mkgmap-dev] Putting the DP code under the microscope

2009-06-17 Thread Johann Gail
Thilo Hannemann schrieb: Here is another approach to the lost last point. The Douglas Peucker filter is improved so that it can deal with identical start- and endpoints. If the start- and the endpoint are identical, the algorithm calculates the distance between these identical points and the