Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-22 Thread Charlie Ferrero
On 11/23/2010 05:20 AM, maning sambale wrote: FYI, I already moved the tags to the multipolygon relation but the 2 poi icons still exist: http://www.openstreetmap.org/browse/relation/452620 I would expect them to, seeing as this is an unwanted outcome of combining the multipolygon and

Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-20 Thread WanMil
I am sorry. The promised patch is more complicated than I thought. The POI generation source code has no access to original tags because it is placed after the transformation from an OSM object to a garmin object. It will take some time to change this. I won't do this before I finished the

Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-18 Thread WanMil
The mp is tagged wrong. http://wiki.openstreetmap.org/wiki/Multipolygon#Tagging points out that the tags are taken from the relation if it has at least one tag beside type=multipolygon. mkgmap follows this rule strictly since r1711. The relation is tagged with name=Manila City Hall so the

[mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-17 Thread maning sambale
This way is tagged as a amenity=townhall and a multipolygon relation: http://www.openstreetmap.org/browse/way/24159829 http://www.openstreetmap.org/browse/relation/452620 In my style: polygons: building=* | man_made=* | amenity=* | tourism=* [0x13 resolution 24] and in the points:

Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-17 Thread Chris66
Am 17.11.2010 13:34, schrieb Greg Troxel: So I think that the relation inherits tags from the outer way, and thus both the multipolygon and the way get a poi point generated. I don't think this is a mkgmap bug. Another possible reason: The MP Code splits the MP to several normal polygons

Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-17 Thread maning sambale
AFAIK, the correct way of tagging is: way 1 - amenity=townhall way 2 - no tag relation type=multipolygon way 1 = outer way 2 = inner I'll check other data to verify. On Wed, Nov 17, 2010 at 8:34 PM, Greg Troxel g...@ir.bbn.com wrote: maning sambale emmanuel.samb...@gmail.com writes: This

Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-17 Thread maning sambale
Can anyone confirm this? (I don't read code sorry) On Wed, Nov 17, 2010 at 8:44 PM, Chris66 chris66...@gmx.de wrote: Am 17.11.2010 13:34, schrieb Greg Troxel: So I think that the relation inherits tags from the outer way, and thus both the multipolygon and the way get a poi point generated.  

Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-17 Thread Marko Mäkelä
On Wed, Nov 17, 2010 at 09:37:17PM +0800, maning sambale wrote: Can anyone confirm this? (I don't read code sorry) If moving all tags from the role=outer way to the multipolygon relation fixes the problem, then Greg Troxel is right. If not, then Chris is right. I may have observed similar

Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-17 Thread Torsten Leistikow
maning sambale schrieb am 17.11.2010 14:36: AFAIK, the correct way of tagging is: way 1 - amenity=townhall way 2 - no tag relation type=multipolygon way 1 = outer way 2 = inner I'll check other data to verify. This one of the possible solutions. Also ok would be way 1 - no tag way

Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-17 Thread Chris66
Another possible reason: The MP Code splits the MP to several normal polygons (without holes), each getting a POI. But this is just a guess. Can anyone confirm this? (I don't read code sorry) Hi, I created a test file with one park and one golf_course. Number of POIs seems to match the

Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-17 Thread Chris66
Number of POIs seems to match the number of holes: http://up.picr.de/5665803.jpg Result is the same if tagging the relation and not the outer way. Chris ___ mkgmap-dev mailing list mkgmap-dev@lists.mkgmap.org.uk

Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-17 Thread Greg Troxel
Marko Mäkelä marko.mak...@iki.fi writes: On Wed, Nov 17, 2010 at 09:37:17PM +0800, maning sambale wrote: Can anyone confirm this? (I don't read code sorry) If moving all tags from the role=outer way to the multipolygon relation fixes the problem, then Greg Troxel is right. If not, then

Re: [mkgmap-dev] 2 pois for a single polygon/multipolygon

2010-11-17 Thread maning sambale
As far as I remember it, It should to be tagged in the outer way. But the wiki says otherwise, http://wiki.openstreetmap.org/wiki/Multipolygon#Usage On Thu, Nov 18, 2010 at 9:03 AM, Greg Troxel g...@ir.bbn.com wrote: Marko Mäkelä marko.mak...@iki.fi writes: On Wed, Nov 17, 2010 at 09:37:17PM