Re: [Mlt-devel] [PATCH] implement matte transition

2014-06-26 Thread Dan Dennedy
On Thu, Jun 26, 2014 at 10:17 AM, Maksym Veremeyenko wrote: > 26.06.14 20:07, Dan Dennedy написав(ла): > [...] >> OK, still some minor problems. In transition_matte_init(), you make >> property "factory" but that is never used. Remove it. >> > i will > >> The bigger problems are now in the yml fil

Re: [Mlt-devel] [PATCH] implement matte transition

2014-06-26 Thread Maksym Veremeyenko
26.06.14 20:07, Dan Dennedy написав(ла): [...] > OK, still some minor problems. In transition_matte_init(), you make > property "factory" but that is never used. Remove it. > i will > The bigger problems are now in the yml file. Why did you not properly > document the full_luma property using the

Re: [Mlt-devel] [PATCH] implement matte transition

2014-06-26 Thread Dan Dennedy
On Thu, Jun 26, 2014 at 1:43 AM, Maksym Veremeyenko wrote: > 26.06.14 09:31, Dan Dennedy написав(ла): > >> On Tue, Jun 24, 2014 at 11:36 PM, Maksym Veremeyenko >> wrote: >>> >>> Hi, >>> >>> attached patch implement *matte* transition. it perform replacing alpha >>> channel of track A with luma of

Re: [Mlt-devel] [PATCH] implement matte transition

2014-06-26 Thread Maksym Veremeyenko
26.06.14 09:31, Dan Dennedy написав(ла): On Tue, Jun 24, 2014 at 11:36 PM, Maksym Veremeyenko wrote: Hi, attached patch implement *matte* transition. it perform replacing alpha channel of track A with luma of track B. Luma of track B will be scaled if it required. Hi Maksym, excellent contri

Re: [Mlt-devel] [PATCH] implement matte transition

2014-06-25 Thread Dan Dennedy
On Tue, Jun 24, 2014 at 11:36 PM, Maksym Veremeyenko wrote: > Hi, > > attached patch implement *matte* transition. it perform replacing alpha > channel of track A with luma of track B. Luma of track B will be scaled if > it required. Hi Maksym, excellent contribution! Have you seen the shape filt