[9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

Hello, Please review the change in testlibrary https://bugs.openjdk.java.net/browse/JDK-8057707 This change is needed for new tests for the feature Lambda Form Reduction and Caching https://bugs.openjdk.java.net/browse/JDK-8046703 Webrev of the testlibrary change:

[9] Review request : JDK-8057719: Develop new tests for LambdaForm Reduction and Caching feature

Hello, Please review the new tests for the feature Lambda Form Reduction and Caching https://bugs.openjdk.java.net/browse/JDK-8046703 JBS task: https://bugs.openjdk.java.net/browse/JDK-8057719 Webrev: http://cr.openjdk.java.net/~kshefov/8057719/webrev.00/ These tests also depend on

Re: [9] Review request : JDK-8057707: TEST library enhancement: copy sun.hotspot.whitebox classes from hotspot repo and enhance lib/testlibrary/jsr292/com/oracle/testlibrary/jsr292/Helper.java

Исходное сообщение От: Alan Bateman alan.bate...@oracle.com Дата:06.09.2014 0:38 (GMT+04:00) Кому: Konstantin Shefov konstantin.she...@oracle.com,VLADIMIR.X.IVANOV vladimir.x.iva...@oracle.com,core-libs-...@openjdk.java.net,mlvm-dev@openjdk.java.net Тема: Re: [9] Review request

[9] Review request : JDK-8058728: TEST_BUG: Make java/lang/invoke/LFCaching/LFGarbageCollectedTest.java skip arrayElementSetter and arrayElementGetter methods

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058728 Webrev is http://cr.openjdk.java.net/~kshefov/8058728/webrev.00 Thanks -Konstantin ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net

Re: [9] Review request : JDK-8058728: TEST_BUG: Make java/lang/invoke/LFCaching/LFGarbageCollectedTest.java skip arrayElementSetter and arrayElementGetter methods

:50 PM, Konstantin Shefov wrote: Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058728 Webrev is http://cr.openjdk.java.net/~kshefov/8058728/webrev.00 Thanks -Konstantin ___ mlvm-dev mailing list mlvm-dev

[9] Review request : JDK-8058695: [TESTBUG] Reinvokers with arity 253 can't be cached

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058695 Webrev is http://cr.openjdk.java.net/~kshefov/8058695/webrev.00/ There is also a fix to https://bugs.openjdk.java.net/browse/JDK-8058733 in this diff. Thanks -Konstantin

Re: [9] Review request : JDK-8058695: [TESTBUG] Reinvokers with arity 253 can't be cached

Hi, I have updated the webrev: http://cr.openjdk.java.net/~kshefov/8058695/webrev.01 Also I will move fix to JDK-8058733 to other request. -Konstantin On 24.09.2014 19:54, Konstantin Shefov wrote: Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058695

Re: [9] Review request : JDK-8058695: [TESTBUG] Reinvokers with arity 253 can't be cached

://cr.openjdk.java.net/~kshefov/8058695/webrev.01 Also I will move fix to JDK-8058733 to other request. -Konstantin On 24.09.2014 19:54, Konstantin Shefov wrote: Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058695 Webrev is http://cr.openjdk.java.net/~kshefov/8058695

Re: [9] Review request : JDK-8058695: [TESTBUG] Reinvokers with arity 253 can't be cached

TestMethods(String name) { this.name = name; +this.maxArity = Helper.MAX_ARITY; } please call TestMethods(String, int) from TestMethods(String) instead of copypaste. Thanks, Igor On 10/01/2014 05:46 PM, Konstantin Shefov wrote: Thanks for reviewing http

[9] Review request : JDK-8058733: [TESTBUG] java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java and LFMultiThreadCachingTest.java failed on some platforms due to java.lang.VirtualMachineError

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058733 Webrev is http://cr.openjdk.java.net/~kshefov/8058733/webrev.00/ Thanks -Konstantin ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net

Re: [9] Review request : JDK-8058733: [TESTBUG] java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java and LFMultiThreadCachingTest.java failed on some platforms due to java.lang.VirtualMachineErro

:24, Vladimir Ivanov wrote: Konstantin, What kind of testing have you done to verify the fix? Best regards, Vladimir Ivanov On 10/8/14, 5:15 PM, Konstantin Shefov wrote: Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8058733 Webrev is http://cr.openjdk.java.net

Re: [9] Review request : JDK-8058733: [TESTBUG] java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java and LFMultiThreadCachingTest.java failed on some platforms due to java.lang.VirtualMachineErro

: HotSpotDiagnosticMXBean mbean = ManagementFactory.getPlatformMXBean(HotSpotDiagnosticMXBean.class); to get a handle on the MBean. You don't need to go through the MBeanServer and newPlatformMXBeanProxy stuff... best regards, -- daniel On 08/10/14 15:15, Konstantin Shefov wrote: Hello, Please review the test bug

Re: [9] Review request : JDK-8058733: [TESTBUG] java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java and LFMultiThreadCachingTest.java failed on some platforms due to java.lang.VirtualMachineErro

on the failing tests passing as modified. Thanks, -Joe On 10/8/2014 7:38 AM, Konstantin Shefov wrote: Daniel, Thanks for your comment Here is the updated webrev: http://cr.openjdk.java.net/~kshefov/8058733/webrev.01 -Konstantin On 08.10.2014 17:25, Daniel Fuchs wrote: Hi Konstantin, I'm

Re: [9] Review request : JDK-8058733: [TESTBUG] java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java and LFMultiThreadCachingTest.java failed on some platforms due to java.lang.VirtualMachineErro

Gently reminder On 09.10.2014 19:56, Joe Darcy wrote: Looks fine Konstantin. (These tests have been failing very often since they were pushed. If your fix isn't pushed today, I'd argue for the tests being excluded.) Please, review Thanks, -Joe On 10/9/2014 1:44 AM, Konstantin Shefov

Re: [9] Review request : JDK-8058733: [TESTBUG] java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java and LFMultiThreadCachingTest.java failed on some platforms due to java.lang.VirtualMachineErro

Thanks for reviewing! Pushed. -Konstantin 10.10.2014 19:06, Vladimir Ivanov пишет: Looks good. Best regards, Vladimir Ivanov On 10/9/14, 12:44 PM, Konstantin Shefov wrote: Hi, I have updated the webrev to take into account the JDK 9 new feature with segmented code cache. http

[9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8059070 Webrev is http://cr.openjdk.java.net/~kshefov/8059070/webrev.00/ Thanks -Konstantin ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net

Re: [9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

Gently reminder On 14.10.2014 16:58, Konstantin Shefov wrote: Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8059070 Webrev is http://cr.openjdk.java.net/~kshefov/8059070/webrev.00/ Thanks -Konstantin ___ mlvm

Re: [9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

Gently reminder 29.10.2014 17:25, Konstantin Shefov пишет: Please, review a test bug fix. http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/ -Konstantin On 27.10.2014 13:16, Konstantin Shefov wrote: Kindly reminder On 23.10.2014 19:04, Paul Sandoz wrote: On Oct 23, 2014, at 1:25 PM

[9] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8062904 Webrev is http://cr.openjdk.java.net/~kshefov/8062904/webrev.00/ Thanks -Konstantin ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net

Re: [9] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option

Igor, Thanks for your comment! Here is the updated webrev: http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/ -Konstantin On 06.11.2014 17:36, Igor Ignatyev wrote: Konstantin, please use 'java.vm.info' instead of iteration over flags. Igor On 11/06/2014 01:44 PM, Konstantin Shefov

Re: [9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

Gently reminder 29.10.2014 17:25, Konstantin Shefov пишет: Please, review a test bug fix. http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/ -Konstantin On 27.10.2014 13:16, Konstantin Shefov wrote: Kindly reminder On 23.10.2014 19:04, Paul Sandoz wrote: On Oct 23, 2014, at 1:25 PM

Re: [9] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option

Kindly reminder http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/ 06.11.2014 18:20, Konstantin Shefov пишет: Igor, Thanks for your comment! Here is the updated webrev: http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/ -Konstantin On 06.11.2014 17:36, Igor Ignatyev wrote

Re: [9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

, Konstantin Shefov wrote: Gently reminder 29.10.2014 17:25, Konstantin Shefov пишет: Please, review a test bug fix. http://cr.openjdk.java.net/~kshefov/8059070/webrev.01/ -Konstantin On 27.10.2014 13:16, Konstantin Shefov wrote: Kindly reminder On 23.10.2014 19:04, Paul Sandoz wrote: On Oct 23

Re: [9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

Kindly reminder. On 10.11.2014 17:45, Konstantin Shefov wrote: Vladimir, thanks for reviewing I have updated the webrev: http://cr.openjdk.java.net/~kshefov/8059070/webrev.02 I have added DEFAULT_TEST_TIMEOUT constant to Utils class. -Konstantin On 10.11.2014 14:33, Vladimir Ivanov wrote

Re: [9] Review request : JDK-8059070: [TESTBUG] java/lang/invoke/LFCaching/LFMultiThreadCachingTest.java failed - timeout

Hello, Vladimir I have updated the Webrev http://cr.openjdk.java.net/~kshefov/8059070/webrev.02 I have added DEFAULT_TEST_TIMEOUT constant to Utils class. -Konstantin On 13.11.2014 15:48, Konstantin Shefov wrote: Kindly reminder. On 10.11.2014 17:45, Konstantin Shefov wrote: Vladimir

[9] Review request : JDK-8068416: LFGarbageCollectedTest.java fails with OOME: GC overhead limit exceeded

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8068416 Webrev is http://cr.openjdk.java.net/~kshefov/8068416/webrev.01/ Test failure is caused by JDK-8078602 [1]. Suggestion is to exclude the test until [1] is fixed. [1]

Re: [8u-dev] Review request : JDK-8068416: LFGarbageCollectedTest.java fails with OOME: GC overhead limit exceeded

-8078602 On 6/4/15 12:10 PM, Konstantin Shefov wrote: Igor, It seems I have given you wrong information. This test fails with OOME against JDK 9 also, I managed to reproduce the failure now. It was hard to reproduce it because of randomness, I need to rerun the test 50 times. Although the test seems

Re: [8u-dev] Review request : JDK-8068416: LFGarbageCollectedTest.java fails with OOME: GC overhead limit exceeded

which should be fixed and your fix just hides it. Igor On 06/03/2015 10:14 PM, Seán Coffey wrote: I bumped into this failure myself today. I think you've got a typo. 440 should be 40. Looks like a good approach otherwise. Regards, Sean. On 03/06/2015 17:33, Konstantin Shefov wrote: Hello

Re: [8u-dev] Review request : JDK-8068416: LFGarbageCollectedTest.java fails with OOME: GC overhead limit exceeded

, Konstantin Shefov wrote: Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8068416 Webrev is http://cr.openjdk.java.net/~kshefov/8068416/webrev.00/ Test fails only against JDK 8u and passes against JDK 9. Fix is to reduce the number of iterations to 40

Re: [8u-dev] Review request : JDK-8068416: LFGarbageCollectedTest.java fails with OOME: GC overhead limit exceeded

to failures on JDK 8u? and please update the bug w/ gotten information. Thanks, Igor On 06/04/2015 12:10 PM, Konstantin Shefov wrote: Igor, It seems I have given you wrong information. This test fails with OOME against JDK 9 also, I managed to reproduce the failure now. It was hard to reproduce

Re: [8u-dev] Review request : JDK-8068416: LFGarbageCollectedTest.java fails with OOME: GC overhead limit exceeded

the test to be excluded until BMHs are converted to VM anonymous classes. Best regards, Vladimir Ivanov [1] https://bugs.openjdk.java.net/browse/JDK-8078602 On 6/4/15 12:10 PM, Konstantin Shefov wrote: Igor, It seems I have given you wrong information. This test fails with OOME against JDK 9

[9] Review request: JDK-8129532: LFMultiThreadCachingTest.java failed with ConcurrentModificationException

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8129532 Webrev is http://cr.openjdk.java.net/~kshefov/8129532/webrev.00/ Thanks -Konstantin ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net

[9] Review request : JDK-8067005 : Several java/lang/invoke tests fail due to exhausted code cache

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8067005 Webrev is http://cr.openjdk.java.net/~kshefov/8067005/webrev.00/ Thanks -Konstantin ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net

Re: [9] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option

Hello, I have updated the fix once more http://cr.openjdk.java.net/~kshefov/8062904/webrev.03/ Please, review Thanks -Konstantin On 06/16/2015 02:01 PM, Konstantin Shefov wrote: Hello, Please, review the new version of the fix to this issue http://cr.openjdk.java.net/~kshefov/8062904

Re: [9] Review request : JDK-8067005 : Several java/lang/invoke tests fail due to exhausted code cache

?). They aren't general enough to be useful for other tests. Also, processVME name is confusing. I'd introduce something like a runMHTest wrapper and process exceptions there. Best regards, Vladimir Ivanov On 6/17/15 1:19 PM, Konstantin Shefov wrote: Hello, Please review the test bug fix https

Re: [9] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option

to JDK-8046809. have you tried to run the tests on the build where JDK-8046809 is fixed? Igor On 11/06/2014 06:20 PM, Konstantin Shefov wrote: Igor, Thanks for your comment! Here is the updated webrev: http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/ -Konstantin On 06.11.2014 17:36, Igor

Re: [8u-dev] Review request : JDK-8068416: LFGarbageCollectedTest.java fails with OOME: GC overhead limit exceeded

will exclude the test with @ignore 8078602 tag. [1] https://bugs.openjdk.java.net/browse/JDK-8078602 -Konstantin On 06/04/2015 02:28 PM, Konstantin Shefov wrote: Vladimir On 06/04/2015 02:19 PM, Vladimir Ivanov wrote: Konstantin, In all cases when OOME happens the test operates

[8u-dev] Review request : JDK-8062904: TEST_BUG: Tests java/lang/invoke/LFCaching fail when run with -Xcomp option

Hello, Please review the test bug fix https://bugs.openjdk.java.net/browse/JDK-8062904 Webrev is http://cr.openjdk.java.net/~kshefov/8062904/webrev.01/ Test fails only against JDK 8u and passes against JDK 9. Thanks -Konstantin ___ mlvm-dev mailing

[9] RFR: 8060717: [TESTBUG] Improve test coverage of MethodHandles.explicitCastArguments()

Hello, Please review a test improvement. Covered more cases for MethodHandles.explicitCastArguments(). Bug: https://bugs.openjdk.java.net/browse/JDK-8060717 Webrev: http://cr.openjdk.java.net/~kshefov/8060717/webrev.00/ -Konstantin ___ mlvm-dev

Re: [9] RFR: 8060717: [TESTBUG] Improve test coverage of MethodHandles.explicitCastArguments()

Michael, thanks for reviewing! Vladimir, could you take a look, please? -Konstantin On 08/02/2015 05:31 PM, Michael Haupt wrote: Hi Konstantin, Am 31.07.2015 um 18:37 schrieb Konstantin Shefov konstantin.she...@oracle.com mailto:konstantin.she...@oracle.com: Please review a test improvement

Re: [9] RFR: 8060717: [TESTBUG] Improve test coverage of MethodHandles.explicitCastArguments()

Kindly reminder On 08/03/2015 06:06 PM, Konstantin Shefov wrote: Michael, thanks for reviewing! Vladimir, could you take a look, please? -Konstantin On 08/02/2015 05:31 PM, Michael Haupt wrote: Hi Konstantin, Am 31.07.2015 um 18:37 schrieb Konstantin Shefov konstantin.she...@oracle.com