Re: review request (L): 7012648/JDK: move JSR 292 to package java.lang.invoke and adjust names

2011-03-23 Thread Christian Thalinger
On Mar 23, 2011, at 10:10 AM, John Rose wrote: > http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.00/ > > Summary: JDK code for package and class renaming from java.dyn to > java.lang.invoke. > > Includes certain other small changes: > - move remaining (miscellaneous) contents of sun.dyn to

Re: review request (L): 7012648/JDK: move JSR 292 to package java.lang.invoke and adjust names

2011-03-24 Thread Christian Thalinger
On Mar 24, 2011, at 6:30 AM, John Rose wrote: > Thanks for the review, Christian. Here's a little bit more... > > Here's an updated webrev: > http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.01/ > http://cr.openjdk.java.net/~jrose/7012648/webrev.jdk.01.nontriv/ > > The "nontriv" version is

JRuby test/test_crazy_blocks fails

2011-03-24 Thread Christian Thalinger
I reran JRuby tests today and noticed a couple of problems. One I'd like an opinion on is test/test_crazy_blocks. It fails with invokedynamic and I'm not sure if either JRuby or the JDK has a bug. Charlie, do you have an idea? -- Christian $ bin/jruby.sh -Xcompile.invokedynamic=false -J-XX:

Re: JRuby test/test_crazy_blocks fails

2011-03-28 Thread Christian Thalinger
On Mar 24, 2011, at 4:06 PM, Christian Thalinger wrote: > I reran JRuby tests today and noticed a couple of problems. One I'd like an > opinion on is test/test_crazy_blocks. It fails with invokedynamic and I'm > not sure if either JRuby or the JDK has a bug. > > Cha

Re: Possible bug: JVM crash due to GC when using indy

2011-03-28 Thread Christian Thalinger
On Mar 28, 2011, at 7:15 PM, shanka@gmail.com wrote: > The complete hs_err log file is pasted here: > http://pylonshq.com/pasties/4ce99d93fbe70ee1347df7fc100934d2 > > What else should I try? -XX:+UseSerialGC. It seems my previous email didn't make it to the list. -- Christian_

Re: Possible bug: JVM crash due to GC when using indy

2011-03-29 Thread Christian Thalinger
On Mar 28, 2011, at 10:20 PM, shanka@gmail.com wrote: > The complete log is pasted here: > http://pylonshq.com/pasties/b8c342db8d9a342d058584a958d434a4 > > The point where it crashes: (at the function _qformat) is where the JVM > should actually invoke via invokedynamic. > I have tested thi

Re: JRuby test/test_crazy_blocks fails

2011-03-29 Thread Christian Thalinger
Filed. -- Christian > > - Charlie > > On Mon, Mar 28, 2011 at 4:30 AM, Christian Thalinger > wrote: >> On Mar 24, 2011, at 4:06 PM, Christian Thalinger wrote: >>> I reran JRuby tests today and noticed a couple of problems. One I'd like >>> an opin

Re: Possible bug: JVM crash due to GC when using indy

2011-03-29 Thread Christian Thalinger
On Mar 29, 2011, at 8:08 PM, shanka@gmail.com wrote: > On Tue, Mar 29, 2011 at 2:20 AM, Christian Thalinger > wrote: > Is this code available somewhere? Since you said this works with simple > tests I assume you can't extract a simpler testcase that shows the same >

Re: hg: jdk7/hotspot-comp/hotspot: 6817525: turn on method handle functionality by default for JSR 292

2011-04-04 Thread Christian Thalinger
On Apr 1, 2011, at 7:21 PM, Arthur Peters wrote: > Hello there, I've been lurking for a while and watching all the work going on. > > Especially now that things are starting to stabilize I'd be really interested > to play with it. What are the best versions for a casual watcher to play > with? I

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Christian Thalinger
On Apr 4, 2011, at 10:34 AM, Gary Benson wrote: > John Rose wrote: >> On Apr 1, 2011, at 7:33 AM, Gary Benson wrote: >>> This webrev adds support for JSR 292 to Zero: >>> >>> http://cr.openjdk.java.net/~gbenson/zero-jsr292-01/ >> >> Most impressive! I think this matches the following previously

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Christian Thalinger
On Apr 5, 2011, at 4:04 PM, Gary Benson wrote: > Christian Thalinger wrote: >> On Apr 1, 2011, at 4:33 PM, Gary Benson wrote: >>> This webrev adds support for JSR 292 to Zero: >>> >>> http://cr.openjdk.java.net/~gbenson/zero-jsr292-01/ >> >>

Re: Review Request: Zero JSR 292 support

2011-04-05 Thread Christian Thalinger
On Apr 5, 2011, at 4:32 PM, Gary Benson wrote: > Christian Thalinger wrote: >> On Apr 5, 2011, at 4:04 PM, Gary Benson wrote: >>> Christian Thalinger wrote: >>>> hotspot/src/share/vm/interpreter/bytecodeInterpreter.cpp: >>>> >>>> +

Re: review request (S): 7019529: JSR292: java/dyn/ClassValueTest.java depends on sub-test execution order

2011-04-08 Thread Christian Thalinger
On Apr 8, 2011, at 6:59 AM, John Rose wrote: > http://cr.openjdk.java.net/~jrose/7019529/webrev.00 > > This fixes a small problem in unit testing. Looks good. -- Christian ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net

Re: 292 Rocks, Core Smalltalk running thanks to all

2011-04-11 Thread Christian Thalinger
On Apr 11, 2011, at 3:00 PM, Mark Roos wrote: > I know you are all working hard to bring 292 to a release so I thought I > would take a moment > to thank you all for your work and to tell you how much that work helped with > our Smalltalk > porting. > > We have about 500K lines of Smalltalk c

Re: Review Request: Zero JSR 292 support

2011-04-11 Thread Christian Thalinger
On Apr 11, 2011, at 3:16 PM, Gary Benson wrote: > Christian Thalinger wrote: >> On Apr 5, 2011, at 3:46 PM, Gary Benson wrote: >>> Christian Thalinger wrote: >>>> On Apr 4, 2011, at 10:34 AM, Gary Benson wrote: >>>>> John Rose wrote: >>

Re: 292 Rocks, Core Smalltalk running thanks to all

2011-04-12 Thread Christian Thalinger
On Apr 11, 2011, at 8:01 PM, Mark Roos wrote: > Hi Christian, > I've always liked your enthusiasm > > So far we are running on OSX and the latest win7 build. both work fine. > > Now that we have the core running we need to move to java.lang.invoke ( which > should be trivial). > > What is

Re: Review Request: Zero JSR 292 support

2011-04-12 Thread Christian Thalinger
On Apr 11, 2011, at 7:47 PM, Christian Thalinger wrote: > On Apr 11, 2011, at 3:16 PM, Gary Benson wrote: >> Christian Thalinger wrote: >>> On Apr 5, 2011, at 3:46 PM, Gary Benson wrote: >>>> Christian Thalinger wrote: >>>>> On Apr 4, 2011, at 10:34

Re: Test cases related to JSR 292

2011-04-21 Thread Christian Thalinger
On Apr 12, 2011, at 7:04 PM, fo...@x9c.fr wrote: > Dear list, > > Is there a blessed set of class files that exhibit the various > possible uses of the JSR 292 features. Such a set would be > very useful to me in order to test an assembler/disassembler > tool. > > Thanks in advance for any pointe

Re: new Mac OS X mlvm build: 2011_04_04

2011-04-21 Thread Christian Thalinger
On Apr 5, 2011, at 9:41 PM, Ola Bini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 2011-04-05 09.07, Rémi Forax wrote: >> Basically in constant() bindTo(x) should be replaced by >> insertArguments(0, x) >> Because bindTo requires that the first argument is an object. >> Here it'

Re: Review Request: Zero JSR 292 support

2011-04-26 Thread Christian Thalinger
On Apr 5, 2011, at 3:46 PM, Gary Benson wrote: > Christian Thalinger wrote: >> On Apr 4, 2011, at 10:34 AM, Gary Benson wrote: >>> John Rose wrote: >>>> On Apr 1, 2011, at 7:33 AM, Gary Benson wrote: >>>>> This webrev adds support for JSR 292 to

Re: Review Request: Zero JSR 292 support

2011-04-26 Thread Christian Thalinger
On Apr 1, 2011, at 4:33 PM, Gary Benson wrote: > Hi all, > > This webrev adds support for JSR 292 to Zero: > > http://cr.openjdk.java.net/~gbenson/zero-jsr292-01/ hotspot/src/cpu/zero/vm/cppInterpreter_zero.cpp: +// NB the x86 code for this (in methodHandles_x86.cpp, search for +// "ge

Re: Review Request: Zero JSR 292 support

2011-04-26 Thread Christian Thalinger
On Apr 5, 2011, at 2:49 PM, Christian Thalinger wrote: >>> Does this code pass the jtreg tests in jdk/test/java/lang/invoke/ ? >> >> It passed their previous incarnation in jdk/test/java/dyn, with >> this webrev applied to stop the tests disabling themselves: >&g

Re: 292 Rocks, Core Smalltalk running thanks to all

2011-04-26 Thread Christian Thalinger
On Apr 12, 2011, at 2:56 PM, Ola Bini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > >> Since there are not many projects out there that already use JSR 292 >> (JRuby and phpreboot are the only real users that I know of, but maybe I >> missed something), the code path coverage is low a

Re: Assembly output from JRuby 'fib'

2011-04-27 Thread Christian Thalinger
On Apr 27, 2011, at 5:54 AM, Charles Oliver Nutter wrote: > I prepared this for someone else, but I thought folks here might be > interested in it too. > > This gist contains hotspot x86 (32-bit) assembly output for JRuby's > dynopt mode and invokedynamic (on a couple-week-old OS X OpenJDK > build

Re: Assembly output from JRuby 'fib'

2011-04-28 Thread Christian Thalinger
On Apr 27, 2011, at 5:54 AM, Charles Oliver Nutter wrote: > I prepared this for someone else, but I thought folks here might be > interested in it too. > > This gist contains hotspot x86 (32-bit) assembly output for JRuby's > dynopt mode and invokedynamic (on a couple-week-old OS X OpenJDK > build

Re: Assembly output from JRuby 'fib'

2011-04-28 Thread Christian Thalinger
On Apr 28, 2011, at 12:16 PM, Christian Thalinger wrote: > On Apr 27, 2011, at 5:54 AM, Charles Oliver Nutter wrote: >> I prepared this for someone else, but I thought folks here might be >> interested in it too. >> >> This gist contains hotspot x86 (32-bit) assembly o

Re: Assembly output from JRuby 'fib'

2011-04-28 Thread Christian Thalinger
On Apr 28, 2011, at 12:33 PM, Christian Thalinger wrote: > On Apr 28, 2011, at 12:16 PM, Christian Thalinger wrote: >> On Apr 27, 2011, at 5:54 AM, Charles Oliver Nutter wrote: >>> I prepared this for someone else, but I thought folks here might be >>> interested in

Re: Assembly output from JRuby 'fib'

2011-04-28 Thread Christian Thalinger
On Apr 28, 2011, at 3:56 PM, Charles Oliver Nutter wrote: > On Thu, Apr 28, 2011 at 8:19 AM, Charles Oliver Nutter > wrote: >> I've been trying to think of ways to reduce the guard cost, since the >> perf without the JRuby guard is a fair bit better (0.79 versus 0.63s >> for fib(35)). The performa

Re: Assembly output from JRuby 'fib'

2011-04-29 Thread Christian Thalinger
On Apr 28, 2011, at 4:50 PM, Charles Oliver Nutter wrote: > On Thu, Apr 28, 2011 at 9:17 AM, Christian Thalinger > wrote: >> I have now a patch that makes the command line switch tweaking superfluous >> and the default performance looks pretty good (see below, 32-bit x86). >

Re: Unusually high polymorphic dispatch costs?

2011-04-29 Thread Christian Thalinger
On Apr 28, 2011, at 9:58 PM, Charles Oliver Nutter wrote: > I'm trying to figure out why polymorphic dispatch is incredibly slow > in JRuby + indy. Take this benchmark, for example: > > class A; def foo; end; end > class B; def foo; end; end > > a = A.new > b = B.new > > 5.times { puts Benchmark

Re: Assembly output from JRuby 'fib'

2011-04-29 Thread Christian Thalinger
On Apr 28, 2011, at 3:19 PM, Charles Oliver Nutter wrote: > On Thu, Apr 28, 2011 at 5:16 AM, Christian Thalinger > wrote: >> I took a look at it. I used 64-bit x86 since the code is a bit smaller than >> with 32-bit. >> >> The code is almost identical but three

Re: Initial Smalltalk execution time

2011-05-02 Thread Christian Thalinger
On May 1, 2011, at 7:39 AM, Mark Roos wrote: > Now that the core works I thought I would take a quick look at the execution > speed. For this I > executed the same code in our current environment (OS/2 and a mid 90's > Smalltalk) and again using > our invokeDynamic based vm translation. The c

Re: Assembly output from JRuby 'fib'

2011-05-02 Thread Christian Thalinger
On Apr 29, 2011, at 3:44 PM, Rémi Forax wrote: > On 04/29/2011 01:09 PM, Christian Thalinger wrote: >> On Apr 28, 2011, at 3:19 PM, Charles Oliver Nutter wrote: >>> On Thu, Apr 28, 2011 at 5:16 AM, Christian Thalinger >>> wrote: >>>> I took a look at it.

Re: Assembly output from JRuby 'fib'

2011-05-03 Thread Christian Thalinger
On May 2, 2011, at 9:55 PM, Charles Oliver Nutter wrote: > On Thu, Apr 28, 2011 at 11:18 AM, Rémi Forax wrote: >> Do you specialize the overflow check depending on the callsite ? >> for fib(n - 1), you just have to check if n is different from >> Integer.MIN_INT, >> for fib(n - 2), if n is <= to I

Re: Assembly output from JRuby 'fib'

2011-05-03 Thread Christian Thalinger
On May 3, 2011, at 5:06 PM, Rémi Forax wrote: > On 05/03/2011 03:59 PM, Christian Thalinger wrote: >> On May 2, 2011, at 9:55 PM, Charles Oliver Nutter wrote: >>> On Thu, Apr 28, 2011 at 11:18 AM, Rémi Forax wrote: >>>> Do you specialize the overflow check depending

Re: hg: mlvm/mlvm/hotspot: meth-conv: process exceptions through ricochets, improve argument spreading

2011-05-04 Thread Christian Thalinger
On May 4, 2011, at 2:36 PM, john.r.r...@oracle.com wrote: > Changeset: 23a80231951e > Author:jrose > Date: 2011-05-04 05:36 -0700 > URL: http://hg.openjdk.java.net/mlvm/mlvm/hotspot/rev/23a80231951e > > meth-conv: process exceptions through ricochets, improve argument spreading > >

Re: hg: mlvm/mlvm/hotspot: meth-conv: process exceptions through ricochets, improve argument spreading

2011-05-04 Thread Christian Thalinger
On May 4, 2011, at 3:08 PM, John Rose wrote: > On May 4, 2011, at 5:50 AM, Christian Thalinger wrote: > >> I don't know how you get over this: >> >> src/share/vm/prims/methodHandles.hpp:487: error: conflicting declaration >> ‘OopClosure* f’ >> src/share/

Re: Unusually high polymorphic dispatch costs?

2011-05-05 Thread Christian Thalinger
On Apr 30, 2011, at 9:27 AM, Charles Oliver Nutter wrote: > I have pushed a change to JRuby master that fails over to a simple > inline cache after one failed GWT. This is not how I would want to do > it long-term, but it does bring some benchmarks back in line with > non-indy JRuby. Specifically,

Re: review request (L): 6939861: JVM should handle more conversion operations

2011-05-05 Thread Christian Thalinger
On May 5, 2011, at 1:16 PM, John Rose wrote: > I have finished the last large chunk of JVM work for JDK 7 JSR 292, the > implementation of so-called "ricochet frames". Here it is for review: > > 6939861: JVM should handle more conversion operations > http://cr.openjdk.java.net/~jrose/6939861/web

Re: review request (L): 6939861: JVM should handle more conversion operations

2011-05-06 Thread Christian Thalinger
On May 6, 2011, at 9:27 AM, John Rose wrote: >> All new header files have the wrong (Sun) copyright header. > > I'm backing off from introducing new header files. The only new file is > methodHandles_x86.hpp. > > See what you think. The idea is to allow each port to control its own > individu

Re: Crash running benchmarks game's binary trees bench

2011-05-09 Thread Christian Thalinger
On May 9, 2011, at 3:34 PM, Charles Oliver Nutter wrote: > FYI, this produced a SIGSEGV: > > jruby --server bench/shootout/binarytrees.ruby-2.ruby 15 > > 14 and lower worked ok. Crash is consistent. Running macosx build from > 4/28...not sure what build of mainline it maps to... This one? stret

Re: Crash running benchmarks game's binary trees bench

2011-05-09 Thread Christian Thalinger
On May 9, 2011, at 3:34 PM, Charles Oliver Nutter wrote: > FYI, this produced a SIGSEGV: > > jruby --server bench/shootout/binarytrees.ruby-2.ruby 15 Is invokedynamic now used by default? -- Christian > > 14 and lower worked ok. Crash is consistent. Running macosx build from > 4/28...not sure

Re: Crash running benchmarks game's binary trees bench

2011-05-09 Thread Christian Thalinger
On May 9, 2011, at 4:27 PM, Christian Thalinger wrote: > On May 9, 2011, at 3:34 PM, Charles Oliver Nutter wrote: >> FYI, this produced a SIGSEGV: >> >> jruby --server bench/shootout/binarytrees.ruby-2.ruby 15 >> >> 14 and lower worked ok. Crash is consistent.

Re: Rhino+invokedynamic

2011-05-10 Thread Christian Thalinger
On May 10, 2011, at 3:25 AM, Douglas Campos (qmx) wrote: > Hi folks > > Charles Nutter mentioned that some people were working/playing with making > Rhino faster. Does anyone have pointers on what were done / has to be done? John knows more about this but there is his blog entry about JavaOne 20

hg: mlvm/mlvm/jdk: Test6998541 updated

2011-05-11 Thread christian . thalinger
Changeset: 961bae798841 Author:twisti Date: 2011-05-11 02:18 -0700 URL: http://hg.openjdk.java.net/mlvm/mlvm/jdk/rev/961bae798841 Test6998541 updated ! meth.patch ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.ja

Re: review request (M): 7034977: JSR 292 MethodHandle.invokeGeneric should be renamed MethodHandle.invoke

2011-05-11 Thread Christian Thalinger
On May 11, 2011, at 6:02 PM, John Rose wrote: > http://cr.openjdk.java.net/~jrose/7034977/webrev.00 > > This is the engineering review for the name changes to remove the term > "generic" from JSR 292. Looks good. -- Christian ___ mlvm-dev mailing lis

Re: Unrecognized VM option '-UseRicochetFrames'

2011-05-12 Thread Christian Thalinger
On May 12, 2011, at 3:51 PM, Stephen Bannasch wrote: > I'm getting some failures running the jtreg tests and wondered whether I > needed to enable or disable Ricochet Frames in theJVM > but that option is unrecognized. > > $ build/bsd-amd64/j2sdk-image/bin/java -XX:-UseRicochetFrame > -versio

Re: review request (XL): 6939861: JVM should handle more conversion operations

2011-05-12 Thread Christian Thalinger
On May 11, 2011, at 6:08 PM, John Rose wrote: > http://cr.openjdk.java.net/~jrose/6939861/webrev.jdk.06/ src/share/classes/java/lang/invoke/AdapterMethodHandle.java: +if (false && spreadArgCount > SPREAD_LIMIT) +return false; +if (false && slotCount + extractStackMove

Re: invokeinterface handle-walking unimplemented?

2011-05-16 Thread Christian Thalinger
On May 14, 2011, at 6:49 PM, Charles Oliver Nutter wrote: > FYI, I assume I'm supposed to see this when I bind an interface method > acquired from findVirtual to an indy call site: > > # > # A fatal error has been detected by the Java Runtime Environment: > # > # Internal Error (methodHandleWalk.

Re: Good news, bad news

2011-05-23 Thread Christian Thalinger
On May 21, 2011, at 1:31 AM, Charles Oliver Nutter wrote: > I am still using the specialized math callsites because they inline well and > an Indy-based approach was still quite a bit slower last time I tried. > > I am back to being worried about the inlining thresholds. With no MHs and > runtim

Re: Good news, bad news

2011-05-23 Thread Christian Thalinger
On May 23, 2011, at 8:45 PM, Charles Oliver Nutter wrote: > On Mon, May 23, 2011 at 11:05 AM, Christian Thalinger > wrote: >> I was on vacation for a couple of days but now I'm back. >> >> I looked at the inlining tree for fib_recursive and I can't see the fi

Re: Good news, bad news

2011-05-25 Thread Christian Thalinger
On May 25, 2011, at 5:58 AM, Ola Bini wrote: > Hi, > > There are at least three problems that are still there. They might be > connected, or not. > (I will tell you how to reproduce these at the end) > > I just built a new JVM: > openjdk version "1.7.0-internal" > OpenJDK Runtime Environment (bui

Re: Good news, bad news

2011-05-25 Thread Christian Thalinger
me hints below). Can someone provide a jar file of the current MLVM JSR 292 classes (like John's meth.jar)? -- Christian > > Cheers > > On 2011-05-25 14.29, Christian Thalinger wrote: >> On May 25, 2011, at 5:58 AM, Ola Bini wrote: >>> Hi, >>> >>&g

Re: Good news, bad news

2011-05-26 Thread Christian Thalinger
On May 26, 2011, at 9:15 AM, Charles Oliver Nutter wrote: > On Thu, May 26, 2011 at 1:58 AM, Tom Rodriguez > wrote: >> but test is some ugly goo because of boxing. It's relatively easy to get >> the optimizer to fold away the boxing for boolean but sadly it doesn't help >> the performance at a

Re: Good news, bad news

2011-05-26 Thread Christian Thalinger
On May 26, 2011, at 10:42 AM, Christian Thalinger wrote: > On May 26, 2011, at 9:15 AM, Charles Oliver Nutter wrote: >> On Thu, May 26, 2011 at 1:58 AM, Tom Rodriguez >> wrote: >>> but test is some ugly goo because of boxing. It's relatively easy to get >&

Re: Good news, bad news

2011-05-26 Thread Christian Thalinger
On May 26, 2011, at 11:24 AM, Jochen Theodorou wrote: > Am 26.05.2011 11:03, schrieb Christian Thalinger: > [...] >> I looked at the inlining tree of fib and everything looks good and is >> inlined. There is one invokeExact which is: >> >> @ 43 java.lang.invoke

Re: JRuby to Java invokedynamic dispatch

2011-06-09 Thread Christian Thalinger
On Jun 8, 2011, at 11:10 PM, Attila Szegedi wrote: > Woo-hoo! I agree :-) > > On Jun 8, 2011, at 9:48 PM, Charles Oliver Nutter wrote: > >> Hello friends! I have another update! >> >> I've just landed preliminary work to make JRuby directly bind Ruby to >> Java calls that were normally done vi

Re: MethodHandles.constant not inlining?

2011-06-09 Thread Christian Thalinger
On Jun 7, 2011, at 10:44 PM, Charles Oliver Nutter wrote: > That's pretty much it. The test I ran looks like this: > > def foo > 1 > end > > 100_000.times { > foo > } > > > The body of the block passed to "times" jits (in Hotspot) and appears > to inline the "foo" method just fine, but the bod

Re: Current Crash status

2011-06-10 Thread Christian Thalinger
On May 27, 2011, at 12:35 AM, Ola Bini wrote: > On 2011-05-27 12.58, John Rose wrote: >> On May 27, 2011, at 12:24 AM, Ola Bini wrote: >> >>> But then it crashes at the same place. >> >> Excellent! >> >> So this works in b144 but not in mlvm? > Yes, that's correct. Is there any other crash you

Re: More performance explorations

2011-06-10 Thread Christian Thalinger
On Jun 4, 2011, at 5:19 AM, Ola Bini wrote: > On 2011-06-04 01.47, John Rose wrote: >> On Jun 3, 2011, at 7:07 AM, Ola Bini wrote: >> >>> Is there anything I can do to help out with finding this problem? >> >> I can't reproduce the VM crash yet. Like Christian, I got through >> problems 1 and 2,

Re: More performance explorations

2011-06-10 Thread Christian Thalinger
On Jun 5, 2011, at 7:23 AM, Charles Oliver Nutter wrote: > OH, and FWIW, here's the LogCompilation -i output roughly around where > I'd expect to see op_plus and op_lt inlining: > >@ 27 java.lang.invoke.MethodHandle::invokeExact (0 bytes) >@ 27 java.lang.invoke.MethodHandle::invokeExact (1

Re: More performance explorations

2011-06-10 Thread Christian Thalinger
On Jun 5, 2011, at 7:23 AM, Charles Oliver Nutter wrote: > OH, and FWIW, here's the LogCompilation -i output roughly around where > I'd expect to see op_plus and op_lt inlining: > >@ 27 java.lang.invoke.MethodHandle::invokeExact (0 bytes) >@ 27 java.lang.invoke.MethodHandle::invokeExact (1

Re: More performance explorations

2011-06-10 Thread Christian Thalinger
On Jun 10, 2011, at 3:37 PM, Charles Oliver Nutter wrote: > On Fri, Jun 10, 2011 at 5:32 PM, Christian Thalinger > wrote: >> It inlines fine with the latest HotSpot and JDK7 b145. I think we're good >> :-) > > Sorry, the logic for this never actually landed on J

Re: Indy crash

2011-06-15 Thread Christian Thalinger
On Jun 15, 2011, at 6:09 AM, Charles Oliver Nutter wrote: > Still crashing! See previous email for hs dumpfile, command-line, and > script, with link to data in the script. I can not reproduce this crash on either Linux nor Solaris. Here is a recent Linux x64 product build: http://cr.openjdk.ja

Re: Inlining heuristic trouble

2011-06-15 Thread Christian Thalinger
On Jun 15, 2011, at 5:26 PM, Rémi Forax wrote: > I've just finished to code a sample for the cookbook that does > integer operation (+ and -) with overflow (to BigInteger). > > https://code.google.com/p/jsr292-cookbook/source/browse/#svn%2Ftrunk%2Fbinary-operation%2Fsrc%2Fjsr292%2Fcookbook%2Fbinop

Re: Inlining heuristic trouble

2011-06-15 Thread Christian Thalinger
On Jun 15, 2011, at 5:48 PM, Christian Thalinger wrote: > On Jun 15, 2011, at 5:26 PM, Rémi Forax wrote: >> I've just finished to code a sample for the cookbook that does >> integer operation (+ and -) with overflow (to BigInteger). >> >> https://code.google.com

Re: Indy crash

2011-06-15 Thread Christian Thalinger
ruby.native.enabled=false org.jruby.Main -X+C --1.9 bench_etl.rb java version "1.7.0-ea" Java(TM) SE Runtime Environment (build 1.7.0-ea-b145) Java HotSpot(TM) 64-Bit Server VM (build 21.0-b14-internal-201106142151.never.7052219, mixed mode) Transform time : 101 Can you confirm that? -- Christ

Re: Indy crash

2011-06-16 Thread Christian Thalinger
On Jun 15, 2011, at 11:18 PM, Tom Rodriguez wrote: > > On Jun 15, 2011, at 11:47 AM, Christian Thalinger wrote: > >> On Jun 15, 2011, at 8:08 PM, Charles Oliver Nutter wrote: >>> FWIW, I only get the crash on my MLVM build if I pass these flags to JVM: >&g

Re: Inlining heuristic trouble

2011-06-17 Thread Christian Thalinger
On Jun 15, 2011, at 5:26 PM, Rémi Forax wrote: > // with the optimization > [forax@localhost binary-operation]$ time java -cp .:classes PerfOpt > real0m0.954s > user0m1.030s > sys0m0.087s > > // without > [forax@localhost binary-operation]$ time java -cp .:classes Perf > real0m0.37

Re: Inlining heuristic trouble

2011-06-17 Thread Christian Thalinger
On Jun 17, 2011, at 11:14 AM, Rémi Forax wrote: > On 06/17/2011 10:58 AM, Christian Thalinger wrote: >> On Jun 15, 2011, at 5:26 PM, Rémi Forax wrote: >>> // with the optimization >>> [forax@localhost binary-operation]$ time java -cp .:classes PerfOpt >>> r

PHP.reboot update?

2011-06-20 Thread Christian Thalinger
Remi, could you update PHP.reboot so that it works with a current JDK 7 build (upcoming b146 that is)? -- Christian ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/mlvm-dev

Re: PHP.reboot update?

2011-06-21 Thread Christian Thalinger
On Jun 20, 2011, at 6:42 PM, Rémi Forax wrote: > On 06/20/2011 06:09 PM, Christian Thalinger wrote: >> Remi, could you update PHP.reboot so that it works with a current JDK 7 >> build (upcoming b146 that is)? > > What is the problem ?? I get an exception: $ bin/phpr.sh tes

Re: PHP.reboot update?

2011-06-21 Thread Christian Thalinger
On Jun 21, 2011, at 11:35 AM, Rémi Forax wrote: > Ok, fixed, > convertArguments doesn't exist anymore and I forget to remove it from > the backport. Awesome, thanks. This one looks weird though: $ bin/phpr.sh test/testdeadreturn.phpr null com.googlecode.phpreboot.runtime.RT$RTError: null at 7,

Re: PHP.reboot update?

2011-06-21 Thread Christian Thalinger
On Jun 21, 2011, at 11:35 AM, Rémi Forax wrote: > Ok, fixed, > convertArguments doesn't exist anymore and I forget to remove it from > the backport. I currently trying to push some PHP code into your web server :-) Is it possible to recognize .php files too (not only .phpr files)? -- Christian

Re: PHP.reboot update?

2011-06-21 Thread Christian Thalinger
On Jun 21, 2011, at 12:20 PM, Christian Thalinger wrote: > On Jun 21, 2011, at 11:35 AM, Rémi Forax wrote: >> Ok, fixed, >> convertArguments doesn't exist anymore and I forget to remove it from >> the backport. > > I currently trying to push some PHP code

Re: PHP.reboot update?

2011-06-21 Thread Christian Thalinger
On Jun 21, 2011, at 1:02 PM, Rémi Forax wrote: > On 06/21/2011 12:29 PM, Christian Thalinger wrote: >> On Jun 21, 2011, at 12:20 PM, Christian Thalinger wrote: >>> On Jun 21, 2011, at 11:35 AM, Rémi Forax wrote: >>>> Ok, fixed, >>>> convertArguments doesn

Re: Errors on OSX version with loading

2011-07-04 Thread Christian Thalinger
On Jul 1, 2011, at 6:01 AM, John Rose wrote: > Do you have a website or blog you can post it on? Is it available somewhere yet? -- Christian > > On Jun 30, 2011, at 8:47 PM, Mark Roos wrote: > >> John requested >> Yes, please. We especially love stress tests. >> >> Oscar is putting it toget

Re: possible fix for 7056328

2011-07-04 Thread Christian Thalinger
On Jun 25, 2011, at 4:16 PM, Ola Bini wrote: >> Please try out the patch. I've also updated the mlvm patches to the >> latest bsd-port which (quite awesomely) is b146. > It runs fine for me. Hmm, this is odd. I'm just trying b147 and I still get the same problem when putting seph.jar on the cla

Re: Errors on OSX version with loading

2011-07-05 Thread Christian Thalinger
On Jul 5, 2011, at 4:16 AM, Mark Roos wrote: > Ok here is is, a test case for our port of Smalltalk to the JVM using 292. > Let me know if you can run it as this is our first outside attempt. > > Its a simple test, towers of Hanoi done in a recursive manner. This version > only uses > 20 d

Re: Errors on OSX version with loading

2011-07-05 Thread Christian Thalinger
On Jul 5, 2011, at 11:02 AM, Christian Thalinger wrote: > On Jul 5, 2011, at 4:16 AM, Mark Roos wrote: >> Ok here is is, a test case for our port of Smalltalk to the JVM using 292. >> Let me know if you can run it as this is our first outside attempt. >> >> Its a s

where are our performance bottlenecks?

2011-07-05 Thread Christian Thalinger
Now that we are done with 7 I'm looking into performance issues we have. Are there any that you know of and would like to get fixed for 7u2? -- Christian ___ mlvm-dev mailing list mlvm-dev@openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/

Re: where are our performance bottlenecks?

2011-07-06 Thread Christian Thalinger
bytes) too big I remember we were talking about the createGWT. Can this go away? -- Christian > > On Tue, Jul 5, 2011 at 9:04 AM, Christian Thalinger > wrote: >> Now that we are done with 7 I'm looking into performance issues we have. >> Are th

Re: where are our performance bottlenecks?

2011-07-06 Thread Christian Thalinger
On Jul 6, 2011, at 10:49 PM, Tom Rodriguez wrote: > > On Jul 6, 2011, at 4:18 AM, Christian Thalinger wrote: > >> On Jul 5, 2011, at 6:39 PM, Charles Oliver Nutter wrote: >>> I'm not in position at this exact moment to report perf issues, but >>> Rémi's

Re: where are our performance bottlenecks?

2011-07-07 Thread Christian Thalinger
On Jul 7, 2011, at 8:52 AM, Christian Thalinger wrote: > On Jul 6, 2011, at 10:49 PM, Tom Rodriguez wrote: >> >> On Jul 6, 2011, at 4:18 AM, Christian Thalinger wrote: >> >>> On Jul 5, 2011, at 6:39 PM, Charles Oliver Nutter wrote: >>>> I'm not

Re: Crash, unknown details, may or may not be invokedynamic-related

2011-07-11 Thread Christian Thalinger
On Jul 10, 2011, at 8:42 AM, Charles Oliver Nutter wrote: > I'm attaching an error log for a crash that's reproducible for me with > a recent openjdk-osx-build. It may or may not be useful depending on > how far behind other fixes they are. > > I thought it would be interesting for MLVM list becau

Re: MethodHandle lookup&invocation performance

2011-07-11 Thread Christian Thalinger
On Jul 9, 2011, at 3:27 PM, Hiroshi Nakamura wrote: > Hello, > > Thanks for you comments. > > On Sat, Jul 9, 2011 at 19:01, Jochen Theodorou wrote: >>> Code is here: >>> https://raw.github.com/nahi/jsr292-sandbox/master/src/jp/gr/java_conf/jruby/MethodHandleTest.java >> >> lookup I don't know.

Re: Inlining heuristic trouble

2011-07-11 Thread Christian Thalinger
On Jun 21, 2011, at 3:28 AM, John Rose wrote: > On Jun 20, 2011, at 12:17 PM, Tom Rodriguez wrote: > >> On Jun 18, 2011, at 5:15 AM, Rémi Forax wrote: >> >>> On 06/18/2011 03:15 AM, Tom Rodriguez wrote: On Jun 17, 2011, at 5:00 PM, John Rose wrote: > On Jun 17, 2011, at 10:21 AM, T

Re: Crash from "recursive" method handle chain

2011-07-27 Thread Christian Thalinger
On Jul 27, 2011, at 12:41 PM, Charles Oliver Nutter wrote: > On Wed, Jul 27, 2011 at 3:21 AM, Rémi Forax wrote: >> I've just read your slides [1]. >> I believe that the test before returning the result of add (slide 201) >> is a safepoint check. > > Oh really? What is it doing with eax, though,

Re: Performance problem with invoke dynamic

2011-07-28 Thread Christian Thalinger
On Jul 28, 2011, at 2:20 AM, Ola Bini wrote: > Hi, > > I've hit a very annoying performance problem with invoke dynamic/method > handles that makes certain benchmarks about 3 times slower for identical > operations. This code is related to to variable lookup and the basic > idea is that I have a

Re: Performance problem with invoke dynamic

2011-07-28 Thread Christian Thalinger
On Jul 28, 2011, at 6:10 PM, Ola Bini wrote: >> The bad performance sounds like something is not inlined at all. How are >> you invoking valueMH? Via invokedynamic or a direct MH call? > > valueMH is combined with an exactInvoker and then chained together with > another method handle that cal

Request for review (L): 7071653: JSR 292: call site change notification should be pushed not pulled

2011-08-05 Thread Christian Thalinger
http://cr.openjdk.java.net/~twisti/7071653 7071653: JSR 292: call site change notification should be pushed not pulled Reviewed-by: Currently every speculatively inlined method handle call site has a guard that compares the current target of the CallSite object to the inlined one. This per-invoc

JRuby/Seph/PHP.reboot/... SwitchPoint usage

2011-08-08 Thread Christian Thalinger
Since I have the basic push-notification of CallSites I'm now looking into push-notification of SwitchPoints: 7071709: JSR 292: switchpoint invalidation should be pushed not pulled Basically it should be the same, just needs some additional love in the compiler. I looked into JRuby's usage of

Re: Request for review (L): 7071653: JSR 292: call site change notification should be pushed not pulled

2011-08-08 Thread Christian Thalinger
;new_type() : (klassOop) NULL; and - MutexLockerEx ccl(CodeCache_lock, thread); + MutexLockerEx ccl(CodeCache_lock, Mutex::_no_safepoint_check_flag); I updated the webrev. -- Christian > > > Vladimir > > On 8/5/11 6:32 AM, Christian Thalinger wrote: >> http://cr.op

Re: JRuby/Seph/PHP.reboot/... SwitchPoint usage

2011-08-08 Thread Christian Thalinger
On Aug 8, 2011, at 4:01 PM, Rémi Forax wrote: > On 08/08/2011 03:51 PM, Christian Thalinger wrote: >> Since I have the basic push-notification of CallSites I'm now looking into >> push-notification of SwitchPoints: >> >> 7071709: JSR 292: switchpoint invalida

Re: JRuby/Seph/PHP.reboot/... SwitchPoint usage

2011-08-08 Thread Christian Thalinger
On Aug 8, 2011, at 6:39 PM, Charles Oliver Nutter wrote: > On Mon, Aug 8, 2011 at 9:51 AM, Christian Thalinger > wrote: >> Since I have the basic push-notification of CallSites I'm now looking into >> push-notification of SwitchPoints: >> >> 7071709: JSR 2

Re: Push invalidation + bimorphic fix

2011-08-09 Thread Christian Thalinger
On Aug 9, 2011, at 7:58 AM, Charles Oliver Nutter wrote: > I have set up a local build against "hsx" hotspot compiler dev branch, > thanks to Christian. I'll try to write something up with the process > tomorrow. > > Anyway, I wanted to test out Tom's patch for GWT bimorphic inlining > and Chris

Re: Request for review (L): 7071653: JSR 292: call site change notification should be pushed not pulled

2011-08-09 Thread Christian Thalinger
some comments explaining why it's doing what it's doing. Done. > > doCall.cpp: > > Can you put in a comment explaining that VolatileCallSite is never inlined. Done. > > Otherwise it looks good. webrev updated. -- Christian > > tom > > > On A

Re: JRuby/Seph/PHP.reboot/... SwitchPoint usage

2011-08-10 Thread Christian Thalinger
On Aug 8, 2011, at 8:21 PM, Christian Thalinger wrote: > > On Aug 8, 2011, at 6:39 PM, Charles Oliver Nutter wrote: > >> On Mon, Aug 8, 2011 at 9:51 AM, Christian Thalinger >> wrote: >>> Since I have the basic push-notification of CallSites I'm now loo

Re: JRuby/Seph/PHP.reboot/... SwitchPoint usage

2011-08-10 Thread Christian Thalinger
On Aug 10, 2011, at 6:21 PM, Charles Oliver Nutter wrote: > On Wed, Aug 10, 2011 at 9:26 AM, Christian Thalinger > wrote: >> Here are the numbers for JDK 7 b147, 7071307+7071653, and >> 7071307+7071653+7071709: >> >> 7071307: MethodHandle bimorphic inlining

Re: Performance problem with invoke dynamic

2011-08-10 Thread Christian Thalinger
On Jul 28, 2011, at 7:29 PM, Ola Bini wrote: > On 2011-07-28 10.11, Christian Thalinger wrote: >> >> On Jul 28, 2011, at 6:10 PM, Ola Bini wrote: >> >>>> The bad performance sounds like something is not inlined at all. >>>> How are you invoki

  1   2   3   4   5   6   7   >