Re: RFR: JDK-8136893: Improve early java.lang.invoke infrastructure initialization

2015-09-25 Thread Michael Haupt
Hi Peter, thanks for this changeset. Note I'm not a Reviewer (with a capital R); please read this review in lower-case. ;-) One question about MethodType: would you mind doing something about the naming of the newly introduced fromDescriptor() method? Its name does not suggest in any way that

Re: RFR: JDK-8136893: Improve early java.lang.invoke infrastructure initialization

2015-09-25 Thread Paul Sandoz
Hi, This looks like a partial dup of https://bugs.openjdk.java.net/browse/JDK-8076596 The changes look ok, but I am concerned post initialization there may be code paths taken that require the system class loader to be used but instead the boot stream class loader is used instead. Is that a le

Re: RFR: JDK-8136893: Improve early java.lang.invoke infrastructure initialization

2015-09-25 Thread Peter Levart
Hi Paul, Thanks for looking into this. On 09/25/2015 04:07 PM, Paul Sandoz wrote: Hi, This looks like a partial dup of https://bugs.openjdk.java.net/browse/JDK-8076596 Ah, sorry, I wasn't aware this has already been registered in JIRA. I have linked the two issues together as DUPs. The

Re: RFR: JDK-8136893: Improve early java.lang.invoke infrastructure initialization

2015-09-25 Thread Peter Levart
Hi Michael, On 09/25/2015 03:37 PM, Michael Haupt wrote: Hi Peter, thanks for this changeset. Note I'm not a Reviewer (with a capital R); please read this review in lower-case. ;-) One question about MethodType: would you mind doing something about the naming of the newly introduced fromDesc