[PATCH] modem-helpers: allow unquoted strings in +CCLK responses

2017-08-09 Thread Aleksander Morgado
Also: * define the leading '+' as a escaped value * allow any number of spaces between '+CCLK' and the string value. --- src/mm-modem-helpers.c | 7 +-- src/tests/test-modem-helpers.c | 7 +++ 2 files changed, 12 insertions(+), 2 deletions(-) diff --git

Re: Sending SMS in PDU mode fails.

2017-08-09 Thread Aleksander Morgado
>>> As far as I know this happens only for Verizon customization that uses >>> SMS over IMS with 3GPP2 pdu. >>> Isn't this actually a bit weird, given that the LE866-SV1 is actually LTE-only (i.e. 3GPP-only, not 3GPP2)? >>> >>> Looks like a carrier

Re: Making disconnection more robust

2017-08-09 Thread Tim Small
On 08/08/17 08:14, Aleksander Morgado wrote: > What we usually do here is to setup a Context struct for the > operation, and define a set of STEPs for a small state machine that > defines the operation. Thanks for that. One snag I've come across is that I want to run this during the

Re: [PATCH v2] modem-helpers: allow unquoted strings in +CCLK responses

2017-08-09 Thread Aleksander Morgado
On Wed, Aug 9, 2017 at 8:26 PM, Dan Williams wrote: > > On Wed, 2017-08-09 at 16:28 +0200, Aleksander Morgado wrote: > > Also: > > * define the leading '+' as a escaped value > > * allow any number of spaces between '+CCLK' and the string value. > > --- > > LGTM > Pushed to

Re: [PATCH v2] mm-broadband-modem-mbim: reprobe on mbim-proxy death

2017-08-09 Thread Eric Caruso
Are we waiting for the libmbim fixes for Sierra Wireless to go in before we push this patch, or is there something else I can improve here? Thanks, -Eric ___ ModemManager-devel mailing list ModemManager-devel@lists.freedesktop.org

[PATCH v2] modem-helpers: allow unquoted strings in +CCLK responses

2017-08-09 Thread Aleksander Morgado
Also: * define the leading '+' as a escaped value * allow any number of spaces between '+CCLK' and the string value. --- Hey, Yes, it makes sense to add unit tests also for the multiple spaces change, see this v2 patch. Cheers! --- src/mm-modem-helpers.c | 7 +--