Re: [PATCH] libmm-glib, messaging: fix object unref in list_sms_context_complete_and_free

On Fri, Jun 23, 2017 at 9:14 AM, Ben Chan wrote: > --- > libmm-glib/mm-modem-messaging.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Pushed to git master, mm-1-6, mm-1-4 and mm-1-2, thanks! > diff --git a/libmm-glib/mm-modem-messaging.c

Re: [PATCH 2/4] build: only define WITH_SYSTEMD_JOURNAL if enabled

On Thu, Jun 22, 2017 at 6:28 PM, Aleksander Morgado <aleksan...@aleksander.es> wrote: >>> > I think this is broken (along the lines of Ben's #if/#ifdef question). >>> > Configuring with --with-systemd-journal results in >>> > >>> > #define

Re: [PATCH] libmm-glib, voice: fix object unref in list_call_context_complete_and_free

On Fri, Jun 23, 2017 at 9:14 AM, Ben Chan wrote: > --- > libmm-glib/mm-modem-voice.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Pushed to git master and mm-1-6, thanks! > diff --git a/libmm-glib/mm-modem-voice.c b/libmm-glib/mm-modem-voice.c > index

Re: [PATCH 3/3] libmm-glib,manager: port mm_manager_scan_devices to use GTask

On 23/06/17 10:12, Ben Chan wrote: > --- > libmm-glib/mm-manager.c | 25 ++--- > 1 file changed, 10 insertions(+), 15 deletions(-) > Pushed to git master, thanks! > diff --git a/libmm-glib/mm-manager.c b/libmm-glib/mm-manager.c > index 9f71414b..2fc08cbb 100644 > ---

Re: [PATCH 2/3] libmm-glib,manager: port mm_manager_set_logging to use GTask

On 23/06/17 10:12, Ben Chan wrote: > --- > libmm-glib/mm-manager.c | 25 ++--- > 1 file changed, 10 insertions(+), 15 deletions(-) > Pushed to git master, thanks! > diff --git a/libmm-glib/mm-manager.c b/libmm-glib/mm-manager.c > index 6a9ce5dd..9f71414b 100644 > ---

Re: [PATCH 3/4] build: WITH_UDEV is only defined when enabled

On Thu, Jun 22, 2017 at 10:59 AM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > Looks like the preprocessor doesn't choke when using #if WITH_UDEV and > it isn't defined to any value, but anyway, better explicitly say that > we're checking if it's defined or not. >

Re: [PATCH 2/4] build: only define WITH_SYSTEMD_JOURNAL if enabled

On Thu, Jun 22, 2017 at 10:59 AM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > --- > configure.ac | 7 ++- > src/mm-context.c | 2 +- > 2 files changed, 3 insertions(+), 6 deletions(-) > This has been merged to git master. > diff --git a/configure.a

Re: [PATCH 1/4] build: only define WITH_POLKIT if enabled

On Thu, Jun 22, 2017 at 10:59 AM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > --- > configure.ac | 4 +--- > src/mm-auth.c | 6 +++--- > 2 files changed, 4 insertions(+), 6 deletions(-) > This has been merged to git master. > diff --git a/configure.ac b/confi

Re: [PATCH] enums: replace Roman numeral suffixes in MM_MODEM_BAND_EUTRAN_*

On Fri, Jun 23, 2017 at 3:08 AM, Ben Chan wrote: > 3GPP TS 36.101 Table 5.5-1 refers the E-UTRA operating bands as 1, 2, 3, > ..., etc. I'm all in for this change, but unfortunately this is part of the API, so we cannot just blindly rename the enums. In order to avoid

Re: [PATCH 4/4] build: rename --with-suspend-resume to --with-systemd-suspend-resume

On Thu, Jun 22, 2017 at 10:59 AM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > And only define WITH_SYSTEMD_SUSPEND_RESUME when enabled. > > We already have other systemd specific features under the > --with-systemd-* name scheme, so consolidate that, given that we don'

Re: MC7455 'Call Failed'

Hey, > > The MC7455 presents two QMI+WWAN pairs which I think is quite common > for the Sierra Wireless modems. The first appears to be raw-ip and the > 2nd 802.3. Most of the qmicli commands won't work on cdc-wdm0 (raw-ip) > and I believe this is expected but I'm not clear exactly why (could >

Re: [PATCH 2/4] build: only define WITH_SYSTEMD_JOURNAL if enabled

On Thu, Jun 22, 2017 at 3:56 PM, Colin Helliwell wrote: > I think this is broken (along the lines of Ben's #if/#ifdef question). > Configuring with --with-systemd-journal results in > #define WITH_SYSTEMD_JOURNAL 0 > in config.h, but the code (e.g. mm-log.c) is

Re: [PATCH 1/4] iface-modem-location: port mm_iface_modem_location_initialize to use GTask

On Tue, Jun 27, 2017 at 7:53 AM, Ben Chan wrote: > /* Don't run new steps if we're cancelled */ > -if (initialization_context_complete_and_free_if_cancelled (ctx)) > +if (g_cancellable_is_cancelled (g_task_get_cancellable (task))) { > +

Re: [PATCH 3/4] iface-modem-location: port mm_iface_modem_location_disable to use GTask

On 27/06/17 07:53, Ben Chan wrote: > --- > src/mm-iface-modem-location.c | 63 > ++- > 1 file changed, 33 insertions(+), 30 deletions(-) > Pushed this one to git master. > diff --git a/src/mm-iface-modem-location.c b/src/mm-iface-modem-location.c >

Re: [PATCH 4/4] iface-modem-location: port setup_gathering to use GTask

On 27/06/17 07:54, Ben Chan wrote: > --- > src/mm-iface-modem-location.c | 107 > ++ > 1 file changed, 57 insertions(+), 50 deletions(-) > Pushed this one to git master. > diff --git a/src/mm-iface-modem-location.c b/src/mm-iface-modem-location.c >

[PATCH 5/5 v2] cinterion: retry GPS Engine activation up to 3 times

The default setup with 100ms between GPS commands doesn't seem to be always enough for the Engine activation step: [1495016625.392972] (ttyACM1): --> 'AT^SGPSC="NMEA/Output","on"' [1495016625.503885] (ttyACM1): <-- '^SGPSC: "Nmea/Output","on"OK' [1495016625.607650] (ttyACM1): -->

Re: [PATCH 4/4] cinterion: use ^SIND unsolicited messages for access tech reporting

On Mon, May 22, 2017 at 6:02 PM, Dan Williams <d...@redhat.com> wrote: > On Sun, 2017-05-21 at 21:49 +0200, Aleksander Morgado wrote: >> If the modem supports ^SIND psinfo reporting, we enable the URC and >> flag the access technology polling unsupported, so that we

Re: [PATCH] udev: remove default ID_MM_PLATFORM_DRIVER_PROBE whitelist

On Mon, May 22, 2017 at 6:06 PM, Dan Williams wrote: >> The whitelist made all platform TTYs managed by the 'atmel_usart' >> kernel driver probed by ModemManager, which isn't something we want, >> as most of these aren't broadband modems. >> >> We leave the logic supporting the

[PATCH 2/4 v3] broadband-modem: query +CMER format before enabling/disabling

Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable Mobile Equipment Event Reporting. We now query the device for the supported formats and use that info to build commands that will work. --- This v3 adds some additional log messages to specify which CMER settings are selected.

Re: [PATCH 2/4] iface-modem: if bands, capabilities or modes change, refresh signal

On Mon, May 22, 2017 at 5:46 PM, Dan Williams wrote: >> We also remove the explicit refresh request from the Cinterion >> plugin, >> as this is a generic action applicable to all modems that require >> polling for signal quality and/or access technology. > > Should the poll

Re: [PATCH] broadband-modem: don't create sim hot swap ports context multiple times

On Tue, May 23, 2017 at 5:58 PM, Carlo Lobrano wrote: > What I can reproduce is the crash, and I can also confirm that this patch > fix it very well. Thank you! Thanks for checking! -- Aleksander https://aleksander.es ___

Re: [PATCH] broadband-modem: don't create sim hot swap ports context multiple times

On 23/05/17 18:40, Aleksander Morgado wrote: >> What I can reproduce is the crash, and I can also confirm that this patch >> fix it very well. Thank you! > Thanks for checking! Pushed to git master, btw. -- Aleksander https:

[PATCH 1/2] altair,hso,samsung: setup send-delay=0 for probing

The Altair, Option HSO and Samsung plugins all use the send-delay=0 setting once the modem object has been created. For consistency, use the same setting during port probing. --- plugins/altair/mm-plugin-altair-lte.c | 1 + plugins/option/mm-plugin-hso.c| 1 +

[PATCH 2/2] ublox: use send-delay=0 by default

Looks like the u-blox SARA-U260 requires this, see: https://lists.freedesktop.org/archives/modemmanager-devel/2017-May/004670.html --- plugins/ublox/mm-broadband-modem-ublox.c | 31 ++- plugins/ublox/mm-plugin-ublox.c | 1 + 2 files changed, 31 insertions(+),

AT send delay set to 0 in port probings

Hey Dan, Brent and everyone, The first patch in the series updates the send-delay settings for the Altair, Option HSO and Samsung plugins, which were already using send-delay 0 once the modem was created, but not during the probing phase. The second patch sets up send-delay 0 for the u-blox

Re: Received SMS and where they'll be stored

On 23/05/17 15:19, colin.helliw...@ln-systems.com wrote: > I'm re-exploring what happens through MM with received SMS - and could do > with some clarification on how it all interacts (modem vs. MM). > > # mmcli -m 0 --messaging-status > /org/freedesktop/ModemManager1/Modem/0 >

Re: [PATCH 2/2] ublox: use send-delay=0 by default

On 23/05/17 18:39, Aleksander Morgado wrote: > Looks like the u-blox SARA-U260 requires this, see: > https://lists.freedesktop.org/archives/modemmanager-devel/2017-May/004670.html > --- Forgot to say that I also tested this in my u-blox Toby L2 and was recognized successfully. > p

Re: AT send delay set to 0 in port probings

On Tue, May 23, 2017 at 8:44 PM, Brent Sink wrote: > Which branch should I be applying the patch to? If I apply the first patch > to the master branch and build, it does compile, but when I run I get a > segmentation fault. If I undo the patch and run again I don't receive

Re: [PATCH] v1: Logging cleanup and systemd journal support

Hey, On Mon, May 22, 2017 at 7:49 AM, Torsten Hilbrich <torsten.hilbr...@secunet.com> wrote: > This series of patches is based on the "Logging and --help > updates" series posted by Aleksander Morgado > <aleksan...@aleksander.es>. > > It start with clean

Re: [PATCH 1/2] log: new --log-func-loc option to enable function location in logs

Hey, On Thu, May 18, 2017 at 12:43 PM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > The --debug output is a bit annoying right now because it includes the > function location information by default. This information is most of > the times not very useful, so just make it

[PATCH 1/4 v2] helpers: new 'AT+CMER=?' parser

--- Hey, (resent to include in CC the mailing list) This v2 patch includes a correct "underscore_name" for the new enums defined in the helpers header, needed if we want to use the _build_string_from_mask() methods. Cheers, --- src/mm-modem-helpers.c | 136

[PATCH 2/4 v2] broadband-modem: query +CMER format before enabling/disabling

Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable Mobile Equipment Event Reporting. We now query the device for the supported formats and use that info to build commands that will work. --- Hey Colin, This patch fixes a check for +CMER mode 1, and includes additional logging

[PATCH1 1/4 v3] helpers: new 'AT+CMER=?' parser

--- Hey Colin, Please try now with this v3 patch. I modified the helper method to allow the comma-separated number sequence you get in your EHS5 for the modes, i.e.: "(1,2)". The regex wasn't catching that logic, so instead of complicating it too much, I switched to splitting the response

[PATCH] broadband-modem: don't create sim hot swap ports context multiple times

--- Hey Carlo, It's never too late :) I couldn't reproduce the issue with the SIM hot swap changes you were trying, because none of my Telit modems here were able to support it properly, so I ended up re-reviewing the logs you sent and I believe I found the issue. When the SIM is already

Re: [PATCH 2/4] broadband-modem: query +CMER format before enabling/disabling

On Mon, May 22, 2017 at 12:36 PM, Colin Helliwell wrote: >> Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable >> Mobile Equipment Event Reporting. We now query the device for the >> >> supported formats and use that info to build commands that

[PATCH 1/4] helpers: new 'AT+CMER=?' parser

--- src/mm-modem-helpers.c | 136 + src/mm-modem-helpers.h | 25 src/tests/test-modem-helpers.c | 53 3 files changed, 214 insertions(+) diff --git a/src/mm-modem-helpers.c b/src/mm-modem-helpers.c index

Generic +CMER setting logic

Hey Dan, Carlo & everyone, This patch series implements the checking of the AT+CMER command parameters so that we can enable or disable them without error. The parser only checks the 'mode' (1st field) and 'ind' (4th field) settings, as those are the ones we request to update. Also modified

[PATCH 4/4] telit: remove custom +CMER enabling

This is now managed directly in the generic plugin. --- plugins/cinterion/mm-broadband-modem-cinterion.c | 2 + plugins/telit/mm-broadband-modem-telit.c | 84 2 files changed, 60 insertions(+), 26 deletions(-) diff --git

Re: [PATCH 4/4] telit: remove custom +CMER enabling

On Sun, May 21, 2017 at 2:54 PM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > +/* Our own enable now */ > +mm_base_modem_at_command_full ( > MM_BASE_MODEM (self), > mm_base_modem_peek_port_secondary (MM_BASE_MODEM (self)), > -unsoli

Re: [PATCH1 1/4 v3] helpers: new 'AT+CMER=?' parser

On Mon, May 22, 2017 at 3:50 PM, Colin Helliwell wrote: > But do bear in mind that I don't have any conviction about what 'CMER' the > EHS5 actually supports, because it's AT doc doesn't mention the command at > all - by rights it shouldn't even respond at all to

Re: [PATCH] telit: manage QSS transistions

On 26/05/17 11:36, Carlo Lobrano wrote: > Currently, Telit's SIM swap implementation is stateless and > based on #QSS unsolicited messages 0/1 (SIM_REMOVED/SIM_INSERTED). > > However, the user might have configured the modem in order to provide a > more detailed information, with #QSS values 2/3

Re: [PATCH] telit: enable 'SIM ready' notifications with #QSS=2

On Thu, May 25, 2017 at 3:41 PM, Carlo Lobrano wrote: > What I was thinking regarding this issue was to define a common error >> id, like "MM_CORE_ERROR_RETRY_LATER". If the logic (e.g. MMIfaceModem >> logic) receives such an error, it would re-schedule the execution of >>

Re: [PATCH] telit: manage QSS transistions

On 27/05/17 19:17, Carlo Lobrano wrote: >> GTask? If you have any doubt or not sure how to do it, leave it with >> GSimpleAsyncResult and I'll do the port to GTask as a follow up patch, >> so that you can see what the changes were; it really is very easy, you >> can check Ben's last emails doing

Re: [PATCH] Infineon: Add support for Infineon / Intel modems

lic License as published by > + * the Free Software Foundation; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of >

Re: [PATCH 2/5] log: Refactor log level text output

Hey Torsten, On 22/05/17 07:49, Torsten Hilbrich wrote: > Adding a helper function to turn the log level into the text. Also > add an internal flag to disable this output. This flag will become > useful when adding systemd journal support. See some comments below. > --- > src/mm-log.c | 35

Re: [PATCH 4/4] telit: remove custom +CMER enabling

On 22/05/17 19:08, Aleksander Morgado wrote: >>> And now that I see this... >>> * Shouldn't we enable +CIEV only for "signal" (that's the only thing >>> we end up parsing in the generic +CIEV parser)? >>> * Shouldn't we move this setting to the gene

Re: [PATCH 4/5] log: Introduce function pointer to handle different log backends

Hey Torsten, See comments below. On 22/05/17 07:49, Torsten Hilbrich wrote: > This allows for easier additions of other logging mechanism. > --- > src/mm-log.c | 53 ++--- > 1 file changed, 34 insertions(+), 19 deletions(-) > > diff --git

Re: [PATCH 2/2] context: rework application options and help output

On 18/05/17 12:43, Aleksander Morgado wrote: > Group together all options that allow configuring the logging output, > and make them have the same --log-[XXX] prefix. > > Also rework the --help output so that all option groups are printed by > default (i.e. there is no longer a --

Re: [PATCH 3/4] cinterion: remove custom +CMER enabling

On 21/05/17 14:54, Aleksander Morgado wrote: > This is now managed directly in the generic plugin. This has been merged to git master. > --- > plugins/cinterion/mm-broadband-modem-cinterion.c | 30 > > 1 file changed, 30 deletions(-) > > diff --gi

Re: [PATCH 2/4 v3] broadband-modem: query +CMER format before enabling/disabling

On 22/05/17 19:21, Aleksander Morgado wrote: > Don't blindly try '+CMER=3,0,0,1' to enable and '+CMER=0' to disable > Mobile Equipment Event Reporting. We now query the device for the > supported formats and use that info to build commands that will work. > --- > > This v3 ad

Re: [PATCH1 1/4 v3] helpers: new 'AT+CMER=?' parser

On 22/05/17 14:43, Aleksander Morgado wrote: > --- > > Hey Colin, > > Please try now with this v3 patch. I modified the helper method to allow the > comma-separated number sequence you get in your EHS5 for the modes, i.e.: > "(1,2)". The regex wasn't

Re: AT send delay set to 0 in port probings

On Wed, May 24, 2017 at 7:15 AM, Brent Sink wrote: > To add to the weirdness, it seems when I enabled debug symbols in the > buildroot build, the segmentation faults went away. Now, when I run > "ModemManager --debug" it works, but instead of a segmentation fault it just >

Re: ModemManager will not start on raspberry pi jessie lite

On Tue, May 16, 2017 at 7:08 PM, marcel wrote: > Hey, I got like the a very similar error as in: > https://lists.freedesktop.org/archives/modemmanager-devel/2015-April/001885.html > > but I got no /usr/share/dbus-1/system-services, as those files are in > /etc/dbus-1/ on my system

Re: [PATCH 2/2] dell: speed probing time up and reduce udev dependency

On 29/05/17 09:51, Carlo Lobrano wrote: > I still need to understand how to reply to old email while using git > send-mail (if possible). You tell your email client to expand the full headers of the original message you want to reply to, and look for the message id, which may be e.g.

Re: [PATCH 2/2] dell: speed probing time up and reduce udev dependency

On 29/05/17 09:48, Carlo Lobrano wrote: > Currently Dell plugin implements a retry logic of three commands > (AT+GMI, AT+CGMI, ATI1I2I3) to detect modem's vendor string. > Moreover, since Telit modems always reply to the first command, to speed > the probing time up, those modem are tagged with an

Re: [PATCH 1/2] telit: removed ID_MM_TELIT_PORTS_TAGGED dependency

On 05/05/17 16:49, Carlo Lobrano wrote: > Currently, Telit plugin depends on ID_MM_TELIT_PORTS_TAGGED > environment variable, set by udev, for tagging modems that > support dynamic port config (#PORTCFG) > > To remove this dependency from udev, Telit plugin now relies > only on the error

Re: [PATCH 1/5] log: Refactor evaluation of log level

Hey Torsten, On 22/05/17 07:49, Torsten Hilbrich wrote: > The level was checked twice in _mm_log. Once at the beginning and > again when turning the level into both the syslog priority and some > descriptive text which was added to the log level. Removing the check > at the second location as it

Re: [PATCH 2/5] cinterion: flag PLS8 GPS data port

On 17/05/17 15:24, Aleksander Morgado wrote: > --- > plugins/cinterion/77-mm-cinterion-port-types.rules | 4 > 1 file changed, 4 insertions(+) > This has been merged to git master. > diff --git a/plugins/cinterion/77-mm-cinterion-port-types.rules > b/plugins/cinteri

Re: [PATCH 3/5] cinterion: setup GPS port only if GPS support detected

On 17/05/17 15:24, Aleksander Morgado wrote: > i.e. if AT^SGPSS not supported, we don't even add traces handler to > the GPS data port. > --- This has been merged to git master. > plugins/cinterion/mm-broadband-modem-cinterion.c | 14 --- > .../cinterion/mm-broadband-modem-

Re: [PATCH 4/5] cinterion: support AT^SGPSC capable modems

On 17/05/17 15:24, Aleksander Morgado wrote: > The AT^SGPSS command provides an easy way to just start/stop GPS, but > unfortunately it isn't supported by all Cinterion modems. > > The AT^SGPSC command instead is more widely available but it requires > several steps to

Re: [PATCH 5/5 v2] cinterion: retry GPS Engine activation up to 3 times

On 20/05/17 09:57, Aleksander Morgado wrote: > The default setup with 100ms between GPS commands doesn't seem to be > always enough for the Engine activation step: > >[1495016625.392972] (ttyACM1): --> 'AT^SGPSC="NMEA/Output","on"' >[1495016625.50

Re: [PATCH 4/5] cinterion: support AT^SGPSC capable modems

On Tue, May 30, 2017 at 8:27 PM, Dan Williams wrote: >> @@ -429,13 +536,15 @@ mm_common_cinterion_disable_location_gathering >> (MMIfaceModemLocation *self, >> typedef enum { >> ENABLE_LOCATION_GATHERING_GPS_STEP_FIRST, >> ENABLE_LOCATION_GATHERING_GPS_STEP_SGPSS, >>

Re: [PATCH v2] telit: manage QSS transistions

Hey Carlo, On Wed, May 31, 2017 at 10:36 AM, Carlo Lobrano wrote: > Currently, Telit's SIM swap implementation is stateless and > based on #QSS unsolicited messages 0/1 (SIM_REMOVED/SIM_INSERTED). > > However, the user might have configured the modem in order to provide a >

Re: [PATCH 2/2] ublox: use send-delay=0 by default

On Tue, May 23, 2017 at 6:39 PM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > Looks like the u-blox SARA-U260 requires this, see: > https://lists.freedesktop.org/archives/modemmanager-devel/2017-May/004670.html > --- Pushed to git master. > plugins/ublox/mm-broad

Re: [PATCH 4/4] cinterion: use ^SIND unsolicited messages for access tech reporting

On Mon, May 22, 2017 at 7:15 PM, Aleksander Morgado <aleksan...@aleksander.es> wrote: >>> +static void >>> +set_unsolicited_events_handlers (MMBroadbandModemCinterion *self, >>> + gboolean enable) >&g

Re: AT send delay set to 0 in port probings

Hi Brent, On Tue, May 30, 2017 at 4:11 PM, Brent Sink wrote: > How did you apply the patches I sent? Did you "save" the emails and > >> apply them with "git am"? or did you manually modify the files with >> the changes seen in the patches? I ask because the \x90\xf0 looks

Re: [PATCH 1/2] altair,hso,samsung: setup send-delay=0 for probing

On Tue, May 23, 2017 at 6:39 PM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > The Altair, Option HSO and Samsung plugins all use the send-delay=0 > setting once the modem object has been created. For consistency, use > the same setting during port probing. Pushe

[PATCH] base-bearer: use an initial longer timeout for connectivity check

If we ask too quick for the PDP context status after a successful connection attempt reported by the modem, we may find it still flagged as inactive if the modem is still busy setting up the PPP session. Do an explicit longer initial timeout before we run the first check, and after that one setup

Re: [PATCH] Infineon: Add support for Infineon / Intel modems

Hey Paul, > > I spent a little more time debugging the HL7588 today. This modem > seems to designed for phone-type SIM cards that have a context for MMS > in the PDP context #1 slot (my combination of SIM card and network has > the internet APN in this slot). It seems to lock configuration of

[PATCH 1/2] telit: make sure QSS status values read are always known

Given that the MMTelitQssStatus enums are mapped directly to the values read from the #QSS response, we need to make sure that we never return a value for which we don't have an enum defined. Also, use set_error() instead of the propagate_error() + error_new() combo. ---

QSS transitions additional patches

Hey Carlo, Your v3 looks good, but I ended up preparing a couple of additional patches to go on top of it; could you review/test them? [PATCH 1/2] telit: make sure QSS status values read are always known [PATCH 2/2] telit: rework QSS unsolicited handler enabling logic Cheers!

Re: [PATCH 2/2] telit: rework QSS unsolicited handler enabling logic

On Mon, Jun 5, 2017 at 1:56 PM, Aleksander Morgado <aleksan...@aleksander.es> wrote: > On Mon, Jun 5, 2017 at 9:51 AM, Carlo Lobrano <c.lobr...@gmail.com> wrote: >> I tested this patch and it looks good to me (I specially like the second >> one). There is just a littl

Re: [PATCH 2/2] telit: rework QSS unsolicited handler enabling logic

On Mon, Jun 5, 2017 at 9:51 AM, Carlo Lobrano wrote: > I tested this patch and it looks good to me (I specially like the second > one). There is just a little mistake I made in my part of the patch. In the > "status changed" log I inverted current status with the previous

Re: MC7455 in X220 with ModemManager 1.6.4

Hey, >> >> > I did recently change modem in my Lenovo X220 running Ubuntu 16.04 to >> > MC7455 I bought from Farnell. I did add Aleksander PPA for ModemManager on >> > Xenial: https://launchpad.net/~aleksander-m to get newer version on MM, >> > which should hopefully support my modem.

Re: [PATCH] helpers: remove unnecessary `>= 0' checks on guint value

On 07/06/17 00:10, Ben Chan wrote: > This CL removes the unnecessary `>= 0' check on `mode_val' and > `ind_val', which are both guint values extracted from a GArray with > guint values, in mm_3gpp_parse_cmer_test_response to address the > following compiler warnings: > >

Re: [PATCH] Infineon: Add support for Infineon / Intel modems

n; either version 2 of the License, or > + * (at your option) any later version. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PUR

Re: MC7455 in X220 with ModemManager 1.6.4

Hey, > > so my card is not listed in rfkill at all: > > litin@x220:~$ rfkill list all > 0: hci0: Bluetooth > Soft blocked: no > Hard blocked: no > 1: tpacpi_bluetooth_sw: Bluetooth > Soft blocked: no > Hard blocked: no > 2: phy0: Wireless LAN > Soft blocked: no > Hard

Re: [PATCH 1/1] telit: fix #PSNT values interpretation for HSDPA and LTE modems

On Fri, Jun 16, 2017 at 4:12 PM, Daniele Palmas wrote: > Telit LTE modems use #PSNT: 4 for LTE access technology, > and #PSNT: 5 for unknown access technology, while HSDPA > modems use #PSNT: 4 for unknown access technology. > > This patch fixes those #PSNT values interpretation

ANN: ModemManager 1.6.8 released

Hey hey, This is a new release in the ModemManager 1.6.x series. This is a quick bugfix release because the previous 1.6.6 release failed to build against libqmi 1.16 (thanks to Michael Biebl for reporting!). Overview of changes in ModemManager 1.6.8 ---

Re: [PATCH 1/1] helpers: extend +WS46=? response parser to support ranges

Hey Daniele, On Fri, Jun 16, 2017 at 10:11 AM, Daniele Palmas wrote: > Telit LTE modems could reply to +WS46=? with: > > +WS46: (12,22,25,28-31) > > This patch extends +WS46=? response parser to support ranges. > --- > Hi, > > current mm log is > > Jun 15 15:04:04 L2122

Re: [PATCH v2 1/1] helpers: extend +WS46=? response parser to support ranges

On 16/06/17 14:57, Daniele Palmas wrote: > Telit LTE modems could reply to +WS46=? with: > > +WS46: (12,22,25,28-31) > > This patch extends +WS46=? response parser to support ranges. > --- > v2: used mm_parse_uint_list as suggested by Aleksander Pushed to git master and mm-1-6. I realized late

Re: Setup MC7455 connection to internet with modem manager

On Wed, Jun 14, 2017 at 10:27 AM, Nassim Dahmani wrote: > ModemManager[2307]: [1497428506.533684] [mm-device.c:525] > mm_device_create_modem(): Creating modem with plugin 'Generic' and '5' ports > ModemManager[2307]: [1497428506.535234] [mm-base-modem.c:280] >

Re: [PATCH] Infineon: Add support for Infineon / Intel modems

On Sat, Jun 10, 2017 at 3:25 AM, Paul Bartell wrote: > I don't have any modems to test ECM data mode with. Likely It could be > supported via the +XDATACHANNEL command in addition to +XCEDATA, but > It's unclear from the Sierra interface guide or Intel docs. > > Either

Re: Setup MC7455 connection to internet with modem manager

Hey, > > I'm trying to setup an internet connection for a box with a MC7455 on ubuntu > 17.04. I'm a newbie on this so some help would be nice > > ~$ sudo mmcli -b 0 > Bearer '/org/freedesktop/ModemManager1/Bearer/0' > - > Status | connected: 'yes' > | suspended: 'no' > |

Re: MMKernelDevice ID_USB_INTERFACE_NUM property isn't set anymore

On Wed, May 3, 2017 at 9:46 PM, Dan Williams wrote: >> > > We need to fix this; we shouldn't be relying on a systemd >> > > property. I >> > > originally thought this was provided by udev itself... although >> > > with >> > > the systemd/udev development being done together, it

Re: MMKernelDevice ID_USB_INTERFACE_NUM property isn't set anymore

On Thu, May 4, 2017 at 10:29 AM, Aleksander Morgado <aleksan...@aleksander.es> wrote: >>> > > We need to fix this; we shouldn't be relying on a systemd >>> > > property. I >>> > > originally thought this was provided by udev itself... althoug

Re: [PATCH 2/2] dell: removed ID_MM_TELIT_PORTS_TAGGED dependency

On Sat, May 6, 2017 at 11:59 AM, Carlo Lobrano wrote: >> Looking at the actual purpose of the code; it looks like it's for >> minimizing probing time because Telit modems always reply well to >> AT+GMI , and that is actually the first command we try... so do we >> even need

Re: ublox SARA-U260 not showing up in mmcli

On Sat, May 6, 2017 at 6:58 AM, Brent Sink wrote: >> Oh, that's weird. Which serial port settings are you using when > >> opening the TTY on minicom? > > I'm using 115200 8N1 > >> Could you get ModemManager debug logs as well to see where/how the >> port probing fails? >>

Re: Re: SIM hot swap with SIM locked

On Mon, May 8, 2017 at 10:33 AM, Carlo Lobrano wrote: > any update on this front? Let me know if you need any help for this Not yet, but not forgotten. I've been adding this task to my weekly TODO task since at least a month, hope to have some time to check it soon... --

Re: ublox SARA-U260 not showing up in mmcli

/dev/ttyACM5 > > # mmcli -V > mmcli 1.7.0 > Copyright (2011 - 2016) Aleksander Morgado > > # mmcli -L > No modems were found > > # dmesg | grep acm > [1.861414] usbcore: registered new interface driver cdc_acm > [1.865803] cdc_acm: USB Abstract Control Model dr

Re: MMKernelDevice ID_USB_INTERFACE_NUM property isn't set anymore

On Wed, May 3, 2017 at 12:10 PM, Carlo Lobrano wrote: >> When using the "udev" backend, which you are, the property isn't >> "loaded" or "stored" anywhere in our code. We directly look for the >> property in the GUdevDevice underneath. >> >> Could you run udevadm info in the

Re: [PATCH 2/2] dell: removed ID_MM_TELIT_PORTS_TAGGED dependency

Hey, On Fri, May 5, 2017 at 4:49 PM, Carlo Lobrano wrote: > Currently Dell plugin depends on ID_MM_TELIT_PORTS_TAGGED > environment variable, set by udev, to speed up probing time > avoiding +CGMI and ATI sending. > > To remove this dependency from udev, I moved the product

Re: QMI modems with MM-master branch error

On Fri, May 5, 2017 at 4:08 PM, Penalva, Salvador wrote: > I thought that too, > > but this modem still worked with the commit before the last changes I > mentioned in the email before. Why is the connection attempt cancelled then > an in the second retry working

Re: Ublox TOBY-L210 needs two retries to connect

On Fri, May 5, 2017 at 5:53 PM, Penalva, Salvador wrote: > I don't mind testing these changes, but I may need a little further guidance > to do the changes. The files mm-broadband-modem-pantech.c and > mm-broadband-modem-ublox.c are quite different... > > I have

Re: [review] dcbw/huawei-voice

On Thu, May 4, 2017 at 4:30 PM, Riccardo Vangelisti wrote: > Aleksander, did you check if this branch works on your MU709 dev board ? I did not, sorry, but I will as soon as I have some time :) -- Aleksander https://aleksander.es

[PATCH v2 4/4] cinterion: use ^SIND unsolicited messages for access tech reporting

If the modem supports ^SIND psinfo reporting, we enable the URC and flag the access technology polling unsupported, so that we only update access technology via the +CIEV URCs. E.g.: (ttyACM1): --> 'AT^SIND="psinfo",1' (ttyACM1): <-- '^SIND: psinfo,1,10OK' Reporting initial access

Allow plugins to specify that signal quality/access tech polling isn't needed (v2)

Hey Dan and everyone, This patch series contains the following updates w.r.t. the v1 patches: * When a explicit signal refresh is requested, setup the initial fast-polling configuration (this was suggested in the review of PATCH 2/4, but the fix has been applied in PATCH v2 1/4). * In the

[PATCH v2 1/4] iface-modem: consolidate signal quality and access tech polling

Plugins have two ways to update signal quality and access technology values: via unsolicited messages or via polling periodically. Instead of keeping separate contexts for polling signal quality and access technology values, we setup a common timeout to trigger both. This allows us to simplify in

[PATCH v2 3/4] port-serial-at: always prepend unsolicited message handlers

The generic modem has several URC handlers for generic messages, like +CIEV. But, there may be cases where the plugins themselves want to provide their own URC handlers to be run before the generic one. This patch enables this setup by always prepending the new URC handlers, so that the last ones

[PATCH v2 2/4] iface-modem: if bands, capabilities or modes change, refresh signal

We also remove the explicit refresh request from the Cinterion plugin, as this is a generic action applicable to all modems that require polling for signal quality and/or access technology. --- plugins/cinterion/mm-broadband-modem-cinterion.c | 10 ++ src/mm-iface-modem.c

<    4   5   6   7   8   9   10   11   12   13   >