[PATCH] telit: use g_assert instead of g_assert_true / g_assert_false

2017-01-11 Thread Ben Chan
`g_assert_true' and `g_assert_false' are defined in glib 2.38 or later. The minimum glib version currently required by ModemMamanger is 2.36. While `g_assert_true' and `g_assert_false' may be preferred over the more generic `g_assert', it seems like overkill to bump the minimum glib version

Re: [systemd-devel] WebUSB

2017-01-11 Thread Christer Weinigel
On 2017-01-10 19:55, Lars Knudsen wrote: > On Tue, Jan 10, 2017 at 7:08 PM, Dan Williams > wrote: > And we're quite happy to keep blacklisting specific VID/PID combos we > know are not modems. Another possible solution is to greylist devices >

Re: [systemd-devel] WebUSB

2017-01-11 Thread Oliver Neukum
Am Mittwoch, den 11.01.2017, 16:01 +0100 schrieb Lars Knudsen: > If it can be invoked via DBus - what is the harm to only do the scan > for the greylisted (in this case webusb) modems when the user > actually wants to search for a modem (like a printer) - and leave the > poor devices alone

Re: [systemd-devel] WebUSB

2017-01-11 Thread Oliver Neukum
On Tue, 2017-01-10 at 19:55 +0100, Lars Knudsen wrote > And we're quite happy to keep blacklisting specific VID/PID > combos we > know are not modems. Another possible solution is to greylist > devices > that happen to have webusb descriptors, such that

Re: [systemd-devel] WebUSB

2017-01-11 Thread Dan Williams
On Wed, 2017-01-11 at 16:01 +0100, Lars Knudsen wrote: > If it can be invoked via DBus - what is the harm to only do the scan > for > the greylisted (in this case webusb) modems when the user actually > wants to > search for a modem (like a printer) - and leave the poor devices > alone >

Re: [systemd-devel] WebUSB

2017-01-11 Thread Aleksander Morgado
On Wed, Jan 11, 2017 at 2:21 PM, Christer Weinigel wrote: >> Actually, that sounds like a very good compromise. I remember my own >> struggles 3-4 years ago when I had to get a device working properly on >> ChromeOS and Ubuntu, where the firmware had to handle that the