Re: bug fix for absent author of

[L. Walsh]

On 2020/03/22 03:45, Neil Bowers wrote:



Oh. It's you.


I was trying to inject some humour, while also indicating I’ll try and 
deal with this, "at some point soon".

I don't think you were entirely unsuccessful in either of those goals.
:-|

Re: bug fix for absent author of

[Neil Bowers]

> Oh. It's you.

Yeah, sorry — after a stressful week (for all of us), I was trying to inject 
some humour, while also indicating I’ll try and deal with this, "at some point 
soon".

x


>

Re: bug fix for absent author of

[Neil Bowers]

> Neil, it's you, not Yves.

I know.

Re: bug fix for absent author of

[Reini Urban]

Neil Bowers  schrieb am Sa., 21. März 2020, 21:20:

> Hi L,
>
> > I was trying to use something that had Text::Quote as a dependency.
> > It has a bug in its test involving a string compare on floating
> > point values (for 2/3) that generates different output on machines
> > with different # bits for floating point.
> >
> > The bug was filed 6 years ago and is still in New state.
> >
> > Attached is a patch and .zip which seems to fix the problem.
> >
> > Maintainers: NEILB, YVES
> >
> > How would this replace the current module+test?
>
> A good approach is to reply on RT, and include your patch in RT.
>
> I’m pretty sure the person who most recently released it has a github
> repo, so you could also consider going the extra mile and doing a pull
> request. But probably best be patient, as like most of the world, he
> probably has other concerns right now.
>


Neil, it's you, not Yves.


> Maybe if he’s done nothing in a week or two, email him a nudge?
>

Re: bug fix for absent author of

[Neil Bowers]

Hi L,

> I was trying to use something that had Text::Quote as a dependency.
> It has a bug in its test involving a string compare on floating
> point values (for 2/3) that generates different output on machines
> with different # bits for floating point.
> 
> The bug was filed 6 years ago and is still in New state.
> 
> Attached is a patch and .zip which seems to fix the problem.
> 
> Maintainers: NEILB, YVES
> 
> How would this replace the current module+test?

A good approach is to reply on RT, and include your patch in RT.

I’m pretty sure the person who most recently released it has a github repo, so 
you could also consider going the extra mile and doing a pull request. But 
probably best be patient, as like most of the world, he probably has other 
concerns right now.

Maybe if he’s done nothing in a week or two, email him a nudge?

Cheers,
Neil

Re: bug fix for absent author of Text::Quote

[L. A. Walsh]

well, it's not like anyone should be confused about what module
if they looked at the patch or zip, but thought I'd make a reply
with the module name in the Subject.

bug fix for absent author of

[L A Walsh]

I was trying to use something that had Text::Quote as a dependency.
It has a bug in its test involving a string compare on floating
point values (for 2/3) that generates different output on machines
with different # bits for floating point.

The bug was filed 6 years ago and is still in New state.

Attached is a patch and .zip which seems to fix the problem.

Maintainers: NEILB, YVES

How would this replace the current module+test?

Tnx,
-l
r



Text-Quote-0.33.tar.gz
Description: GNU Zip compressed data
diff -ru Text-Quote-0.32-2/Changes /tmp/Text-Quote-0.33/Changes
--- Text-Quote-0.32-2/Changes	2014-06-28 00:23:56.0 -0700
+++ /tmp/Text-Quote-0.33/Changes	2020-03-21 11:31:32.345989836 -0700
@@ -1,5 +1,12 @@
 Revision history for Perl module Text::Quote
 
+0.33 2020-03-21 LAWALSH
+- test compares text output 2/3 -- different depending on #float bits.
+  instead, since we are not testing division, use exact float number
+  we expect : '0.667'; (14 sixes) as a quoted string (so
+  no math precision diffs can make a difference. Likely not best
+  solution, but seems to be most str8 forward one.
+
 0.32 2014-06-28 NEILB
 - Doh, the test for regexp serialization format clearly needs to
   check what version of Perl it's running under, and change expectations
diff -ru Text-Quote-0.32-2/META.yml /tmp/Text-Quote-0.33/META.yml
--- Text-Quote-0.32-2/META.yml	2014-06-28 00:23:56.0 -0700
+++ /tmp/Text-Quote-0.33/META.yml	2020-03-21 11:42:47.851817355 -0700
@@ -26,4 +26,4 @@
 resources:
   homepage: https://github.com/neilbowers/Text-Quote
   repository: https://github.com/neilbowers/Text-Quote.git
-version: '0.32'
+version: '0.33'
diff -ru Text-Quote-0.32-2/Makefile.PL /tmp/Text-Quote-0.33/Makefile.PL
--- Text-Quote-0.32-2/Makefile.PL	2014-06-28 00:23:56.0 -0700
+++ /tmp/Text-Quote-0.33/Makefile.PL	2020-03-21 11:42:07.323628308 -0700
@@ -32,7 +32,7 @@
 "Test::More" => 0,
 "vars" => 0
   },
-  "VERSION" => "0.32",
+  "VERSION" => "0.33",
   "test" => {
 "TESTS" => "t/*.t"
   }
Only in /tmp/Text-Quote-0.33: Makefile.old
diff -ru Text-Quote-0.32-2/README /tmp/Text-Quote-0.33/README
--- Text-Quote-0.32-2/README	2014-06-28 00:23:56.0 -0700
+++ /tmp/Text-Quote-0.33/README	2020-03-21 11:45:02.587769880 -0700
@@ -1,7 +1,7 @@
 
 
 This archive contains the distribution Text-Quote,
-version 0.32:
+version 0.33:
 
   Quotes strings as required for perl to eval them back correctly 
 
diff -ru Text-Quote-0.32-2/dist.ini /tmp/Text-Quote-0.33/dist.ini
--- Text-Quote-0.32-2/dist.ini	2014-06-28 00:23:56.0 -0700
+++ /tmp/Text-Quote-0.33/dist.ini	2020-03-21 11:41:28.891500693 -0700
@@ -4,7 +4,7 @@
 copyright_holder = Yves Orton
 copyright_year   = 2002
 
-version = 0.32
+version = 0.33
 
 [@Basic]
 [PkgVersion]
diff -ru Text-Quote-0.32-2/lib/Text/Quote.pm /tmp/Text-Quote-0.33/lib/Text/Quote.pm
--- Text-Quote-0.32-2/lib/Text/Quote.pm	2014-06-28 00:23:56.0 -0700
+++ /tmp/Text-Quote-0.33/lib/Text/Quote.pm	2020-03-21 11:32:34.794823678 -0700
@@ -1,5 +1,5 @@
 package Text::Quote;
-$Text::Quote::VERSION = '0.32';
+$Text::Quote::VERSION = '0.33';
 use 5.006;
 use strict;
 use warnings;
diff -ru Text-Quote-0.32-2/t/quote.t /tmp/Text-Quote-0.33/t/quote.t
--- Text-Quote-0.32-2/t/quote.t	2014-06-28 00:23:56.0 -0700
+++ /tmp/Text-Quote-0.33/t/quote.t	2020-03-21 11:40:04.092012416 -0700
@@ -111,7 +111,7 @@
 	my @quotes=map{Text::Quote->quote($_,indent=>6,col_width=>60)}('"The time has come"
 	the	walrus said,
 	"to speak of many things..."',"\0\1\2\3\4\5\6\a\b\t\n\13\f\r\16\17\20\21\22\23\24\25\26\27\30\31\32\e\34\35".
-	"\36\37",("\6\a\b\t\n\13\f\r\32\e\34" x 5),2/3,10,'£20','00',);
+	"\36\37",("\6\a\b\t\n\13\f\r\32\e\34" x 5),'q(0.667)',10,'£20','00',);
 	my $res;
 	for my $i (1..@quotes) {
 		$res.= "\$var$i=".$quotes[$i-1].";\n";
@@ -122,7 +122,7 @@
 $var2="\0\1\2\3\4\5\6\a\b\t\n\13\f\r\16\17\20\21\22\23\24\25\26\27".
   "\30\31\32\e\34\35\36\37";
 $var3=("\6\a\b\t\n\13\f\r\32\e\34" x 5);
-$var4=0.667;
+$var4='q(0.667)';
 $var5=10;
 $var6='£20';
 $var7='00';