Re: Bug in prereq_report?

2006-09-28 Thread Andreas J. Koenig
> On Thu, 28 Sep 2006 16:26:02 -0500, Ken Williams <[EMAIL PROTECTED]> said: > On Sep 28, 2006, at 2:04 PM, Andreas J. Koenig wrote: >> This is not a flaw in MakeMaker but a simple rule on CPAN that people >> have learned to accept in over 10 years. Isn't it a bit irritating >> when diff

Re: Bug in prereq_report?

2006-09-28 Thread Ken Williams
On Sep 28, 2006, at 11:11 AM, John Peacock wrote: Ken Williams wrote: Probably the first step is to add a failing test case to t/ moduleinfo.t, would that be fairly easy? I have to rewrite a custom reporting app for work, so I'm not going to get to it before tonight. It's fairly straightf

Re: Bug in prereq_report?

2006-09-28 Thread David Golden
On 9/28/06, Andreas J. Koenig <[EMAIL PROTECTED]> wrote: While testing my own current development version of CPAN.pm (1.8851) I ran across the following while in the CPAN::Reporter directory: CPAN-Reporter-0.20% ./Build prereq_report Use of uninitialized value in concatenation (.) or strin

Re: Bug in prereq_report?

2006-09-28 Thread Ken Williams
On Sep 28, 2006, at 2:04 PM, Andreas J. Koenig wrote: But maybe one should have followed the very old MakeMaker convention that only the first $VERSION assignment per file is parsed to determine the version. That's the procedure we started from a year or so ago, and then when we found obvio

Re: Bug in prereq_report?

2006-09-28 Thread Andreas J. Koenig
> On Thu, 28 Sep 2006 12:11:51 -0400, John Peacock <[EMAIL PROTECTED]> said: >> My understanding was that the second line shouldn't be scanned at >> all, because we already have a $VERSION variable set from the first >> line. > The problem is (now that I have reviewed the code) that the

Re: Bug in prereq_report?

2006-09-28 Thread Ken Williams
On Sep 28, 2006, at 11:15 AM, Matthew Carlisle wrote: Hello, If you have you a [EMAIL PROTECTED] on this distribution list, please remove him, he is no longer at this address. Thanks. I don't control the subscription list. He can send a message to [EMAIL PROTECTED] to unsubscribe himsel

Re: Bug in prereq_report?

2006-09-28 Thread John Peacock
Ken Williams wrote: Probably the first step is to add a failing test case to t/moduleinfo.t, would that be fairly easy? I have to rewrite a custom reporting app for work, so I'm not going to get to it before tonight. It's fairly straightforward: 1) create a dummy module with the offending t

Re: Bug in prereq_report?

2006-09-28 Thread Ken Williams
On Sep 28, 2006, at 9:53 AM, John Peacock wrote: John Peacock wrote: Ahhh, it is this code from CPAN.pm (being these are lines 4 and 5): $CPAN::VERSION = '1.8801'; $CPAN::VERSION = eval $CPAN::VERSION; OK, I have it sussed out, but I'm not sure how to fix it yet for the general cas

Re: Bug in prereq_report?

2006-09-28 Thread John Peacock
John Peacock wrote: Ahhh, it is this code from CPAN.pm (being these are lines 4 and 5): $CPAN::VERSION = '1.8801'; $CPAN::VERSION = eval $CPAN::VERSION; OK, I have it sussed out, but I'm not sure how to fix it yet for the general case. The issue only comes up when you use fully-quali

Re: Bug in prereq_report?

2006-09-28 Thread John Peacock
Andreas J. Koenig wrote: CPAN-Reporter-0.20% ./Build prereq_report Use of uninitialized value in concatenation (.) or string at /home/src/perl/repoperls/installed-perls/perl/p0zpP0q/[EMAIL PROTECTED]/lib/5.9.4/Module/Build/ModuleInfo.pm line 223, line 5. Package 'CPAN' already declared w

Bug in prereq_report?

2006-09-28 Thread Andreas J. Koenig
While testing my own current development version of CPAN.pm (1.8851) I ran across the following while in the CPAN::Reporter directory: CPAN-Reporter-0.20% ./Build prereq_report Use of uninitialized value in concatenation (.) or string at /home/src/perl/repoperls/installed-perls/perl/p0zpP0q/