Re: Ending Build.PL if there are missing modules

2012-02-05 Thread Adam Kennedy
If the goal is only to pick up versioned dependencies, I'm surprised we even need to bother with that. For M:I I've been thinking of just scanning all of script and lib for /^use Module::Name 1.23/ to determine requires, and all of t to find build_requires/test_requires. Anything loaded without a

Re: Ending Build.PL if there are missing modules

2012-02-05 Thread Adam Kennedy
That's how Module::Install's requires_from does it too. I should look at zilla's code and see how it runs, might be worth aligning M:I and it's detection. Adam On Sun, Feb 5, 2012 at 12:31 AM, David Golden wrote: > On Sat, Feb 4, 2012 at 7:48 AM, Leon Timmermans wrote: >> On Sat, Feb 4, 2012 a

Re: Ending Build.PL if there are missing modules

2012-02-05 Thread Adam Kennedy
I was thinking about dropping anything without a specific numberic version completely and requiring manual, because I figure the chances for misidentification is too high (whereas a number will only really be there after a human has put some specific thought into it). Adam On Sun, Feb 5, 2012 at

Re: Ending Build.PL if there are missing modules

2012-02-05 Thread David Golden
On Sun, Feb 5, 2012 at 1:15 AM, Eric Wilhelm wrote: >>It doesn't help with optional, dynamic prereqs so those have to be >>specified manually, but that's unavoidable I think. > > I've experimented with detecting those using my Devel::TraceDeps on the > running test suite.  It is possible to see th

Re: Ending Build.PL if there are missing modules

2012-02-04 Thread Eric Wilhelm
# from David Golden # on Saturday 04 February 2012 17:23: >It doesn't help with optional, dynamic prereqs so those have to be >specified manually, but that's unavoidable I think. I've experimented with detecting those using my Devel::TraceDeps on the running test suite. It is possible to see th

Re: Ending Build.PL if there are missing modules

2012-02-04 Thread David Golden
On Sat, Feb 4, 2012 at 9:51 PM, Adam Kennedy wrote: > I was thinking about dropping anything without a specific numberic > version completely and requiring manual, because I figure the chances > for misidentification is too high (whereas a number will only really > be there after a human has put s

Re: Ending Build.PL if there are missing modules

2012-02-04 Thread David Golden
On Sat, Feb 4, 2012 at 9:43 PM, Adam Kennedy wrote: > If the goal is only to pick up versioned dependencies, I'm surprised > we even need to bother with that. It picks up as many "standard" dependencies as it can, but treats anything without a version as requesting version 0. -- David

Re: Ending Build.PL if there are missing modules

2012-02-04 Thread David Golden
On Sat, Feb 4, 2012 at 5:17 PM, Adam Kennedy wrote: > That's how Module::Install's requires_from does it too. > > I should look at zilla's code and see how it runs, might be worth > aligning M:I and it's detection. It uses Ricardo's Perl::PrereqScanner, which does a pretty sane job of it (even de

Re: Ending Build.PL if there are missing modules

2012-02-04 Thread David Golden
On Sat, Feb 4, 2012 at 7:48 AM, Leon Timmermans wrote: > On Sat, Feb 4, 2012 at 1:32 AM, Adam Kennedy > wrote: >> While I agree it needs to finish, I do kind of wish dependencies could >> be enforced at the build module level so that tests couldn't run until >> dependencies are satisfied. > > I t

Re: Ending Build.PL if there are missing modules

2012-02-04 Thread Leon Timmermans
On Sat, Feb 4, 2012 at 1:32 AM, Adam Kennedy wrote: > While I agree it needs to finish, I do kind of wish dependencies could > be enforced at the build module level so that tests couldn't run until > dependencies are satisfied. I tend to agree with that. I've been writting Test::CheckDeps (warnin

Re: Ending Build.PL if there are missing modules

2012-02-04 Thread Leon Timmermans
2012/2/4 Alberto Simões : > Basically, I depend on Parse::Yapp, and I would like to call `yapp` on > Build.PL so I can have the generated .pm file before M::B generates all its > data dir. > > In fact, I can add that to inc/MyBuilder.pm, but I am afraid the generated > .pm will not be installed. >

Re: Ending Build.PL if there are missing modules

2012-02-04 Thread Alberto Simões
Hello On 04/02/12 01:33, Michael G Schwern wrote: On 2012.2.3 3:22 PM, Leon Timmermans wrote: You shouldn't make it stop. «perl Build.PL» does configuration, not building. Hence build or runtime requirements are not required to be satisfied. What you're observing is not an error in any way, but

Re: Ending Build.PL if there are missing modules

2012-02-03 Thread Michael G Schwern
On 2012.2.3 4:32 PM, Adam Kennedy wrote: > While I agree it needs to finish, I do kind of wish dependencies could > be enforced at the build module level so that tests couldn't run until > dependencies are satisfied. This should be enforced not by the build tool, which cannot resolve the dependenc

Re: Ending Build.PL if there are missing modules

2012-02-03 Thread Michael G Schwern
On 2012.2.3 3:22 PM, Leon Timmermans wrote: > You shouldn't make it stop. «perl Build.PL» does configuration, not > building. Hence build or runtime requirements are not required to be > satisfied. What you're observing is not an error in any way, but an > essential step in the process. It gives th

Re: Ending Build.PL if there are missing modules

2012-02-03 Thread Adam Kennedy
While I agree it needs to finish, I do kind of wish dependencies could be enforced at the build module level so that tests couldn't run until dependencies are satisfied. Adam On 4 February 2012 10:22, Leon Timmermans wrote: > 2012/2/3 Alberto Simões : >> Hello >> >> Builder->new seems to check i

Re: Ending Build.PL if there are missing modules

2012-02-03 Thread Leon Timmermans
2012/2/3 Alberto Simões : > Hello > > Builder->new seems to check if all required modules are available. But if > any fails, it continues to process the Build.PL file. > > Is there any way to make it stop? > > Thanks Hi Alberto, You shouldn't make it stop. «perl Build.PL» does configuration, not