Re: [Mono-dev] Mono Winforms on Mac

2010-10-30 Thread Carlos Alberto Cortez
Hello, I will step up, since I have more experience on the code, but based on its size, I may be giving feedback piece by piece. Carlos. 2010/10/30 Miguel de Icaza mig...@novell.com Hello Ralph, Does the Mono Project have it's own format utility? It would be nice to make all the code

Re: [Mono-dev] SerialPort and OnDataReceived event

2010-07-30 Thread Carlos Alberto Cortez
Hey, This event is indeed not implemented. I began to implement it some time ago, but due to some technical reasons I don't remember now -it was something related to poll/select functions, likely), I didn't commit it (and now I can't seem to find that patch). And yes, we would accept patches in

Re: [Mono-dev] [PATCH] Bug 494234: XplatUIX11.WorkingArea can segfault if the WM does not support _NET_WORKAREA

2010-04-08 Thread Carlos Alberto Cortez
Hey, The change seems fine, but we need to test it. Will do that this weekend. Thanks, Carlos. 2010/4/3 Brian Pellin bpel...@gmail.com Is there anything I can do to encourage applying the patch in Bug 494234? [1] I get a segfault every time I run KeePass[2] in the xmonad[3] window manager,

Re: [Mono-dev] [Bug 575813] FileStream doesn't handle errors on Close (disk full, generic error, etc.)

2010-02-08 Thread Carlos Alberto Cortez
Hey! I was taking a look and the issue is not reproducible in trunk, since r145271 seems to fix it indirectly, by calling MonoIO.Write until *all* the bytes have been written. At least it fixes the very specific scenario described in the bug report, and since that revision is expected to be

Re: [Mono-dev] [Bug 575813] FileStream doesn't handle errors on Close (disk full, generic error, etc.)

2010-02-05 Thread Carlos Alberto Cortez
I will take a look at it in the next days. Carlos. 2010/2/5 Alex Shulgin alexander.shul...@yessoftware.com Alex Shulgin wrote: Hi, I've filed a somewhat nasty bug a few days back (you may lose your data if you trigger it): https://bugzilla.novell.com/show_bug.cgi?id=575813 I'd

Re: [Mono-dev] Mono 2.6.x

2010-02-02 Thread Carlos Alberto Cortez
#569535 has been already backported, so it should appear in the next release. Carlos. 2010/2/2 Kris Ray k...@landmarkdigital.com I would like to vote for backports of the following bugs, which are already fixed in trunk: https://bugzilla.novell.com/show_bug.cgi?id=565149

Re: [Mono-dev] Fwd: Could you please review/comment or approve?

2010-01-22 Thread Carlos Alberto Cortez
de Icaza mig...@novell.com Date: Sun, Nov 22, 2009 at 10:46 PM Subject: Could you please review/comment or approve? To: Carlos Alberto Cortez calberto.cor...@gmail.com Cc: skol...@gmail.com Hello Carlos, Could you please review this patch that has been sitting on mono-devel

[Mono-dev] [Patch] Support for exponents in Int32.Parse

2009-12-21 Thread Carlos Alberto Cortez
Hey! I was going to commit the attached patch, in order to support exponent notation in our Int32.Parse method (as declared in NumberStyles.AllowExponent). But then I thought it would be a good idea to throw the patch to the public, in case somebody is interested - specially in the overflow

Re: [Mono-dev] Announcing the release of Mono 2.4.3

2009-12-09 Thread Carlos Alberto Cortez
It was indeed fixed. Sorry, I forgot to close that one. Carlos. 2009/12/9 Oskar Berggren oskar.bergg...@gmail.com The release notes lists the following issue as fixed: 467418 (https://bugzilla.novell.com/show_bug.cgi?id=467418) - ListView in VirtualMode uses too much memory and is slow

Re: [Mono-dev] [Patch] Report an error if src and dest are the same in Copy

2009-11-27 Thread Carlos Alberto Cortez
Yes - sorry, I forgot to send it with the previous patch ;-) Carlos. 2009/11/27 Rodrigo Kumpera kump...@gmail.com Do you have a test case for that? On Fri, Nov 27, 2009 at 12:09 AM, Carlos Alberto Cortez calberto.cor...@gmail.com wrote: Hey, The attached patch on CopyFile on our io

[Mono-dev] [Patch] Report an error if src and dest are the same in Copy

2009-11-26 Thread Carlos Alberto Cortez
Hey, The attached patch on CopyFile on our io-layer -which is used by System.IO.File.Copy- check if the source and the destination are the same, and in that case, report that the file is currently in use, and proceed to throw an exception. I tried to add this check directly in our C# side, but

Re: [Mono-dev] Gtk depends on Winforms ¿?

2009-09-07 Thread Carlos Alberto Cortez
Hey, But since Mono's System.Windows.Forms is Open Source [1], why was it again that no one has found out what DoEvents does? ;-) Andreas [1] http://anonsvn.mono-project.com/viewvc/trunk/mcs/class/Managed.Windows.Forms/System.Windows.Forms/XplatUIWin32.cs?view=markup We do know what

Re: [Mono-dev] WinForms Control.Invoke Issue

2009-08-07 Thread Carlos Alberto Cortez
Hey! I had been reviewing some patches we have in bugzilla - but I missed this one. It's now reviewed - see bugzilla ;-) Thanks! Carlos. 2009/8/7 Tom Spink tsp...@gmail.com Hi Guys, I filed a bug a while ago about an issue with Control.Invoke in WinForms. A guy said he'd take a look at a

Re: [Mono-dev] current serialport status..

2009-07-13 Thread Carlos Alberto Cortez
As Atsushi said, nobody is working in the serial ports these days, but you can still fill a bug report, and at some point we will try to fix it. Carlos. 2009/7/13 Atsushi Eno atsushi...@veritas-vos-liberabit.com My understanding is that no one is working on serial port stack now. I haven't

Re: [Mono-dev] Bug In Mono FTP System.Net.FtpWebRequest

2008-09-04 Thread Carlos Alberto Cortez
This is mostly an eror. Please fill a bug for it. See http://mono-project.com/Bugs Carlos. El mié, 03-09-2008 a las 05:23 -0700, Dieuzorro escribió: With my code I was able to download a file on the server ftp://ftp-developpez.com/konflor/Latex/formation/FormationLatex.pdf; anonymously. But

Re: [Mono-dev] Mono 2.0 Preview 1 is out!!

2008-08-20 Thread Carlos Alberto Cortez
Hello, 3) You asked post bug reports. OK. I looked in tracker - there are 171 bugs only in SWF (some of them are mine). Some bugs assigned to developers. But most of them not assigned. What do you plan to do with such bugs? Will you ignore them and make 2.0 release? Developing the

[Mono-dev] [Patch] DateTimePicker changes

2008-07-20 Thread Carlos Alberto Cortez
Hey, While working on #, I found some small bits not matching .net. So basically the attached patch: * Doesn't change the DateTimePicker.Value property immediately when editing -this means, when a user types a single digit-, but when the max number of digits is reached *or* the selection moves

[Mono-dev] [Patch] Implement basic AutoComplete support for ComboBox

2008-07-01 Thread Carlos Alberto Cortez
Hey! Attached is a patch that implements support for ComboBox. The idea is to use the available support in TextBox, so the TextBox has direct access to our items. Since this is not the clearest approach, it's the better in terms of performance, since otherwise we should create a IList of item's

Re: [Mono-dev] Mono C# Serial Port problem

2008-05-30 Thread Carlos Alberto Cortez
Would you mind filling a bug with the precise information? Thanks, Carlos. El jue, 29-05-2008 a las 02:24 -0700, Bs360 escribió: Alan_Chun wrote: HI, currently I am porting a windows app to linux using Mono. I have some difficulties to get the serial port work. here is the

Re: [Mono-dev] ListBox.cs ownder draw variable size

2008-05-30 Thread Carlos Alberto Cortez
Hey, Two things for your next patch: * Use the coding guidelines: http://www.mono-project.com/Coding_Guidelines * Send your patch as an attached file, not in the body of the message. Committed your patch, thanks for the correction! Carlos. El mié, 28-05-2008 a las 06:42 +0200, jkeymer

Re: [Mono-dev] Mono C# Serial Port problem

2008-05-21 Thread Carlos Alberto Cortez
Hello, The issue with our code is that we call the Mono posix libraries, this is not cross platform. Our implementation uses the Win32 api in windows and posix calls with a C helper layer in Unix platforms. Observe that we never tested it with Mac. Since you are using the Mono.Posix

Re: [Mono-dev] Mono C# Serial Port problem

2008-05-15 Thread Carlos Alberto Cortez
That's likely because 'mono test.exe' actually uses mono, and 'test.exe' runs .net instead. This appears to be a bug. Please fill a bug report with the attached repro. Thanks! Carlos El jue, 15-05-2008 a las 12:01 -0700, Alan_Chun escribió: Panoramix wrote: In Linux to use a device

Re: [Mono-dev] Installing policy file in the GAC?

2008-03-05 Thread Carlos Alberto Cortez
gacutil won't install a policy file in the GAC because the policy file isn't an assembly. So, obviously, I have to copy it there from the install script. But how can the install script find out where Mono is installed? Is there any command I can use to get at the Mono installation

Re: [Mono-dev] [PATCH] Cache errno for serial port

2008-02-19 Thread Carlos Alberto Cortez
Hey Miguel, Somehow I had this wrong idea that GetLastError would retrieve windows-specific codes (not the ones errno gets). Thanks, Carlos. El lun, 18-02-2008 a las 20:19 -0500, Miguel de Icaza escribió: Hello Carlos, The attached patch adds a 'serial_errno' variable in

[Mono-dev] [PATCH] Cache errno for serial port

2008-02-17 Thread Carlos Alberto Cortez
Hey, The attached patch adds a 'serial_errno' variable in mono/support/serial.c, to cache the last error related to serial port functions. At first I tried to just create a function directly retrieving errno, but it was getting a different value from the original (probably some code modified it

Re: [Mono-dev] SerialPort - patch waiting to apply

2007-07-01 Thread Carlos Alberto Cortez
El jue, 28-06-2007 a las 17:44 +0200, Leszek Ciesielski escribió: http://bugzilla.ximian.com/show_bug.cgi?id=78911 There's a patch and Miguel's positive comment - can someone apply this, please? Sorry, I thought I had applied it already. This is now in SVN. Thanks for the remainder.

Re: [Mono-dev] Bugzilla bugs needing attention

2007-03-05 Thread Carlos Alberto Cortez
The others I'll verify the patches content and commit if no one objects in the next few hours. That if my networking troubles with access to Mono's SVN repository, doesn't forbid me. In that case I'll report in this thread. It would be a good idea to also have some tests for those patches

Re: [Mono-dev] [Mono-list] serial port problem

2007-01-18 Thread Carlos Alberto Cortez
Hey, Could you cook a test case? That way we can try to take a look at the issue. Carlos. First, I can succesfully read a text string, when I loopback a serial cable, connecting pins 2 and 3 I send the string and can read it immediatly, it worked fine for me in Linux (running mono as

Re: [Mono-dev] [Patch] TreeView, TreeNode, TreeNodeCollection

2007-01-09 Thread Carlos Alberto Cortez
+ public virtual void RemoveByKey(string key) + { + int index = -1; + for (int i = 0; i nodes.Count; i++) + { + if (!string.Equals(nodes[i].Name,key,

Re: [Mono-dev] [PATCH] Generate Consts.vb from Consts.cs (new patch)

2006-08-24 Thread Carlos Alberto Cortez
I might be wrong but I am wondering if it is consistent to use Perl for this kind of things, inside the mono project. It would be more logical to use Mono itself, and then not having another external dependency (Mono depending on Perl??), right? Just for the record: we already have perl

Re: [Mono-dev] [PATCH] Use the correct type for S.D.Printing.PrintDocument.PrintController

2006-08-04 Thread Carlos Alberto Cortez
(controller = {0}, doc.PrintController.GetType()); } } outputs: controller = System.Drawing.Printing.StandardPrintController Chris On Wed, 2006-08-02 at 04:30 -0500, Carlos Alberto Cortez wrote: Hey, S.D.Printing.PrintDocument.PrintController

[Mono-dev] [PATCH] Use the correct type for S.D.Printing.PrintDocument.PrintController

2006-08-02 Thread Carlos Alberto Cortez
Hey, S.D.Printing.PrintDocument.PrintController has as default a new instance of S.W.F.PrintControllerWithStatusDialog, which is in SWF assembly. The current code assigns a new instance of S.D.P.StandardPrintController to PrintDocument.PrintController, which isn't the right behaviour. The

Re: [Mono-dev] [PATCH] Use the correct type for S.D.Printing.PrintDocument.PrintController

2006-08-02 Thread Carlos Alberto Cortez
Oh, that's perfect (I wasn't aware of that constant). Carlos. El mié, 02-08-2006 a las 14:00 +0200, Robert Jordan escribió: Hey, Carlos Alberto Cortez wrote: + Assembly wf_assembly = Assembly.Load (System.Windows.Forms, Version=2.0.3600.0, Culture=neutral

Re: [Mono-dev] SerialPort and Ring Indicator signal

2006-05-23 Thread Carlos Alberto Cortez
be monotored with events ?? please could you give mon hints about this ??? this could be a solution for me ! Thank you. Jean-François PS : please forget my English ;) Carlos Alberto Cortez wrote: Well, RING indicator can't be directly used (as opossed to Cts, Dsr, CD, Rts and Dtr

Re: [Mono-dev] SerialPort and Ring Indicator signal

2006-05-22 Thread Carlos Alberto Cortez
Well, RING indicator can't be directly used (as opossed to Cts, Dsr, CD, Rts and Dtr). The public API in .Net does not expose this indicator directly (you can only monitor it based on the events). Of course we could add it to the get_signal_code () function and retrieve it. But the real problem

[Mono-dev] [Patch] mono/support/serial.c

2006-04-07 Thread Carlos Alberto Cortez
Hello, The attached patch has some changed that I need to apply some others in the C# side in the class library. Is it ok to commit? Carlos. Index: serial.c === --- serial.c (revisión: 59128) +++ serial.c (copia de trabajo) @@

Re: [Mono-dev] Re: Profiling output

2006-03-24 Thread Carlos Alberto Cortez
Hello, A pair of years ago I wrote a small patch for saving the profile output to a xml file. It's almost sure that you won't be able to apply this patch to the current sources, but it could help you to write a custom profiler or just 'catch' the info. Carlos. El vie, 24-03-2006 a las 07:44

[Mono-dev] [Patch] Signals access in mono/support/serial

2006-03-14 Thread Carlos Alberto Cortez
) +++ ChangeLog (copia de trabajo) @@ -1,3 +1,7 @@ +2006-03-14 Carlos Alberto Cortez [EMAIL PROTECTED] + + * serial.c: Add functions to handle signals access. + 2006-03-09 Carlos Alberto Cortez [EMAIL PROTECTED] * serial.c: Fix a pair of wrong or incomplete assignations

[Mono-dev] [Patch] Stream 2.0 updates

2006-02-28 Thread Carlos Alberto Cortez
Hey, This patch adds some of the new 2.0 members to System.IO.Stream. No problems appeared when building, and only got some warnings (they can be removed adding 'override' to the child streams). Carlos. Index: Stream.cs === ---

[Mono-dev] [Patch] Constant changes in mono/support/serial.c

2006-02-22 Thread Carlos Alberto Cortez
Hello, The attached patch updates some comparisons in mono/support/serial.c (some values inside System.IO.Ports changed and need to be taken in count). May I proceed? Carlos. Index: serial.c === --- serial.c (revisión: 56687) +++

Re: [Mono-dev] Assembly Mono.Cecil not found while compiling

2006-02-21 Thread Carlos Alberto Cortez
Yes, tha's the way it works: you install the assembly in the GAC, and _optionally_ set pkg info for the assembly. So, yes, you need to have the assembly in GAC even when using the pkg option. El dom, 19-02-2006 a las 17:33 +0530, vijaya raghava mutharaju escribió: Hi, Thank you

Re: [Mono-dev] Assembly Mono.Cecil not found while compiling

2006-02-17 Thread Carlos Alberto Cortez
Hello, I would like to add something that could be of help: Installing assemblies in tha GAC doesn't mean you can reference them using the '-r' option (this -r option applies to the assembly path, such MyAssembly.dll or ../Something/MyAssembly.dll or /fullpath/MyAssembly.dll). The exceptions to

[Mono-dev] Re: [Fwd: [Mono-patches] r56693 - trunk/mcs/class/System/System.Net]

2006-02-09 Thread Carlos Alberto Cortez
Hey, thanks for the report, I think I've been messing the things the latest days with small things :-( Carlos. El jue, 09-02-2006 a las 17:13 +0900, Atsushi Eno escribió: svn up -r 56692 in ___ Mono-devel-list mailing list

Re: [Mono-dev] [PATCH] Remove version numbers from MonoReflectionAssemblyName

2005-12-14 Thread Carlos Alberto Cortez
Anything else? Is it ok to commit it? Carlos. El lun, 12-12-2005 a las 19:36 -0500, Ben Maurer escribió: On Mon, 2005-12-12 at 15:33 -0600, Carlos Alberto Cortez wrote: Hey, This small patch removes the versions numbers from MonoReflectionAssemblyName, which are unnecessary since we

[Mono-dev] [PATCH] Remove version numbers from MonoReflectionAssemblyName

2005-12-12 Thread Carlos Alberto Cortez
Hey, This small patch removes the versions numbers from MonoReflectionAssemblyName, which are unnecessary since we have a Version field inside it. May I commit? Index: icall.c === --- icall.c (revisión: 54166) +++ icall.c (copia de

[Mono-dev] [PATCH] Update InternalsVisibleTo check

2005-11-12 Thread Carlos Alberto Cortez
Hey, The attached patch updates the check when using InternalsVisibleToAttribute, to have the same behaviour of release of .Net 2.0 (to include the entire key, not the key token). Carlos. Index: codegen.cs === --- codegen.cs

Re: [Mono-dev] [PATCH] Friend access for class members

2005-11-01 Thread Carlos Alberto Cortez
Hey, Sorry for answering this late, I was working on other things and forgot this patch ;-) I've been profiling the consumed memory before and after this patch with heap-buddy, and everything looks to be working fine (no memory regression, at least in managed world). I got the next summaries

[Mono-dev] [PATCH] Friend access for class members

2005-10-28 Thread Carlos Alberto Cortez
Hey, The attached patch implements friend access for class members (methods, properties, fields). I'm not including the type-check section, since that part will be modified (next merge to gmcs) and I'm waiting for that to happen. However, that change should be small (I will send the patch).

Re: [Mono-dev] [PATCH] Friend access for class members

2005-10-28 Thread Carlos Alberto Cortez
. El vie, 28-10-2005 a las 16:23 +0530, Raja R Harinath escribió: Hi, Carlos Alberto Cortez [EMAIL PROTECTED] writes: The attached patch implements friend access for class members (methods, properties, fields). I'm not including the type-check section, since that part will be modified

Re: [Mono-dev] [PATCH] Friend access for class members

2005-10-28 Thread Carlos Alberto Cortez
I forgot to attach the patch ;-) Carlos. El vie, 28-10-2005 a las 16:23 +0530, Raja R Harinath escribió: Hi, Carlos Alberto Cortez [EMAIL PROTECTED] writes: The attached patch implements friend access for class members (methods, properties, fields). I'm not including the type

Re: [Mono-dev] [PATCH] Friend access for class members

2005-10-28 Thread Carlos Alberto Cortez
messages. Carlos. Marek I forgot to attach the patch ;-) Carlos. El vie, 28-10-2005 a las 16:23 +0530, Raja R Harinath escribió: Hi, Carlos Alberto Cortez [EMAIL PROTECTED] writes: The attached patch implements friend access for class members (methods

Re: [Mono-dev] [PATCH] Friend access for class members

2005-10-28 Thread Carlos Alberto Cortez
I forgot to attach the patch ;-) Carlos. El vie, 28-10-2005 a las 16:23 +0530, Raja R Harinath escribió: Hi, Carlos Alberto Cortez [EMAIL PROTECTED] writes: The attached patch implements friend access for class members (methods, properties, fields

Re: [Mono-dev] [PATCH] Int32.Parse

2005-10-21 Thread Carlos Alberto Cortez
) { ... if (something_is_wrong) { if (!tryParse) ex = new ArgumentException (); return false; } Zoltan On 10/20/05, Carlos Alberto Cortez [EMAIL PROTECTED] wrote: Hey, Currently the Int32.TryParse method calls the Int32.Parse

Re: [Mono-dev] [PATCH] Int32.Parse

2005-10-21 Thread Carlos Alberto Cortez
it would be easier to add an out ex argument to CheckStyle as well, instead of duplicating the exception message in three different places. Zoltan On 10/21/05, Carlos Alberto Cortez [EMAIL PROTECTED] wrote: Hello, Ok, then let's keep as you said. The attached patch applies

Re: [Mono-dev] [PATCH] Warning and errors for InternalsVisibleAttr

2005-10-20 Thread Carlos Alberto Cortez
Hey guys, Any news? I think this small patch can go in gmcs, since nobody commented on the posibility of having it on mcs. Carlos. El vie, 14-10-2005 a las 09:08 +0100, Marek Safar escribió: Hello, The attached patch checks the validity of InternalsVisibleToAttribute, and reports and

[Mono-dev] [PATCH] Int32.Parse

2005-10-20 Thread Carlos Alberto Cortez
Hey, Currently the Int32.TryParse method calls the Int32.Parse method, and catches the exceptions. That's not the best behaviour, since Int32.TryParse is designed to avoid the performance problems associated with exception handling. The attached patch proposes an approach to keep the result of

Re: [Mono-dev] [PATCH] Warning and errors for InternalsVisibleAttr

2005-10-14 Thread Carlos Alberto Cortez
Hey, Comments below: El vie, 14-10-2005 a las 09:08 +0100, Marek Safar escribió: Hello, The attached patch checks the validity of InternalsVisibleToAttribute, and reports and warnings depending on the contents. May I commit? - no test for CS1700. Sorry, since it is a warning I

Re: [Mono-dev] [PATCH] Warning and errors for InternalsVisibleAttr

2005-10-14 Thread Carlos Alberto Cortez
Hey Marek, I've attached the patch that I was missing for this patch to be approved. So I think the remaining issue has to see with applying the patch to mcs and/or gmcs or not. Carlos. // gcs1700.cs: Assembly reference `MyAssemblyName, Version=' is invalid and cannot be resolved // Line: 8 //

[Mono-dev] Extern alias patch (latest modifications)

2005-10-13 Thread Carlos Alberto Cortez
Hey, The attached patch contains the impl of extern alias, and also the clean ups to the original code needed for my patch, as required by Hari. I'm also attaching some tests and tests for errors (observe that cs1679 and cs1780 are receiving an error, since it looks like '=' in the comp options

[Mono-dev] [PATCH] Warning and errors for InternalsVisibleAttr

2005-10-13 Thread Carlos Alberto Cortez
Hey, The attached patch checks the validity of InternalsVisibleToAttribute, and reports and warnings depending on the contents. May I commit? Carlos. PD - Attached are some tests. Index: typemanager.cs === --- typemanager.cs

[Mono-dev] [Patch] Avoid creating version in AssemblyName ctor

2005-10-06 Thread Carlos Alberto Cortez
Hey, The attached patch adds a param to mono_assembly_name_parse_full, which lets us avoid creating 'version' if it wasn't defined. This helps us to have the same behavior when the version wasn't defined in AssemblyName(string name). Carlos. Index: assembly.c

[Mono-dev] [Patch] Extern alias (with modifications)

2005-10-05 Thread Carlos Alberto Cortez
Hey, I applied the corrections made by Hari and all my tests are working fine. Comments and suggestions are welcome. Carlos. Index: typemanager.cs === --- typemanager.cs (revisión: 51315) +++ typemanager.cs (copia de trabajo) @@

Re: [Mono-dev] [Patch] Extern assembly alias

2005-09-24 Thread Carlos Alberto Cortez
Hey, I've been thinking about your ideas, but haven't understood yet the some of the reasons behind your suggestions. Maybe to have a cleaner code? or am I losing anything? Some more comments below: El vie, 23-09-2005 a las 18:34 +0530, Raja R Harinath escribió: Hi, Carlos Alberto Cortez

[Mono-dev] [Patch] Extern assembly alias

2005-09-23 Thread Carlos Alberto Cortez
Hey, The attached patch implements extern assembly alias support for mcs. I've also added tests and errors for it, and all the tests are running fine. Could anybody of the mcs guys take a look at it? Thanks, Carlos. PD - The next link gives some info about it:

Re: [Mono-dev] [Patch] AssemblyName ctor (with corrections)

2005-09-16 Thread Carlos Alberto Cortez
Hey Paolo, Thanks for the comments. Carlos. El mié, 14-09-2005 a las 20:45 +0200, Paolo Molaro escribió: On 09/01/05 Carlos Alberto Cortez wrote: Index: AssemblyName.cs === --- AssemblyName.cs (revisión: 48811

Re: [Mono-dev] [Patch] Generic Array.Sort

2005-09-05 Thread Carlos Alberto Cortez
, On Thu, 2005-08-18 at 20:45 -0500, Carlos Alberto Cortez wrote: I've attached a patch containing the impl for the generic versions of Array.Sort. What's the status of this patch? I am thinking that the performance of this is probably good enough that we can get it in. IIRC, there were

Re: [Mono-dev] [Patch] AssemblyName ctor (yes, again)

2005-08-25 Thread Carlos Alberto Cortez
This break the ABI: is_version_defined is not needed since you can check the fields anyway. is_persistent can go away some other way (for example by always having public_key allocated, but it would be better to find another which doesn't make us waste memory). No, you can't check the

Re: [Mono-dev] [Patch] AssemblyName ctor

2005-08-23 Thread Carlos Alberto Cortez
Hey, I didn't take the choice of using the internal call (unamnaged code) since I thought it was not optimal (Paolo's told me that was not true). About the other point, I hadn't thought about it (using the same function to provide the same behavior for all the possible uses). So I will be using

Re: [Mono-dev] [Patch] AssemblyName ctor

2005-08-22 Thread Carlos Alberto Cortez
avoid calling the internal call. What do you think? Carlos. El sáb, 20-08-2005 a las 12:27 +0200, Paolo Molaro escribió: On 08/19/05 Carlos Alberto Cortez wrote: The patch attached implements the new AssemblyName ctor without using internal calls. Could anybody review it? And the advantage

Re: [Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-20 Thread Carlos Alberto Cortez
Hey Paolo, Thanks for the comments. I will be commiting today. Carlos. El sáb, 20-08-2005 a las 15:50 +0200, Paolo Molaro escribió: On 08/17/05 Carlos Alberto Cortez wrote: the attached patch works ok, and applies the last suggestions you did. Please commit, _after_ fixing the coding

Re: [Mono-dev] [Patch] AssemblyName ctor

2005-08-19 Thread Carlos Alberto Cortez
Hello again, comments below: + if (String.Compare (parts [i], 0, Version=, 0, 8, true, CultureInfo.InvariantCulture) == 0) This is most likely incorrect and needs to use an ordinal comparison, no InvariantCulture (used more than one time) I'm not sure that's correct. I tested in .Net

[Mono-dev] [Patch] AssemblyName ctor (fixed)

2005-08-19 Thread Carlos Alberto Cortez
Hey, The attached patch contains the latest suggestions of both Kornel and Ben. Maybe the only thing to be noted is that I kept the hexadecimal notation when comparing chars, since the same is used in Char.GetNumericalValue (). New tests are also attached, and run fine under .Net 2.0 Carlos.

[Mono-dev] [Patch] Generic Array.Sort

2005-08-18 Thread Carlos Alberto Cortez
Hey, I've attached a patch containing the impl for the generic versions of Array.Sort. Could anybody take a look at it? Carlos. Index: Array.cs === --- Array.cs (revisión: 48473) +++ Array.cs (copia de trabajo) @@ -912,6 +912,18

Re: [Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-17 Thread Carlos Alberto Cortez
Hey, the attached patch works ok, and applies the last suggestions you did. Carlos. El lun, 15-08-2005 a las 19:55 +0200, Paolo Molaro escribió: On 08/13/05 Carlos Alberto Cortez wrote: struct version doesn't conform to the mono naming conventions. Use a typedef and something like

Re: [Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-15 Thread Carlos Alberto Cortez
Hey Paolo, Thanks for answering, comments below: El vie, 12-08-2005 a las 15:49 +0200, Paolo Molaro escribió: On 08/11/05 Carlos Alberto Cortez wrote: Index: assembly.c === --- assembly.c (revisión: 47896

[Mono-dev] Re: [Mono-devel-list] [Patch] Publisher Policy support

2005-08-14 Thread Carlos Alberto Cortez
Hey, Great. Maybe we could move it to the svn tree. Carlos. El vie, 12-08-2005 a las 19:30 -0400, Ben Maurer escribió: Hey, I'm re-sending this patch, since the corrected version was only sent by mistake to Miguel, Paolo and Ben. Ben, I applied your change, do you think it's ok?

[Mono-dev] [Patch] AssemblyName ctor

2005-08-09 Thread Carlos Alberto Cortez
hey, Currently the AssemblyName (string) ctor is not implemented to receive the long format assembly name (such MyAssembly, Version=1.2,...). The attached patch adds support for it. Some tests are also attached. Carlos. Index: icall.c

[Mono-dev] [Patch] AssemblyName ctor (correction)

2005-08-09 Thread Carlos Alberto Cortez
In the last message some attachments were missing. All of them are now correctly attached. Index: AssemblyName.cs === --- AssemblyName.cs (revisión: 48211) +++ AssemblyName.cs (copia de trabajo) @@ -37,6 +37,7 @@ using System.Text;

[Mono-dev] Re: [Mono-devel-list] [PATCH] Check for assembly attributes

2005-08-08 Thread Carlos Alberto Cortez
Hey, I'm implementing it right now. So, as soon as it gets in the svn tree, we can re-use it in mcs. Carlos. El lun, 08-08-2005 a las 14:42 +0100, Marek Safar escribió: Hello, I just checked it, and saw that in the .Net docs, it states that AssemblyName (string name) receives the simple

Re: [Mono-devel-list] [PATCH] Check for assembly attributes

2005-08-05 Thread Carlos Alberto Cortez
Hey, The constructor receiving a string doesn't parse the long format name. Instead, it just assign Name property. So, I don't think we can use it. Carlos. El vie, 05-08-2005 a las 13:55 +0100, Marek Safar escribió: Hello, The other things were applied. I attached two test cases. Do you

Re: [Mono-devel-list] [PATCH] Check for assembly attributes

2005-08-05 Thread Carlos Alberto Cortez
Hey, I just checked it, and saw that in the .Net docs, it states that AssemblyName (string name) receives the simple name. However, in the beta 2, if you pass the long format name, it parses it. I think we should keep this change to mcs this way, and wait for this change in the api

Re: [Mono-devel-list] Differences between Mono and .NET

2005-08-05 Thread Carlos Alberto Cortez
Hello, I think. the best of Mono is its open source nature, and the fact thet everybody can adapt it or modify it, adding the stability and the support for more than one arch. On the other hand, what Mono is missing the most, is an IDE for Winforms and also documentation (docs for Mono libs and

Re: [Mono-devel-list] [PATCH] Check for assembly attributes

2005-08-04 Thread Carlos Alberto Cortez
Hello, Below my comments. El jue, 04-08-2005 a las 00:46 -0400, Ben Maurer escribió: On Wed, 2005-08-03 at 20:55 -0500, Carlos Alberto Cortez wrote: Hey, A patch is attached, containing a check for InternalsVisibleToAttribute, when it is applied to an assembly. It reports a warning

Re: [Mono-devel-list] [PATCH] Check for assembly attributes

2005-08-04 Thread Carlos Alberto Cortez
Right, that's true, since we need to support an insensitive case comparison. Just corrected that. Carlos. El jue, 04-08-2005 a las 18:23 -0400, Ben Maurer escribió: On Thu, 2005-08-04 at 17:15 -0500, Carlos Alberto Cortez wrote

[Mono-devel-list] Re: [Mono-patches] r47921 - trunk/mcs/gmcs

2005-08-03 Thread Carlos Alberto Cortez
=== --- trunk/mcs/gmcs/ChangeLog 2005-08-02 16:26:27 UTC (rev 47920) +++ trunk/mcs/gmcs/ChangeLog 2005-08-02 16:33:16 UTC (rev 47921) @@ -1,11 +1,3 @@ -2005-07-27 Carlos Alberto Cortez [EMAIL PROTECTED] - - Fix #75417 - * ecore.cs (Expression.IsAccessorAccessible): Change

[Mono-devel-list] [PATCH] Check for assembly attributes

2005-08-03 Thread Carlos Alberto Cortez
) +++ ChangeLog (copia de trabajo) @@ -1,3 +1,9 @@ +2005-08-03 Carlos Alberto Cortez [EMAIL PROTECTED] + + * codegen.cs + (AssemblyClass.CheckAttributeValid): New method to check + validity in assembly attributes. + 2005-08-03 Martin Baulig [EMAIL PROTECTED] Make iterators in generic

Re: [Mono-devel-list] Re: Mono-devel-list Digest, Vol 3, Issue 83

2005-07-29 Thread Carlos Alberto Cortez
I think you need the devel package for apache. Carlos. El vie, 29-07-2005 a las 09:12 +, Rajesh Kumar Aggani escribió: Hi Friends, I want to use Mono on Red Hat linux Server edition. I have installed Mono with binary file. Apache is already installed during RedHat installation. I

[Mono-devel-list] [PATCH] Assembly.GetReferencedAssemblies

2005-07-29 Thread Carlos Alberto Cortez
ran just fine (both for default and 2_0 profiles). May I commit it? Carlos. Index: ChangeLog === --- ChangeLog (revisión: 47832) +++ ChangeLog (copia de trabajo) @@ -1,3 +1,11 @@ +2005-07-29 Carlos Alberto Cortez [EMAIL PROTECTED

[Mono-devel-list] [Patch] Publisher Policy support

2005-07-21 Thread Carlos Alberto Cortez
Carlos Alberto Cortez [EMAIL PROTECTED] + + This patch implements a big portion of publisher policy + support, used to bind assembly versions and redirect + one assembly from version A to version B. + + * assembly.c: + (assembly_binding_maps_name): New static function for checking if a + assembly

[Mono-devel-list] [Patch] Include resource files in the GAC

2005-07-01 Thread Carlos Alberto Cortez
= Path.Combine (ref_dir, asmb_file); Index: ChangeLog === --- ChangeLog (revisión: 46867) +++ ChangeLog (copia de trabajo) @@ -1,3 +1,8 @@ +2005-07-01 Carlos Alberto Cortez [EMAIL PROTECTED] + + * driver.cs (Install): Copy the linked

[Mono-devel-list] [Patch] Images loaded with Reflection Only Assemblies

2005-06-09 Thread Carlos Alberto Cortez
Hey, Currently, when loading a reflection only assembly, and then a normal assembly is also loaded, they share their images, which of course is not correct. With the attached patch separated images are loaded. Carlos. Index: appdomain.c

[Mono-devel-list] [Patch] Define Version for AssemblyBuilder

2005-06-07 Thread Carlos Alberto Cortez
) @@ -1,4 +1,8 @@ +2005-06-07 Carlos Alberto Cortez [EMAIL PROTECTED] + * reflection.c (mono_image_basic_init): Define + Version in MonoDynamicAssembly. + 2005-06-06 Michael Meeks [EMAIL PROTECTED] * object.c (extend_interface_array): fix really silly Index: AssemblyNameTest.cs

Re: [Mono-devel-list] Re: [Mono-patches] r45553 - trunk/mcs/class/corlib/System.Reflection

2005-06-06 Thread Carlos Alberto Cortez
/System.Reflection/ChangeLog trunk/mcs/class/corlib/System.Reflection/CustomAttributeData.cs trunk/mcs/class/corlib/System.Reflection/CustomAttributeNamedArgument.cs trunk/mcs/class/corlib/System.Reflection/CustomAttributeTypedArgument.cs Log: 2005-06-07 Carlos Alberto Cortez [EMAIL

Re: [Mono-devel-list] [Patch] AssemblyName changes

2005-05-19 Thread Carlos Alberto Cortez
Hey, Does this fix http://bugzilla.ximian.com/show_bug.cgi?id=59891 -- Ben It is not exactly a patch for that error (I'm not getting that error, however), but to correct the problem of always having something like: AssemblyName aname = new AssemblyName (); aname.Name = Something; and

[Mono-devel-list] [Patch] AssemblyName changes

2005-05-18 Thread Carlos Alberto Cortez
Hey there, I made some changes to at icall.c and AssemblyName.cs to correct some incorrect behavior of AssemblyName class. With these changes, all the tests at AssemblyNameTest.cs run ok, and I even could make a bootstrap. Any comment? Carlos. Index: icall.c

Re: [Mono-devel-list] [Patch] AssemblyName changes

2005-05-18 Thread Carlos Alberto Cortez
Hey, I noticed this too, but in the MS impl, a new Version instance is created. We could however, use the same. Carlos. El mi, 18-05-2005 a las 18:25 -0400, Ben Maurer escribi: On Wed, 2005-05-18 at 17:25 -0500, Carlos Alberto Cortez wrote: Hey there, I made some changes to at icall.c

[Mono-devel-list] [Path] AssemblyName changes

2005-04-21 Thread Carlos Alberto Cortez
Hey, Attached is a patch with changes for AssemblyName, to behave like the .Net impl. I still don't know which was the intention of that code in Version property, anyway. Any comments? Carlos. Index: AssemblyName.cs === ---

[Mono-devel-list] [Patch] CustomAttributeData support

2005-04-19 Thread Carlos Alberto Cortez
=== --- CustomAttributeData.cs (revisin: 43304) +++ CustomAttributeData.cs (copia de trabajo) @@ -3,6 +3,7 @@ // // Author: // Zoltan Varga ([EMAIL PROTECTED]) +// Carlos Alberto Cortez ([EMAIL PROTECTED]) // // Copyright (C) 2004 Novell, Inc (http://www.novell.com) // @@ -32,57 +33,98 @@ using

Re: [Mono-devel-list] Problems with Array.AsReadOnly

2005-04-14 Thread Carlos Alberto Cortez
It's working now smoothly :-) Carlos. Hi Carlos, I think this is already fixed. I'm running your sample from svn of 2005-04-13 23:55, localtime GMT-3 and I get the expected result: 10 Please, update your svn and give it a try. Thanks for reporting. - -- Regards, Francisco

[Mono-devel-list] Problems with Array.AsReadOnly

2005-04-13 Thread Carlos Alberto Cortez
Hello, With mono from svn (updated a day ago) I'm getting a NullReferenceError when trying to use a IList returned by Array.AsReadOnlyT. I've tried to see what happend, and ReadOnlyArray (internal representation) is working well, so I can only think that something is working bad in the runtime.

  1   2   >