Re: [Monotone-devel] bugfest analysis - final points

2010-05-17 Thread Stephen Leake
Thomas Keller m...@thomaskeller.biz writes: Am 16.05.10 11:19, schrieb Stephen Leake: Thomas Keller m...@thomaskeller.biz writes: For the others: If you think your branch is ready for the final merge, give me a note if you want to get it reviewed another time, otherwise just merge it.

Re: [Monotone-devel] bugfest analysis - final points

2010-05-17 Thread Thomas Keller
Am 17.05.2010 14:08, schrieb Stephen Leake: Thomas Keller m...@thomaskeller.biz writes: Am 16.05.10 11:19, schrieb Stephen Leake: For net.venge.monotone.bugfest-2010.13604-stephen_leake, I've removed the --recursive option from 'undrop'. So I think this is ready to merge.

Re: [Monotone-devel] bugfest analysis - final points

2010-05-16 Thread Stephen Leake
Thomas Keller m...@thomaskeller.biz writes: For the others: If you think your branch is ready for the final merge, give me a note if you want to get it reviewed another time, otherwise just merge it. For net.venge.monotone.bugfest-2010.13604-stephen_leake, I've removed the --recursive option

Re: [Monotone-devel] bugfest analysis - final points

2010-05-16 Thread Thomas Keller
Am 16.05.10 11:19, schrieb Stephen Leake: Thomas Keller m...@thomaskeller.biz writes: For the others: If you think your branch is ready for the final merge, give me a note if you want to get it reviewed another time, otherwise just merge it. For

Re: [Monotone-devel] bugfest analysis - final points

2010-05-16 Thread Derek Scherger
On Sun, May 16, 2010 at 3:51 PM, Thomas Keller m...@thomaskeller.biz wrote: Am 16.05.10 11:19, schrieb Stephen Leake: Thomas Keller m...@thomaskeller.biz writes: For the others: If you think your branch is ready for the final merge, give me a note if you want to get it reviewed another

Re: [Monotone-devel] bugfest analysis - final points

2010-05-12 Thread Derek Scherger
On Mon, May 10, 2010 at 3:53 PM, Thomas Keller m...@thomaskeller.bizwrote: * #20447: mtn diff filename fails inside of a renamed directory - net.venge.monotone.bugfest-2010.20447-dscherger - @Derek: whats your plan here? Is this reviewable? Patch looks ok, if you add tests for the

Re: [Monotone-devel] bugfest analysis - final points

2010-05-12 Thread Thomas Keller
Am 12.05.10 18:26, schrieb Derek Scherger: On Mon, May 10, 2010 at 3:53 PM, Thomas Keller m...@thomaskeller.bizwrote: * #20447: mtn diff filename fails inside of a renamed directory - net.venge.monotone.bugfest-2010.20447-dscherger - @Derek: whats your plan here? Is this reviewable?

Re: [Monotone-devel] bugfest analysis

2010-05-11 Thread Stephen Leake
Derek Scherger de...@echologic.com writes: On Mon, May 10, 2010 at 3:47 PM, Stephen Leake stephen_le...@stephe-leake.org wrote: I think restrictions in general are poorly defined, which is one reason I never use them. If you say 'undrop file' you're using them! ;) Well, yes, that's how

Re: [Monotone-devel] bugfest analysis

2010-05-11 Thread Stephen Leake
Stephen Leake stephen_le...@stephe-leake.org writes: Derek Scherger de...@echologic.com writes: On Mon, May 10, 2010 at 3:47 PM, Stephen Leake stephen_le...@stephe-leake.org wrote: I think restrictions in general are poorly defined, which is one reason I never use them. If you say

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Thomas Keller
Am 10.05.2010 04:52, schrieb Derek Scherger: On Sun, May 9, 2010 at 5:28 PM, Thomas Keller m...@thomaskeller.biz wrote: * #20447: mtn diff filename fails inside of a renamed directory - net.venge.monotone.bugfest-2010.20447-dscherger - @Derek: whats your plan here? Is this reviewable?

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Thomas Keller
Am 10.05.2010 05:23, schrieb Timothy Brownawell: On 05/09/2010 06:28 PM, Thomas Keller wrote: * #17878: Usability: too easy to accidentally fork after merge or disapprove - branch is net.venge.monotone.bugfest-2010.17878-tbrownaw - @Tim: is this done? It needs a test using the

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Stephen Leake
Thomas Keller m...@thomaskeller.biz writes: Here is a little analysis of the recent bugfest efforts. Thanks for all your work in organizing this. Point proposals from me are noted for In test issues. If no one else objects, please close the issues I marked accordingly yourself: 1)

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Stephen Leake
Derek Scherger de...@echologic.com writes: On Sun, May 9, 2010 at 5:28 PM, Thomas Keller m...@thomaskeller.biz wrote: * #13604: need 'undelete' ('undrop'?) - net.venge.monotone.bugfest-2010.13604-stephen_leake - patch looks largely cool, some minor objections: revert = not undrop; - is

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Derek Scherger
On Mon, May 10, 2010 at 6:24 AM, Stephen Leake stephen_le...@stephe-leake.org wrote: It is a minor modification of revert; I factored out the common code. undrop just tells revert not to revert a file that is present in the workspace, because it had changes when it was dropped. Ahh I see.

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Derek Scherger
On Mon, May 10, 2010 at 6:21 AM, Stephen Leake stephen_le...@stephe-leake.org wrote: Thomas Keller m...@thomaskeller.biz writes: Here is a little analysis of the recent bugfest efforts. Thanks for all your work in organizing this. I'll second that, you've done a great job of keeping

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Thomas Keller
Am 10.05.10 17:03, schrieb Derek Scherger: One thing I noticed in trying to fix the diff bug was this: $ mtn mv dir dir2 $ edit dir2/file $ mth revert dir2/file # only reverts content, leaves directory rename in place $ edit dir2/file $ mtn revert dir2 --depth=0 # should revert the rename

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Thomas Keller
Am 10.05.10 05:23, schrieb Timothy Brownawell: On 05/09/2010 06:28 PM, Thomas Keller wrote: * #17878: Usability: too easy to accidentally fork after merge or disapprove - branch is net.venge.monotone.bugfest-2010.17878-tbrownaw - @Tim: is this done? It needs a test using the

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Thomas Keller
Am 10.05.10 17:08, schrieb Derek Scherger: On Mon, May 10, 2010 at 6:21 AM, Stephen Leake stephen_le...@stephe-leake.org wrote: Thomas Keller m...@thomaskeller.biz writes: Here is a little analysis of the recent bugfest efforts. Thanks for all your work in organizing this. I'll

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Stephen Leake
Derek Scherger de...@echologic.com writes: On Mon, May 10, 2010 at 6:24 AM, Stephen Leake stephen_le...@stephe-leake.org wrote: It is a minor modification of revert; I factored out the common code. undrop just tells revert not to revert a file that is present in the workspace, because it

Re: [Monotone-devel] bugfest analysis - final points

2010-05-10 Thread Thomas Keller
Hi again! So I got comments on most things - lets check the final scores: 1) Assigned, but not (yet) closed issues: * #7221: [NEED TEST] monotone cert should not require its target be on a branch - net.venge.monotone.bugfest-2010.7221-stephen_leake - @Stephe: Please look at my

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Timothy Brownawell
On 05/10/2010 03:44 PM, Thomas Keller wrote: Am 10.05.10 05:23, schrieb Timothy Brownawell: On 05/09/2010 06:28 PM, Thomas Keller wrote: * #17878: Usability: too easy to accidentally fork after merge or disapprove - branch is net.venge.monotone.bugfest-2010.17878-tbrownaw -

Re: [Monotone-devel] bugfest analysis

2010-05-10 Thread Derek Scherger
On Mon, May 10, 2010 at 3:47 PM, Stephen Leake stephen_le...@stephe-leake.org wrote: I don't know; --no-content to me sounds like don't revert content, just renmaes and other stuff. That's not the same as 'undrop', which does revert content if the file actually got deleted from the workspace.

Re: [Monotone-devel] bugfest analysis - final points

2010-05-10 Thread Derek Scherger
On Mon, May 10, 2010 at 3:53 PM, Thomas Keller m...@thomaskeller.biz wrote: * #20447: mtn diff filename fails inside of a renamed directory - net.venge.monotone.bugfest-2010.20447-dscherger - @Derek: whats your plan here? Is this reviewable? Patch looks ok, if you add tests for the

[Monotone-devel] bugfest analysis

2010-05-09 Thread Thomas Keller
Hi all! Here is a little analysis of the recent bugfest efforts. Point proposals from me are noted for In test issues. If no one else objects, please close the issues I marked accordingly yourself: 1) Assigned, but not (yet) closed issues: * #7221: [NEED TEST] monotone cert should not require

Re: [Monotone-devel] bugfest analysis

2010-05-09 Thread Derek Scherger
On Sun, May 9, 2010 at 5:28 PM, Thomas Keller m...@thomaskeller.biz wrote: * #20447: mtn diff filename fails inside of a renamed directory - net.venge.monotone.bugfest-2010.20447-dscherger - @Derek: whats your plan here? Is this reviewable? I spent most of the day working on this and made

Re: [Monotone-devel] bugfest analysis

2010-05-09 Thread Timothy Brownawell
On 05/09/2010 06:28 PM, Thomas Keller wrote: * #17878: Usability: too easy to accidentally fork after merge or disapprove - branch is net.venge.monotone.bugfest-2010.17878-tbrownaw - @Tim: is this done? It needs a test using the --update option, which I'll get to either in the