Re: [Mzmine-devel] Question about merging

2015-03-23 Thread Tomas Pluskal
Hi Vasily, Thanks for sending the patch! A few comments to it: 1) Your new module extends the functionality of the "Exact mass detector", but the code is mostly copy&pasted from it. We don't want to have duplicated code, so it would be better if your module calls the Exact mass detector and the

Re: [Mzmine-devel] Question about merging

2015-03-23 Thread Vasily Avilov
Hi Tomas, I attached patch for current revision. If there will me any modifications needed I will ready to make them. Regards, Vasily пн, 23 марта 2015 г. в 16:25, Tomas Pluskal : > Hi Vasily, > > Of course, we will be happy to include your new module! Please send a > patch file so we can revie

Re: [Mzmine-devel] Question about merging

2015-03-22 Thread Tomas Pluskal
Hi Vasily, Of course, we will be happy to include your new module! Please send a patch file so we can review it. Cheers, Tomas > On Mar 23, 2015, at 09:31, Vasily Avilov wrote: > > Hello > > I done some modifications in sources - added one filter. May you consider of > the source merging?

[Mzmine-devel] Question about merging

2015-03-22 Thread Vasily Avilov
Hello I done some modifications in sources - added one filter. May you consider of the source merging? Regrads, Vasily -- Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and develop