Re: [Mzmine-devel] Question about merging

2015-03-23 Thread Vasily Avilov
Hi Tomas, I attached patch for current revision. If there will me any modifications needed I will ready to make them. Regards, Vasily пн, 23 марта 2015 г. в 16:25, Tomas Pluskal : > Hi Vasily, > > Of course, we will be happy to include your new module! Please send a > patch file so we can revie

[Mzmine-devel] Move sources to GitHub?

2015-03-23 Thread Tomas Pluskal
Hi Thomas and all, I am thinking to move the MZmine source repository from SVN to GitHub. It offers much better features for parallel development and also for reviewing code contributions. Does anybody have any objection to that? Best, Tomas === T

Re: [Mzmine-devel] Question about merging

2015-03-23 Thread Tomas Pluskal
Hi Vasily, Thanks for sending the patch! A few comments to it: 1) Your new module extends the functionality of the "Exact mass detector", but the code is mostly copy&pasted from it. We don't want to have duplicated code, so it would be better if your module calls the Exact mass detector and the