[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1666763 into nagios-charm:master

2017-06-21 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:lp1666763 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/326126 Fixes LP1666763 -- Your team Nagios

[Nagios-charmers] [Bug 1669920] Re: nagios/thruk-slave incorrect permissions on livestatus directory

2017-06-22 Thread Xav Paice
** Changed in: nagios-charm Status: New => Confirmed -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1669920 Title: nagios/thruk-slave incorrect permissions on livestatus dire

Re: [Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1666763 into nagios-charm:master

2017-06-22 Thread Xav Paice
Review: Disapprove Incorrectly includes a separate change - will cancel this review. -- https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/326126 Your team Nagios Charm developers is requested to review the proposed merge of ~xavpaice/nagios-charm:lp1666763 into nagios-ch

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:fix-lp1666763 into nagios-charm:master

2017-06-22 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:fix-lp1666763 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/326195 bug fix for https

[Nagios-charmers] [Bug 1623658] Re: livestatus socket permission

2017-06-29 Thread Xav Paice
** Package changed: nagios (Juju Charms Collection) => check-mk (Ubuntu) ** Also affects: nagios-charm Importance: Undecided Status: New -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpa

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:fix-lp1623658 into nagios-charm:master

2017-08-07 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:fix-lp1623658 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/328677 -- Your team Nagios Charm

[Nagios-charmers] [Bug 1623658] Re: livestatus socket permission

2017-08-07 Thread Xav Paice
In https://git.launchpad.net/nagios-charm/tree/hooks/install the Nagios charm creates the mklivestatus directory and sets perms. We will need to change this to add +x. -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm.

[Nagios-charmers] [Bug 1623658] Re: livestatus socket permission

2017-08-07 Thread Xav Paice
https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios- charm/+merge/328677 -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1623658 Title: livestatus socket permission Status

[Nagios-charmers] [Bug 1623658] Re: livestatus socket permission

2017-08-07 Thread Xav Paice
** Changed in: nagios-charm Status: New => In Progress -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1623658 Title: livestatus socket permission Status in Nagios Charm: I

[Nagios-charmers] [Bug 1677580] Re: nagios unit local checks should be editable

2017-08-17 Thread Xav Paice
charm) to monitor the local nagios box. Ideally, it would be a different nagios server monitoring the nagios server anyway. ** Tags added: canonical-bootstack ** Changed in: nagios-charm Status: New => In Progress ** Changed in: nagios-charm Assignee: (unassigned) => Xav

[Nagios-charmers] [Bug 1677580] Re: nagios unit local checks should be editable

2017-08-17 Thread Xav Paice
https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios- charm/+merge/329234 -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1677580 Title: nagios unit local checks should be e

[Nagios-charmers] [Bug 1677580] Re: nagios unit local checks should be editable

2017-08-17 Thread Xav Paice
cancel that last one, I must have been on another planet. https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios- charm/+merge/329236 -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/

Re: [Nagios-charmers] [Merge] ~jhebden/nagios-charm:readonly-account into nagios-charm:master

2017-08-17 Thread Xav Paice
Review: Approve In this case, we're already managing a chunk of the config files and I don't see an alternative for that particular config (no conf.d option for cgi.cfg). While we could use a sed equivalent to alter the config on that one file, we don't take that approach with nagios.cfg and I'

[Nagios-charmers] [Merge] ~jhebden/nagios-charm:readonly-account into nagios-charm:master

2017-08-17 Thread Xav Paice
The proposal to merge ~jhebden/nagios-charm:readonly-account into nagios-charm:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~jhebden/nagios-charm/+git/nagios-charm/+merge/318564 -- Your team Nagios Charm developers is subscribed t

[Nagios-charmers] [Bug 1677580] Re: nagios unit local checks should be editable

2017-08-17 Thread Xav Paice
** Changed in: nagios-charm Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1677580 Title: nagios unit local checks should be editable St

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1623658 into nagios-charm:master

2017-08-21 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:lp1623658 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/329344 fix for https://bugs.launchpad.net

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1623658 into nagios-charm:master

2017-08-21 Thread Xav Paice
The proposal to merge ~xavpaice/nagios-charm:lp1623658 into nagios-charm:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/329344 -- Your team Nagios Charm developers is subscribed to bra

[Nagios-charmers] [Bug 1623658] Re: livestatus socket permission

2017-08-21 Thread Xav Paice
https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios- charm/+merge/329344 ** Merge proposal linked: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/329344 ** Changed in: nagios-charm Status: In Progress => Fix Committed -- You received this bug not

[Nagios-charmers] [Bug 1712977] Re: config-changed hook fails: nrpe_helpers.py:nagios_hostname in _metadata_unit with FileNotFoundError error for metadata.yaml of related unit on another host

2017-08-27 Thread Xav Paice
** Tags added: canonical-bootstack ** Also affects: nagios-charm Importance: Undecided Status: New -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1712977 Title: config-ch

[Nagios-charmers] [Bug 1712977] Re: config-changed hook fails: nrpe_helpers.py:nagios_hostname in _metadata_unit with FileNotFoundError error for metadata.yaml of related unit on another host

2017-08-27 Thread Xav Paice
This also affects the Nagios charm, e.g.: (added pdb.set_trace() to L210 of core/hookenv.py) root@juju-machine-0-lxc-6:/var/lib/juju/agents/unit-nagios-0/charm# ./hooks/upgrade-charm > /var/lib/juju/agents/unit-nagios-0/charm/hooks/charmhelpers/core/hookenv.py(218)principal_unit() -> for reltyp

[Nagios-charmers] [Bug 1712977] Re: config-changed hook fails: nrpe_helpers.py:nagios_hostname in _metadata_unit with FileNotFoundError error for metadata.yaml of related unit on another host

2017-08-27 Thread Xav Paice
FWIW, this problem makes it impossible to upgrade charms to the current head/master. -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1712977 Title: config-changed hook fails: nrpe_he

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1712977 into nagios-charm:master

2017-08-28 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:lp1712977 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/329768 -- Your team Nagios Charm developers

[Nagios-charmers] [Bug 1712977] Re: config-changed hook fails: nrpe_helpers.py:nagios_hostname in _metadata_unit with FileNotFoundError error for metadata.yaml of related unit on another host

2017-08-28 Thread Xav Paice
rev 786 of charmhelpers fixes the bug, need to update both nrpe and nagios charms to collect that update. https://code.launchpad.net/~xavpaice/nrpe-charm/+git/nrpe-charm/+merge/329767 https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/329768 -- You received this bug notif

[Nagios-charmers] [Bug 1712977] Re: config-changed hook fails: nrpe_helpers.py:nagios_hostname in _metadata_unit with FileNotFoundError error for metadata.yaml of related unit on another host

2017-08-28 Thread Xav Paice
Fixes available in cs:~nagios-charmers/nagios-5 and cs:~nrpe- charmers/nrpe-20, I don't have perms to release these to the main charm store urls. ** Changed in: nrpe-charm Status: Confirmed => Fix Committed ** Changed in: nagios-charm Status: New => Fix Committed -- You received t

[Nagios-charmers] [Bug 1569044] Re: Perl script permissions wrong for nagios integration

2017-09-05 Thread Xav Paice
** Package changed: nagios (Juju Charms Collection) => nagios-charm -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1569044 Title: Perl script permissions wrong for nagios integratio

[Nagios-charmers] [Bug 1677580] Re: nagios unit local checks should be editable

2017-09-05 Thread Xav Paice
** Changed in: nagios-charm Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1677580 Title: nagios unit local checks should be editable S

[Nagios-charmers] [Bug 1569044] Re: Perl script permissions wrong for nagios integration

2017-09-05 Thread Xav Paice
** Changed in: nagios-charm Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1569044 Title: Perl script permissions wrong for nagios integrati

[Nagios-charmers] [Bug 1715086] Re: upgrade-charm and config-changed fail on Juju < 2.2.2

2017-09-05 Thread Xav Paice
** Changed in: nagios-charm Status: New => Fix Committed -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1715086 Title: upgrade-charm and config-changed fail on Juju < 2.2.2

[Nagios-charmers] [Bug 1623658] Re: livestatus socket permission

2017-09-05 Thread Xav Paice
** Changed in: nagios-charm Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1623658 Title: livestatus socket permission Status in Nagios

[Nagios-charmers] [Bug 1715086] Re: upgrade-charm and config-changed fail on Juju < 2.2.2

2017-09-05 Thread Xav Paice
Fix included in cs:nagios-18 ** Changed in: nagios-charm Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1715086 Title: upgrade-charm an

[Nagios-charmers] [Bug 1718833] [NEW] pagerduty integration needs HTTP::Request::Common module

2017-09-21 Thread Xav Paice
Public bug reported: On a newly deployed unit on Xenial, I try to run /usr/local/bin/pagerduty_nagios.pl and get: Can't locate HTTP/Request/Common.pm in @INC (you may need to install the HTTP::Request::Common module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.22.1 /usr/loc

[Nagios-charmers] [Bug 1718835] [NEW] pagerduty alerts are lost if pagerduty script is broken

2017-09-21 Thread Xav Paice
Public bug reported: Using the current charm, on Xenial, when I setup a fresh unit and enable pagerduty, if I do something which causes an alert but the pagerduty script doesn't work (e.g. because of bug 1718833) then the alert is lost into the dark void of nowhere. Maybe we're not doing somethin

Re: [Nagios-charmers] [Merge] ~mthaddon/nagios-charm/+git/trunk:master into nagios-charm:master

2017-09-26 Thread Xav Paice
Review: Approve Tested, LGTM -- https://code.launchpad.net/~mthaddon/nagios-charm/+git/trunk/+merge/331366 Your team Nagios Charm developers is subscribed to branch nagios-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to : nagios-charmers@lists.launchpad.net Uns

[Nagios-charmers] [Bug 1718833] Re: pagerduty integration needs HTTP::Request::Common module

2017-09-26 Thread Xav Paice
Thanks Tom, that patch works a treat. Have merged and pushed. ** Changed in: nagios-charm Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/171

[Nagios-charmers] [Bug 1718833] Re: pagerduty integration needs HTTP::Request::Common module

2017-09-26 Thread Xav Paice
** Changed in: nagios-charm Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1718833 Title: pagerduty integration needs HTTP::Request::Com

[Nagios-charmers] [Bug 1722325] [NEW] Wishlist: host dependency and/or parents in host definitions

2017-10-09 Thread Xav Paice
; field in a host definition which would do this, but we don't have that info when defining the host in a container - hostdependency definitions could work? ** Affects: nagios-charm Importance: Undecided Assignee: Xav Paice (xavpaice) Status: New ** Affects: nrpe-charm

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:parents into nagios-charm:master

2017-10-11 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:parents into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/332127 Depends on https://code.launchpad.net

[Nagios-charmers] [Bug 1722325] Re: Wishlist: host dependency and/or parents in host definitions

2017-10-12 Thread Xav Paice
I've added a preliminary 'parents' option: NRPE MP: https://code.launchpad.net/~xavpaice/nrpe-charm/+git/nrpe-charm/+merge/332126 Nagios MP: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/332127 What this does is, for a host that is a container on a machine, and there

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:master into nagios-charm:master

2017-10-17 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:master into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/332351 -- Your team Nagios Charm developers is

Re: [Nagios-charmers] [Merge] ~xavpaice/nagios-charm:master into nagios-charm:master

2017-10-17 Thread Xav Paice
Review: Approve Trivial -- https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/332351 Your team Nagios Charm developers is subscribed to branch nagios-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to : nagios-charmers@lists.launchpad.net U

[Nagios-charmers] [Bug 1723906] Re: "monitors-relation-changed" failed: exit status 1

2017-10-19 Thread Xav Paice
This is fixed in cs:nagios-22, https://git.launchpad.net/nagios- charm/commit/?id=ea544187130d4be627a1e3c956afb5c59ff8ef60 ** Changed in: nagios-charm Status: New => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed

[Nagios-charmers] [Bug 1725376] [NEW] monitors-relation-changed repeats many times and takes a very long time

2017-10-20 Thread Xav Paice
Public bug reported: On a setup where we have many nrpe units related to nagios, the monitors-relation-changed hook runs a loop through every unit in every relation and uses pynag to save intermediate files to disk each time. This takes about 2.5 mins in some environments, and the hook repeats for

[Nagios-charmers] [Bug 1722325] Re: Wishlist: host dependency and/or parents in host definitions

2018-04-03 Thread Xav Paice
** Changed in: nrpe-charm Status: Confirmed => Fix Released ** Changed in: nagios-charm Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/

[Nagios-charmers] [Bug 1763576] [NEW] Pagerduty script does not honor the proxy environment vars

2018-04-12 Thread Xav Paice
Public bug reported: If the model is configured with https-proxy set, we should use the --proxy switch in the cron job. There's currently no setting for this in the template. ** Affects: nagios-charm Importance: Undecided Status: New ** Tags: canonical-bootstack -- You received

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1763576 into nagios-charm:master

2018-04-14 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:lp1763576 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/343254 -- Your team Nagios Charm developers

[Nagios-charmers] [Bug 1763576] Re: Pagerduty script does not honor the proxy environment vars

2018-04-14 Thread Xav Paice
https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios- charm/+merge/343254 ** Changed in: nagios-charm Assignee: (unassigned) => Xav Paice (xavpaice) ** Changed in: nagios-charm Importance: Undecided => Low ** Changed in: nagios-charm Status: New => In Progress

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1763576 into nagios-charm:master

2018-04-17 Thread Xav Paice
The proposal to merge ~xavpaice/nagios-charm:lp1763576 into nagios-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/343254 -- Your team Nagios Charm developers is requested to

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1763576 into nagios-charm:master

2018-04-17 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:lp1763576 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/343472 -- Your team Nagios Charm developers

[Nagios-charmers] [Bug 1763576] Re: Pagerduty script does not honor the proxy environment vars

2018-04-17 Thread Xav Paice
Released fix in cs:nagios-24 ** Changed in: nagios-charm Status: In Progress => Fix Committed ** Changed in: nagios-charm Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:add-bindings into nagios-charm:master

2018-06-14 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:add-bindings into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/348028 -- Your team Nagios Charm

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:pagerduty into nagios-charm:master

2018-08-01 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:pagerduty into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/352052 -- Your team Nagios Charm developers

Re: [Nagios-charmers] [Merge] ~aieri/thruk-agent-charm:1796318-add-bionic-support into thruk-agent-charm:master

2018-11-21 Thread Xav Paice
I'm adding bionic packages for 2.24 to the PPA now - should avoid needing this. -- https://code.launchpad.net/~aieri/thruk-agent-charm/+git/thruk-agent-charm/+merge/358387 Your team Nagios Charm developers is subscribed to branch thruk-agent-charm:master. -- Mailing list: https://launchpad.net/

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_unittests into hw-health-charm:master

2019-02-19 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_unittests into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363403 -- Your team Nagios

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master

2019-02-20 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363450 -- Your team

Re: [Nagios-charmers] [Merge] ~aieri/hw-health-charm:lp/1814863 into hw-health-charm:master

2019-02-20 Thread Xav Paice
Review: Approve lgtm -- https://code.launchpad.net/~aieri/hw-health-charm/+git/hw-health-charm/+merge/363062 Your team Nagios Charm developers is subscribed to branch hw-health-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to : nagios-charmers@lists.launchpad.n

[Nagios-charmers] [Merge] ~aieri/hw-health-charm:lp/1814863 into hw-health-charm:master

2019-02-20 Thread Xav Paice
The proposal to merge ~aieri/hw-health-charm:lp/1814863 into hw-health-charm:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~aieri/hw-health-charm/+git/hw-health-charm/+merge/363062 -- Your team Nagios Charm developers is subscrib

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-24 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363593 -- Your team Nagios Charm

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-25 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363593 -- Your team Nagios Charm developers is su

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-25 Thread Xav Paice
Review: Resubmit Thanks for the detailed review - I've address (most) of the comments. I've not added all the docstrings requested as it's hard to know where to draw the line between changes relevant to this branch and changes that just make the overall code better - I suggest raising bugs for

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-25 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master. Requested reviews: Xav Paice (xavpaice) Peter Sabaini (peter-sabaini) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363638 -- Your team

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-26 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363638 -- Your team Nagios Charm developers is su

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-26 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master. Requested reviews: Xav Paice (xavpaice) Peter Sabaini (peter-sabaini) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363681 -- Your team

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-26 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363681 -- Your team Nagios Charm developers is su

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-26 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master. Requested reviews: Xav Paice (xavpaice) Peter Sabaini (peter-sabaini) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363682 -- Your team

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-26 Thread Xav Paice
I've addressed the comments, and squashed the commits to one. -- https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363682 Your team Nagios Charm developers is subscribed to branch hw-health-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-26 Thread Xav Paice
Currently have left the tox.ini with complexity at 20, need to add a second commit (unrelated) to get the complexity down to 10, so it passes. We need to raise a bug report to track that. -- https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363682 Your team Nagios

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_tests into hw-health-charm:master

2019-02-27 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_tests into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363758 -- Your team Nagios

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master

2019-02-27 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363760 -- Your team Nagios

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master

2019-02-27 Thread Xav Paice
Please review https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363758 first, which will make this change smaller -- https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363760 Your team Nagios Charm developers is requested to review th

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_tests into hw-health-charm:master

2019-02-28 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_tests into hw-health-charm:master. Requested reviews: Peter Sabaini (peter-sabaini) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363813 -- Your team Nagios Charm developers

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_tests into hw-health-charm:master

2019-02-28 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:fix_tests into hw-health-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363758 -- Your team Nagios Charm developers is s

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_tests into hw-health-charm:master

2019-02-28 Thread Xav Paice
Thanks Peter, I've updated as suggested. -- https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363813 Your team Nagios Charm developers is subscribed to branch hw-health-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to : nagios-char

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master

2019-03-01 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363760 -- Your team Nagios Charm developers i

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master

2019-03-01 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363833 -- Your team Nagios

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_smart into hw-health-charm:master

2019-03-01 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:add_smart into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363834 -- Your team Nagios

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:lp1819733 into hw-health-charm:master

2019-03-12 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:lp1819733 into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/364345 -- Your team Nagios

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_upgrade_hook into hw-health-charm:master

2019-03-12 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_upgrade_hook into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/364355 -- Your team

[Nagios-charmers] [Bug 1827159] [NEW] check_all_disks includes squashfs /snap/* which are 100%

2019-04-30 Thread Xav Paice
Public bug reported: When using nagios to monitor the Nagios host itself, if the host is not a container, the template for checking the disk space on the Nagios host does not exclude any snap filesystems. This means we get a Critical report if any snap is installed. This can be changed by adding

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master

2019-04-30 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366740 -- Your team Nagios Charm developers

[Nagios-charmers] [Bug 1827159] Re: check_all_disks includes squashfs /snap/* which are 100%

2019-04-30 Thread Xav Paice
** Merge proposal linked: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366740 -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1827159 Title: check_a

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master

2019-04-30 Thread Xav Paice
The proposal to merge ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366740 -- Your team Nagios Charm developers is subscribed to

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master

2019-04-30 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master. Commit message: Add custom disk monitor for nagios host Requested reviews: James Hebden (ec0) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366741

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master

2019-05-02 Thread Xav Paice
The proposal to merge ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366741 -- Your team Nagios Charm developers is subscribed to b

[Nagios-charmers] [Bug 1827703] [NEW] using Openstack based model, nrpe relation gets the floating IP but connects via fixed IP

2019-05-04 Thread Xav Paice
Public bug reported: I have two models on Openstack, both are in the same project, and same controller. Using a cross model relation, I have related nrpe on model1 to Nagios on model2. The Nagios host has a floating IP address, the machines in model1 (nrpe) do not. When I added the relation, tw

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master

2019-05-22 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363450 -- Your team Nagios Charm develo

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master

2019-05-22 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:cron_mdadm_unittests into hw-health-charm:master has been updated. Commit message changed to: Minor fix for unit tests For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363450 -- Your team Nag

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_smart into hw-health-charm:master

2019-05-22 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:add_smart into hw-health-charm:master has been updated. Commit message changed to: Add smartctl nrpe checks Adds a Nagios plugin and nrpe check using it for smartctl checks against a list of disks that support it. One check for all disks, report

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_clear_sel into hw-health-charm:master

2019-05-23 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_clear_sel into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/367880 -- Your team Nagios

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_cron into hw-health-charm:master

2019-05-23 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_cron into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/367882 -- Your team Nagios Charm

[Nagios-charmers] [Merge] ~xavpaice/thruk-agent-charm:update_charmhelpers into thruk-agent-charm:master

2019-06-16 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/thruk-agent-charm:update_charmhelpers into thruk-agent-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/thruk-agent-charm/+git/thruk-agent-charm/+merge/368892

[Nagios-charmers] [Merge] ~xavpaice/thruk-agent-charm:update_charmhelpers into thruk-agent-charm:master

2019-06-16 Thread Xav Paice
The proposal to merge ~xavpaice/thruk-agent-charm:update_charmhelpers into thruk-agent-charm:master has been updated. Commit message changed to: Update to allow the use of the newer juju proxy settings for apt installations. For more details, see: https://code.launchpad.net/~xavpaice/thruk-agen

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:lp1833897 into hw-health-charm:master

2019-06-23 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:lp1833897 into hw-health-charm:master. Commit message: Fix for lp1833897 handle separate filesystem for /var Requested reviews: Canonical IS Reviewers (canonical-is-reviewers) Nagios Charm developers (nagios-charmers) Related bugs

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_clear_sel_unittest into hw-health-charm:master

2019-06-23 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_clear_sel_unittest into hw-health-charm:master. Commit message: fix unit tests for clear-sel action Requested reviews: Canonical IS Reviewers (canonical-is-reviewers) Nagios Charm developers (nagios-charmers) For more details

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_clear_sel_unittest into hw-health-charm:master

2019-06-24 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:fix_clear_sel_unittest into hw-health-charm:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/369224 -- Your team Nagios Charm deve

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:lp1833897 into hw-health-charm:master

2019-06-24 Thread Xav Paice
Many thanks for that, I've updated the change accordingly. This does seem like a better approach. -- https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/369219 Your team Nagios Charm developers is subscribed to branch hw-health-charm:master. -- Mailing list: https

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:add-service_check_timeout_state into nagios-charm:master

2019-06-30 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:add-service_check_timeout_state into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/369495 -- Your team

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:pagerduty-defaults into nagios-charm:master

2019-06-30 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:pagerduty-defaults into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/369496 -- Your team Nagios Charm

[Nagios-charmers] [Bug 1834976] [NEW] config-changed doesn't restart nagios3 when config file is modified

2019-07-01 Thread Xav Paice
Public bug reported: If a hook modifies /etc/nagios3/nagios.cfg, we need the service to restart to collect that change, but the hook doesn't initiate that service restart. ** Affects: nagios-charm Importance: Undecided Status: New ** Tags: canonical-bootstack -- You received thi

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:add_service_timeout into nagios-charm:master

2019-07-02 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:add_service_timeout into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/369630 -- Your team Nagios Charm

[Nagios-charmers] [Bug 1843863] [NEW] Postfix installed listens on all interfaces by default

2019-09-12 Thread Xav Paice
Public bug reported: When installing a fresh Nagios unit, Postfix is pulled in as a dependency. A security audit has pulled up that although the config doesn't allow open relay, there is an SSL vulnerability of note that needs fixing (https://discussions.qualys.com/docs/DOC-1097). Although that'

  1   2   >