[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:fix-lp1623658 into nagios-charm:master

2017-08-07 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:fix-lp1623658 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/328677 -- Your team Nagios Charm

[Nagios-charmers] [Bug 1623658] Re: livestatus socket permission

2017-08-07 Thread Xav Paice
https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios- charm/+merge/328677 -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1623658 Title: livestatus socket permission

[Nagios-charmers] [Bug 1677580] Re: nagios unit local checks should be editable

2017-08-17 Thread Xav Paice
charm) to monitor the local nagios box. Ideally, it would be a different nagios server monitoring the nagios server anyway. ** Tags added: canonical-bootstack ** Changed in: nagios-charm Status: New => In Progress ** Changed in: nagios-charm Assignee: (unassigned) => Xav

[Nagios-charmers] [Merge] ~jhebden/nagios-charm:readonly-account into nagios-charm:master

2017-08-17 Thread Xav Paice
The proposal to merge ~jhebden/nagios-charm:readonly-account into nagios-charm:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~jhebden/nagios-charm/+git/nagios-charm/+merge/318564 -- Your team Nagios Charm developers is subscribed

[Nagios-charmers] [Bug 1677580] Re: nagios unit local checks should be editable

2017-08-17 Thread Xav Paice
cancel that last one, I must have been on another planet. https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios- charm/+merge/329236 -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm.

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:fix-lp1666763 into nagios-charm:master

2017-06-22 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:fix-lp1666763 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/326195 bug fix for https

[Nagios-charmers] [Bug 1718835] [NEW] pagerduty alerts are lost if pagerduty script is broken

2017-09-21 Thread Xav Paice
Public bug reported: Using the current charm, on Xenial, when I setup a fresh unit and enable pagerduty, if I do something which causes an alert but the pagerduty script doesn't work (e.g. because of bug 1718833) then the alert is lost into the dark void of nowhere. Maybe we're not doing

[Nagios-charmers] [Bug 1722325] [NEW] Wishlist: host dependency and/or parents in host definitions

2017-10-09 Thread Xav Paice
in a host definition which would do this, but we don't have that info when defining the host in a container - hostdependency definitions could work? ** Affects: nagios-charm Importance: Undecided Assignee: Xav Paice (xavpaice) Status: New ** Affects: nrpe-charm Importance

Re: [Nagios-charmers] [Merge] ~xavpaice/nagios-charm:master into nagios-charm:master

2017-10-17 Thread Xav Paice
Review: Approve Trivial -- https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/332351 Your team Nagios Charm developers is subscribed to branch nagios-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to : nagios-charmers@lists.launchpad.net

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:master into nagios-charm:master

2017-10-17 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:master into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/332351 -- Your team Nagios Charm developers

[Nagios-charmers] [Bug 1722325] Re: Wishlist: host dependency and/or parents in host definitions

2017-10-12 Thread Xav Paice
I've added a preliminary 'parents' option: NRPE MP: https://code.launchpad.net/~xavpaice/nrpe-charm/+git/nrpe-charm/+merge/332126 Nagios MP: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/332127 What this does is, for a host that is a container on a machine, and

[Nagios-charmers] [Bug 1623658] Re: livestatus socket permission

2017-09-05 Thread Xav Paice
** Changed in: nagios-charm Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1623658 Title: livestatus socket permission Status in

[Nagios-charmers] [Bug 1677580] Re: nagios unit local checks should be editable

2017-09-05 Thread Xav Paice
** Changed in: nagios-charm Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1677580 Title: nagios unit local checks should be editable

[Nagios-charmers] [Bug 1569044] Re: Perl script permissions wrong for nagios integration

2017-09-05 Thread Xav Paice
** Changed in: nagios-charm Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1569044 Title: Perl script permissions wrong for nagios

[Nagios-charmers] [Bug 1569044] Re: Perl script permissions wrong for nagios integration

2017-09-05 Thread Xav Paice
** Package changed: nagios (Juju Charms Collection) => nagios-charm -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1569044 Title: Perl script permissions wrong for nagios

[Nagios-charmers] [Bug 1718833] Re: pagerduty integration needs HTTP::Request::Common module

2017-09-26 Thread Xav Paice
** Changed in: nagios-charm Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1718833 Title: pagerduty integration needs

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1623658 into nagios-charm:master

2017-08-21 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:lp1623658 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/329344 fix for https://bugs.launchpad.net

[Nagios-charmers] [Bug 1712977] Re: config-changed hook fails: nrpe_helpers.py:nagios_hostname in _metadata_unit with FileNotFoundError error for metadata.yaml of related unit on another host

2017-08-27 Thread Xav Paice
This also affects the Nagios charm, e.g.: (added pdb.set_trace() to L210 of core/hookenv.py) root@juju-machine-0-lxc-6:/var/lib/juju/agents/unit-nagios-0/charm# ./hooks/upgrade-charm > /var/lib/juju/agents/unit-nagios-0/charm/hooks/charmhelpers/core/hookenv.py(218)principal_unit() -> for

[Nagios-charmers] [Bug 1712977] Re: config-changed hook fails: nrpe_helpers.py:nagios_hostname in _metadata_unit with FileNotFoundError error for metadata.yaml of related unit on another host

2017-08-27 Thread Xav Paice
** Tags added: canonical-bootstack ** Also affects: nagios-charm Importance: Undecided Status: New -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1712977 Title:

[Nagios-charmers] [Bug 1712977] Re: config-changed hook fails: nrpe_helpers.py:nagios_hostname in _metadata_unit with FileNotFoundError error for metadata.yaml of related unit on another host

2017-08-27 Thread Xav Paice
FWIW, this problem makes it impossible to upgrade charms to the current head/master. -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1712977 Title: config-changed hook fails:

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1712977 into nagios-charm:master

2017-08-28 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:lp1712977 into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/329768 -- Your team Nagios Charm developers

[Nagios-charmers] [Bug 1712977] Re: config-changed hook fails: nrpe_helpers.py:nagios_hostname in _metadata_unit with FileNotFoundError error for metadata.yaml of related unit on another host

2017-08-28 Thread Xav Paice
rev 786 of charmhelpers fixes the bug, need to update both nrpe and nagios charms to collect that update. https://code.launchpad.net/~xavpaice/nrpe-charm/+git/nrpe-charm/+merge/329767 https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/329768 -- You received this bug

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:add-bindings into nagios-charm:master

2018-06-14 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:add-bindings into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/348028 -- Your team Nagios Charm

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:pagerduty into nagios-charm:master

2018-08-01 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:pagerduty into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/352052 -- Your team Nagios Charm developers

[Nagios-charmers] [Bug 1763576] [NEW] Pagerduty script does not honor the proxy environment vars

2018-04-12 Thread Xav Paice
Public bug reported: If the model is configured with https-proxy set, we should use the --proxy switch in the cron job. There's currently no setting for this in the template. ** Affects: nagios-charm Importance: Undecided Status: New ** Tags: canonical-bootstack -- You

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1763576 into nagios-charm:master

2018-04-17 Thread Xav Paice
The proposal to merge ~xavpaice/nagios-charm:lp1763576 into nagios-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/343254 -- Your team Nagios Charm developers is requested to

[Nagios-charmers] [Bug 1763576] Re: Pagerduty script does not honor the proxy environment vars

2018-04-17 Thread Xav Paice
Released fix in cs:nagios-24 ** Changed in: nagios-charm Status: In Progress => Fix Committed ** Changed in: nagios-charm Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios

[Nagios-charmers] [Bug 1722325] Re: Wishlist: host dependency and/or parents in host definitions

2018-04-03 Thread Xav Paice
** Changed in: nrpe-charm Status: Confirmed => Fix Released ** Changed in: nagios-charm Status: Confirmed => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm.

Re: [Nagios-charmers] [Merge] ~aieri/thruk-agent-charm:1796318-add-bionic-support into thruk-agent-charm:master

2018-11-21 Thread Xav Paice
I'm adding bionic packages for 2.24 to the PPA now - should avoid needing this. -- https://code.launchpad.net/~aieri/thruk-agent-charm/+git/thruk-agent-charm/+merge/358387 Your team Nagios Charm developers is subscribed to branch thruk-agent-charm:master. -- Mailing list:

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-25 Thread Xav Paice
Review: Resubmit Thanks for the detailed review - I've address (most) of the comments. I've not added all the docstrings requested as it's hard to know where to draw the line between changes relevant to this branch and changes that just make the overall code better - I suggest raising bugs

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-25 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363593 -- Your team Nagios Charm developers is

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_tests into hw-health-charm:master

2019-02-28 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:fix_tests into hw-health-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363758 -- Your team Nagios Charm developers is

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_tests into hw-health-charm:master

2019-02-28 Thread Xav Paice
Thanks Peter, I've updated as suggested. -- https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363813 Your team Nagios Charm developers is subscribed to branch hw-health-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to :

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_tests into hw-health-charm:master

2019-02-28 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_tests into hw-health-charm:master. Requested reviews: Peter Sabaini (peter-sabaini) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363813 -- Your team Nagios Charm developers

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-24 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363593 -- Your team Nagios Charm

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master

2019-03-01 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363833 -- Your team Nagios

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master

2019-03-01 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363760 -- Your team Nagios Charm developers

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_smart into hw-health-charm:master

2019-03-01 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:add_smart into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363834 -- Your team Nagios

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master

2019-02-27 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363760 -- Your team Nagios

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_smartctl into hw-health-charm:master

2019-02-27 Thread Xav Paice
Please review https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363758 first, which will make this change smaller -- https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363760 Your team Nagios Charm developers is requested to review

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-26 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363638 -- Your team Nagios Charm developers is

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-26 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master has been updated. Status: Needs review => Superseded For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363681 -- Your team Nagios Charm developers is

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-26 Thread Xav Paice
Currently have left the tox.ini with complexity at 20, need to add a second commit (unrelated) to get the complexity down to 10, so it passes. We need to raise a bug report to track that. -- https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363682 Your team

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_ipmi into hw-health-charm:master

2019-02-26 Thread Xav Paice
I've addressed the comments, and squashed the commits to one. -- https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363682 Your team Nagios Charm developers is subscribed to branch hw-health-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers

Re: [Nagios-charmers] [Merge] ~aieri/hw-health-charm:lp/1814863 into hw-health-charm:master

2019-02-20 Thread Xav Paice
Review: Approve lgtm -- https://code.launchpad.net/~aieri/hw-health-charm/+git/hw-health-charm/+merge/363062 Your team Nagios Charm developers is subscribed to branch hw-health-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to :

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:lp1819733 into hw-health-charm:master

2019-03-12 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:lp1819733 into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/364345 -- Your team Nagios

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_upgrade_hook into hw-health-charm:master

2019-03-12 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_upgrade_hook into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/364355 -- Your team

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_unittests into hw-health-charm:master

2019-02-19 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_unittests into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/363403 -- Your team Nagios

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:lp1833897 into hw-health-charm:master

2019-06-24 Thread Xav Paice
Many thanks for that, I've updated the change accordingly. This does seem like a better approach. -- https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/369219 Your team Nagios Charm developers is subscribed to branch hw-health-charm:master. -- Mailing list:

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_clear_sel_unittest into hw-health-charm:master

2019-06-24 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:fix_clear_sel_unittest into hw-health-charm:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/369224 -- Your team Nagios Charm

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_clear_sel_unittest into hw-health-charm:master

2019-06-24 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_clear_sel_unittest into hw-health-charm:master. Commit message: fix unit tests for clear-sel action Requested reviews: Canonical IS Reviewers (canonical-is-reviewers) Nagios Charm developers (nagios-charmers) For more details

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:add_smart into hw-health-charm:master

2019-05-22 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:add_smart into hw-health-charm:master has been updated. Commit message changed to: Add smartctl nrpe checks Adds a Nagios plugin and nrpe check using it for smartctl checks against a list of disks that support it. One check for all disks, report

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_cron into hw-health-charm:master

2019-05-23 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_cron into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/367882 -- Your team Nagios Charm

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_clear_sel into hw-health-charm:master

2019-05-23 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_clear_sel into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/367880 -- Your team Nagios

[Nagios-charmers] [Bug 1827159] Re: check_all_disks includes squashfs /snap/* which are 100%

2019-04-30 Thread Xav Paice
** Merge proposal linked: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366740 -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1827159 Title:

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master

2019-04-30 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master. Commit message: Add custom disk monitor for nagios host Requested reviews: James Hebden (ec0) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366741

[Nagios-charmers] [Bug 1827703] [NEW] using Openstack based model, nrpe relation gets the floating IP but connects via fixed IP

2019-05-04 Thread Xav Paice
Public bug reported: I have two models on Openstack, both are in the same project, and same controller. Using a cross model relation, I have related nrpe on model1 to Nagios on model2. The Nagios host has a floating IP address, the machines in model1 (nrpe) do not. When I added the relation,

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master

2019-05-02 Thread Xav Paice
The proposal to merge ~xavpaice/nagios-charm:lp1827159 into nagios-charm:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/366741 -- Your team Nagios Charm developers is subscribed to

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:add-service_check_timeout_state into nagios-charm:master

2019-06-30 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:add-service_check_timeout_state into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/369495 -- Your team

[Nagios-charmers] [Merge] ~xavpaice/nagios-charm:pagerduty-defaults into nagios-charm:master

2019-06-30 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/nagios-charm:pagerduty-defaults into nagios-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/nagios-charm/+git/nagios-charm/+merge/369496 -- Your team Nagios Charm

[Nagios-charmers] [Bug 1741540] Re: pagerduty not getting resolved status when re-check performed via thruk

2020-02-25 Thread Xav Paice
Need to know if this is consistent with alerts going from CRITICAL to OK without flapping. If they're going from CRITICAL to WARNING, or flapping is detected, then the notification won't be sent. Likely there's a better Pagerduty integration we can write that conveys current status, but the

[Nagios-charmers] [Bug 1860981] Re: tests cannot be run on Ubuntu releases more recent than Xenial

2020-02-25 Thread Xav Paice
This charm needs to be re-worked to include a newer pytest framework that is standard for the llama-charmers structure. That will remove the Amulet tests, and replace with functional tests that are more complete (and work on all the platforms supported). Marking wishlist since that work is

[Nagios-charmers] [Bug 1864968] Re: Add support for modifying default contact configuration

2020-03-01 Thread Xav Paice
** Changed in: charm-nagios Status: New => In Progress ** Changed in: charm-nagios Assignee: (unassigned) => Sandor Zeestraten (szeestraten) ** Changed in: charm-nagios Importance: Undecided => Wishlist -- You received this bug notification because you are a member of Nagios

[Nagios-charmers] [Merge] ~aieri/charm-nagios:bug/1843863 into charm-nagios:master

2020-03-01 Thread Xav Paice
The proposal to merge ~aieri/charm-nagios:bug/1843863 into charm-nagios:master has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~aieri/charm-nagios/+git/nagios-charm/+merge/378160 -- Your team Nagios Charm developers is subscribed to branch

[Nagios-charmers] [Bug 1864970] Re: Add support to change default time zone

2020-03-01 Thread Xav Paice
** Changed in: charm-nagios Importance: Undecided => Wishlist ** Changed in: charm-nagios Status: New => Triaged -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1864970

Re: [Nagios-charmers] [Merge] ~szeestraten/charm-nagios:bug/1864968 into charm-nagios:master

2020-03-01 Thread Xav Paice
Review: Needs Fixing Many thanks for this patch. I've made a few comments regarding the config options in config.yaml, around documentation. The change itself seems good, and has tested OK via a manual deployment test. Diff comments: > diff --git a/config.yaml b/config.yaml > index

[Nagios-charmers] [Bug 1843863] Re: Postfix installed listens on all interfaces by default

2020-03-01 Thread Xav Paice
** Changed in: charm-nagios Status: In Progress => Fix Committed -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1843863 Title: Postfix installed listens on all interfaces by

[Nagios-charmers] [Bug 1811997] Re: Password(s) stored on file(s) readable by anyone

2020-03-01 Thread Xav Paice
** Changed in: charm-nagios Status: In Progress => Fix Released -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1811997 Title: Password(s) stored on file(s) readable by

Re: [Nagios-charmers] [Merge] ~giulio.cervera/charm-nagios:bug/1860669 into charm-nagios:master

2020-03-01 Thread Xav Paice
Review: Approve LGTM -- https://code.launchpad.net/~giulio.cervera/charm-nagios/+git/nagios-charm/+merge/378449 Your team Nagios Charm developers is subscribed to branch charm-nagios:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to :

[Nagios-charmers] [Bug 1819537] Re: config-changed hook fails with enable_livestatus enabled

2020-03-01 Thread Xav Paice
I'm unable to find a reproducer for this, it's likely either been fixed by an update since the bug was reported, or I need to get some more info on how to demonstrate this issue. ** Changed in: charm-nagios Status: Triaged => Incomplete -- You received this bug notification because you

[Nagios-charmers] [Bug 1740264] Re: hostgroups defined in nrpe charm are not created

2020-03-01 Thread Xav Paice
The hostgroups config item only takes effect for when the hosts are exported via export_nagios_definitions, this is not sent across relations at this stage. We could clear that up by changing the documentation, or better yet add the information to the relation data and update Nagios to include

[Nagios-charmers] [Bug 1864969] Re: Add support for modifying host and service definitions

2020-03-01 Thread Xav Paice
** Changed in: charm-nagios Importance: Undecided => Wishlist ** Changed in: charm-nagios Status: New => Triaged -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1864969

[Nagios-charmers] [Bug 1834976] Re: config-changed doesn't restart nagios3 when config file is modified

2020-03-01 Thread Xav Paice
So far, I've been unable to reproduce Aurelien's reproducer, but I'm also aware that the Nagios charm takes a while to complete all the iterations of monitors-relation-changed. The hook does include a service reload, and on my tests I have seen new hosts appear in the list after some time,

[Nagios-charmers] [Bug 1807457] Re: local nagios disk monitor doesn't ignore /snap mounts with 0 inodes free

2020-03-02 Thread Xav Paice
Current versions of the charm are OK now without needing the extra switch. ** Changed in: charm-nrpe Status: New => Invalid -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm.

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:LP1814867 into hw-health-charm:master

2020-01-27 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:LP1814867 into hw-health-charm:master. Commit message: Update README for tools resource info Requested reviews: Canonical IS Reviewers (canonical-is-reviewers) Nagios Charm developers (nagios-charmers) Related bugs: Bug #1814867

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:LP1838562 into hw-health-charm:master

2020-01-27 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:LP1838562 into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) Related bugs: Bug #1838562 in hw-health-charm: "cron_ipmi_sensors.py can get blocked if PID file not removed&quo

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:LP1838562 into hw-health-charm:master

2020-01-27 Thread Xav Paice
Updated the change to add the file paths in the error messages trapped. -- https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/378128 Your team Nagios Charm developers is subscribed to branch hw-health-charm:master. -- Mailing list:

Re: [Nagios-charmers] [Merge] ~peter-sabaini/hw-health-charm:lp1817791-reduce-complexity into hw-health-charm:master

2020-01-27 Thread Xav Paice
Review: Approve LGTM -- https://code.launchpad.net/~peter-sabaini/hw-health-charm/+git/hw-health-charm/+merge/378151 Your team Nagios Charm developers is subscribed to branch hw-health-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to :

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_unittests into hw-health-charm:master

2020-02-18 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:fix_unittests into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/379414 -- Your team Nagios

Re: [Nagios-charmers] [Merge] ~afreiberger/hw-health-charm:add-mdadm-checks into hw-health-charm:master

2020-02-18 Thread Xav Paice
https://code.launchpad.net/~peter-sabaini/hw-health-charm/+git/hw-health-charm/+merge/378123 starts to address the getcwd() issues, I think we can complete that change with these fixed too after a rebase. --

Re: [Nagios-charmers] [Merge] ~afreiberger/hw-health-charm:add-mdadm-checks into hw-health-charm:master

2020-02-18 Thread Xav Paice
Review: Needs Fixing This change unfortunately needs rebasing against master, currently there's more merge conflicts than Git can handle. -- https://code.launchpad.net/~afreiberger/hw-health-charm/+git/hw-health-charm/+merge/374838 Your team Nagios Charm developers is subscribed to branch

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:fix_unittests into hw-health-charm:master

2020-02-18 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:fix_unittests into hw-health-charm:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/379414 -- Your team Nagios Charm developers

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:lp1855095 into hw-health-charm:master

2020-02-18 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/hw-health-charm:lp1855095 into hw-health-charm:master. Requested reviews: Nagios Charm developers (nagios-charmers) Related bugs: Bug #1855095 in hw-health-charm: "hpsa driver not implemented" https://bugs.launchpad.net/hw-health-charm/+b

Re: [Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:lp1855095 into hw-health-charm:master

2020-02-19 Thread Xav Paice
commit message updated - I've left the code there since the addition is on the roadmap and it'll save some time looking up vendor strings in the future. -- https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/379431 Your team Nagios Charm developers is subscribed to

[Nagios-charmers] [Merge] ~xavpaice/hw-health-charm:lp1855095 into hw-health-charm:master

2020-02-19 Thread Xav Paice
The proposal to merge ~xavpaice/hw-health-charm:lp1855095 into hw-health-charm:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~xavpaice/hw-health-charm/+git/hw-health-charm/+merge/379431 -- Your team Nagios Charm developers is

Re: [Nagios-charmers] [Merge] ~woutervb/nagios-charm:master into nagios-charm:reactive

2020-02-16 Thread Xav Paice
Review: Needs Fixing Needs a review and update for the changes made to master since this was written, this is a massive rewrite and necessary work, but needs some focus from our engineering to complete. -- https://code.launchpad.net/~woutervb/nagios-charm/+git/nagios-charm/+merge/364360 Your

Re: [Nagios-charmers] [Merge] ~aggkolaitis/nagios-charm:extra_contacts into nagios-charm:master

2020-02-16 Thread Xav Paice
I'd prefer to see a subordinate charm for this kind of option, adding the packages and package config, plus dropping an extra .cfg in the Nagios config dirs, to allow the extra contact. However, given that the charm includes contacts-cfg.tmpl and that templates the file which defines the

[Nagios-charmers] [Bug 1827006] Re: Add more notification groups

2020-02-16 Thread Xav Paice
Redirect to nagios-charm (not package) ** Package changed: nagios (Juju Charms Collection) => nagios-charm ** Changed in: nagios-charm Status: New => Triaged ** Changed in: nagios-charm Importance: Undecided => Wishlist -- You received this bug notification because you are a member

Re: [Nagios-charmers] [Merge] ~aieri/nagios-charm:bug/1811997 into nagios-charm:master

2020-02-16 Thread Xav Paice
Review: Approve Trivial change, will merge without Canonical IS Reviewers input (been a couple of weeks waiting now). -- https://code.launchpad.net/~aieri/nagios-charm/+git/nagios-charm/+merge/378116 Your team Nagios Charm developers is subscribed to branch nagios-charm:master. -- Mailing

[Nagios-charmers] [Merge] ~aieri/nagios-charm:bug/1843863 into nagios-charm:master

2020-02-16 Thread Xav Paice
The proposal to merge ~aieri/nagios-charm:bug/1843863 into nagios-charm:master has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~aieri/nagios-charm/+git/nagios-charm/+merge/378160 -- Your team Nagios Charm developers is subscribed to

Re: [Nagios-charmers] [Merge] ~aieri/nagios-charm:bug/1843863 into nagios-charm:master

2020-02-16 Thread Xav Paice
Review: Approve Tested, lgtm. May need a rebase. -- https://code.launchpad.net/~aieri/nagios-charm/+git/nagios-charm/+merge/378160 Your team Nagios Charm developers is subscribed to branch nagios-charm:master. -- Mailing list: https://launchpad.net/~nagios-charmers Post to :

Re: [Nagios-charmers] [Merge] ~giulio.cervera/nagios-charm:bug/1860669 into nagios-charm:master

2020-02-16 Thread Xav Paice
Thanks for the contribution. I'm concerned that we have the code to enable the module, but nothing to actually deploy the module itself, meaning that this change alone doesn't achieve much. Adding the module would be ideally put into a subordinate charm, along with dropping a fresh config

Re: [Nagios-charmers] [Merge] ~giulio.cervera/nagios-charm:bug/1860669 into nagios-charm:master

2020-02-16 Thread Xav Paice
The docs are pretty clear, this is an option for the main config file only, and given the age of Nagios 3 it's unlikely to be something that'll change any time soon. Since we're in the middle of a release, I'll postpone this till after the release and target for the next one. --

[Nagios-charmers] [Bug 1860669] Re: add support for enabling broker modules

2020-02-16 Thread Xav Paice
** Merge proposal linked: https://code.launchpad.net/~giulio.cervera/nagios-charm/+git/nagios-charm/+merge/378449 -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1860669 Title:

[Nagios-charmers] [Bug 1866624] Re: Set application version for Nagios

2020-03-09 Thread Xav Paice
** Changed in: charm-nagios Importance: Undecided => Wishlist ** Changed in: charm-nagios Status: New => Triaged -- You received this bug notification because you are a member of Nagios Charm developers, which is subscribed to Nagios Charm. https://bugs.launchpad.net/bugs/1866624

Re: [Nagios-charmers] [Merge] ~szeestraten/charm-nagios:bug/1864968 into charm-nagios:master

2020-03-16 Thread Xav Paice
Review: Needs Fixing There's some merge conflict markers in hooks/upgrade-charm which need sorting, and likely a rebase against master to ensure there's no further conflicts. Other than that, lgtm. -- https://code.launchpad.net/~szeestraten/charm-nagios/+git/nagios-charm/+merge/379943 Your

[Nagios-charmers] [Merge] ~xavpaice/charm-nagios:bug/1819537 into charm-nagios:master

2020-09-30 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/charm-nagios:bug/1819537 into charm-nagios:master. Requested reviews: Nagios Charm developers (nagios-charmers) Related bugs: Bug #1819537 in Nagios Charm: "config-changed hook fails with enable_livestatus enabled" https://bugs.launchpad

[Nagios-charmers] [Merge] ~xavpaice/charm-nagios:bug/1819537 into charm-nagios:master

2020-09-30 Thread Xav Paice
Xav Paice has proposed merging ~xavpaice/charm-nagios:bug/1819537 into charm-nagios:master. Requested reviews: Nagios Charm developers (nagios-charmers) Related bugs: Bug #1819537 in Nagios Charm: "config-changed hook fails with enable_livestatus enabled" https://bugs.launchpad

[Nagios-charmers] [Bug 1819537] Re: config-changed hook fails with enable_livestatus enabled

2020-09-30 Thread Xav Paice
Reproducer: juju deploy cs:nagios-38 wait for hooks to settle juju config nagios enable_livestatus=true 2020-09-30 07:32:28 WARNING unit.nagios/0.config-changed logger.go:60 Traceback (most recent call last): 2020-09-30 07:32:28 WARNING unit.nagios/0.config-changed logger.go:60 File

Re: [Nagios-charmers] [Merge] ~xavpaice/charm-nagios:bug/1819537 into charm-nagios:master

2020-10-01 Thread Xav Paice
Ah... the functest has enable livestatus enabled at install, and hooks/install does the package install for that. -- https://code.launchpad.net/~xavpaice/charm-nagios/+git/nagios-charm/+merge/391667 Your team Nagios Charm developers is subscribed to branch charm-nagios:master. -- Mailing list:

  1   2   >