Hi Ian,
So I'm happy to go with Tomas's solution - leaving the sys properties
non read only.
OK, I'm game. I've done the fix and added a couple of new unit tests to the
SysInfo task to ensure both conditions hold true :)
While looking through the code, though, I noticed that the code in
While looking through the code, though, I noticed that the code in
PropertyDictionary's indexer is:
set {
if (!_readOnlyProperties.Contains(name)) {
Dictionary[name] = value;
}
}
Now, this will silently be ignored if the property is
readonly. Somehow, I
don't think this is
Wouldn't something like make's ?= be useful here? The value is only
assigned if it doesn't already have a value. That way you could tell by
looking at the build file which variables were intended to be overriden
on the command line. In nant's case, maybe an extra attribute on the
property