RE: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

Hi Michael, Looks good. Few limitations with absolute paths. On cmd.exe: jjs -scripting $EXEC("D:\work\nashorn-dev\dev\build\windows-x86_64-normal-server-release\images\jdk\bin\java.exe") Good thing is on cygwin if we give mixed path like:

Re: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

Looks good! Hannes Am 2016-03-07 um 13:28 schrieb Michael Haupt: Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8151291 Webrev: http://cr.openjdk.java.net/~mhaupt/8151291/webrev.00/ For Cygwin, paths need special attention as the /cygdrive/x/... format is

Re: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

Hi Jim, thanks - > Am 07.03.2016 um 13:36 schrieb Jim Laskey (Oracle) : > 1. use a final static for "/cygdrive" I've added that. > 2. Are you sure you want the ex.printStackTrace(); left in No; that's a leftover from investigating. I'll push with these changes

Re: RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

1. use a final static for "/cygdrive" 2. Are you sure you want the ex.printStackTrace(); left in +1 > On Mar 7, 2016, at 8:28 AM, Michael Haupt wrote: > > Dear all, > > please review this change. > Bug: https://bugs.openjdk.java.net/browse/JDK-8151291 > Webrev:

RFR(S): 8151291: $EXEC yields "unknown command" on Cygwin

Dear all, please review this change. Bug: https://bugs.openjdk.java.net/browse/JDK-8151291 Webrev: http://cr.openjdk.java.net/~mhaupt/8151291/webrev.00/ For Cygwin, paths need special attention as the /cygdrive/x/... format is not recognised by Windows. Thanks, Michael --

Re: Review request for JDK-8148148: Remove pluggable CodeStore API

Thanks for the reviews. I just noticed the original webrev didn't remove unused headers and update the copyright date. I've uploaded a new webrev with those changes added. http://cr.openjdk.java.net/~hannesw/8148148/webrev.01/ Hannes Am 2016-03-07 um 10:37 schrieb Attila Szegedi: +1 On