Re: RFR: 8184720(Nashorn engine in strict mode throws a java.lang.ClassCastException when calling apply() and passing the arguments object)

Looks good! Hannes > Am 25.08.2017 um 09:22 schrieb Srinivas Dama : > > Thank you Hannes for the comments. > > Here is the revised patch at > http://cr.openjdk.java.net/~sdama/8184720/webrev.01/ . > > Note: This includes additional fix from Hannes on top of existing

RE: RFR: 8184720(Nashorn engine in strict mode throws a java.lang.ClassCastException when calling apply() and passing the arguments object)

Thank you Hannes for the comments. Here is the revised patch at http://cr.openjdk.java.net/~sdama/8184720/webrev.01/ . Note: This includes additional fix from Hannes on top of existing fix to resolve assertion error while running tests from 'ant' test runner without 'scripting' option.

Re: RFR: 8184720(Nashorn engine in strict mode throws a java.lang.ClassCastException when calling apply() and passing the arguments object)

Hi Srini, I don’t think the -scripting option is needed in the test, and you could just call the function without try-catch and printing messages. Otherwise +1 Hannes > Am 23.08.2017 um 06:38 schrieb Srinivas Dama : > > Hi, > > Please review