Re: RFR: 8134516(Move getInvokeByName and getDynamicInvoker methods from Global to Context)

2017-12-12 Thread Srinivas Dama
a.net Sent: Monday, December 11, 2017 4:45:56 PM GMT +05:30 Chennai, Kolkata, Mumbai, New Delhi Subject: Re: RFR: 8134516(Move getInvokeByName and getDynamicInvoker methods from Global to Context) You shouldn't make Global.getContext() public. Context is a security-sensitive class, and the o

Re: RFR: 8134516(Move getInvokeByName and getDynamicInvoker methods from Global to Context)

2017-12-11 Thread Attila Szegedi
You shouldn't make Global.getContext() public. Context is a security-sensitive class, and the only public access to it is supposed to be through Context.getContext(), which includes a security check. I see you have also simply disabled that security check in your patch. I’m afraid that’s

Re: RFR: 8134516(Move getInvokeByName and getDynamicInvoker methods from Global to Context)

2017-12-07 Thread Hannes Wallnöfer
I have some doubts about whether this is worth it. The idea was to be able to use these internal callsites between various globals without relinking. But since built-in prototypes in different globals have different property maps that doesn’t really happen. That matches your observation that

RFR: 8134516(Move getInvokeByName and getDynamicInvoker methods from Global to Context)

2017-12-06 Thread Srinivas Dama
Hi, Please review http://cr.openjdk.java.net/~sdama/8134516/webrev.01/ for https://bugs.openjdk.java.net/browse/JDK-8134516 Regards, Srinivas