Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

2017-09-29 Thread Hannes Wallnöfer
> From: hannes.wallnoe...@oracle.com > To: srinivas.d...@oracle.com > Cc: nashorn-dev@openjdk.java.net > Sent: Friday, September 29, 2017 7:33:18 PM GMT +05:30 Chennai, Kolkata, > Mumbai, New Delhi > Subject: Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly) > > Hi Sri

Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

2017-09-29 Thread Srinivas Dama
, Kolkata, Mumbai, New Delhi Subject: Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly) Hi Srini, a few notes: - Shouldn’t the new test include an invocation with > ARGLIMIT double arguments to test it works? - No need to use Number(1.1), a number with a fractional part will res

Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

2017-09-29 Thread Jim Laskey (Oracle)
> Cc: nashorn-dev@openjdk.java.net > Sent: Friday, September 29, 2017 7:33:18 PM GMT +05:30 Chennai, Kolkata, > Mumbai, New Delhi > Subject: Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly) > > Hi Srini, > > a few notes: > > - Shouldn’t the new test in

Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

2017-09-29 Thread Srinivas Dama
Hi Hannes, Thank you for the comments -Modified test case already covers both > ARGLIMIT and ARGLIMIT double arguments to test it works? - No need to use Number(1.1), a number with a fractional part will result in a double. - I assume eval() in the test is to force this-object and callee

Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

2017-09-29 Thread Hannes Wallnöfer
Hi Srini, a few notes: - Shouldn’t the new test include an invocation with > ARGLIMIT double arguments to test it works? - No need to use Number(1.1), a number with a fractional part will result in a double. - I assume eval() in the test is to force this-object and callee to be sent,

RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

2017-09-29 Thread Srinivas Dama
Hi, Please review http://cr.openjdk.java.net/~sdama/8147076/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8147076 Regards, Srinivas