Re: RFR 8145750: jjs fails to run simple scripts with security manager turned on

2015-12-20 Thread Sundararajan Athijegannathan
File a separate to track jdk.dynalink permissions: https://bugs.openjdk.java.net/browse/JDK-8145868 Adjusted test comments that Hannes mentioned and pushing changes in webrev @ http://cr.openjdk.java.net/~sundar/8145750/webrev.01/ Thanks -Sundar On 12/20/2015 9:53 PM, Alan Bateman wrote:

Re: RFR 8145750: jjs fails to run simple scripts with security manager turned on

2015-12-20 Thread Alan Bateman
On 18/12/2015 12:55, Sundararajan Athijegannathan wrote: May be, not. But I tried giving only sun.reflect package access -- didn't work. There are a few doPrivileged blocks in dynalink code as well. This needs further analysis. But dynalink code was part of nashorn and so was getting

RFR 8145750: jjs fails to run simple scripts with security manager turned on

2015-12-18 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8145750/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8145750 Adding missing permissions for jdk.dynalink module. Note that it used to be part of jdk.scripting.nashorn module in the past and therefore got AllPermission. Thanks,

Re: RFR 8145750: jjs fails to run simple scripts with security manager turned on

2015-12-18 Thread Alan Bateman
On 18/12/2015 12:23, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8145750/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8145750 Adding missing permissions for jdk.dynalink module. Note that it used to be part of jdk.scripting.nashorn module

Re: RFR 8145750: jjs fails to run simple scripts with security manager turned on

2015-12-18 Thread Hannes Wallnoefer
Looks good. Some of the new test scripts have an incomplete @summary line, e.g. jjs-strictTest.sh: # @summary Test that output of 'jjs -strict' Hannes Am 2015-12-18 um 13:23 schrieb Sundararajan Athijegannathan: Please review http://cr.openjdk.java.net/~sundar/8145750/webrev.00/ for

Re: RFR 8145750: jjs fails to run simple scripts with security manager turned on

2015-12-18 Thread Sean Mullan
On 12/18/2015 07:55 AM, Sundararajan Athijegannathan wrote: inline comments below.. On 12/18/2015 6:22 PM, Alan Bateman wrote: On 18/12/2015 12:23, Sundararajan Athijegannathan wrote: Please review http://cr.openjdk.java.net/~sundar/8145750/webrev.00/ for