Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

2018-05-31 Thread Alan Bateman
On 30/05/2018 16:06, Jan Lahoda wrote: Hi, An updated webrev is here: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/complete/ A webrev showing changes from the previous revision is here: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/delta/ The changes are: -updated

Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

2018-05-31 Thread Hannes Wallnöfer
Hi Jan, Works as expected with jjs now. Thanks, Hannes > Am 30.05.2018 um 17:06 schrieb Jan Lahoda : > > Hi, > > An updated webrev is here: > http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/complete/ > > A webrev showing changes from the previous revision is here: >

Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

2018-05-30 Thread Jan Lahoda
Hi, An updated webrev is here: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/complete/ A webrev showing changes from the previous revision is here: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/delta/ The changes are: -updated src/jdk.internal.le/share/legal/jline.md -the

Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

2018-05-29 Thread Jan Lahoda
Hi Hannes, On 29.5.2018 17:32, Hannes Wallnöfer wrote: Hi Jan, Nashorn changes look good. I noticed one slight change of behaviour in jjs. When I enter „java.m“ and hit the tab key, it autocompletes to „java.math “, adding a space character at the end. This is a bit inconvenient, and the

Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

2018-05-29 Thread Hannes Wallnöfer
Hi Jan, Nashorn changes look good. I noticed one slight change of behaviour in jjs. When I enter „java.m“ and hit the tab key, it autocompletes to „java.math “, adding a space character at the end. This is a bit inconvenient, and the old version of jline didn’t do that. Hannes > Am

Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

2018-05-29 Thread Jan Lahoda
Hi, On 29.5.2018 14:51, Alan Bateman wrote: On 25/05/2018 21:20, Jan Lahoda wrote: Hi, I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6. The complete webrev is here: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/ To simplify reviewing, there is:

Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

2018-05-29 Thread Alan Bateman
On 25/05/2018 21:20, Jan Lahoda wrote: Hi, I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6. The complete webrev is here: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/ To simplify reviewing, there is: -an antipatch that removes the JDK-specific