+1
-Sundar
On 4/26/2016 3:28 PM, Hannes Wallnoefer wrote:
> Thanks for the reviews. I uploaded a new webrev:
>
> http://cr.openjdk.java.net/~hannesw/8134503/webrev.01/
>
> I left the copyright year as 2015, 2016 for those files I got with
> that date from Andreas, I think that's the correct thin
Thanks for the reviews. I uploaded a new webrev:
http://cr.openjdk.java.net/~hannesw/8134503/webrev.01/
I left the copyright year as 2015, 2016 for those files I got with that
date from Andreas, I think that's the correct thing to do.
The change of endPosition for object literal property node
Hi Hannes,
that's a really significant improvement, thanks for taking this on!
There is one thing that I think needs to be addressed. Several occurrences of
throw error(...) pass a plain English string, rather than passing the result of
a call to AbstractParser.message(...), which stands in the
* new sources copyright year to be 2016
* can the new IR node classes be final? ClassNode etc.?
* .EXPECTED files have new endPosition now. are we being precise now?
+1
-Sundar
On 4/25/2016 5:19 PM, Hannes Wallnoefer wrote:
> Please review JDK-8134503: support ES6 parsing in Nashorn
>
> http:/
+1
> On Apr 25, 2016, at 8:49 AM, Hannes Wallnoefer
> wrote:
>
> Please review JDK-8134503: support ES6 parsing in Nashorn
>
> http://cr.openjdk.java.net/~hannesw/8134503/webrev/
>
> The original patch was contributed by Andreas Woess, I just did the
> integration into Nashorn tip.
>
> Than
Please review JDK-8134503: support ES6 parsing in Nashorn
http://cr.openjdk.java.net/~hannesw/8134503/webrev/
The original patch was contributed by Andreas Woess, I just did the
integration into Nashorn tip.
Thanks,
Hannes
