Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

+1 Nashorn changes and modules.xml changes look good to me. -Sundar On 9/16/2015 7:35 PM, Attila Szegedi wrote: On Sep 16, 2015, at 2:51 PM, Alan Bateman wrote: On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

> On Sep 16, 2015, at 2:51 PM, Alan Bateman wrote: > > > > On 16/09/2015 13:28, Magnus Ihse Bursie wrote: >> On 2015-09-11 18:00, Attila Szegedi wrote: >>> Please review the revised changes for JDK-8135251 "Use >>> Unsafe.defineAnonymousClass for loading Nashorn script code” >>>

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

Nope. Just compiled it with 9-b81 and no such warnings are present. > On Sep 14, 2015, at 9:55 AM, Marcus Lagergren wrote: > > ant test > > Does it spit out warnings like e.g. > > Temp.java:1: warning: Unsafe is internal proprietary API and may be removed > in a future release > import sun.mi

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

+1 for the Nashorn changes. Am 2015-09-11 um 18:00 schrieb Attila Szegedi: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code” The revision incorporates the following changes: -

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

On 09/16/2015 07:51 AM, Alan Bateman wrote: On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code”

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

On 16/09/2015 14:06, David M. Lloyd wrote: Also I could be wrong but it looks to me like the jigsaw/jake forest's equivalent module graph has evolved somewhat, and thus doesn't quite match this file anyway. jigsaw/jake is currently at jdk9-b81. There may be changes backed up in jdk9/dev that

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

On 16/09/2015 14:04, Magnus Ihse Bursie wrote: Does this mean that updates to modules.xml between now and the integration-to-come of jigsaw/jake do not anymore need specific approval? I think we should keep the status quo and CC jigsaw-dev when there are changes to modules.xml. If nothing els

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

On 2015-09-16 14:51, Alan Bateman wrote: On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code”

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

On 16/09/2015 13:28, Magnus Ihse Bursie wrote: On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code” The revision incorporates the foll

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

On 2015-09-11 18:00, Attila Szegedi wrote: Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code” The revision incorporates the following changes: - the feature can be disabled by set

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

ant test Does it spit out warnings like e.g. Temp.java:1: warning: Unsafe is internal proprietary API and may be removed in a future release import sun.misc.Unsafe; ^ Temp.java:6: warning: Unsafe is internal proprietary API and may be removed in a future release private stati

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

What do you mean by “unsafe warning”? > On Sep 13, 2015, at 12:47 PM, Marcus Lagergren wrote: > > +1. Nicely done. > > Does this compile without unsafe warnings, though? > > /M > >> On 11 Sep 2015, at 18:00, Attila Szegedi > > wrote: >> >> e >

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

+1. Nicely done. Does this compile without unsafe warnings, though? /M > On 11 Sep 2015, at 18:00, Attila Szegedi wrote: > > e

Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

Please review the revised changes for JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code” The revision incorporates the following changes: - the feature can be disabled by setting the "nashorn.disableVmAnonymousClasses

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

+1 Looks good to me too. Great that you cleaned up that “owner” generic. I can’t remember what else we had as owners in the beginning for CodeInstallers than ScriptEnvironments. Nitpicks: not sure if we had a convention that static final fields are named UPPER_CASE_LIKE_THIS. We have e.g. the L

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

"Remi Forax" >>> Cc: nashorn-dev@openjdk.java.net >>> Envoyé: Mercredi 9 Septembre 2015 16:56:50 >>> Objet: Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass >>> for loading Nashorn script code >>> >>> There’s one h

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

Looks good to me. Hannes Am 2015-09-09 um 15:35 schrieb Attila Szegedi: Please review JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code" at for Implementatio

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

"Attila Szegedi" >> À: "Remi Forax" >> Cc: nashorn-dev@openjdk.java.net >> Envoyé: Mercredi 9 Septembre 2015 16:56:50 >> Objet: Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass >> for loading Nashorn scri

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

tembre 2015 16:56:50 > Objet: Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass > forloading Nashorn script code > > There’s one host class per CodeSource. Host classes provide their > ProtectionDomain to the anonymous classes, and we must code for running &g

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

There’s one host class per CodeSource. Host classes provide their ProtectionDomain to the anonymous classes, and we must code for running under a security manager. > On Sep 9, 2015, at 4:40 PM, Remi Forax wrote: > > Hi Attila, > in your patch you're using several different host classes (i bele

Re: Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

Hi Attila, in your patch you're using several different host classes (i beleive one by script) and i don't understand why ? cheers, Rémi On 09/09/2015 03:35 PM, Attila Szegedi wrote: > Please review JDK-8135251 "Use Unsafe.defineAnonymousClass for loading > Nashorn script code" at >

Review request for JDK-8135251: Use Unsafe.defineAnonymousClass for loading Nashorn script code

Please review JDK-8135251 "Use Unsafe.defineAnonymousClass for loading Nashorn script code" at for Implementation notes are in