Re: Review request for JDK-8138906

Hi Srinivas, this has already been reviewed; here's the thread: http://mail.openjdk.java.net/pipermail/nashorn-dev/2016-February/005991.html I'll sponsor the push. Best, Michael > Am 11.03.2016 um 10:08 schrieb Srinivas Dama : > > Hi, > > Please review

Review request for JDK-8138906

Hi, Please review http://cr.openjdk.java.net/~sdama/8138906/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8138906 I did testing with recent $EXEC changes from Michael and very small code cleanup. Regards, Srinivas

Re: Review request for JDK-8138906

From: Michael Haupt Sent: Tuesday, March 01, 2016 3:16 PM To: Srinivas Dama Cc: nashorn-dev@openjdk.java.net Subject: Re: Review request for JDK-8138906 Hi Srinivas, Am 29.02.2016 um 17:28 schrieb Srinivas Dama mailto:srinivas.d...@oracle.com"srinivas.d...@oracle.com>:

RE: Review request for JDK-8138906

Dama Cc: nashorn-dev@openjdk.java.net Subject: Re: Review request for JDK-8138906   Hi Srinivas,   Am 29.02.2016 um 17:28 schrieb Srinivas Dama mailto:srinivas.d...@oracle.com"srinivas.d...@oracle.com>: Please review : Bug : https://bugs.openjdk.java.net/browse/JDK-8138906 Webre

Re: Review request for JDK-8138906

Hi Srinivas, > Am 29.02.2016 um 17:28 schrieb Srinivas Dama : > Please review : > Bug : https://bugs.openjdk.java.net/browse/JDK-8138906 > Webrev : http://cr.openjdk.java.net/~sdama/8138906/webrev.01 I've verified this works on Windows. Lower-case thumbs up, with these

Review request for JDK-8138906

Hello All, Please review : Bug : https://bugs.openjdk.java.net/browse/JDK-8138906 Webrev : http://cr.openjdk.java.net/~sdama/8138906/webrev.01 Fix is to pick 'java' from specified JAVA_HOME folder, along with this, I have added some utility functions(can be added more) which can be used in all