Re: RFR: 8185257(Nashorn AST is missing nodes when a for-loop contains a VariableDeclarationList)

2017-09-25 Thread Sundararajan Athijegannathan
+1 -Sundar On 26/09/17, 1:01 AM, Srinivas Dama wrote: Hi, Please review revised patch after migrating to jdk10/master repo. http://cr.openjdk.java.net/~sdama/8185257/webrev.02/ Regards, Srinivas -Original Message- From: Hannes Wallnöfer Sent: Wednesday, September 13, 2017 1:49 AM To:

Re: RFR 8187934: dropping a shebang script in src/sample/nashorn directory results in test failure

2017-09-25 Thread Jim Laskey (Oracle)
+1 > On Sep 25, 2017, at 11:15 AM, Sundararajan Athijegannathan > wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8187934 > Webrev: http://cr.openjdk.java.net/~sundar/8187934/webrev.00/ > > PS. Piggybacking a sample script

RFR 8187934: dropping a shebang script in src/sample/nashorn directory results in test failure

2017-09-25 Thread Sundararajan Athijegannathan
Please review. Bug: https://bugs.openjdk.java.net/browse/JDK-8187934 Webrev: http://cr.openjdk.java.net/~sundar/8187934/webrev.00/ PS. Piggybacking a sample script (psgrep.js) Thanks, -Sundar

Re: RFR 8187934: dropping a shebang script in src/sample/nashorn directory results in test failure

2017-09-25 Thread Hannes Wallnöfer
+1 Hannes > Am 25.09.2017 um 16:28 schrieb Jim Laskey (Oracle) : > > +1 > >> On Sep 25, 2017, at 11:15 AM, Sundararajan Athijegannathan >> wrote: >> >> Please review. >> >> Bug:

Re: RFR:8186011(Fix samples/java_completion.js and samples/disassemble.js)

2017-09-25 Thread Srinivas Dama
Hi, Please review migrated patch to jdk10/master repo. http://cr.openjdk.java.net/~sdama/8186011/webrev.01/ Regards, Srinivas - Original Message - From: hannes.wallnoe...@oracle.com To: srinivas.d...@oracle.com Cc: nashorn-dev@openjdk.java.net Sent: Tuesday, September 19, 2017 4:10:46 PM

RE: RFR: 8185257(Nashorn AST is missing nodes when a for-loop contains a VariableDeclarationList)

2017-09-25 Thread Srinivas Dama
Hi, Please review revised patch after migrating to jdk10/master repo. http://cr.openjdk.java.net/~sdama/8185257/webrev.02/ Regards, Srinivas -Original Message- From: Hannes Wallnöfer Sent: Wednesday, September 13, 2017 1:49 AM To: Srinivas Dama Cc: Nashorn-dev Subject: Re: RFR:

Re: RFR: 8185257(Nashorn AST is missing nodes when a for-loop contains a VariableDeclarationList)

2017-09-25 Thread Hannes Wallnöfer
Looks good! Hannes > Am 25.09.2017 um 21:31 schrieb Srinivas Dama : > > Hi, > > Please review revised patch after migrating to jdk10/master repo. > http://cr.openjdk.java.net/~sdama/8185257/webrev.02/ > > Regards, > Srinivas > -Original Message- > From:

Re: RFR:8186011(Fix samples/java_completion.js and samples/disassemble.js)

2017-09-25 Thread Hannes Wallnöfer
+1 Hannes > Am 25.09.2017 um 12:49 schrieb Srinivas Dama : > > Hi, > Please review migrated patch to jdk10/master repo. > http://cr.openjdk.java.net/~sdama/8186011/webrev.01/ > > Regards, > Srinivas > - Original Message - > From: hannes.wallnoe...@oracle.com >

Re: RFR:8133623:JDK-8055034.js and JDK-8130127.js fail in nashorn nightly

2017-09-25 Thread Hannes Wallnöfer
+1 Hannes > Am 25.09.2017 um 07:47 schrieb Priya Lakshmi Muthuswamy > : > > Hi, > > Please review JDK-8133623 : JDK-8055034.js and JDK-8130127.js fail in nashorn > nightly. > > JDK-8130127.js was already fixed. > This RFR is for JDK-8055034.js. > >