Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

2017-09-29 Thread Hannes Wallnöfer
Looks good! Hannes > Am 29.09.2017 um 17:37 schrieb Srinivas Dama : > > Hi, > > here is the revised patch > http://cr.openjdk.java.net/~sdama/8147076/webrev.01/ > > Regards, > Srinivas > - Original Message - > From: hannes.wallnoe...@oracle.com > To:

Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

2017-09-29 Thread Srinivas Dama
Hi, here is the revised patch http://cr.openjdk.java.net/~sdama/8147076/webrev.01/ Regards, Srinivas - Original Message - From: hannes.wallnoe...@oracle.com To: srinivas.d...@oracle.com Cc: nashorn-dev@openjdk.java.net Sent: Friday, September 29, 2017 7:33:18 PM GMT +05:30 Chennai,

Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

2017-09-29 Thread Jim Laskey (Oracle)
+1 > On Sep 29, 2017, at 11:33 AM, Srinivas Dama wrote: > > Hi Hannes, > > Thank you for the comments > > -Modified test case already covers both > ARGLIMIT and with double). > I have added a new test case for double arguments.anyway,I will modify the > test as you

Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

2017-09-29 Thread Srinivas Dama
Hi Hannes, Thank you for the comments -Modified test case already covers both > ARGLIMIT and ARGLIMIT double arguments to test it works? - No need to use Number(1.1), a number with a fractional part will result in a double. - I assume eval() in the test is to force this-object and callee

Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

2017-09-29 Thread Hannes Wallnöfer
Hi Srini, a few notes: - Shouldn’t the new test include an invocation with > ARGLIMIT double arguments to test it works? - No need to use Number(1.1), a number with a fractional part will result in a double. - I assume eval() in the test is to force this-object and callee to be sent,

RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

2017-09-29 Thread Srinivas Dama
Hi, Please review http://cr.openjdk.java.net/~sdama/8147076/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8147076 Regards, Srinivas

Re: RFR 8180274: Fix links in nashorn documentation

2017-09-29 Thread Jim Laskey (Oracle)
+1 > On Sep 29, 2017, at 1:56 AM, Sundararajan Athijegannathan > wrote: > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8180274 > Webrev: http://cr.openjdk.java.net/~sundar/8180274/webrev.00/ > > Thanks, > -Sundar

Re: RFR 8180274: Fix links in nashorn documentation

2017-09-29 Thread Hannes Wallnöfer
+1 Hannes > Am 29.09.2017 um 06:56 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8180274 > Webrev: http://cr.openjdk.java.net/~sundar/8180274/webrev.00/ > > Thanks, > -Sundar