On 9.6.2015 01:31, Daniel D. Daugherty wrote:
http://cr.openjdk.java.net/~ihse/JDK-8085822-JEP-223-initial-patch/webrev.01
langtools/src/java.compiler/share/classes/javax/lang/model/SourceVersion.java
old L171: case 1.9:
new L171: case 9:
Hello,
I am proposing to add JLine 2.12.1 into the jdk repository for use by
the Java and Nashorn REPLs. Full patch is available here:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev.00/full/
To aid the review, I've split this patch into to smaller patches:
-a patch that only adds
-jdk.jdi.gmk as a template. Is the
-DUSE_MMAP just an artifact of that copy or do you know that it is needed?
/Erik
On 2015-06-18 16:25, Jan Lahoda wrote:
Hello,
I am proposing to add JLine 2.12.1 into the jdk repository for use by
the Java and Nashorn REPLs. Full patch is available here:
http
recommendations
-the module name is now changed to jdk.internal.le
Any comments are welcome!
Thanks,
Jan
On 18.6.2015 16:25, Jan Lahoda wrote:
Hello,
I am proposing to add JLine 2.12.1 into the jdk repository for use by
the Java and Nashorn REPLs. Full patch is available here:
http
Hi Alan,
Thanks for the comments! A question inline.
On 25.6.2015 18:38, Alan Bateman wrote:
On 25/06/2015 17:25, Jan Lahoda wrote:
Hello,
Based on the feedback I've received so far, I've uploaded an updated
version of the patch:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev.01/full
!
Jan
+1 from nashorn point of view.
Thanks,
-Sundar
On Thursday 18 June 2015 07:55 PM, Jan Lahoda wrote:
Hello,
I am proposing to add JLine 2.12.1 into the jdk repository for use by
the Java and Nashorn REPLs. Full patch is available here:
http://cr.openjdk.java.net/~jlahoda/8080679/webrev
,
Has this been tested with a JDK 9 compiler?
The last time I checked JLine wouldn't build with an OpenJDK 9 javac.
Thanks,
Ben
On 18 Jun 2015 3:26 pm, Jan Lahoda jan.lah...@oracle.com
mailto:jan.lah...@oracle.com wrote:
Hello,
I am proposing to add JLine 2.12.1 into the jdk repository
Hi Sundar,
Regarding the new Console.java, there is a copy of EditingHistory from
JShell. That implements a support for simpler editing of multi-line
snippet from history (still somewhat experimental, I think). If that
would be useful for jjs, then I think we(/I) should work on sharing that
simpler history implementation. Updated
nashorn webrev:
http://cr.openjdk.java.net/~sundar/8133347/nashorn/webrev.01/
Thanks,
-Sundar
On 8/13/2015 3:37 PM, Jan Lahoda wrote:
Hi Sundar,
Regarding the new Console.java, there is a copy of EditingHistory from
JShell. That implements a support
Seems fine to me. Yes, I think that, eventually, we should generalize
what we need into jdk.internal.le, so that we don't have to maintain two
copies of the code.
Jan
On 20.8.2015 16:05, Attila Szegedi wrote:
+1
On Aug 20, 2015, at 3:11 PM, Sundararajan Athijegannathan
Please review.
Problem: when pasting code that contains tab characters into both jshell
and jjs, the tab completion gets invoked on tabs instead of using the
tab character itself.
The proposed solution is to set setCopyPasteDetection(true) on jline's
ConsoleReader, which should enable
Hello,
In jshell, there's a special history mode that is intended to aid with
editing/re-entering multi-line snippets (EditingHistory). It works like
this: when the user goes back through the history to the first line of a
multi-line snippet, and enters/confirms that line, the history view is
Hello,
When jshell or jjs are suspended and resumed, the terminal is reset to
un-raw/cooked mode and jline editing is not working properly (as that
requires raw mode). The solution I know about is to reset the terminal
to raw mode on resume. This can be achieved using
Hi,
I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6.
The complete webrev is here:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/
To simplify reviewing, there is:
-an antipatch that removes the JDK-specific changes and restores the
vanilla 2.12.1
Hi,
The Nashorn APIs have been enhanced in JDK 8 updates. The proposal here
is to update the historical data for --release 8 to JDK 8u40.
Note this includes removal of:
jdk.nashorn.api.scripting.NashornException.ENGINE_SCRIPT_SOURCE_NAME
and:
-the problem with automatically adding space after completion is resolved
-a few tweaks to tests
Does this look good?
Thanks,
Jan
On 29.5.2018 16:04, Jan Lahoda wrote:
Hi,
On 29.5.2018 14:51, Alan Bateman wrote:
On 25/05/2018 21:20, Jan Lahoda wrote:
Hi,
I'd like to upgrade the JLine used
Hi,
On 29.5.2018 14:51, Alan Bateman wrote:
On 25/05/2018 21:20, Jan Lahoda wrote:
Hi,
I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to
2.14.6.
The complete webrev is here:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/
To simplify reviewing
:20 schrieb Jan Lahoda :
Hi,
I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6.
The complete webrev is here:
http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/
To simplify reviewing, there is:
-an antipatch that removes the JDK-specific changes and restores
Hi,
I'd like to update the internal JLine used by JShell and jjs to JLine
3.9.0. Two notable advantages of this version is multi-line snippet
editing and better UI on Windows (escape sequence support on Windows).
As a consequence, this patch drops EditingHistory, as it does not seem
to be
On 6.12.2018 06:08, Michel Trudeau wrote:
What about Ctrl-Enter ?
Actually, Alt-Enter turnes out to work on Linux (KDE Konsole) as a
shortcut to add a new line. The main issue here is that we can only use
shortcuts for which the terminal will produce an escape sequence, and
IIRC on Mac this
"Meta" is "Alt" on many keyboards.
Line editing support is derived from JLine 3.
___________
-Robert
On 12/8/18 11:47 AM, Jan Lahoda wrote:
On 8.12.2018 20:39, Robert Field wrote:
Thanks for updating.
Goo
on-trivial changes as well.
terminal/impl/jna/win/Kernel32.java -- short doc of the Windows change
Will do.
Thanks!
Jan
Review of JShell tool and test code in separate email.
-Robert
On 11/29/18 1:06 PM, Jan Lahoda wrote:
Hi,
I'd like to update the internal JLine used by JShell and jj
ppet -- thus introducing more
inconsistency.
Ok. This was meant more as a backup in case there's no reasonable
shortcut we could use to add new lines.
Thanks for the comments!
Jan
Thanks,
Robert
On 12/8/18 7:21 AM, Jan Lahoda wrote:
Hi,
I've updated the patch to reflect the comments so
The only difference between the .01 and .01a patches is the way they
allow to add new lines into the multi-line snippets. Other changes are
the same.
Any feedback on this is welcome.
Thanks!
Jan
On 5.12.2018 18:18, Jan Lahoda wrote:
Hi Robert,
On 4.12.2018 23:59, Robert Field wrote:
I saw no iss
://cr.openjdk.java.net/~jlahoda/8214491/webrev.delta.02.03/
Thanks for the comments and for the text! Any feedback is welcome.
Thanks,
Jan
Robert
On December 9, 2018 6:36:26 AM Jan Lahoda wrote:
Hi Robert,
On 9.12.2018 02:40, Robert Field wrote:
OK, here is my thinking on a /help keys
o add these to failing tests and/or address the
issue before push.
Thanks,
-Sundar
On 10/12/18, 4:15 AM, Jan Lahoda wrote:
On 9.12.2018 16:40, Robert Field wrote:
Ok. Go ahead and incorporate the text. I'll make a separate bug to sync
the representation of keys in the other help entries.
An u
method etc. don't
seem to work.
Thanks,
-Sundar
On 10/12/18, 3:09 PM, Jan Lahoda wrote:
Hi Sundar,
Thanks for finding the problem! I was running tier1-3 tests, but seems
these are not there.
Seems the problem is how JLine(3) handles "dumb" terminals, it
probably does not affect inter
27 matches
Mail list logo
