RFR: 8232209: Update double-conversion license file to version 3.1.5

Please review this trivial patch to update the version number in the double-conversion license file. JBS: https://bugs.openjdk.java.net/browse/JDK-8232209 Webrev: http://cr.openjdk.java.net/~hannesw/8232209/webrev.00/ Thanks, Hannes

Re: RFR: 8230709: Array index out of bounds in ES6 mode

Am 09.09.2019 um 16:50 schrieb Attila Szegedi : > > +1. Ugh. I guess our default lexical context stack is 16 deep. > It is indeed :) Thanks for reviewing. Hannes >> On 2019. Sep 9., at 16:38, Hannes Wallnöfer >> wrote: >> >> Please review this off-by-one

RFR: 8230766: Changed message in IllegalMonitorStateException

Please review this fix for a test failing because of a changed exception message in java.lang.Object.wait(): JBS: https://bugs.openjdk.java.net/browse/JDK-8230766 Webrev: http://cr.openjdk.java.net/~hannesw/8230766/webrev.00/ Thanks, Hannes

RFR: 8230709: Array index out of bounds in ES6 mode

Please review this off-by-one array index fix that was recently reported on this list: JBS: https://bugs.openjdk.java.net/browse/JDK-8230709 Webrev: http://cr.openjdk.java.net/~hannesw/8230709/webrev.00/ Thanks, Hannes

Re: ArrayIndexOutOfBoundsException in LexicalContext.java#inUnprotectedSwitchContext

Hi Anton, Thanks for the report - that’s a really interesting one! I’ll file a bug for it, but given that Nashorn is deprecated and this is part of the incomplete ES6 support I don’t think it will be deemed worthy of a 8u backport. Hannes > Am 09.08.2019 um 11:16 schrieb Anton Mitrofanov :

RFR: Update double-conversion to version 3.1.5

Please review the update of the Java port of the V8 double conversion library to the most recent release. JBS: https://bugs.openjdk.java.net/browse/JDK-8227391 Webrev: http://cr.openjdk.java.net/~hannesw/8227391/webrev.00/ Although the commit log between the two releases is very long [1] (I’m

Re: Nashorn on the module-path

Hi Christian, I cloned and tried your example project. When I run the project, I get one successful and one aborted tests in both cases: Module path output: └─ JUnit Jupiter ✔ └─ CheckTests ✔ ├─ test() ✔ └─ emitStringRepresentationOfTestModule() ■ Assumption failed: module

RFR: 8222528: Fix javadoc headers in Nashorn sources

Please review: Issue: https://bugs.openjdk.java.net/browse/JDK-8222528 Webrev: http://cr.openjdk.java.net/~hannesw/8222528/webrev.00/ Javadoc now requires that headings be consistent with accessibility guidelines. Since h1 is usually the page heading user documentation headings should start

RFR: 8214795: Add safety check to dynalink inner class lookup

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8214795 Webrev: http://cr.openjdk.java.net/~hannesw/8214795/webrev.00/ This is to make sure we use the right inner classes regardless of the order of classes returned by Class.getClasses(). Thanks, Hannes

Re: RFR: 8210943: Hiding of inner classes not resolved properly

.com/javase/10/docs/api/java/lang/Class.html#getClasses() >> >> Do we need a check using Class.getDeclaringClass() or do I something here? >> >> Thanks, >> -Sundar >> >> On 30/11/18, 4:44 PM, Attila Szegedi wrote: >>> +1. Thanks for fix

Re: RFR: 8214525: Bit rot in Nashorn Ant script

Am 30.11.2018 um 14:04 schrieb Jim Laskey : > > +1 > > too bad you have to hardcode the version 12 docs aren’t in their final place, and who knows if they’ll change the URL scheme again :) Thanks! Hannes >> On Nov 30, 2018, at 6:58 AM, Hannes Wallnöfer >> wro

RFR: 8214525: Bit rot in Nashorn Ant script

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8214525 Webrev: http://cr.openjdk.java.net/~hannesw/8214525/webrev.00/ This enables gzip encoding for the YUI download and switches javadoc tasks to modularized version of -linkoffline. Thanks, Hannes

RFR: 8210943: Hiding of inner classes not resolved properly

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8210943 Webrev: http://cr.openjdk.java.net/~hannesw/8210943/webrev.00/ AccessibleMembersLookup#lookupAccessibleMembers adds all nested classes returned by Class.getClasses(), but these may contain inherited classes that are shadowed

Re: casting typed array to java byte[] is it possible?

Hi Paulo, Java.to() would be the way to go, but as you found out it does not support typed arrays. What works is to convert the typed array to an ordinary JS array and convert to byte[] from there: Java.to(Array.prototype.slice.call(arr), 'byte[]‘); That’s obviously not very elegant nor

Re: RFR 8204492 Add deprecation annotation to Nashorn APIs and warning to nashorn, jjs

Looks good. Hannes > Am 27.06.2018 um 06:19 schrieb Sundararajan Athijegannathan > : > > Forgot to CC build-dev for makefile changes. > > -Sundar > > On 27/06/18, 9:46 AM, Sundararajan Athijegannathan wrote: >> Please review. >> >> Bug https://bugs.openjdk.java.net/browse/JDK-8204492 >>

Re: RFR: 8203814: javac --release=8 \"cannot find symbol\" for NashornException.getEcmaError()

more tweaks that turned out to be needed.) > > Jan > > On 15.6.2018 16:52, Hannes Wallnöfer wrote: >> Thanks for helping out with this, Jan. >> >> Unfortunately I found another change that was backported to 8u102 that >> changes the signatures of ScriptUtil

Re: RFR: 8203814: javac --release=8 \"cannot find symbol\" for NashornException.getEcmaError()

Thanks for helping out with this, Jan. Unfortunately I found another change that was backported to 8u102 that changes the signatures of ScriptUtils makeSynchronizedFunction(…) and wrap(…) methods (again). https://bugs.openjdk.java.net/browse/JDK-8148379 I’m sorry about this, I should have

RFR: 8204290: Add check to limit number of capture groups

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8204290 Webrev: http://cr.openjdk.java.net/~hannesw/8204290/webrev/ This (like the previous RFR) is another backport from jruby/joni. Thanks, Hannes

RFR: 8204288: Matching the end of a string followed by an empty greedy regex and a word boundary fails

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8204288 Webrev: http://cr.openjdk.java.net/~hannesw/8204288/webrev/ Thanks, Hannes

Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

Hi Jan, Works as expected with jjs now. Thanks, Hannes > Am 30.05.2018 um 17:06 schrieb Jan Lahoda : > > Hi, > > An updated webrev is here: > http://cr.openjdk.java.net/~jlahoda/8203827/webrev.01/complete/ > > A webrev showing changes from the previous revision is here: >

Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

Hi Jan, Nashorn changes look good. I noticed one slight change of behaviour in jjs. When I enter „java.m“ and hit the tab key, it autocompletes to „java.math “, adding a space character at the end. This is a bit inconvenient, and the old version of jline didn’t do that. Hannes > Am

RFR: 8200716: Object propertyIsEnumerable buggy behavior on short integer-string key

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8200716 Webrev: http://cr.openjdk.java.net/~hannesw/8200716/webrev/ Thanks, Hannes

Re: Longs aren't numbers in Java 8u162

Hi Ryan, Yes, this change was intentional. We were aware at the time that it would cause some problems, but on the other hand treating longs as numbers clashed with the ECMA spec and caused silent loss of precision. In most cases there should be simple workarounds, like using the unary +

RFR: 8198816: AbstractScriptEngine.getScriptContext creation of SimpleScriptContext is inefficient

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8198816 Webrev: http://cr.openjdk.java.net/~hannesw/8198816/webrev/ Thanks, Hannes

RFR: 8201466: Nashorn: defineProperty setters/getters on prototype object ignored with numeric property names

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8201466 Webrev: http://cr.openjdk.java.net/~hannesw/8201466/webrev/ Thanks, Hannes

Re: Cast/boxing/unboxing of numbers Java 9

> Firstly, thanks for the quick answer. > I tried some parameters however did not work, I suppose I miss typed > something. > Disabling optimistic-types will work just like JDK 8 or may have some other > side effect ? > > > Em ter, 27 de mar de 2018 às 12:51, Hannes Wallnöfer

Re: Cast/boxing/unboxing of numbers Java 9

Hi Paulo, What you are observing is a side effect of the optimistic-types feature, which was shipped with JDK 8u, but only became enabled by default with JDK 9. It is unfortunate that this affects observable behaviour in this case, but conversion between JavaScript and Java types is quite

Re: RFR 8200215: 17th loop of "let foo = ''"; throws ReferenceError

+1 Hannes > Am 26.03.2018 um 15:27 schrieb Sundararajan Athijegannathan > <sundararajan.athijegannat...@oracle.com>: > > Updated: http://cr.openjdk.java.net/~sundar/8200215/webrev.01/ > > Please review. > > -Sundar > > On 26/03/18, 6:03 PM

Re: RFR 8200215: 17th loop of "let foo = ''"; throws ReferenceError

The new ScriptObject.declareAndSet method is almost identical, so the existing one could be rewritten to make use of the new one. Otherwise looks good. Hannes > Am 26.03.2018 um 14:00 schrieb Sundararajan Athijegannathan > : > > Please review

RFR: 8199869: Missing copyright headers in nashorn source code

Please review (trivial change, two copyright headers added): Bug: https://bugs.openjdk.java.net/browse/JDK-8199869 Webrev: http://cr.openjdk.java.net/~hannesw/8199869/webrev/ Thanks, Hannes

RFR: 8199443: Nashorn multithread bottleneck with "use strict"

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8199443 Webrev: http://cr.openjdk.java.net/~hannesw/8199443/webrev/ If we make sure the property maps for strict functions and arguments are set up correctly (they weren’t before) we can skip setting the property in

RFR: 8199236: Nashorn uses deprecated HTML tags in Javadoc

Please review 8199236: Nashorn uses deprecated HTML tags in Javadoc: Bug: https://bugs.openjdk.java.net/browse/JDK-8199236 Webrev: http://cr.openjdk.java.net/~hannesw/8199236/webrev/ Thanks, Hannes

Re: Da Capo: JSON "clear text" signatures

super interface. > The existing Nashorn method (after upgrade to match ES better) moved to the > Java layer would probably be just fine. > > Anders > >> -Sundar >> On 29/01/18, 7:45 PM, Anders Rundgren wrote: >>> On 2018-01-29 14:52, Hannes Wallnöfer wrote: &

Re: Da Capo: JSON "clear text" signatures

Hi Anders, I think I lack the context required to understand what you’re asking for. Can you explain how transmitting numbers/doubles in JSON should work and how the static method you’re asking for would enable this? Also, is there a document somewhere describing the IETF standardization work

Re: RFR: 8147614: add jjs test for -t option

+1 Hannes > Am 23.01.2018 um 07:34 schrieb Priya Lakshmi Muthuswamy > : > > Hi, > > Kindly review JDK-8147614: add jjs test for -t option > > JBS: https://bugs.openjdk.java.net/browse/JDK-8147614 > webrev:

Re: RFR 8195829 Parsing a nameless ES6 class results in a thrown NullPointerException.

+1 Hannes > Am 22.01.2018 um 15:44 schrieb Sundararajan Athijegannathan > : > > Please review. > > Webrev: http://cr.openjdk.java.net/~sundar/8195829/webrev.00/index.html > Bug: https://bugs.openjdk.java.net/browse/JDK-8195829 > > Thanks, > -Sundar

Re: ES6 and JavaImporter

Brad, I as I wrote in my last reply to this list, ES6 support is quite incomplete in Nashorn. However, that doesn’t really explain this error. I’m looking into it and will file a bug. Hannes > Am 19.01.2018 um 04:06 schrieb Brad Grier : > > Hello, > > I wanted to

Re: ES6 from Java, using Nashorn

Hi Olivier, Support for ECMAScript 6 is quite incomplete in Nashorn unfortunately. We only support a small set of ES6 features in JDK 9: • Template strings • let, const, and block scope • Iterators and for..of loops • Map, Set, WeakMap, and WeakSet •

RFR: 8195123: Very large regressions in Octane benchmarks using 10-b39

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8195123 Webrev: http://cr.openjdk.java.net/~hannesw/8195123/webrev.00/ This undoes the recent fix for JDK-8193567 (Attila, in case you’re reading, I should have taken your doubts more serously) and replaces it with a different fix.

Re: RFR [11]: 8194985: JavaAdapterBytecodeGenerator passes invalid type descriptor to ASM

ust substitute L anymore for > anything that’s not a known primitive type name. > > Attila. > >> On 2018. Jan 12., at 11:08, Sundararajan Athijegannathan >> <sundararajan.athijegannat...@oracle.com> wrote: >> >> +1 >> >> -Sundar >> >

RFR [11]: 8194985: JavaAdapterBytecodeGenerator passes invalid type descriptor to ASM

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8194985 Webrev: http://cr.openjdk.java.net/~hannesw/8194985/webrev.00/ Thanks, Hannes

Re: RFR:8157251:BeanLinker relinks array length operations for array types

Priya, The problem with your solution that using an object array invocation with a primitive array will throw a ClassCastException as it passes the isArray guard. On the other hand, the problem with instanceof validation in Attila’s snippet is that it uses the concrete callsite type (e.g.

Re: RFR:8157251:BeanLinker relinks array length operations for array types

+1 Hannes > Am 09.01.2018 um 14:23 schrieb Jim Laskey (Oracle) : > > +1 > > >> On Jan 9, 2018, at 3:00 AM, Priya Lakshmi Muthuswamy >> wrote: >> >> Hi, >> >> Please review JDK-8157251 : BeanLinker relinks array length

Re: RFR: 8193567: Conversion of comparison nodes affects local slots in optimistic continuation

t terrible expression in the test, but if you > have a quick explanation… > > Thanks, > Attila. > >> On Dec 21, 2017, at 4:36 PM, Hannes Wallnöfer <hannes.wallnoe...@oracle.com> >> wrote: >> >> Please review: >> >> Bug: https://bugs.open

Re: Review request for JDK-8193295: Remove no longer used COMMALEFT

Interesting. I bet the answer is in the commits from before we went open source. +1 I assume this is for JDK 11? Hannes > Am 21.12.2017 um 19:20 schrieb Attila Szegedi : > > Please review JDK-8193295 "Remove no longer used COMMALEFT" at >

RFR: 8193567: Conversion of comparison nodes affects local slots in optimistic continuation

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8193567 Webrev: http://cr.openjdk.java.net/~hannesw/8193567/webrev.00/ I’ve tried finding a smaller fix like just tagging the child nodes of all comparisons as non-optimistic, but that didn't fix the problem as those nodes could

Re: RFR 8193779: Fix copyright header in nashorn builtin scripts

+1 Hannes > Am 19.12.2017 um 11:38 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8193799 > Webrev: http://cr.openjdk.java.net/~sundar/8193799/webrev.00/ > > Thanks, > -Sundar >

Re: Changes in Java 9

nes > Am 06.12.2017 um 22:30 schrieb Nils Kilden-Pedersen <nil...@gmail.com>: > > Hannes, > > I've sent an email with zip file attachment. > > Just letting you know in a separate email, in case it ends up being blocked. > > Nils > > On Wed, Dec 6, 201

Re: Review request for JDK-8193371: Use Dynalink REMOVE operation in Nashorn

Nice work indeed. +1 Hannes > Am 14.12.2017 um 12:42 schrieb Attila Szegedi : > > Please review JDK-8193371 "Use Dynalink REMOVE operation in Nashorn" at > for > >

RFR: 8193508: Expressions in split literals must never be optimistic

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8193508 Webrev: http://cr.openjdk.java.net/~hannesw/8193508/webrev.00/ The actual fix is quite simple: stop visiting when we encounter a split object or array literal in OptimisticTypesCalculator. There are a few non-essential

Re: RFR:8191301:JavaImporter fails to resolve imported elements within functions, that contain too many statements

+1, and I like the fact that the patch has become smaller. Hannes > Am 12.12.2017 um 13:32 schrieb Priya Lakshmi Muthuswamy > : > > Hi, > > Kindly review. I have modified the fix to work with multiple with scopes. > > webrev :

Re: Any news from JDK-8151981 in Java8 ?

ink the first step is to understand what is going wrong there. Without a better understanding of the problem it is very hard to provide provide any help. Hannes > Rémi > > - Mail original ----- >> De: "Hannes Wallnöfer" <hannes.wallnoe...@oracle.com> >> À: "João

Re: RFR: 8069338: Implement sharedScopeCall for optimistic types

stem property? > > -Sundar > > On 12/12/17, 5:51 PM, Hannes Wallnöfer wrote: >> Thanks for the review, Attila. >> >> I’ve uploaded a new webrev with your suggested changes (including making >> ScriptObject.getProto(int) accept 0 argument and refactoring GET_PRO

Re: Any news from JDK-8151981 in Java8 ?

Hi João, this functionality is part of java.lang.invoke package, not Nashorn, so we can’t help you here. The best place to ask about this would be the core-libs-dev mailing list. Regards, Hannes > Am 11.12.2017 um 23:07 schrieb João Paulo Varandas : > > Hi guys! >

Re: Review request for JDK-8193298: Don't run javadoc with test.single

+1 Hannes > Am 10.12.2017 um 17:26 schrieb Attila Szegedi : > > Please review JDK-8193298 "Don't run javadoc with test.single" at > for > > > Thanks, > Attila.

Re: Review request for JDK-8191905: Add a REMOVE value to jdk.dynalink.StandardOperation

+1 Hannes > Am 08.12.2017 um 12:13 schrieb Attila Szegedi : > > Please review JDK-8191905 "Add a REMOVE value to > jdk.dynalink.StandardOperation" at > for > > >

Re: RFR: 8069338: Implement sharedScopeCall for optimistic types

edScopeCall or > UnwarrantedOptimismException; it’s more typesafe than writing type > descriptors as strings. > > 3. So, UOE.hasPrimitiveReturnValue was unused, I take it? > > 3. In getStaticSignature you have another occurrence of number 3 that you can > replace with FIXE

Re: RFR:JDK-8193137:Nashorn crashes when given an empty script file

+1 Hannes > Am 08.12.2017 um 10:26 schrieb Priya Lakshmi Muthuswamy > : > > Thanks Sundar. I have modified the test. > > updated webrev : http://cr.openjdk.java.net/~pmuthuswamy/8193137/webrev.01/ > > Thanks, > Priya > On 12/8/2017 2:40 PM, Sundararajan

Re: RFR: 8134516(Move getInvokeByName and getDynamicInvoker methods from Global to Context)

I have some doubts about whether this is worth it. The idea was to be able to use these internal callsites between various globals without relinking. But since built-in prototypes in different globals have different property maps that doesn’t really happen. That matches your observation that

RFR: 8069338: Implement sharedScopeCall for optimistic types

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8069338 Webrev: http://cr.openjdk.java.net/~hannesw/8069338/webrev.00/ This implements shared scope calls for optimistic vars/calls. I followed Attila’s blueprint in the bug description to the last detail - thanks for figuring it

Re: Review request for JDK-8192970: Element getters/setters with fixed key fail to link properly

D'oh! I blindly clicked on that links of course :) > Am 04.12.2017 um 17:05 schrieb Attila Szegedi <szege...@gmail.com>: > > I know, it’s subtle; that’s why I decided to describe it in detail :-) > >> On 2017. Dec 4., at 16:36, Hannes Wallnöfer <hannes.walln

Re: Review request for JDK-8192970: Element getters/setters with fixed key fail to link properly

Took me some time to spot the difference in behaviour (adaptation of method type in Binder)! +1 Hannes > Am 04.12.2017 um 13:40 schrieb Attila Szegedi : > > Please review JDK-8192970 "Element getters/setters with fixed key fail to > link properly" at

Re: Changes in Java 9

Hi Nils, Are you just evaluating the script files you linked in your first message, or trying to do some further processing? Using the jjs tool from JDK 9.0.1 I see no errors running both versions of CoffeeScript. Hannes > Am 03.12.2017 um 21:08 schrieb Nils Kilden-Pedersen

Re: RFR: 8191891: Update minumum Ant version in Nashorn build.xml

anything. Hannes > > -Sundar > > On 28/11/17, 7:56 PM, Hannes Wallnöfer wrote: >> Please review: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8191891 >> Webrev: http://cr.openjdk.java.net/~hannesw/8191891/webrev.00/ >> >> Thanks, >> Hannes

RFR: 8191891: Update minumum Ant version in Nashorn build.xml

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8191891 Webrev: http://cr.openjdk.java.net/~hannesw/8191891/webrev.00/ Thanks, Hannes

RFR: 8059835: Optimistic splitting doesn't work with let and const

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8059835 Webrev: http://cr.openjdk.java.net/~hannesw/8059835/webrev.00/ Thanks, Hannes

Re: Review request for JDK-8191878: Reduce code duplication in BeanLinker

Hi Attila, > Am 26.11.2017 um 19:51 schrieb Attila Szegedi : > > I’m able to spend some free time again on OpenJDK development, and one thing > I have on my plate is adding a REMOVE operation to Dynalink. > great! > This CR however, is not yet it: that will require a CCC

Re: RFR 8135178: importPackage not working even with load "Mozilla compatibility script"

+1 Hannes > Am 27.11.2017 um 11:24 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8135178 > Webrev: http://cr.openjdk.java.net/~sundar/8135178/webrev.00/ > > Thanks, > -Sundar

Re: RFR: 8191819: String.prototype.match should follow ES6 specification

Sorry, the test in the first webrev uses replace() instead of match(), which already works as expected. New webrev with correct test is here: http://cr.openjdk.java.net/~hannesw/8191819/webrev.01/ Hannes > Am 23.11.2017 um 14:18 schrieb Hannes Wallnöfer > <hannes.wallnoe...@o

RFR: 8191819: String.prototype.match should follow ES6 specification

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8191819 Webrev: http://cr.openjdk.java.net/~hannesw/8191819/webrev/ Thanks, Hannes

Re: RFR 8191810: jjs should avoid hard coded javadoc base url for shift-tab documentation feature

+1 Hannes > Am 23.11.2017 um 09:52 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191810 > Webrev: http://cr.openjdk.java.net/~sundar/8191810/webrev.00/ > > Thanks, > -Sundar

Re: RFR 8191771: nashorn ant makefile uses javadoc -link which may fail

+1 Hannes > Am 22.11.2017 um 17:43 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191771 > Webrev: http://cr.openjdk.java.net/~sundar/8191771/webrev.00/ > > Thanks, > -Sundar

Re: RFR 8191468: jdk.scripting.nashorn.shell (jjs) module should use optional dependency for java.compiler module

Looks good! Hannes > Am 17.11.2017 um 07:30 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8191468 > Webrev: http://cr.openjdk.java.net/~sundar/8191468/webrev.00/index.html > > Thanks, >

Re: RFR 8068741: javax.script.ScriptEngineFactory.getMethodCallSyntax() spec allows null passed as an object

+1 Hannes > Am 15.11.2017 um 18:05 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8068741 > Webrev: http://cr.openjdk.java.net/~sundar/8068741/webrev.00/index.html > > Thanks, > -Sundar

RFR: 8191133: Ant task to fetch underscore.js requires gzip decoding option

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8191133 Webrev: http://cr.openjdk.java.net/~hannesw/8191133/webrev/ Thanks, Hannes

RFR: 8185119: Uninitialized const when using multiple threads

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8185119 Webrev: http://cr.openjdk.java.net/~hannesw/8185119/webrev/ Thanks, Hannes

RFR: 8191131: Nashorn test comparator breaks comparator contract

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8191131 Webrev: http://cr.openjdk.java.net/~hannesw/8191131/webrev/ Thanks, Hannes

RFR: 8190427 : Test for JDK-8165198 fails intermittently because of GC

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8190427 Webrev: http://cr.openjdk.java.net/~hannesw/8190427/webrev.02/ This started as simple bug fix but turned into a full refactoring of the code that manages property switch points. However, I do think it is actually the only

Re: RFR 8190795: jjs should show javadoc for java methods on shift-tab

Looks good! Hannes > Am 06.11.2017 um 15:37 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8190795 > Webrev: http://cr.openjdk.java.net/~sundar/8190795/webrev.00/ > > Piggybacking

Re: RFR 8190698: jjs tool of jdk.scripting.nashorn.shell module should not statically depend on java.desktop

+1 Hannes > Am 03.11.2017 um 10:10 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8190698 > Webrev: http://cr.openjdk.java.net/~sundar/8190698/webrev.00 > > Thanks, > -Sundar

Re: RFR:JDK-8186807:JSObject gets ScriptFunction when ScriptObjectMirror is expected

+1 Hannes > Am 03.11.2017 um 13:27 schrieb Sundararajan Athijegannathan > : > > +1 > > -Sundar > > On 03/11/17, 5:15 PM, Priya Lakshmi Muthuswamy wrote: >> Updated the webrev with modified testcase. >> >> webrev:

RFR: 8189617: Remove undocumented --print-mem-usage option

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8189617 Webrev: http://cr.openjdk.java.net/~hannesw/8189617/webrev.00/ Thanks, Hannes

Re: RFR: 8068513: Adding elements to a javascript 'object' (a map) is slow

ntext property/option - but even a simple nashorn.* system property perhaps? > > +1 other than that > > -Sundar > > On 13/10/17, 7:55 PM, Hannes Wallnöfer wrote: >> I uploaded a new webrev, please review: >> >> http://cr.openjdk.java.net/~hannesw/8068513/webrev

Re: RFR: 8068513: Adding elements to a javascript 'object' (a map) is slow

068513/webrev.01/ > > Thanks, > Hannes > > >> Am 05.09.2017 um 19:57 schrieb Hannes Wallnöfer >> <hannes.wallnoe...@oracle.com>: >> >> Please review 8068513: Adding elements to a javascript 'object' (a map) is >> slow: >> >> Bug:

Re: RFR: 8027302: Identifiers containing unicode escapes are not recognized as reserved words

atch(e) ? > Indeed. I forgot I left this in. Thanks for the review! Hannes > -Sundar > > On 13/10/17, 2:06 PM, Hannes Wallnöfer wrote: >> Please review: >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8027302 >> Webrev: http://cr.openjdk.java.net/~hanne

RFR: 8027302: Identifiers containing unicode escapes are not recognized as reserved words

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8027302 Webrev: http://cr.openjdk.java.net/~hannesw/8027302/webrev.01 ES6 and ES5 require different handling regarding unencoding Unicode escapes in keywords and identifiers. This patch makes handling more compliant and more

Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

Looks good! Hannes > Am 29.09.2017 um 17:37 schrieb Srinivas Dama : > > Hi, > > here is the revised patch > http://cr.openjdk.java.net/~sdama/8147076/webrev.01/ > > Regards, > Srinivas > - Original Message - > From: hannes.wallnoe...@oracle.com > To:

Re: RFR:8147076(LinkerCallSite.ARGLIMIT is used incorrectly)

Hi Srini, a few notes: - Shouldn’t the new test include an invocation with > ARGLIMIT double arguments to test it works? - No need to use Number(1.1), a number with a fractional part will result in a double. - I assume eval() in the test is to force this-object and callee to be sent,

Re: RFR 8180274: Fix links in nashorn documentation

+1 Hannes > Am 29.09.2017 um 06:56 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8180274 > Webrev: http://cr.openjdk.java.net/~sundar/8180274/webrev.00/ > > Thanks, > -Sundar

Re: RFR 8188098: NPE in SimpleTreeVisitorES6 visitor when parsing a tagged template literal

+1, good catch! Hannes > Am 28.09.2017 um 18:38 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8188098 > Webrev: http://cr.openjdk.java.net/~sundar/8188098/webrev.00/ > > Thanks, > -Sundar

Re: RFR 8188082: autoimports.js sample is broken

+1 That tagged literal demo is nifty! Hannes > Am 28.09.2017 um 07:37 schrieb Sundararajan Athijegannathan > : > > Please review. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8188082 > Webrev: http://cr.openjdk.java.net/~sundar/8188082/webrev.00/

RFR: 8186815: Java.from has a bug, when element is ScriptObject

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8186815 Webrev: http://cr.openjdk.java.net/~hannesw/8186815/webrev/ Thanks, Hannes

Re: RFR 8188023: Avoid -source and -target javac options in nashorn ant compilation

+1 Hannes > Am 27.09.2017 um 14:07 schrieb Jim Laskey (Oracle) : > > +1 > >> On Sep 27, 2017, at 8:59 AM, Sundararajan Athijegannathan >> wrote: >> >> Please review. >> >> Bug:

Re: RFR:8133623:JDK-8055034.js and JDK-8130127.js fail in nashorn nightly

+1 Hannes > Am 27.09.2017 um 08:17 schrieb Priya Lakshmi Muthuswamy > : > > Hi, > > --patch-module actually works and added it to back to the testcase. > > webrev : http://cr.openjdk.java.net/~pmuthuswamy/8133623/webrev.01/ > > Thanks, > Priya > > On

RFR: 8187962: Optimistic types ignore JavaAdapter return types

Please review: Bug: https://bugs.openjdk.java.net/browse/JDK-8187962 Webrev: http://cr.openjdk.java.net/~hannesw/8187962/webrev/ Thanks, Hannes

Re: RFR 8187965: dynalink samples under $jdk10/src/sample/nashorn/dynalink are broken

+1 Hannes > Am 26.09.2017 um 16:41 schrieb Jim Laskey (Oracle) : > > +1 nicer too > > >> On Sep 26, 2017, at 10:58 AM, Sundararajan Athijegannathan >> wrote: >> >> Please review. >> >> Bug:

Re: RFR: 8185257(Nashorn AST is missing nodes when a for-loop contains a VariableDeclarationList)

t; -Original Message- > From: Hannes Wallnöfer > Sent: Wednesday, September 13, 2017 1:49 AM > To: Srinivas Dama > Cc: Nashorn-dev > Subject: Re: RFR: 8185257(Nashorn AST is missing nodes when a for-loop > contains a VariableDeclarationList) > > +1 > > Hannes

Re: RFR 8187934: dropping a shebang script in src/sample/nashorn directory results in test failure

+1 Hannes > Am 25.09.2017 um 16:28 schrieb Jim Laskey (Oracle) : > > +1 > >> On Sep 25, 2017, at 11:15 AM, Sundararajan Athijegannathan >> wrote: >> >> Please review. >> >> Bug:

Re: RFR:8186011(Fix samples/java_completion.js and samples/disassemble.js)

+1 Hannes > Am 25.09.2017 um 12:49 schrieb Srinivas Dama : > > Hi, > Please review migrated patch to jdk10/master repo. > http://cr.openjdk.java.net/~sdama/8186011/webrev.01/ > > Regards, > Srinivas > - Original Message - > From: hannes.wallnoe...@oracle.com >

Re: RFR:8133623:JDK-8055034.js and JDK-8130127.js fail in nashorn nightly

+1 Hannes > Am 25.09.2017 um 07:47 schrieb Priya Lakshmi Muthuswamy > : > > Hi, > > Please review JDK-8133623 : JDK-8055034.js and JDK-8130127.js fail in nashorn > nightly. > > JDK-8130127.js was already fixed. > This RFR is for JDK-8055034.js. > >

  1   2   3   >