Re: [Nbd] [PATCH 5/5] nbd: add multi-connection support

2016-09-12 Thread Josef Bacik
On 09/10/2016 03:43 AM, Christoph Hellwig wrote: > Hi Josef, > > I haven't read the full path as I'm a bit in a hurry, but is there > a good reason to not simply have a socket per-hw_ctx and store it in > the hw_ctx private data instead of using the index in the nbd_cmd > structure? > No good

Re: [Nbd] [PATCH 5/5] nbd: add multi-connection support

2016-09-10 Thread Christoph Hellwig
Hi Josef, I haven't read the full path as I'm a bit in a hurry, but is there a good reason to not simply have a socket per-hw_ctx and store it in the hw_ctx private data instead of using the index in the nbd_cmd structure?

[Nbd] [PATCH 5/5] nbd: add multi-connection support

2016-09-08 Thread Josef Bacik
NBD can become contended on its single connection. We have to serialize all writes and we can only process one read response at a time. Fix this by allowing userspace to provide multiple connections to a single nbd device. This coupled with block-mq drastically increases performance in

[Nbd] [PATCH 5/5] nbd: add multi-connection support

2016-09-08 Thread Josef Bacik
NBD can become contended on its single connection. We have to serialize all writes and we can only process one read response at a time. Fix this by allowing userspace to provide multiple connections to a single nbd device. This coupled with block-mq drastically increases performance in