On 04/14/2016 03:12 PM, Alex Bligh wrote:
Sorry for reviving an old thread, but just a heads-up to implementors:
> Improve the documentation as per the mailing list discussion.
> Here's what we decided (broadly).
>
> * One side MAY drop the connection if the other end violates a
> MUST conditi
Hi Alex,
On Thu, Oct 13, 2016 at 09:47:53AM +0100, Alex Bligh wrote:
> Wouter,
>
> > On 12 Oct 2016, at 19:40, Wouter Verhelst wrote:
> >
> > While stuck in an airport on a 9-hour layover two days ago, I (finally)
> > spent some time working on a STARTTLS implementation for the reference
> > nb
On Thu, Oct 13, 2016 at 05:36:18PM -0500, Eric Blake wrote:
> On 10/12/2016 01:40 PM, Wouter Verhelst wrote:
> > Hi,
> >
> > While stuck in an airport on a 9-hour layover two days ago, I (finally)
> > spent some time working on a STARTTLS implementation for the reference
> > nbd-server implementat
On Thu, Oct 13, 2016 at 05:33:18PM -0500, Eric Blake wrote:
> I'm getting this failure when trying to build NBD, as part of
> 'autoreconf -vfi':
>
> configure.ac:248: error: required file 'systemd/n...@.service.sh.in' not
> found
That's why we have autogen.sh ;-)
--
< ron> I mean, the main *pra
On Fri, Oct 14, 2016 at 12:59:54PM -0500, Eric Blake wrote:
> On 04/14/2016 03:12 PM, Alex Bligh wrote:
>
> Sorry for reviving an old thread, but just a heads-up to implementors:
>
> > Improve the documentation as per the mailing list discussion.
> > Here's what we decided (broadly).
> >
> > * O
On 10/14/2016 01:30 PM, Wouter Verhelst wrote:
>>>
>>> It's not been tested yet, however, because the client side hasn't been
>>> done yet.
>>
>> It has at least one bug, from what I've quickly seen. You HAVE to parse
>> off length and any data the client sends before you can try to read the
>> ne
On 10/14/2016 01:32 PM, Wouter Verhelst wrote:
> On Thu, Oct 13, 2016 at 05:33:18PM -0500, Eric Blake wrote:
>> I'm getting this failure when trying to build NBD, as part of
>> 'autoreconf -vfi':
>>
>> configure.ac:248: error: required file 'systemd/n...@.service.sh.in' not
>> found
>
> That's why
On 10/14/2016 02:23 PM, Eric Blake wrote:
>> static void socket_read(CLIENT* client, void *buf, size_t len) {
>> +void *tmp = NULL;
>> +if (!buf) {
>> +/* FIXME: Enforce maximum bound on client-provided len? */
>> +tmp = buf = malloc(len);
>> +}
>> g_asser
Starting from a fresh git checkout, running ./autogen.sh gives a
couple of warnings on my Fedora 24 build tools, one from libtool:
libtoolize: Consider adding '-I support' to ACLOCAL_AMFLAGS in Makefile.am.
and one from automake:
tests/run/Makefile.am:4: warning: source file '$(top_srcdir)/clise
Any client attempting to probe support for a new option, such as
NBD_OPT_STARTTLS or NBD_OPT_GO, with plans to do a graceful
fallback to older methods, will fail in its attempt if the server
does not ignore the length field and potential payload of the
unrecognized (or rejected) option, because the
On 10/14/2016 04:02 PM, Eric Blake wrote:
> Any client attempting to probe support for a new option, such as
> NBD_OPT_STARTTLS or NBD_OPT_GO, with plans to do a graceful
> fallback to older methods, will fail in its attempt if the server
> does not ignore the length field and potential payload of
On 10/14/2016 04:02 PM, Eric Blake wrote:
> /**
> * Consume data from a socket that we don't want
> *
> - * @param f a file descriptor
> + * @param c the client data stream
> * @param buf a buffer
> * @param len the number of bytes to consume
> * @param bufsiz the size of the buffer
> @
On 10/14/2016 01:18 PM, Wouter Verhelst wrote:
>>> If you want to check it out, just run nbd-server from git master.
>>> Feedback (and/or review) welcome :-)
>>
>> I'm happy to have a detailed look at this later (and indeed
>> do some interoperability testing - I'll see if I can dig out
>> the qem
13 matches
Mail list logo
