hg: jdk8/tl/jdk: 2 new changesets

2013-06-12 Thread weijun . wang
Changeset: 021fdd093cd9 Author:weijun Date: 2013-06-13 09:59 +0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/021fdd093cd9 8014310: JAAS/Krb5LoginModule using des encytypes failure with NPE after JDK-8012679 Reviewed-by: valeriep ! src/share/classes/sun/security/krb5/Config.j

Re: Code Review Request: 8015421: NegativeArraySizeException occurs in ChunkedOutputStream() with Integer.MAX_VALUE

2013-06-12 Thread Kurchi Hazra
Apologies, I had used the wrong subject line - correcting it here for records. On 6/12/2013 11:41 AM, Kurchi Hazra wrote: Right, what I have now should not be really problematic, it will throw an OutOfMemoryError and I pass the test in that case. But I am ok with skipping it too. I'll just pu

Code Review Request: 7169142: CookieHandler does not work with localhost

2013-06-12 Thread Kurchi Hazra
Hi, The problem that this bug points out is that when a cookie is from a localhost and no domain is set, our implementation sets the default domain of the cookie to its uri.getHost() [1], (which is localhost here), and since the domain now does not contain .local, the cookie gets rejected

hg: jdk8/tl/jdk: 8016448: java/util/BitSet/BitSetStreamTest.java no longer compiles, missed by 8015895

2013-06-12 Thread mike . duigou
Changeset: ce8fbca80bbc Author:henryjen Date: 2013-06-12 14:07 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ce8fbca80bbc 8016448: java/util/BitSet/BitSetStreamTest.java no longer compiles, missed by 8015895 Reviewed-by: mduigou ! test/java/util/BitSet/BitSetStreamTest.jav

Re: RFC compliant address selection vs. home made getaddrinfo

2013-06-12 Thread Matthew Hall
On Thu, Jun 13, 2013 at 12:11:34AM +0200, Bernd Eckenfels wrote: > dns(only)-based providers are not the best option for general > purpose resolving because (besides the fact that they will not use > alternative naming methods which are typically used (mDNS, WINS, > Hostsfile)) they also cannot use

Re: RFC compliant address selection vs. home made getaddrinfo

2013-06-12 Thread Bernd Eckenfels
Hello Matthew, Am 13.06.2013, 00:01 Uhr, schrieb Matthew Hall : There is a pre-existing alternative provider, dnsjava: dns(only)-based providers are not the best option for general purpose resolving because (besides the fact that they will not use alternative naming methods which are typic

Re: RFC compliant address selection vs. home made getaddrinfo

2013-06-12 Thread Matthew Hall
On Wed, Jun 12, 2013 at 11:05:00PM +0200, Bernd Eckenfels wrote: > If you think it is not a good idea to fix this, I would vote for an > alternate name service provider which can be selected if rfc > compliant behavior is needed. I agree with the other points. There is a pre-existing alternative

RFC compliant address selection vs. home made getaddrinfo

2013-06-12 Thread Bernd Eckenfels
Hello, I have given a (german) talk about Java and IPv6 at the largest european IPv6 Congress last week in Frankfurt. As part of my preparation for that talk was looking at some of the details of Java IPv6 networking. I have some points to discuss because of that: RFC 3484 defines the def

hg: jdk8/tl/jdk: 8010325: Remove hash32() method and hash32 int field from java.lang.String

2013-06-12 Thread mike . duigou
Changeset: c9f5a2fd7d3d Author:bchristi Date: 2013-06-12 11:11 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c9f5a2fd7d3d 8010325: Remove hash32() method and hash32 int field from java.lang.String Reviewed-by: alanb, mduigou ! src/share/classes/java/lang/String.java ! src/s

Re: Code Review Request: 7051862: CookiePolicy spec conflicts with CookiePolicy.ACCEPT_ORIGINAL_SERVER

2013-06-12 Thread Kurchi Hazra
Right, what I have now should not be really problematic, it will throw an OutOfMemoryError and I pass the test in that case. But I am ok with skipping it too. I'll just push the source code change then. - Kurchi On 6/12/2013 11:37 AM, Chris Hegarty wrote: On 12 Jun 2013, at 19:29, Chris Hegar

Re: Code Review Request: 7051862: CookiePolicy spec conflicts with CookiePolicy.ACCEPT_ORIGINAL_SERVER

2013-06-12 Thread Chris Hegarty
On 12 Jun 2013, at 19:29, Chris Hegarty wrote: > The source change looks fine to me, since our implementation treats the given > chunk length as the complete chunk size ( including header & footer ). > > I would prefer to not add a test, if the test will end up being problematic, > given this

Re: Code Review Request: 7051862: CookiePolicy spec conflicts with CookiePolicy.ACCEPT_ORIGINAL_SERVER

2013-06-12 Thread Chris Hegarty
The source change looks fine to me, since our implementation treats the given chunk length as the complete chunk size ( including header & footer ). I would prefer to not add a test, if the test will end up being problematic, given this is a corner case. -Chris On 12 Jun 2013, at 18:48, Kurchi

Re: Code Review Request: 7051862: CookiePolicy spec conflicts with CookiePolicy.ACCEPT_ORIGINAL_SERVER

2013-06-12 Thread Matthew Hall
Put the relevant part of the test in try-catch. If you get OOME skip / ignore. If you get NASE, then you have a regression. -- Sent from my mobile device. Kurchi Hazra wrote: > > > >Hi, > >In HttpUrlConnection, if the chunk length is set to Integer.MAX_VALUE, >our code was trying to initializ

Re: Code Review Request: 7051862: CookiePolicy spec conflicts with CookiePolicy.ACCEPT_ORIGINAL_SERVER

2013-06-12 Thread Kurchi Hazra
Thanks Matthew! That is what I have currently. - Kurchi On 6/12/2013 11:07 AM, Matthew Hall wrote: Put the relevant part of the test in try-catch. If you get OOME skip / ignore. If you get NASE, then you have a regression.

Code Review Request: 7051862: CookiePolicy spec conflicts with CookiePolicy.ACCEPT_ORIGINAL_SERVER

2013-06-12 Thread Kurchi Hazra
Hi, In HttpUrlConnection, if the chunk length is set to Integer.MAX_VALUE, our code was trying to initialize a buffer of size greater than that, which was resulting in an integer overflow, and consequently a NegativeArraySizeException. This fix ensures that while initializing the internal bu

hg: jdk8/tl/jaxws: 8013021: Rebase 8005432 & 8003542 against the latest jdk8/jaxws; ...

2013-06-12 Thread chris . hegarty
Changeset: 8f2986ff0235 Author:mkos Date: 2013-06-12 14:47 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/8f2986ff0235 8013021: Rebase 8005432 & 8003542 against the latest jdk8/jaxws 8003542: Improve processing of MTOM attachments 8005432: Update access to JAX-WS Reviewed-b

hg: jdk8/tl/jdk: 8016369: java/lang/instrument/RetransformBigClass.sh failing again

2013-06-12 Thread alan . bateman
Changeset: 6df79b7bae6f Author:alanb Date: 2013-06-12 09:44 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6df79b7bae6f 8016369: java/lang/instrument/RetransformBigClass.sh failing again Reviewed-by: sla, sergei ! test/java/lang/instrument/MakeJAR4.sh

hg: jdk8/tl/jdk: 8016370: javadoc warnings, unexpected mostly

2013-06-12 Thread alan . bateman
Changeset: f56b5c243f7c Author:alanb Date: 2013-06-12 08:04 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f56b5c243f7c 8016370: javadoc warnings, unexpected mostly Reviewed-by: martin, jjg ! makefiles/scripts/genExceptions.sh ! src/share/classes/java/nio/Buffer.java ! src/