Hi Arno,
good job, this is a nice addition!
Some remarks/questions (not a full review):
1) The naming of the unix...DefaultProxySelector.c is confusing. Could we
rename it to gnome/../DefaultProxySelector?
2) DefaultProxySelector.java
- style nit: "that list will most of the time" -> "that
Hi Vyom,
thanks for the comments – now I understand the problem. I reworked all three
platforms to check for exceptions and NULL if needed.
Regarding the JNIReleaseString calls: I seem to be on the save sidether. They
are listed as some of the few calls that can be called with a pending
On 12/22/2016 4:08 PM, Zeller, Arno wrote:
Hi Vyom,
thanks you for having a look at my patch!
Regarding your suggestion to call CHECK_NULL_RETURN in
DefaultProxySelector.c:
I guess you mean the Unix variant of DefaultProxySelector.c
Hi Vyom,
thanks you for having a look at my patch!
Regarding your suggestion to call CHECK_NULL_RETURN in DefaultProxySelector.c:
I guess you mean the Unix variant of DefaultProxySelector.c
(src/java.base/unix/native/libnet/DefaultProxySelector.c).
419 if (proxies) {
420 if
