looks good to me.
Thanks,
Vyom
- Original message -From: Aleks Efimov Sent by: "net-dev" To: net-dev Cc:Subject: [teststabilization] RFR: 8225430: Replace wildcard address with loopback or local host in tests - part 14Date: Tue, Aug 6, 2019 8:13 PM
Hi,Please help to review few test fixes
Hello,
Please help to review the change that fixes
java/net/httpclient/SomeTest.java timeout issue:
http://cr.openjdk.java.net/~aefimov/8228508/00
The test now uses the 'com/sun/net/httpclient/EchoHandler.java' test class.
The test fails before the fix on Windows 7 and passes after. No mach5
Hi Aleksei,
Thanks for taking care of these tests!
http://cr.openjdk.java.net/~aefimov/8225430/00/test/jdk/java/net/Socket/NullHost.java
39 svr.bind(new
InetSocketAddress(InetAddress.getLoopbackAddress(), 0));
maybe it would be worth adding a comment just before this line:
On 06/08/2019 17:20, Michael McMahon wrote:
Thanks Daniel. Suggested changes made and new webrev at:
http://cr.openjdk.java.net/~michaelm/8199849/webrev.4/
Thanks Michael. LGTM now!
best regards,
-- daniel
- Michael.
On 06/08/2019, 14:37, Daniel Fuchs wrote:
Hi Michael, Patrick,
BasicA
Thanks Daniel. Suggested changes made and new webrev at:
http://cr.openjdk.java.net/~michaelm/8199849/webrev.4/
- Michael.
On 06/08/2019, 14:37, Daniel Fuchs wrote:
Hi Michael, Patrick,
BasicAuthentication.java:
The two constructors might benefit from a bit of refactoring
allowing them t
Hi,
Please help to review few test fixes which address intermittent
networking failures:
http://cr.openjdk.java.net/~aefimov/8225430/00
JBS:
https://bugs.openjdk.java.net/browse/JDK-8225430
The following tests have been marked with @intermittent keyword:
java/net/DatagramSocket/ReuseAddressTe
Hi Michael, Patrick,
BasicAuthentication.java:
The two constructors might benefit from a bit of refactoring
allowing them to share the code that encode the credentials.
BasicAuthenticator.java:
76 if ("".equals(realm))
I'd suggest using
if (realm.isEmpty())
If
This change went through a couple of rounds of review before, and I got
diverted to something else
at the time. So, just picking it up now.
Bug: https://bugs.openjdk.java.net/browse/JDK-8199849
Webrev: http://cr.openjdk.java.net/~michaelm/8199849/webrev.3/index.html
CSR: https://bugs.openjdk.j
Hi,
Thanks for the feedback, Pavel. I'll make that switch now!
Kind regards,
Patrick
On 06/08/2019 11:31, Pavel Rappo wrote:
May I suggest using org.testng.Assert.assertThrows instead of hand-rolled
try-catch constructs in the test?
On 6 Aug 2019, at 11:12, Patrick Concannon wrote:
Hi,
W
Hi Christoph,
The backport ooks good to me.
best regards,
-- daniel
On 06/08/2019 09:52, Langer, Christoph wrote:
Hi,
please review the jdk11u backport of a fix for test
java/net/httpclient/UnknownBodyLengthTest.java. The test is instable in
jdk11u, too, so it should be backported. The pat
May I suggest using org.testng.Assert.assertThrows instead of hand-rolled
try-catch constructs in the test?
> On 6 Aug 2019, at 11:12, Patrick Concannon
> wrote:
>
> Hi,
>
> Would it be possible to have my fix for JDK-8228970 reviewed?
>
> The fix modifies the read(byte[], int, int) method fr
Hi Christoph,
FWIW the backport looks good to me.
best regards,
-- daniel
On 06/08/2019 09:58, Langer, Christoph wrote:
Hi,
please review the jdk11u backport of another fix for test
java/net/httpclient/UnknownBodyLengthTest.java. The patch did apply
mostly clean but needed some help in the
Hi,
Would it be possible to have my fix for JDK-8228970 reviewed?
The fix modifies the read(byte[], int, int) method from
ResponseSubscribers$HttpResponseInputStream adding further checks for
bad parameters. I've also added an additional test case that ensures
that these checks are being met.
Hi Michael and Daniel,
Thanks for your comments. I made the following changes to B8185898:
- Added checks for URLConnection::getRequestProperties,
::getHeaderField(0), ::getHeaderFieldKey(0)
- Included a test of MessageHeader::print and ::toString. Added a null
check for the requestLine in M
Hi Christoph,
On Tue, 2019-08-06 at 08:58 +, Langer, Christoph wrote:
> Hi,
>
> please review the jdk11u backport of another fix for test
> java/net/httpclient/UnknownBodyLengthTest.java. The patch did apply
> mostly clean but needed some help in the import directives. Now the
> change looks
On 8/6/19 10:58 AM, Langer, Christoph wrote:
> Hi,
>
> please review the jdk11u backport of another fix for test
> java/net/httpclient/UnknownBodyLengthTest.java. The patch did apply mostly
> clean but needed some help in the import directives. Now the change looks
> effectively the same as the
Hi,
please review the jdk11u backport of another fix for test
java/net/httpclient/UnknownBodyLengthTest.java. The patch did apply mostly
clean but needed some help in the import directives. Now the change looks
effectively the same as the original.
Bug: https://bugs.openjdk.java.net/browse/JDK
Hi,
please review the jdk11u backport of a fix for test
java/net/httpclient/UnknownBodyLengthTest.java. The test is instable in jdk11u,
too, so it should be backported. The patch did apply mostly but the changes to
the @run main/othervm directives needed some manual intervention.
Bug: https://b
18 matches
Mail list logo
