On Tue, 15 Sep 2020 15:43:59 GMT, Julia Boes wrote:
>> Replaced the use of ThreadLocalCoders with regular non-caching
>> CharsetEncoder and added a benchmark to confirm that
>> there is no performance impact.
>
> Julia Boes has updated the pull request incrementally with one additional
> commit
On Tue, 15 Sep 2020 09:51:27 GMT, Daniel Fuchs wrote:
>> Julia Boes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fix typo in test and cleanup benchmark
>
> Changes requested by dfuchs (Reviewer).
Updated benchmark results:
before
Be
> Replaced the use of ThreadLocalCoders with regular non-caching CharsetEncoder
> and added a benchmark to confirm that
> there is no performance impact.
Julia Boes has updated the pull request incrementally with one additional
commit since the last revision:
fix typo in test and cleanup benc
On Tue, 15 Sep 2020 09:40:06 GMT, Alan Bateman wrote:
>> test/micro/org/openjdk/bench/java/net/ThreadLocalParseUtil.java line 61:
>>
>>> 59: Class c = Class.forName("sun.net.www.ParseUtil");
>>> 60: MH_DECODE = LOOKUP.findStatic(c, "decode",
>>> methodType(String.class, String.c
On Tue, 15 Sep 2020 09:31:16 GMT, Aleksey Shipilev wrote:
>> Replaced the use of ThreadLocalCoders with regular non-caching
>> CharsetEncoder and added a benchmark to confirm that
>> there is no performance impact.
>
> test/micro/org/openjdk/bench/java/net/ThreadLocalParseUtil.java line 65:
>
>
On Tue, 15 Sep 2020 09:49:36 GMT, Daniel Fuchs wrote:
>> src/java.base/share/classes/sun/net/www/ParseUtil.java line 181:
>>
>>> 179: CharBuffer cb = CharBuffer.allocate(n);
>>> 180: CharsetDecoder dec = UTF_8.INSTANCE.newDecoder()
>>> 181: .onMalformedInput(Codin
On Tue, 15 Sep 2020 08:53:35 GMT, Julia Boes wrote:
> Replaced the use of ThreadLocalCoders with regular non-caching CharsetEncoder
> and added a benchmark to confirm that
> there is no performance impact.
Changes requested by dfuchs (Reviewer).
-
PR: https://git.openjdk.java.net/
On Tue, 15 Sep 2020 09:46:36 GMT, Alan Bateman wrote:
>> Replaced the use of ThreadLocalCoders with regular non-caching
>> CharsetEncoder and added a benchmark to confirm that
>> there is no performance impact.
>
> src/java.base/share/classes/sun/net/www/ParseUtil.java line 181:
>
>> 179:
On Tue, 15 Sep 2020 08:53:35 GMT, Julia Boes wrote:
> Replaced the use of ThreadLocalCoders with regular non-caching CharsetEncoder
> and added a benchmark to confirm that
> there is no performance impact.
Hi Julia,
The code changes look good to me. For the benchmarks, I'll defer to the expert
On Tue, 15 Sep 2020 08:53:35 GMT, Julia Boes wrote:
> Replaced the use of ThreadLocalCoders with regular non-caching CharsetEncoder
> and added a benchmark to confirm that
> there is no performance impact.
src/java.base/share/classes/sun/net/www/ParseUtil.java line 181:
> 179: CharBuff
On Tue, 15 Sep 2020 09:33:40 GMT, Aleksey Shipilev wrote:
>> Replaced the use of ThreadLocalCoders with regular non-caching
>> CharsetEncoder and added a benchmark to confirm that
>> there is no performance impact.
>
> test/micro/org/openjdk/bench/java/net/ThreadLocalParseUtil.java line 61:
>
>
On Tue, 15 Sep 2020 08:53:35 GMT, Julia Boes wrote:
> Replaced the use of ThreadLocalCoders with regular non-caching CharsetEncoder
> and added a benchmark to confirm that
> there is no performance impact.
Drive-by benchmark comments below.
test/micro/org/openjdk/bench/java/net/ThreadLocalPars
Replaced the use of ThreadLocalCoders with regular non-caching CharsetEncoder
and added a benchmark to confirm that
there is no performance impact.
-
Commit messages:
- Replace ThreadLocalCoders and add benchmark
Changes: https://git.openjdk.java.net/jdk/pull/170/files
Webrev: htt
13 matches
Mail list logo
