RFR: 8260366: ExtendedSocketOptions can deadlock in some circumstances

2021-02-16 Thread Jaikiran Pai
Can I please get a review for this change which proposes to fix the issue reported in https://bugs.openjdk.java.net/browse/JDK-8260366? The issue relates to the concurrent classloading of `sun.net.ext.ExtendedSocketOptions` and `jdk.net.ExtendedSocketOptions` leading to a deadlock. This is beca

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v12]

2021-02-16 Thread Andrey Turbanov
> 8080272 Refactor I/O stream copying to use > InputStream.transferTo/readAllBytes and Files.copy Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision: 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo cleanu

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v9]

2021-02-16 Thread Andrey Turbanov
On Tue, 9 Feb 2021 11:40:09 GMT, Philippe Marschall wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo >> fix review comments > > src/ja

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy [v9]

2021-02-16 Thread Andrey Turbanov
On Mon, 8 Feb 2021 21:18:44 GMT, Philippe Marschall wrote: >> Andrey Turbanov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8080272: Refactor I/O stream copying to use java.io.InputStream.transferTo >> fix review comments > > src/ja

Re: RFR: 8080272 Refactor I/O stream copying to use InputStream.transferTo/readAllBytes and Files.copy

2021-02-16 Thread Julia Boes
On Sun, 20 Dec 2020 17:05:21 GMT, Andrey Turbanov wrote: > 8080272 Refactor I/O stream copying to use > InputStream.transferTo/readAllBytes and Files.copy Hi @turbanoff, I'm happy to sponsor but I see two comments by @marschall - have they been addressed? https://github.com/openjdk/jdk/pull/

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-02-16 Thread Jamie Le Tual
On Mon, 18 Jan 2021 09:17:51 GMT, Chris Hegarty wrote: > I think that the changes are mostly good. I would like to try them out on my > local system and our internal buildAndTest system. Chris, were you able to test the patch? Also if anyone has an idea as to the best way to unit test this, l

Re: RFR: JDK-8257235: [PATCH] InetAddress.isReachable: Try to use an IPPROTO_ICMP socket type before attempting RAW_SOCK [v2]

2021-02-16 Thread Jamie Le Tual
On Mon, 18 Jan 2021 08:25:34 GMT, Alan Bateman wrote: >> Jamie Le Tual has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed formatting > > src/java.base/unix/native/libnet/Inet6AddressImpl.c line 713: > >> 711: This usually require

Re: RFR: 8261750: Remove internal class sun.net.www.MimeLauncher

2021-02-16 Thread Julia Boes
On Tue, 16 Feb 2021 10:09:08 GMT, Daniel Fuchs wrote: >> This change removes sun.net.www.MimeLauncher, a package-private class that >> is no longer used. >> >> The sun.net.www package is exported to java.net.http and jdk.jartool. The >> only public access point to a MimeLauncher instance is >

RFR: JDK-8261791: handleSendFailed in SctpChannelImpl.c potential leaks

2021-02-16 Thread Matthias Baesken
In another bug this question from m was answered by Alan Bateman : Btw. while adjusting Java_sun_nio_ch_sctp_SctpChannelImpl_receive0 , I started to wonder what happens to the allocated memory in the same file in handleSendFailed ( if ((addressP = malloc(dataLe

Re: RFR: 8261750: Remove internal class sun.net.www.MimeLauncher

2021-02-16 Thread Daniel Fuchs
On Mon, 15 Feb 2021 18:30:58 GMT, Julia Boes wrote: > This change removes sun.net.www.MimeLauncher, a package-private class that is > no longer used. > > The sun.net.www package is exported to java.net.http and jdk.jartool. The > only public access point to a MimeLauncher instance is > sun.ne

Re: RFR: JDK-8261601: free memory in early return in Java_sun_nio_ch_sctp_SctpChannelImpl_receive0

2021-02-16 Thread Matthias Baesken
On Tue, 16 Feb 2021 08:42:42 GMT, Alan Bateman wrote: > I see this has been integrated but the fix is incomplete. Are you planning to > create a follow-on issue for the issues that I pointed out above? Hi Alan, thanks about your comment to my question about handleSendFailed . I opened a follo

Re: RFR: JDK-8261601: free memory in early return in Java_sun_nio_ch_sctp_SctpChannelImpl_receive0

2021-02-16 Thread Alan Bateman
On Sat, 13 Feb 2021 17:27:47 GMT, Alan Bateman wrote: >> There seems to be an early return in >> Java_sun_nio_ch_sctp_SctpChannelImpl_receive0 that misses freeing memory. >> >> Sonar reports : >> https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=c&open=AXck8Cl0BBG2CXpcnjFu&resolved

Integrated: JDK-8261601: free memory in early return in Java_sun_nio_ch_sctp_SctpChannelImpl_receive0

2021-02-16 Thread Matthias Baesken
On Fri, 12 Feb 2021 08:50:14 GMT, Matthias Baesken wrote: > There seems to be an early return in > Java_sun_nio_ch_sctp_SctpChannelImpl_receive0 that misses freeing memory. > > Sonar reports : > https://sonarcloud.io/project/issues?id=shipilev_jdk&languages=c&open=AXck8Cl0BBG2CXpcnjFu&resolved=