On Tue, 31 May 2022 18:29:30 GMT, Brian Burkhalter wrote:
>> Modify `sun.net.www.MimeTable.findByFileName(String)` to attempt to find the
>> file extension in the entire file name if it is not found in the portion of
>> the name preceding the optional fragment beginning with a hash (`#`).
>
>
1.0.14) ?. If this is not the case then I would like to fix
this build failure.
Thanks,
Vyom
On Wed, 10 Mar 2021 17:32:30 GMT, Jayashree S Kumar
wrote:
>> Issue
>>
>> https://bugs.openjdk.java.net/browse/JDK-8243376
>>
>> Problem
>>
>> The scenario is:
>> - Some specified target hostname resolves to two IP addresses (always the
>> same address pair).
>> - The DNS resolved order
On Thu, 21 Oct 2021 16:47:44 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my changes (and CSR) to drop support for pre JDK
>> 1.4 `DatagramSocketImpl` implementations?
>>
>> These changes propose to drop support for `DatagramSocketImpls` that were
>> compiled with
On Tue, 19 Oct 2021 13:48:24 GMT, Evan Whelan wrote:
>> Hi,
>>
>> Please review my fix for JDK-8274779 which changes how HttpClient and
>> HttpsClient checks for equality when comparing request methods.
>>
>> When `HttpURLConnection.setRequestMethod` is passed `new String("POST")`
>>
On Mon, 11 Oct 2021 09:42:12 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changes (and CSR) to drop support for pre JDK
> 1.4 `DatagramSocketImpl` implementations?
>
> These changes propose to drop support for `DatagramSocketImpls` that were
> compiled with JDK 1.3
On Fri, 17 Sep 2021 08:56:47 GMT, Andrey Turbanov
wrote:
> String.contains was introduced in Java 5.
> Some code in java.base still uses old approach with `String.indexOf` to check
> if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to
On Thu, 29 Jul 2021 10:22:51 GMT, Julia Boes wrote:
> This is a minor change that updates
> `sun.net.httpserver.HttpConnection::toString` to never return null.
>
> Testing: tier 1-3 all clear
Looks good.
-
Marked as reviewed by vtewari (Committer).
PR:
On Mon, 12 Jul 2021 20:39:53 GMT, Christoph Langer wrote:
> The change for JDK-8257001 left an obsolete int field. Remove it.
Marked as reviewed by vtewari (Committer).
-
PR: https://git.openjdk.java.net/jdk/pull/4759
On Wed, 7 Jul 2021 09:34:13 GMT, Thejasvi Voniadka
wrote:
> Hi,
>
> Please review this simple change to remove redundancy of @run tags. The test
> "java/net/httpclient/DigestEchoClientSSL.java" contains a couple of redundant
> @run tags:
>
> * @run main/othervm/timeout=300
> *
On Mon, 5 Jul 2021 11:21:39 GMT, Daniel Fuchs wrote:
> Please find here a trivial fix for:
>
> 8269772: [macos-aarch64] test compilation failed with "SocketException: No
> buffer space available"
>
> Running several of the websocket tests concurrently on some of the CI
> machines is causing
On Fri, 28 May 2021 13:11:43 GMT, Chris Hegarty wrote:
> The SCTP channel factory methods, namely SctpChannel::open,
> SctpServerChannel::open, and SctpMultiChannel::open, are specified to throw
> UnsupportedOperationException, if the SCTP protocol is not supported.
> Currently, underlying
On Tue, 13 Apr 2021 10:30:18 GMT, Conor Cleary wrote:
>> ### Description
>> `Inet6Address/B6206527.java` test creates two instances of ServerSocket,
>> both of which are explicity bound to a Link-Local address. Neither of the
>> ServerSocket instances are explicitly closed meaning there is no
On Mon, 22 Mar 2021 06:02:37 GMT, Kim Barrett wrote:
> Please review this change to java.net.SocketInputStream and
> java.net.SocketOutputStream, removing their "finalize" methods. These
> methods are empty. Their purpose is to override and suppress the finalize
> methods of their superclasses
On Fri, 5 Mar 2021 15:08:10 GMT, Michael McMahon wrote:
>> Jayashree S Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Code Review: Incorporated Indention correction, added getIP and updated
>> try-catch inside for loop
>
>
On Tue, 16 Feb 2021 07:50:05 GMT, Vyom Tewari wrote:
> HttpsURLConnection, works with SunJSSE provider but does not work with other
> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
> follows
>
> s = (SSLSocket)serverSocket;
>if (s instan
On Thu, 4 Mar 2021 00:27:52 GMT, Xue-Lei Andrew Fan wrote:
>> Vyom Tewari has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - resolve jcheck issue.
>> - put if block which will prevent host being set twic
On Wed, 3 Mar 2021 15:20:29 GMT, Vyom Tewari wrote:
>> Vyom, can you provide, or point to a test that exercises the code paths that
>> have been changed? And also some new test that would fail before the fix and
>> pass after?
>>
>> best regards,
>>
>
tImpl)s).setHost(host);
>}
>
> But in case of other providers(BouncyCastleProvider ) host will not get set
> and "java.security.cert.CertificateException: No subject alternative name
> found matching IP address" exception will be thrown.
Vyom Tewari has updated the pull req
On Wed, 3 Mar 2021 16:16:48 GMT, Xue-Lei Andrew Fan wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reverted the overly deleted else block
>
> src/java.base/share/classes/sun/net/www/p
tImpl)s).setHost(host);
>}
>
> But in case of other providers(BouncyCastleProvider ) host will not get set
> and "java.security.cert.CertificateException: No subject alternative name
> found matching IP address" exception will be thrown.
Vyom Tewari has updated the pull requ
On Wed, 3 Mar 2021 10:09:34 GMT, Daniel Fuchs wrote:
> Vyom, can you provide, or point to a test that exercises the code paths that
> have been changed? And also some new test that would fail before the fix and
> pass after?
>
> best regards,
>
> -- daniel
Hi Daniel
tImpl)s).setHost(host);
>}
>
> But in case of other providers(BouncyCastleProvider ) host will not get set
> and "java.security.cert.CertificateException: No subject alternative name
> found matching IP address" exception will be thrown.
Vyom Tewari has updated the pull req
On Wed, 3 Mar 2021 11:36:19 GMT, Vyom Tewari wrote:
>> src/java.base/share/classes/sun/net/www/protocol/https/HttpsClient.java line
>> 454:
>>
>>> 452: s = (SSLSocket)factory.createSocket(serverSocket,
>>> 453:
On Wed, 3 Mar 2021 10:05:24 GMT, Daniel Fuchs wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> used List.of instead of Collections.singletonList
>
> src/java.base/share/clas
tImpl)s).setHost(host);
>}
>
> But in case of other providers(BouncyCastleProvider ) host will not get set
> and "java.security.cert.CertificateException: No subject alternative name
> found matching IP address" exception will be thrown.
Vyom Tewari has updated the pull req
On Wed, 3 Mar 2021 05:01:13 GMT, Vyom Tewari wrote:
>>> HttpsURLConnection, works with SunJSSE provider but does not work with
>>> other JSSE provider. In case of SunJSSE , HttpsURLConnection set the host
>>> name as follows
>>>
>>> s =
On Wed, 3 Mar 2021 04:38:47 GMT, Xue-Lei Andrew Fan wrote:
> > HttpsURLConnection, works with SunJSSE provider but does not work with
> > other JSSE provider. In case of SunJSSE , HttpsURLConnection set the host
> > name as follows
> > s = (SSLSocket)serverSocket;
> > if (s instanceof
On Tue, 2 Mar 2021 20:17:25 GMT, Xue-Lei Andrew Fan wrote:
>> Vyom Tewari has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> used List.of instead of Collections.singletonList
>
> src/java.base/share/clas
tImpl)s).setHost(host);
>}
>
> But in case of other providers(BouncyCastleProvider ) host will not get set
> and "java.security.cert.CertificateException: No subject alternative name
> found matching IP address" exception will be thrown.
Vyom Tewari has updated the pull req
On Tue, 2 Mar 2021 15:56:35 GMT, Daniel Fuchs wrote:
>> i ran tests, it looks
>> clean(https://github.com/vyommani/jdk/actions/runs/612949667)
>
> As far as I know this is only tier1 - so none of the network tests have been
> run.
I ran tier1 & tier2 tests locally on my linux vm, it was
On Tue, 2 Mar 2021 15:03:47 GMT, Daniel Fuchs wrote:
>> May be i am not sure, we may need this code change to review by security
>> expert. I am setting "SNIHostName" only if "isDefaultHostnameVerifier" is
>> true(If the HNV is the default from HttpsURLConnection) so there should not
>> be
On Tue, 2 Mar 2021 12:43:27 GMT, Daniel Fuchs wrote:
>> HttpsURLConnection, works with SunJSSE provider but does not work with other
>> JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
>> follows
>>
>> s = (SSLSocket)serverSocket;
>>if (s instanceof
On Tue, 2 Mar 2021 10:15:13 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my changeset that fixes the "no comment" warnings
> generated by `javadoc -Xdoclint` for `java.base/jdk.net`?
>
> Kind regards,
> Patrick
LGTM
-
Marked as reviewed by vtewari
HttpsURLConnection, works with SunJSSE provider but does not work with other
JSSE provider. In case of SunJSSE , HttpsURLConnection set the host name as
follows
s = (SSLSocket)serverSocket;
if (s instanceof SSLSocketImpl) {
((SSLSocketImpl)s).setHost(host);
}
But in case of
On Fri, 19 Feb 2021 04:26:26 GMT, Jaikiran Pai wrote:
> After thinking a bit more about this issue and the patch I had proposed, I
> realized what I did wrong in this patch. The `synchronized` block in the
> `sun.net.ext.ExtendedSocketOptions#getInstance()` was scoped one statement
> too
in
> a deadlock. It's clears why that happens.
>
> I am going to take a step back and come back with a different fix for this
> one. Thank you everyone for these reviews - they definitely helped.
Hi Jaikiran,
I tested with my suggested change and i did not see any deadlock at my local
Linux environment. I just ran test in loop and it worked as expected.
Thanks,
Vyom
-
PR: https://git.openjdk.java.net/jdk/pull/2601
On Thu, 18 Feb 2021 05:01:41 GMT, Jaikiran Pai wrote:
>>> > Changes looks OK to me, any specific reason for removing "final"
>>> > specifier from "getInstance" & "register" methods ?.
>>>
>>> Hello Vyom, tha
On Thu, 18 Feb 2021 01:06:50 GMT, Jaikiran Pai wrote:
> > Changes looks OK to me, any specific reason for removing "final" specifier
> > from "getInstance" & "register" methods ?.
>
> Hello Vyom, thank you for the review. Since those tw
>
> Marked as reviewed by alanb (Reviewer).
Looks ok to me.
Vyom
-
PR: https://git.openjdk.java.net/jdk/pull/2580
On Tue, 5 Jan 2021 09:48:11 GMT, Jayashree S Kumar
wrote:
>> Issue
>>
>> https://bugs.openjdk.java.net/browse/JDK-8243376
>>
>> Problem
>>
>> The scenario is:
>> - Some specified target hostname resolves to two IP addresses (always the
>> same address pair).
>> - The DNS resolved order of
+1
Vyom
On Fri, Aug 28, 2020 at 8:24 PM Alexander Scherbatiy <
alexander.scherba...@bell-sw.com> wrote:
> On 28.08.2020 17:40, Alan Bateman wrote:
>
> > On 28/08/2020 15:32, Alexander Scherbatiy wrote:
> >>
> >> I run the java/nio/channels tests with the f
Hi Patrick,
Changes looks ok to me.
Thanks,
Vyom
On Wed, Jul 29, 2020 at 9:45 PM Patrick Concannon <
patrick.concan...@oracle.com> wrote:
> Hi,
>
> Could someone please review my fix for JDK-8246164 —
> ‘SendDatagramToBadAddress.java and ChangingAddress.java should be chang
looks ok to me.
Vyom
On Fri, Jul 24, 2020 at 6:05 AM Joe Darcy wrote:
> Hello,
>
> Please review the replacement of default constructors in various
> abstract classes in java.net with explicit constructors:
>
> webrev: http://cr.openjdk.java.net/~darcy/8250244.0/
Hi Daniel,
you are right, Alan is talking the same , in webrev that i have posted code
is not properly formatted.
In my local repo code is properly formatted.
Thanks,
Vyom
On Wed, Jul 15, 2020 at 2:55 PM Daniel Fuchs
wrote:
> Hi Vyom,
>
> I don't know if that's what Alan is
is properly formatted and i am assuming that while pushing
there will not be any formatting issue.
Please let me know if I am missing something.
thanks,
Vyom
On Wed, Jul 15, 2020 at 12:44 AM Alan Bateman
wrote:
>
>
> On 14/07/2020 20:09, Daniel Fuchs wrote:
> > On 12/07/2020 07:
Hi Patrick,
Thanks for testing, Alan, Daniel can i get the final review comment from
you both ?.
Thanks,
Vyom
On Wed, Jul 8, 2020 at 8:17 PM Patrick Concannon <
patrick.concan...@oracle.com> wrote:
> Hi,
>
> No problem.
>
> I ran our tests against your latest patch,
Hi Patrick,
Thanks for testing, please find the latest webrev(
http://cr.openjdk.java.net/~vtewari/8237858/webrev1.0/index.html). I fixed
the windows build issue.
Thanks,
Vyom
On Tue, Jul 7, 2020 at 11:49 PM Patrick Concannon <
patrick.concan...@oracle.com> wrote:
> Hi Vyom,
>
>
Hi All,
Please find the updated webrev(
http://cr.openjdk.java.net/~vtewari/8237858/webrev0.9/index.html). I leave
the idea of using the PoolCleaner.
Thanks,
Vyom
On Sat, Jul 4, 2020 at 9:08 PM Martin Buchholz wrote:
> Right. It would be a project to create a jtreg test utility inspi
Hi Martin
Thanks for the review, I will try to address your review comment.
I wanted to write a simple test case for this issue but it is getting more
complex.
Thanks,
Vyom
On Sat, Jul 4, 2020 at 8:14 PM Martin Buchholz wrote:
> On Fri, Jul 3, 2020 at 11:12 PM Alan Bateman
>
will address all your review comments.
Thanks,
Vyom
On Sat, Jul 4, 2020 at 11:41 AM Alan Bateman
wrote:
> On 30/06/2020 06:39, Vyom Tiwari wrote:
> >
> >
> > Thanks for review please find the latest
> > webrev(http://cr.openjdk.java.net/~vtewari/8237858/webrev0.8/index.html)
Hi Daniel,
Thanks for review please find the latest webrev(
http://cr.openjdk.java.net/~vtewari/8237858/webrev0.8/index.html). I fixed
the Windows build issue.
Thanks,
Vyom
On Mon, Jun 29, 2020 at 10:23 PM Daniel Fuchs
wrote:
> Hi Vyom,
>
>
> On 29/06/2020 08:03, Vyom Tiwari w
nate lot's of duplicate
code.
Thanks,
Vyom
diff -r beb15266ba1a src/solaris/native/java/net/ExtendedOptionsImpl.c
--- a/src/solaris/native/java/net/ExtendedOptionsImpl.c Thu Feb 27 19:01:36
2020 +
+++ b/src/solaris/native/java/net/ExtendedOptionsImpl.c Mon Jun 29 21:12:16
2020 +0530
@@ -25,6 +25,10 @@
know if i am missing something.
Thanks,
Vyom
On Mon, Jun 29, 2020 at 2:25 PM Severin Gehwolf wrote:
> Hi Vyom!
>
> On Fri, 2020-06-26 at 15:55 +0530, Vyom Tiwari wrote:
> > Hi Severin,
> >
> > Overall code changes looks ok to me, I build & tested at my local
of the test. If tests send signals in
separate threads then tests have to make sure that server thread is alive
and running.
Thanks,
Vyom
On Sat, Jun 27, 2020 at 12:56 PM Vyom Tiwari wrote:
> Hi Alan,
>
> Thanks for the review comment, we can send multiple signals for sure. I
>
think webrev is ignoring the spaces that is why you are observing the
formatting issues in (linux/bsd)_close.c files. In my local repo code looks
well formatted.
Thanks,
Vyom
On Sat, Jun 27, 2020 at 11:46 AM Alan Bateman
wrote:
> On 26/06/2020 05:17, Vyom Tiwari wrote:
> > Hi Daniel/Alan,
&
e, T value) you can avoid the
local int variable.
3-> Any specific reason for two set of functions "setTcpKeepAliveTime0
and setTcpKeepAliveTime"
for all three socket options ?
Thanks,
Vyom
On Fri, Jun 26, 2020 at 1:08 PM Severin Gehwolf wrote:
> Hi,
>
> On Thu, 2020-06
Hi Bernd,
When we added these socket options to JDK, that time these options were not
available on Windows.
Thanks,
Vyom
On Fri, Jun 26, 2020 at 7:12 AM Bernd Eckenfels
wrote:
> Hello,
>
> This would be a great addition. I do not understand why it does not
> support the optio
Hi Daniel/Alan,
Please find the latest webrev(
http://cr.openjdk.java.net/~vtewari/8237858/webrev0.6/index.html).
Thanks,
Vyom
On Wed, Jun 24, 2020 at 5:32 PM Vyom Tiwari wrote:
> let me refactor the test, i will try to incorporate your suggestion.
> Vyom
>
>
> On Wed, Jun 24,
let me refactor the test, i will try to incorporate your suggestion.
Vyom
On Wed, Jun 24, 2020 at 5:21 PM Daniel Fuchs
wrote:
> On 24/06/2020 12:14, Vyom Tiwari wrote:
> > 3-> Looking at SocketAcceptInterruptTest it looks like the test
> > will succeed if it manages
try to
use if it is possible.
Thanks,
Vyom
On Wed, Jun 24, 2020 at 4:11 PM Daniel Fuchs
wrote:
> Hi Vyom,
>
> What is the purpose of calling NativeThread.close?
> Is that just to clean up and make the server thread terminate?
> If so there should be better ways to do that.
Hi Alan,
thanks for the review, i think there is some problem with webrev, in my
local repo linux_close.c, bsd_close.c both are properly formatted.
I will do the suggested changes in the tests and will send the updated
webrev soon.
Thanks,
Vyom
On Wed, Jun 24, 2020 at 11:49 AM Alan Bateman
/index.html) where i
have incorporated most of the review comments.
Thanks,
Vyom
On Tue, Jun 23, 2020 at 5:47 PM Daniel Fuchs
wrote:
> Hi Vyom,
>
> Just to let you know that the new SocketAcceptInterruptTest test
> seems to have some stability issues. Patrick imported your te
Hi,
Please find the latest webrev(
http://cr.openjdk.java.net/~vtewari/8237858/webrev0.4/index.html) where i
fix the build issue as well.
Thanks,
Vyom
On Wed, Jun 17, 2020 at 3:34 PM Vyom Tiwari wrote:
> Hi Alan,
>
> Please find the latest webrev(
> http://cr.openjdk.java.net/~vte
trying to build my
native code using JDK builds scripts, i am hoping someone will help to
resolve this issue. I manually build the native library and copy in the
required folder before running my tests.
Thanks,
Vyom
On Tue, Mar 17, 2020 at 12:33 PM Alan Bateman
wrote:
>
>
> On 17/03/2
Hi Patrick,
Changes looks good to me.
Thanks,
Vyom
On Wed, May 27, 2020 at 9:12 PM Patrick Concannon <
patrick.concan...@oracle.com> wrote:
> Hi,
>
> Could someone please review my webrev and CSR for JDK-8244582 'Remove
> terminally deprecated Solaris-specific SO_FLOW
Hi Aleksei,
Latest webrev(01) looks good to me, one minor comment "PREFER_IPV4_STACK"
variable naming convention is not consistent with other similar
variables(preferIPv6Address) in InetAddress.java.
Thanks,
Vyom
On Mon, May 25, 2020 at 4:18 PM Aleks Efimov
wrote:
> Hi
Thanks for the clarification Alan. I think, i missed some part of
discussion.
Vyom
On Tue, May 12, 2020 at 1:20 PM Alan Bateman
wrote:
> On 12/05/2020 08:34, Vyom Tiwari wrote:
>
> Hi Vladimir,
>
> Latest changes looks good to me, but i am not 100% sure if we need to
> disting
ttempt to set unsupported option " +
option);+else+throw new
SocketException("Attempt to set read only option " + option);
If developer wants to know the supported socket options he can use
"supportedOptions" to get the list of
Looks good to me, minor comment can you please use some int constant in
place of (65527, 65507) ?.
Vyom
On Fri, May 8, 2020 at 7:19 PM Patrick Concannon <
patrick.concan...@oracle.com> wrote:
> Hi,
>
> Could someone please review my fix for JDK-8242885
> 'PlainDatagramSocket
Hi Vladimir,
Latest webrev(03) looks ok to me , one minor bit, method signature(Signature:
(I)I;) is not correct in incomingNapiIdSupported0.
Thanks,
Vyom
++/*+ * Class: jdk_net_LinuxSocketOptions+ * Method:
incomingNapiIdSupported0+ * Signature: (I)I;+ */+JNIEXPORT jboolean
JNICALL
anks,
Vyom
On Tue, Apr 28, 2020 at 3:36 AM Ivanov, Vladimir A <
vladimir.a.iva...@intel.com> wrote:
> Thanks for the comments. The webrev was updated:
> http://cr.openjdk.java.net/~sviswanathan/Vladimir/8243099/webrev.02/
>
> Only the code was changed here. Change
Hi Vladimir,
In LinuxSocketOptions.c we have lot's of duplicate code, can you please
reuse "socketOptionSupported" & "handleError" as follows, this we remove
lot's of duplicate code.
Thanks,
Vyom
diff -r b6b4506a7827 src/jdk.net/linux/native/libextnet/LinuxSocketOptions.c
Looks good to me.
Vyom
On Fri, Mar 20, 2020 at 12:49 PM Ivan Gerasimov
wrote:
> Hello!
>
> An OOM error is intermittently observed on MacOS when joining a
> multicast group.
>
> A workaround was implemented as part of the fix for JDK-8236925.
>
> It is proposed to backpo
Hi Vipin,
changes looks OK to me as well , i will sponsor this doc patch for you.
Thanks,
Vyom
- Original message -From: Alan Bateman Sent by: "net-dev" To: Vipin Mv1 , net-dev@openjdk.java.netCc:Subject: [EXTERNAL] Re: Fw: RE: RFR 8129841 Upda
Hi Daniel/Michael,
Please find the latest webrev(
http://cr.openjdk.java.net/~vtewari/8237858/webrev0.2/index.html), where i
put a test case as well.
Thanks,
Vyom
On Wed, Mar 11, 2020 at 3:16 PM Bernd Eckenfels
wrote:
> Hello,
>
> Depending on the test environment you don't need mu
ite a test case(which requires some native code as well) which simulate the above but that will be lot of work.
We can file a new issue to write a test which test how(read,write,accept) operations behave when they are interrupted by a signal.
Alan, what do you think ?.
Thanks,
V
Hi Daniel/Michael,
Please find the latest webrev(http://cr.openjdk.java.net/~vtewari/8237858/webrev0.1/index.html) where i did the similar changes in (aix_close,solaris_close,bsd_close).c
files as well.
Thanks,
Vyom
- Original message -From: Michael McMahon Sent by: "ne
I think changes are good & safe and we don't need to do any additional changes.
Thanks,
Vyom
- Original message -From: Daniel Fuchs To: Vyom Tewari26 Cc: net-dev@openjdk.java.netSubject: [EXTERNAL] Re: RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectlyDate: Tue,
ding the code.
NET_Timeout does not tells that there is infinite(-1) timeout as well, if you see the code changes I explicitly put else block to make code more readable.
I hosted the patch to cr.openjdk.net(http://cr.openjdk.java.net/~vtewari/8237858/webrev/index.html).
Thanks,
Vyom
- Original mess
Hi,
Patch looks OK to me, although i am not the official reviewer.
Thanks,
Vyom
- Original message -From: sha.ji...@oracle.comSent by: "net-dev" To: net-dev@openjdk.java.netCc:Subject: [EXTERNAL] Re: RFR[15] JDK-8238740: java/net/httpclient/whitebox/FlowTestDriver.
Hi Daniel,
thanks for the review, i pushed the change(https://hg.openjdk.java.net/jdk/jdk/rev/ca2dcaf37fad).
Thanks,
Vyom
- Original message -From: Daniel Fuchs To: Vyom Tewari26 Cc: core-libs-...@openjdk.java.net, net-dev@openjdk.java.net, vyomm...@gmail.comSubject: [EXTERNAL] Re
Ping,
please review the below code.
Vyom
- Original message -From: "Vyom Tewari26" Sent by: "net-dev" To: net-dev@openjdk.java.netCc:Subject: [EXTERNAL] RFR 8237858: PlainSocketImpl.socketAccept() handles EINTR incorrectlyDate: Tue, Feb 25, 2020 10:07 PM
Hi ,
P
Hi Ravi,
Latest changes looks good to me.
Thanks,
Vyom
- Original message -From: Ravi Reddy Sent by: "net-dev" To: Daniel Fuchs , Vyom Tiwari Cc: net-dev Subject: [EXTERNAL] RE: RFR[15] JDK-8183369 : RFC unconformity of HttpURLConnection with proxyDate: Mon, Mar 2, 2020 8
Hi Daniel,
Thanks for the review i need a favor , as my OpenJDK(vtewari) id is not working so i can not push the code.
Can you please push the code once review is done.
Thanks,
Vyom
- Original message -From: Daniel Fuchs To: Vyom Tewari26 Cc: core-libs-...@openjdk.java.net, net
by signal(EINTR) then in case of -1 timeout it returns immediately instead of looping again.
Thanks,
Vyom
##
diff -r d6b968af8b65 src/java.base/linux/native/libnet/linux_close.c--- a/src/java.base/linux/native/libnet/linux_close.c Mon F
Sounds good
Thanks,
Vyom
- Original message -From: Daniel Fuchs Sent by: "net-dev" To: Vyom Tiwari , net-dev , core-libs-dev Cc:Subject: [EXTERNAL] Re: RFR 8238579: HttpsURLConnection drops the timeout and hangs forever in readDate: Sat, Feb 15, 2020 1:11 AM
Hi Vyom,On the sur
resolved.
Thanks,
Vyom
- Original message -From: "felixxfyang(杨晓峰)" Sent by: "core-libs-dev" To: Vyom Tiwari , net-dev , core-libs-dev Cc:Subject: [EXTERNAL] Re: RFR 8238579: HttpsURLConnection drops the timeout and hangs forever in read(Internet mail)Date: Fri, Feb 14, 20
connect & read timeout.
Thanks,
Vyom
diff -r 7e6165c9c606
src/java.base/share/classes/sun/net/www/protocol/https/AbstractDelegateHttpsURLConnection.java
---
a/src/java.base/share/classes/sun/net/www/protocol/https/AbstractDelegateHttpsURLConnection.java
Thu Feb 13 17:14:45 2020 -0800
+++
b/s
change copyright year(2020) as well.
Thanks,
Vyom
On Thu, Feb 13, 2020 at 6:27 PM Daniel Fuchs
wrote:
> Hi,
>
> On 13/02/2020 10:52, Ravi Reddy wrote:
> > I notice that the `break` from the original code has not been
> >
> > reintroduced. I don't think that it is s
Hi Julia,
Your change looks OK but it will increase the worst case, running time of test from (2500+1000)ms to (15000 + 1000)ms and this will definitely decrease the probability of intermittent failure but not 100% full proof.
Thanks,
Vyom
- Original message -From: Julia Boes
Hi Patrick,
Thanks for explanation.
Vyom
- Original message -From: Patrick Concannon To: Vyom Tewari26 , alan.bate...@oracle.comCc: daniel.fu...@oracle.com, net-dev@openjdk.java.netSubject: [EXTERNAL] Re: RFR[8234148]: DatagramSocket.setOption/getOption/supportedOption should support
Hi Patrick,
Changes looks OK to me except, SupportedOptionsCheck tests
if (!Platform.isWindows())
55 assertTrue(options.containsAll(multicastOptions));
What this test will do on Windows ?.
Thanks,
Vyom
- Original message -From: Alan Bateman Sent by: "ne
try { dispatcherThread.join(); } catch (InterruptedException e) { Thread.currentThread().interrupt(); logger.log (Level.TRACE, "ServerImpl.stop: ", e); } }
Hi Mathias,
Code change looks OK to me, although i am not the official OpenJDK reviewer.
Thanks,
Vyom
- Original message -From: "Baesken, Matthias" Sent by: "net-dev" To: Alan Bateman , "net-dev@openjdk.java.net" Cc:Subject: [EXTERNAL] RE: RFR: 8234629
looks OK to me, i searched through entire JDK code base and i did not found any uses of "NET_ReadV" .
Thanks,
Vyom
- Original message -From: "Baesken, Matthias" Sent by: "net-dev" To: "net-dev@openjdk.java.net" Cc:Subject: [EXTERNAL] RFR: [XS]
Hi Patric,
Changes looks good to me.
Thanks,
Vyom
- Original message -From: Patrick Concannon Sent by: "net-dev" To: OpenJDK Network Dev list Cc:Subject: [EXTERNAL] RFR[8234083]: DatagramSocket should report SO_BROADCAST as a supported optionDate: Fri, Nov 15, 2019 6:45 PM
looks good to me.
Vyom
- Original message -From: Patrick Concannon To: Vyom Tewari26 Cc: alan.bate...@oracle.com, net-dev@openjdk.java.netSubject: [EXTERNAL] Re: RFR[8233860]: java/net/SocketOption/AfterClose.java test incorrectly handles IP_MULTICAST_IFDate: Thu, Nov 14, 2019 4:27 PM
Hi Patric,
Change looks ok to me, one minor bit i will suggest you to use "List.of()" in place of "new ArrayList<>();".
Thanks,
Vyom
- Original message -From: Patrick Concannon Sent by: "net-dev" To: Alan Bateman , OpenJDK Network Dev list Cc:Subjec
Hi Ivan,
cookie expiration date change(Sat, 09-Nov-2019 23:12:40 GMT) looks ok to me.
Thanks,
Vyom
- Original message -From: Ivan Gerasimov Sent by: "net-dev" To: net-dev@openjdk.java.netCc:Subject: [EXTERNAL] RFR 8233886 : TEST_BUG jdk/java/net/CookieHandler/B679192
1 - 100 of 276 matches
Mail list logo
