RE: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-31 Thread Martin Sawicki (MS OPEN TECH)
: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7 Thanks all - Agreed changes pushed to 7u85 and I'll make a request to see if we can include this in 7u80 code base. regards, Sean. On 30/01/2015 16:00, Alan Bateman wrote: On 30/01/2015 12:18, Seán Coffey wrote: Alan, hadn't

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-30 Thread Alan Bateman
On 30/01/2015 12:18, Seán Coffey wrote: Alan, hadn't spotted the race issue. I guess we could delay setting ver_initialized until OSVERSIONINFO is populated. Alternatively - like you say, I think we can revert back to the simpler edit :

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-30 Thread Seán Coffey
Thanks all - Agreed changes pushed to 7u85 and I'll make a request to see if we can include this in 7u80 code base. regards, Sean. On 30/01/2015 16:00, Alan Bateman wrote: On 30/01/2015 12:18, Seán Coffey wrote: Alan, hadn't spotted the race issue. I guess we could delay setting

RE: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-30 Thread Valery Kopylov (Akvelon)
From: Seán Coffey [mailto:sean.cof...@oracle.com] Alan, hadn't spotted the race issue. I guess we could delay setting ver_initialized until OSVERSIONINFO is populated. Alternatively - like you say, I think we can revert back to the simpler edit :

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-30 Thread Seán Coffey
Alan, hadn't spotted the race issue. I guess we could delay setting ver_initialized until OSVERSIONINFO is populated. Alternatively - like you say, I think we can revert back to the simpler edit : http://cr.openjdk.java.net/~coffeys/webrev.8060170.7u.v2/webrev/ I'll run with this version

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-29 Thread Alan Bateman
On 26/01/2015 13:48, Seán Coffey wrote: Valeriy, those changes look fine to me and I've verified that they run through testing fine also. webrev here for reference : http://cr.openjdk.java.net/~coffeys/webrev.8060170.7u.v3/webrev/ Can I have a jdk7u reviewer for this change ? There is a

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-26 Thread Seán Coffey
*Subject:* RE: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7 Sorry about the delay. Valeryi has prepared a patch – he’ll be responding soon. *From:*Seán Coffey [mailto:sean.cof...@oracle.com] *Sent:* Friday, January 23, 2015 5:55 AM *To:* Valery Kopylov (Akvelon

RE: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-26 Thread Valery Kopylov (Akvelon)
: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7 Sorry about the delay. Valeryi has prepared a patch - he'll be responding soon. From: Seán Coffey [mailto:sean.cof...@oracle.com] Sent: Friday, January 23, 2015 5:55 AM To: Valery Kopylov (Akvelon); Martin Sawicki (MS OPEN

Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-23 Thread Seán Coffey
) Subject: Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7 Hey Martin, I can help in getting this enhancement ported to jdk7u-dev. I'm just waiting on approval for use of new system property in jdk7u release. Once I have that, I can get this in. regards, Sean

RE: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7

2015-01-23 Thread Martin Sawicki (MS OPEN TECH)
Network Dev list Subject: Re: Backporting the TCP loopback fast path (Windows) improvement to OpenJDK v7 Valeriy, I didn't see a follow up on this. I've modified the patch so that we cater for a possible WSAEINVAL error to be returned from the NET_EnableFastTcpLoopback call. Latest webrev