Re: Code Review 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe

2010-08-19 Thread Chris Hegarty
gustav trede wrote: On 18 August 2010 13:22, Michael McMahon michael.x.mcma...@oracle.com mailto:michael.x.mcma...@oracle.com wrote: gustav trede wrote: On 18 August 2010 12:10, Chris Hegarty chris.hega...@oracle.com mailto:chris.hega...@oracle.com

Re: Code Review 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe

2010-08-19 Thread gustav trede
On 19 August 2010 17:50, Chris Hegarty chris.hega...@oracle.com wrote: gustav trede wrote: On 18 August 2010 13:22, Michael McMahon michael.x.mcma...@oracle.commailto: michael.x.mcma...@oracle.com wrote: gustav trede wrote: On 18 August 2010 12:10, Chris Hegarty

Re: Code Review 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe

2010-08-19 Thread Michael McMahon
gustav trede wrote: On 19 August 2010 17:50, Chris Hegarty chris.hega...@oracle.com mailto:chris.hega...@oracle.com wrote: gustav trede wrote: On 18 August 2010 13:22, Michael McMahon michael.x.mcma...@oracle.com mailto:michael.x.mcma...@oracle.com

Code Review 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe

2010-08-18 Thread Chris Hegarty
Michael, java.net.HttpCookie uses static SimpleDateFormat which is not thread safe. I think the best solution here is to simply create local SimpleDateFormat as needed. Webrev: http://cr.openjdk.java.net/~chegar/6965924/webrev.00/webrev/ Thanks, -Chris.

Re: Code Review 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe

2010-08-18 Thread gustav trede
On 18 August 2010 12:10, Chris Hegarty chris.hega...@oracle.com wrote: Michael, java.net.HttpCookie uses static SimpleDateFormat which is not thread safe. I think the best solution here is to simply create local SimpleDateFormat as needed. Webrev:

Re: Code Review 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe

2010-08-18 Thread Chris Hegarty
On 18/08/2010 11:28, gustav trede wrote: On 18 August 2010 12:10, Chris Hegarty chris.hega...@oracle.com mailto:chris.hega...@oracle.com wrote: Michael, java.net.HttpCookie uses static SimpleDateFormat which is not thread safe. I think the best solution here is to simply create

Re: Code Review 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe

2010-08-18 Thread gustav trede
On 18 August 2010 12:47, Chris Hegarty chris.hega...@oracle.com wrote: On 18/08/2010 11:28, gustav trede wrote: On 18 August 2010 12:10, Chris Hegarty chris.hega...@oracle.com mailto:chris.hega...@oracle.com wrote: Michael, java.net.HttpCookie uses static SimpleDateFormat which is

Re: Code Review 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe

2010-08-18 Thread Michael McMahon
gustav trede wrote: On 18 August 2010 12:10, Chris Hegarty chris.hega...@oracle.com mailto:chris.hega...@oracle.com wrote: Michael, java.net.HttpCookie uses static SimpleDateFormat which is not thread safe. I think the best solution here is to simply create local

Re: Code Review 6965924: java.net.HttpCookie using static SimpleDateFormat which is not thread safe

2010-08-18 Thread gustav trede
On 18 August 2010 13:22, Michael McMahon michael.x.mcma...@oracle.comwrote: gustav trede wrote: On 18 August 2010 12:10, Chris Hegarty chris.hega...@oracle.com mailto: chris.hega...@oracle.com wrote: Michael, java.net.HttpCookie uses static SimpleDateFormat which is not thread